This revision was automatically updated to reflect the committed changes.
Closed by commit rG1d9b860fb6a8: Unify the return value of GetByteSize to an
llvm::Optionaluint64_t (NFC-ish) (authored by aprantl).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
Author: Adrian Prantl
Date: 2020-07-25T08:27:21-07:00
New Revision: 1d9b860fb6a85df33fd52fcacc6a5efb421621bd
URL:
https://github.com/llvm/llvm-project/commit/1d9b860fb6a85df33fd52fcacc6a5efb421621bd
DIFF:
https://github.com/llvm/llvm-project/commit/1d9b860fb6a85df33fd52fcacc6a5efb421621bd.diff
clayborg added a comment.
If removing 'd' was only to make it available for "up" and "down" in
https://reviews.llvm.org/D68541, then maybe we should switch 'D' to "detach and
let run? Or is that what we did, but the comment on line 4331 is now out of
date?
Repository:
rLLDB LLDB
CHANGES
clayborg added a comment.
So it seems like we should be either moving everything to the process menu, or
keeping everything and introducing a confirmation dialog for any dangerous
commands (kill, both detaches). This patch seems to keep some dangerous
commands (detach suspended), remove one
Author: Eric Christopher
Date: 2020-07-25T18:42:04-07:00
New Revision: 4b14ef33e81c01632e848e7a67ccc6b11fb4c595
URL:
https://github.com/llvm/llvm-project/commit/4b14ef33e81c01632e848e7a67ccc6b11fb4c595
DIFF:
clayborg added a comment.
Yikes, sorry for not responding for so long. In the fall I was out on medical
leave due to a head injury. Please feel free to ping more often if I do this
again. I commented in the other patches (one accepted, and questions in the
other). Let me know your thoughts.
Hi Adrian,
I'm really sorry, but I've just reverted this. I'm not sure what's up, but
it's causing massive test failures in lldb on linux. Happy to help sync up
with you.
echristo@athyra ~/s/llvm-project> git push
To github.com:llvm/llvm-project.git
18975762c19..4b14ef33e81 master -> master
