[Lldb-commits] [lldb] 0fcacef - [lldb] Format unix signal table (NFC)

Author: Jonas Devlieghere Date: 2020-10-06T23:36:56-07:00 New Revision: 0fcacefd160494280dc040f4f055db6df695ac12 URL: https://github.com/llvm/llvm-project/commit/0fcacefd160494280dc040f4f055db6df695ac12 DIFF:

[Lldb-commits] [PATCH] D88906: [lldb/docs] Clarify python/swig version incompatibility

labath added a comment. In D88906#2314777 , @amccarth wrote: > Yes, I also (independently) discovered this problem. Yeah, that seems to be a fairly common problem. I'm gonna try to add some kind of a cmake warning about this. Comment

[Lldb-commits] [PATCH] D87868: [RFC] When calling the process mmap try to call all found instead of just the first one

labath added inline comments. Comment at: lldb/source/Plugins/Process/Utility/InferiorCallPOSIX.cpp:54 +if (sc_list.GetContextAtIndex(i, sc) && +(sc.symbol->IsExternal() || sc.symbol->IsWeak())) { const uint32_t range_scope = clayborg wrote: >

[Lldb-commits] [PATCH] D88728: [lldb] Check for and use ptsname_r if available

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3dfb94986170: [lldb] Check for and use ptsname_r if available (authored by labath). Changed prior to commit:

[Lldb-commits] [PATCH] D88906: [lldb/docs] Clarify python/swig version incompatibility

This revision was automatically updated to reflect the committed changes. Closed by commit rG029290f1a623: [lldb/docs] Clarify python/swig version incompatibility (authored by labath). Changed prior to commit: https://reviews.llvm.org/D88906?vs=296474=296657#toc Repository: rG LLVM Github

[Lldb-commits] [lldb] 029290f - [lldb/docs] Clarify python/swig version incompatibility

Author: Pavel Labath Date: 2020-10-07T15:29:29+02:00 New Revision: 029290f1a6231507b82981d56c0a0d2b02d508e0 URL: https://github.com/llvm/llvm-project/commit/029290f1a6231507b82981d56c0a0d2b02d508e0 DIFF: https://github.com/llvm/llvm-project/commit/029290f1a6231507b82981d56c0a0d2b02d508e0.diff

[Lldb-commits] [lldb] 3dfb949 - [lldb] Check for and use ptsname_r if available

Author: Pavel Labath Date: 2020-10-07T15:29:29+02:00 New Revision: 3dfb94986170c57d9b3f5f2cba039a2eab5e6f13 URL: https://github.com/llvm/llvm-project/commit/3dfb94986170c57d9b3f5f2cba039a2eab5e6f13 DIFF: https://github.com/llvm/llvm-project/commit/3dfb94986170c57d9b3f5f2cba039a2eab5e6f13.diff

[Lldb-commits] [PATCH] D88387: Create "skinny corefiles" for Mach-O with process save-core / reading

DavidSpickett added a comment. For what it's worth I'm aware of this change, don't hold back on my account. It doesn't overlap that much and I think I'll be reworking mine anyway. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88387/new/

[Lldb-commits] [PATCH] D88939: [lldb] Remove unused code in GetVersion (NFC)

teemperor added a reviewer: JDevlieghere. teemperor added a comment. LLDB_REVISION and LLDB_REPOSITORY are coming from VCSVersion.inc where it should be defined as a string. However the generation of that file seems to be broken since the monorepo migration. I put up a patch here that gets this

[Lldb-commits] [PATCH] D88728: [lldb] Check for and use ptsname_r if available

labath added a comment. In D88728#2315648 , @MaskRay wrote: > LGTM. Worth mentioning that this will be in POSIX issue 8 > https://www.austingroupbugs.net/bug_view_page.php?bug_id=508 Oh, cool. I didn't know posix is still being worked on :P

[Lldb-commits] [PATCH] D88939: [lldb] Remove unused code in GetVersion (NFC)

kastiglione updated this revision to Diff 296700. kastiglione added a comment. Update commit message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88939/new/ https://reviews.llvm.org/D88939 Files: lldb/source/lldb.cpp Index:

[Lldb-commits] [PATCH] D88975: [LLDB] On Windows, fix tests

labath added a comment. Is there a way to force a program to use a specific locale, ignoring the system-wide setting (something like `export LC_ALL=C` on unix)? Hardcoding the error message for all locales is not a viable long term strategy... :/ Repository: rG LLVM Github Monorepo CHANGES

[Lldb-commits] [PATCH] D87442: [lldb] Show flags for memory regions

DavidSpickett planned changes to this revision. DavidSpickett added a comment. > Yes, that's pretty much it. Great, I will rework this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87442/new/ https://reviews.llvm.org/D87442

[Lldb-commits] [PATCH] D88975: [LLDB] On Windows, fix tests

aganea created this revision. aganea added reviewers: amccarth, labath. Herald added a reviewer: JDevlieghere. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. aganea requested review of this revision. This patch fixes a few issues seen when running `ninja check-lldb` in a

[Lldb-commits] [PATCH] D88967: [lldb] Add a cmake warning about the python/swig incompatibility

labath created this revision. labath added reviewers: amccarth, tatyana-krasnukha, JDevlieghere. Herald added a subscriber: mgorny. Herald added a project: LLDB. labath requested review of this revision. Raise awareness of the fact that some versions of swig and python (and build types) just

[Lldb-commits] [PATCH] D88939: [lldb] Remove unused code in GetVersion (NFC)

kastiglione updated this revision to Diff 296695. kastiglione added a comment. Restore repository handling Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88939/new/ https://reviews.llvm.org/D88939 Files: lldb/source/lldb.cpp Index:

[Lldb-commits] [PATCH] D88939: [lldb] Remove unused code in GetVersion (NFC)

kastiglione added a comment. @teemperor I removed the comment and restored repository handling. It becomes much more of a useless diff :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88939/new/ https://reviews.llvm.org/D88939

[Lldb-commits] [PATCH] D88992: [lldb] Fix "frame var" for large bitfields

labath created this revision. labath added reviewers: jingham, teemperor. Herald added a reviewer: JDevlieghere. Herald added a project: LLDB. labath requested review of this revision. The problem here is in the "sliding" code in ValueObjectChild::UpdateValue. It modifies m_bitfield_bit_offset

[Lldb-commits] [PATCH] D88975: [LLDB] On Windows, fix tests

aganea added a comment. In D88975#2317494 , @amccarth wrote: > Maybe dotest.py could change its own Windows locale setting and the processes > it spawns would inherit that. I don't know if that would work, but I don't > see a good alternative. One

[Lldb-commits] [PATCH] D88975: [LLDB] On Windows, fix tests

labath added a comment. I really want to avoid having language specific strings in the tests. Skipping tests which depend on these is a reasonable approach (as you've discovered, there shouldn't be that many of them -- it's really just the tests which check that we actually can retrieve the

[Lldb-commits] [PATCH] D88975: [LLDB] On Windows, fix tests

aganea added a comment. In D88975#2317566 , @labath wrote: > I really want to avoid having language specific strings in the tests. We all agree on that. I'll update the patch once it passes all tests on my machines. Repository: rG LLVM Github

[Lldb-commits] [PATCH] D88939: [lldb] Remove unused code in GetVersion (NFC)

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. Yeah there isn't a lot of unused code left here. If you want you can make a follow up replacing all the C-string logic with `std::string` (and removing the static local result var as

[Lldb-commits] [PATCH] D88975: [LLDB] On Windows, fix tests

amccarth added a comment. It's interesting that I haven't encountered some of these errors. There are five _other_ lldb tests that do fail for me. I have a fix in the works for some of those. I agree with @labath that including error message patterns in various languages isn't scalable.

[Lldb-commits] [PATCH] D88992: [lldb] Fix "frame var" for large bitfields

shafik accepted this revision. shafik added a comment. This revision is now accepted and ready to land. LGTM I notice that we are using `m_byte_offset` directly a little above the line you fixed instead of `GetByteOffset()`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D88975: [LLDB] On Windows, fix tests

aganea updated this revision to Diff 296809. aganea marked an inline comment as done. aganea added a comment. As discussed above: - Remove locale-specific messages. - Skip relevant locale-sensitive TestTargetCommand tests. - Only skip EXPECT calls in Utility/StatusTest. Repository: rG LLVM

[Lldb-commits] [PATCH] D88387: Create "skinny corefiles" for Mach-O with process save-core / reading

jasonmolenda added a comment. Yeah, I'm not opposed to mutually exclusive options to process save-core to request a specific style of coredump to be created, whether it's a --core-style enum or a series of flags isn't important to me. Right now I only intend to add the two that are possible -

[Lldb-commits] [PATCH] D88387: Create "skinny corefiles" for Mach-O with process save-core / reading

clayborg added a comment. In D88387#2318495 , @jasonmolenda wrote: > Yeah, I'm not opposed to mutually exclusive options to process save-core to > request a specific style of coredump to be created, whether it's a > --core-style enum or a series of

[Lldb-commits] [PATCH] D88769: [trace] Scaffold "thread trace dump instructions"

wallace updated this revision to Diff 296866. wallace edited the summary of this revision. wallace added a comment. Addressed comments, which includse: - Implemented the requested repeat command logic, including tests - Now showing the total number of instructions as part of the dump command,

[Lldb-commits] [PATCH] D88967: [lldb] Add a cmake warning about the python/swig incompatibility

amccarth added a comment. In D88967#2317545 , @labath wrote: > In D88967#2317522 , @amccarth wrote: > >> If I recall correctly, the non-debug builds still had the problem, they just >> didn't have the assertion

Re: [Lldb-commits] Upcoming upgrade of LLVM buildbot

It looks like all sanitizer builder are still offline http://lab.llvm.org:8011/#/builders On Tue, 6 Oct 2020 at 00:34, Galina Kistanova via cfe-commits < cfe-comm...@lists.llvm.org> wrote: > Hello everyone, > > The staging buildbot was up and running for 6 days now, and looks good. > > Tomorrow

[Lldb-commits] [PATCH] D82863: [LLDB] Add support to resize SVE registers at run-time

omjavaid updated this revision to Diff 296811. omjavaid added a comment. This is an update after addressing comments from @jasonmolenda CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82863/new/ https://reviews.llvm.org/D82863 Files:

[Lldb-commits] [PATCH] D88967: [lldb] Add a cmake warning about the python/swig incompatibility

JDevlieghere accepted this revision. JDevlieghere added a comment. Neat! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88967/new/ https://reviews.llvm.org/D88967 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D88387: Create "skinny corefiles" for Mach-O with process save-core / reading

clayborg added a comment. In D88387#2318226 , @jasonmolenda wrote: > I was thinking about the UI of this some more today. > > I think process save-core should take a --core-style argument with an enum of > (currently) 'full' or 'modified-memory'.

[Lldb-commits] [lldb] 81b11c9 - Fix a macOS build break caused by 3dfb94986170.

Author: Jim Ingham Date: 2020-10-07T15:01:27-07:00 New Revision: 81b11c91070f3a969b64b2c2e6011b02450fa75f URL: https://github.com/llvm/llvm-project/commit/81b11c91070f3a969b64b2c2e6011b02450fa75f DIFF: https://github.com/llvm/llvm-project/commit/81b11c91070f3a969b64b2c2e6011b02450fa75f.diff

[Lldb-commits] [PATCH] D89019: Change the default handling of SIGCONT to nostop/noprint

JDevlieghere added a comment. As discussed offline I also think this makes sense. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89019/new/ https://reviews.llvm.org/D89019 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D82863: [LLDB] Add support to resize SVE registers at run-time

omjavaid added inline comments. Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteRegisterContext.cpp:767 + m_reg_data.Clear(); + m_reg_data.SetData(reg_data_sp); + m_reg_data.SetByteOrder(GetByteOrder()); jasonmolenda wrote: > I'm

[Lldb-commits] [PATCH] D88975: [LLDB] On Windows, fix tests

aganea added a comment. In D88975#2317494 , @amccarth wrote: > It's interesting that I haven't encountered some of these errors. There are > five _other_ lldb tests that do fail for me. I have a fix in the works for > some of those. Please see my

[Lldb-commits] [PATCH] D88387: Create "skinny corefiles" for Mach-O with process save-core / reading

jasonmolenda added a comment. I was thinking about the UI of this some more today. I think process save-core should take a --core-style argument with an enum of (currently) 'full' or 'modified-memory'. Plugin::SaveCore will take a requested_coredump_style and will return an