[Lldb-commits] [lldb] d36e879 - [lldb] Disable PipeTest.OpenAsReader on windows

Author: Pavel Labath Date: 2021-01-11T13:37:49+01:00 New Revision: d36e879c21c9620c9b6a1a8f45afe46379142d2f URL: https://github.com/llvm/llvm-project/commit/d36e879c21c9620c9b6a1a8f45afe46379142d2f DIFF: https://github.com/llvm/llvm-project/commit/d36e879c21c9620c9b6a1a8f45afe46379142d2f.diff

Re: [Lldb-commits] [PATCH] D94063: lldb: Add support for DW_AT_ranges on DW_TAG_subprograms

> On Jan 10, 2021, at 5:37 PM, David Blaikie wrote: > > Thanks for all the context - so sounds like mostly based on (3) the > recommendation would be for this to be an API test (is there a way to test > the line table directly? good place for reference on the SB API options - I > looked at

[Lldb-commits] [PATCH] D93874: [process] fix exec support on Linux

wallace added a comment. @jingham, friendly ping :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93874/new/ https://reviews.llvm.org/D93874 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D78978: [LLDB] Add support for WebAssembly debugging

paolosev added a comment. In D78978#2488134 , @aprantl wrote: > What's the testing story for WASM going to be? Thanks for the feedback @aprantl! This patch was also create to show a possible alternative to https://reviews.llvm.org/D78801, but D78801

[Lldb-commits] [PATCH] D93951: [vscode] Improve runInTerminal and support linux

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Just one rename of an instance variable and this is good to go! Much cleaner without the directory and multiple files. Comment at: lldb/tools/lldb-vscode/FifoFiles.h:26

[Lldb-commits] [PATCH] D93874: [process] fix exec support on Linux

jingham added inline comments. Comment at: lldb/test/API/functionalities/exec/TestExec.py:91-93 +# Single step to create a thread plan. We have to make sure that after exec +# we clear all existing thread plans. +thread.StepInstruction(False)

[Lldb-commits] [PATCH] D93874: [process] fix exec support on Linux

clayborg added a comment. I still think we should add a Process::ProcessDidExec() as mentioned in the inline comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93874/new/ https://reviews.llvm.org/D93874

[Lldb-commits] [PATCH] D78978: [LLDB] Add support for WebAssembly debugging

aprantl added a comment. Thanks for the explanation! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78978/new/ https://reviews.llvm.org/D78978 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D93874: [process] fix exec support on Linux

wallace added a comment. I've done a lightweight test and it seems that the BaseThreadPlan is being asked for the stop reason when the exec happens, but it holds a reference to the thread whose destructor has been called, which causes the crash. On Darwin, as Greg said, the BaseThreadPlan is

[Lldb-commits] [lldb] edde2eb - Add unconditional logging to debugserver for launch/attach processes

Author: Jason Molenda Date: 2021-01-11T22:17:10-08:00 New Revision: edde2eb1d2093905a2cb6166e6a60f9cc04c2bbc URL: https://github.com/llvm/llvm-project/commit/edde2eb1d2093905a2cb6166e6a60f9cc04c2bbc DIFF: https://github.com/llvm/llvm-project/commit/edde2eb1d2093905a2cb6166e6a60f9cc04c2bbc.diff

[Lldb-commits] [PATCH] D94357: [NFC] Add some additional, unconditional, logging to debugserver mostly related to app launching/attaching

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGedde2eb1d209: Add unconditional logging to debugserver for launch/attach processes (authored by jasonmolenda). Repository: rG LLVM Github

[Lldb-commits] [PATCH] D93874: [process] fix exec support on Linux

clayborg added inline comments. Comment at: lldb/test/API/functionalities/exec/TestExec.py:93 +# we clear all existing thread plans. +thread.StepInstruction(False) + On Darwin threads have unique identifiers and the thread ID before exec !=

[Lldb-commits] [PATCH] D93874: [process] fix exec support on Linux

jingham added inline comments. Comment at: lldb/test/API/functionalities/exec/TestExec.py:93 +# we clear all existing thread plans. +thread.StepInstruction(False) + clayborg wrote: > On Darwin threads have unique identifiers and the thread ID