[Lldb-commits] [PATCH] D100140: [lldb] [gdb-remote server] Refactor handling qSupported

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. cool Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerCommon.cpp:835 + // Parse client-indicated features. + llvm::StringRef view =

[Lldb-commits] [lldb] 8a64d80 - [lldb] Require x86 backend for a bunch of DWARF tests

Author: David Spickett Date: 2021-04-13T08:47:41Z New Revision: 8a64d80a959bf2844df33f9112e456f33de7b468 URL: https://github.com/llvm/llvm-project/commit/8a64d80a959bf2844df33f9112e456f33de7b468 DIFF: https://github.com/llvm/llvm-project/commit/8a64d80a959bf2844df33f9112e456f33de7b468.diff

[Lldb-commits] [PATCH] D100191: [lldb] [llgs] Support owning and detaching extra processes

labath added a comment. I like this a lot more than the previous version. The thing I'd like to know is, whether we can replace `m_additional_processes` with something like `m_debugged_processes` (i.e., just have a single list of all processes we are debugging. We could replace all occurrences

[Lldb-commits] [PATCH] D100146: [lldb] [gdb-remote client] Refactor handling qSupported

labath added a comment. In D100146#2685026 , @mgorny wrote: > In D100146#2684942 , @labath wrote: > >> looks great, just fix the build errors :) > > Yeah, I'm trying to see if I can reproduce them when building

[Lldb-commits] [PATCH] D100193: [lldb] Require x86 backend for a bunch of DWARF tests

This revision was automatically updated to reflect the committed changes. Closed by commit rG8a64d80a959b: [lldb] Require x86 backend for a bunch of DWARF tests (authored by DavidSpickett). Changed prior to commit: https://reviews.llvm.org/D100193?vs=336783=337068#toc Repository: rG LLVM

[Lldb-commits] [PATCH] D100192: [lldb][Arm/AArch64] Add basic disassemble tests for Arm/AArch64

This revision was automatically updated to reflect the committed changes. Closed by commit rG96c82166b6e3: [lldb][Arm/AArch64] Add basic disassemble tests for Arm/AArch64 (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D100140: [lldb] [gdb-remote server] Refactor handling qSupported

mgorny marked 2 inline comments as done. mgorny added inline comments. Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerCommon.cpp:1310-1311 + "QStartNoAckMode+", + "QThreadSuffixSupported+", + "QListThreadsInStopReply+", +

[Lldb-commits] [PATCH] D100195: [lldb] Require x86 for unwind no-return test

This revision was automatically updated to reflect the committed changes. Closed by commit rGa1f3187ca8a3: [lldb] Require x86 for unwind no-return test (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100195/new/

[Lldb-commits] [lldb] a1f3187 - [lldb] Require x86 for unwind no-return test

Author: David Spickett Date: 2021-04-13T08:51:04Z New Revision: a1f3187ca8a39a62f4a430da823c01aa7874b0d3 URL: https://github.com/llvm/llvm-project/commit/a1f3187ca8a39a62f4a430da823c01aa7874b0d3 DIFF: https://github.com/llvm/llvm-project/commit/a1f3187ca8a39a62f4a430da823c01aa7874b0d3.diff

[Lldb-commits] [PATCH] D100195: [lldb] Require x86 for unwind no-return test

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. In D100195#2679590 , @DavidSpickett wrote: > (apologies for the review spam, you're the author of the test in this case) np > lldb in fact crashes

[Lldb-commits] [PATCH] D100146: [lldb] [gdb-remote client] Refactor handling qSupported

labath added a comment. Herald added a subscriber: JDevlieghere. looks great, just fix the build errors :) Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp:375 + +for (auto x : server_features) { + if (x == "qXfer:auxv:read+")

[Lldb-commits] [lldb] c9cf394 - [lldb] Replace NativeProcess delegate list with a single delegate

Author: Pavel Labath Date: 2021-04-13T09:49:38+02:00 New Revision: c9cf394f796e181b9ee3bc9b69d84fbbba2fe45c URL: https://github.com/llvm/llvm-project/commit/c9cf394f796e181b9ee3bc9b69d84fbbba2fe45c DIFF: https://github.com/llvm/llvm-project/commit/c9cf394f796e181b9ee3bc9b69d84fbbba2fe45c.diff

[Lldb-commits] [PATCH] D100146: [lldb] [gdb-remote client] Refactor handling qSupported

mgorny marked 2 inline comments as done. mgorny added inline comments. Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp:375 + +for (auto x : server_features) { + if (x == "qXfer:auxv:read+") labath wrote: > mgorny

[Lldb-commits] [PATCH] D100153: [lldb] [Process] Introduce protocol extension support API

labath added a comment. I like that (particularly the dependency graph :P). Let's just figure out the error handling.. In D100153#2678223 , @mgorny wrote: > Note that I've included full `fork-events+` and `vfork-events+` as demo of > the API. I can

[Lldb-commits] [PATCH] D100146: [lldb] [gdb-remote client] Refactor handling qSupported

mgorny added a comment. In D100146#2684942 , @labath wrote: > looks great, just fix the build errors :) Yeah, I'm trying to see if I can reproduce them when building with Clang. Comment at:

[Lldb-commits] [lldb] ff31af4 - [lldb] [gdb-remote client] Refactor handling qSupported

Author: Michał Górny Date: 2021-04-13T11:20:11+02:00 New Revision: ff31af4f55af65d173cedcd2f09063c81c8f4f12 URL: https://github.com/llvm/llvm-project/commit/ff31af4f55af65d173cedcd2f09063c81c8f4f12 DIFF: https://github.com/llvm/llvm-project/commit/ff31af4f55af65d173cedcd2f09063c81c8f4f12.diff

[Lldb-commits] [lldb] 96c8216 - [lldb][Arm/AArch64] Add basic disassemble tests for Arm/AArch64

Author: David Spickett Date: 2021-04-13T08:49:48Z New Revision: 96c82166b6e38fd0c138876fb21d2a61af3cfcac URL: https://github.com/llvm/llvm-project/commit/96c82166b6e38fd0c138876fb21d2a61af3cfcac DIFF: https://github.com/llvm/llvm-project/commit/96c82166b6e38fd0c138876fb21d2a61af3cfcac.diff

[Lldb-commits] [lldb] 121cff7 - Revert "[lldb] [Process] Watch for fork/vfork notifications" and associated followups

Author: Pavel Labath Date: 2021-04-13T11:03:06+02:00 New Revision: 121cff78a8032a73aa4fb820625dc1ecae8e3997 URL: https://github.com/llvm/llvm-project/commit/121cff78a8032a73aa4fb820625dc1ecae8e3997 DIFF: https://github.com/llvm/llvm-project/commit/121cff78a8032a73aa4fb820625dc1ecae8e3997.diff

[Lldb-commits] [PATCH] D98153: Some FormatEntity.cpp cleanup and unit testing

nealsid updated this revision to Diff 337331. nealsid added a comment. Fixed comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98153/new/ https://reviews.llvm.org/D98153 Files: lldb/include/lldb/Core/FormatEntity.h

[Lldb-commits] [lldb] accb095 - [lldb] Disable TestClangModulesUpdate.py because it's flaky

Author: Jonas Devlieghere Date: 2021-04-13T20:37:17-07:00 New Revision: accb0955129d94636280cbd713c905b2189e30d4 URL: https://github.com/llvm/llvm-project/commit/accb0955129d94636280cbd713c905b2189e30d4 DIFF:

[Lldb-commits] [PATCH] D100443: [lldb-vscode] Reduce chattiness of progress events

wallace added inline comments. Comment at: lldb/tools/lldb-vscode/ProgressEvent.cpp:38-78 +const char *ProgressEvent::GetEventName() const { + if (m_event_type == progressStart) +return "progressStart"; + else if (m_event_type == progressEnd) +return "progressEnd"; +

[Lldb-commits] [PATCH] D98153: Some FormatEntity.cpp cleanup and unit testing

nealsid updated this revision to Diff 337334. nealsid marked an inline comment as done. nealsid added a comment. Update type in for loop. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98153/new/ https://reviews.llvm.org/D98153 Files:

[Lldb-commits] [PATCH] D98153: Some FormatEntity.cpp cleanup and unit testing

nealsid marked an inline comment as done. nealsid added a comment. Thanks for the review, and apologies for the delay in updating the diffs - seems like I haven't even had an hour to sit down at my dev machine for the past couple weeks, much less actually do any coding :) I don't have commit

[Lldb-commits] [lldb] e825eff - [lldb] Build debugserver 2-way fat on AS

Author: Jonas Devlieghere Date: 2021-04-13T19:55:13-07:00 New Revision: e825effe9ba98c81c9c1799f58e3a7a43e887b38 URL: https://github.com/llvm/llvm-project/commit/e825effe9ba98c81c9c1799f58e3a7a43e887b38 DIFF:

[Lldb-commits] [PATCH] D98153: Some FormatEntity.cpp cleanup and unit testing

nealsid updated this revision to Diff 337329. nealsid added a comment. CR feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98153/new/ https://reviews.llvm.org/D98153 Files: lldb/include/lldb/Core/FormatEntity.h

[Lldb-commits] [PATCH] D100443: [lldb-vscode] Reduce chattiness of progress events

wallace created this revision. wallace added reviewers: clayborg, aadsm. Herald added a subscriber: mgorny. wallace requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Progress events internally have a completed count and a total count, which

[Lldb-commits] [PATCH] D98153: Some FormatEntity.cpp cleanup and unit testing

nealsid marked an inline comment as done. nealsid added inline comments. Comment at: lldb/unittests/Core/FormatEntityTest.cpp:154 +TEST(FormatEntity, LookupAllEntriesInTree) { + for (const auto : lookupStrings) { +Entry e; teemperor wrote: > teemperor

[Lldb-commits] [PATCH] D100191: [lldb] [llgs] Support owning and detaching extra processes

labath added inline comments. Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp:1036 +std::unique_ptr _process) { + // Apparently the process has been dealt with by another delegate. + if (!child_process) mgorny

[Lldb-commits] [PATCH] D100140: [lldb] [gdb-remote server] Refactor handling qSupported

labath added inline comments. Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerCommon.cpp:1310-1311 + "QStartNoAckMode+", + "QThreadSuffixSupported+", + "QListThreadsInStopReply+", + "qEcho+", mgorny wrote: >

[Lldb-commits] [PATCH] D98822: [lldb] [Process] Watch for fork/vfork notifications

labath added a comment. I've reverted this (121cff78a8032a73aa4fb820625dc1ecae8e3997 ) because it made the linux bot super-flaky. I think it's likely that this affects _only_ linux (and the BSD code is fine -- though we don't

[Lldb-commits] [PATCH] D100191: [lldb] [llgs] Support owning and detaching extra processes

mgorny added a comment. @labath, if we're going to remove `m_debugged_process_up`, then I suppose it makes sense to merge D100256 first. Could you review that one, please? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100191/new/

[Lldb-commits] [PATCH] D100256: [lldb] [gdb-remote server] Abstract away getting current process

labath added a comment. Does this actually need to be a function? It seems like this could just be a pointer variable (or two), pointing into our pool of processes. I'd consider making a small struct to group the current process and the current thread within that process. CHANGES SINCE LAST

[Lldb-commits] [PATCH] D98370: [lldb] Fix SBValue::Persist() for constant values

werat added a comment. @jingham @teemperor ping :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98370/new/ https://reviews.llvm.org/D98370 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D100256: [lldb] [gdb-remote server] Abstract away getting current process

labath added a comment. In D100256#2685807 , @mgorny wrote: > In D100256#2685632 , @labath wrote: > >> Does this actually need to be a function? It seems like this could just be a >> pointer variable (or two),

[Lldb-commits] [PATCH] D97786: LLDB: Use path relative to binary, not relative to debugger CWD, for finding .dwo files.

cmtice added a comment. Pavel, your last comment lost me completely. How can I test the code I added to lldb if I don't run lldb? I am a complete newbie at writing test cases so there's probably something basic I'm missing? How would I observe the value of the variable without running lldb?

[Lldb-commits] [lldb] 29a4d78 - [lldb][AArch64] Only run MTE memory region test if we have MTE

Author: David Spickett Date: 2021-04-13T15:40:38+01:00 New Revision: 29a4d7813c75c1fbbd7afef33d32dde92598d1ad URL: https://github.com/llvm/llvm-project/commit/29a4d7813c75c1fbbd7afef33d32dde92598d1ad DIFF:

[Lldb-commits] [PATCH] D100256: [gdb-remote server] Abstract away getting current process

mgorny updated this revision to Diff 337154. mgorny retitled this revision from "[lldb] [gdb-remote server] Abstract away getting current process" to "[gdb-remote server] Abstract away getting current process". mgorny edited the summary of this revision. mgorny added a comment. Switched to

[Lldb-commits] [PATCH] D99944: [LLDB] AArch64 PAC elf-core stack unwinder support

omjavaid added a comment. In D99944#2684280 , @jasonmolenda wrote: > Hi Omair, sorry for the delay in looking at this. It seems like we have two > overlapping patches here, @justincohen patch in > https://reviews.llvm.org/D98886 and this one. > > I'm

[Lldb-commits] [lldb] 14b9f32 - [lldb] Remote @debugserver_test from TestAppleSimulatorOSType

Author: Pavel Labath Date: 2021-04-13T16:09:50+02:00 New Revision: 14b9f320fef9888ab63ff0e791060437a0e1dcc8 URL: https://github.com/llvm/llvm-project/commit/14b9f320fef9888ab63ff0e791060437a0e1dcc8 DIFF: https://github.com/llvm/llvm-project/commit/14b9f320fef9888ab63ff0e791060437a0e1dcc8.diff

[Lldb-commits] [PATCH] D100191: [lldb] [llgs] Support owning and detaching extra processes

mgorny updated this revision to Diff 337164. mgorny edited the summary of this revision. mgorny added a comment. Updated to keep a single list of all attached processes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100191/new/ https://reviews.llvm.org/D100191 Files:

[Lldb-commits] [PATCH] D100256: [gdb-remote server] Abstract away getting current process

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Looks about right. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100256/new/ https://reviews.llvm.org/D100256 ___ lldb-commits mailing

[Lldb-commits] [PATCH] D100384: [lldb/Plugins] Update ScriptedProcess Process Plugin

mib created this revision. mib added reviewers: JDevlieghere, jingham, jasonmolenda. mib added a project: LLDB. Herald added a subscriber: mgorny. mib requested review of this revision. Herald added a subscriber: lldb-commits. This patch is an update of D95713

[Lldb-commits] [PATCH] D97786: LLDB: Use path relative to binary, not relative to debugger CWD, for finding .dwo files.

labath added a comment. One more thing I forgot to mention: In the all-paths-are-relative scenario, lldb will need some help with finding the source files. I believe that currently these will still be resolved relative to CWD, and that's something you may not want (?) Unlike dwos, this can be

[Lldb-commits] [lldb] d7ce89c - [lldb] Remove self-skipping code from lldb-server tests

Author: Pavel Labath Date: 2021-04-13T16:23:43+02:00 New Revision: d7ce89c769d2a518efef5cc4eda152ded33b7ddf URL: https://github.com/llvm/llvm-project/commit/d7ce89c769d2a518efef5cc4eda152ded33b7ddf DIFF: https://github.com/llvm/llvm-project/commit/d7ce89c769d2a518efef5cc4eda152ded33b7ddf.diff

[Lldb-commits] [PATCH] D100256: [lldb] [gdb-remote server] Abstract away getting current process

mgorny added a comment. In D100256#2685632 , @labath wrote: > Does this actually need to be a function? It seems like this could just be a > pointer variable (or two), pointing into our pool of processes. I'd consider > making a small struct to group

[Lldb-commits] [lldb] 872b1da - [lldb/test] s/add_no_ack_remote_stream/do_handshake

Author: Pavel Labath Date: 2021-04-13T17:10:32+02:00 New Revision: 872b1da6ad276515ccfb1481009d23b129c72cac URL: https://github.com/llvm/llvm-project/commit/872b1da6ad276515ccfb1481009d23b129c72cac DIFF: https://github.com/llvm/llvm-project/commit/872b1da6ad276515ccfb1481009d23b129c72cac.diff

[Lldb-commits] [PATCH] D97786: LLDB: Use path relative to binary, not relative to debugger CWD, for finding .dwo files.

labath added a comment. In D97786#2685814 , @cmtice wrote: > Pavel, your last comment lost me completely. How can I test the code I added > to lldb if I don't run lldb? I am a complete newbie at writing test cases so > there's probably something basic

[Lldb-commits] [PATCH] D100153: [lldb] [Process] Introduce protocol extension support API

mgorny added inline comments. Comment at: lldb/include/lldb/Host/common/NativeProcessProtocol.h:389 +m_enabled_extensions = flags; +return llvm::Error::success(); + } labath wrote: > Are you sure that returning success is the best "default" behavior?

[Lldb-commits] [lldb] 63d7564 - Reland "[lldb] [Process] Watch for fork/vfork notifications" for FreeBSD

Author: Michał Górny Date: 2021-04-13T13:19:42+02:00 New Revision: 63d75641054afb0fe43928e9430a2bb92f09e121 URL: https://github.com/llvm/llvm-project/commit/63d75641054afb0fe43928e9430a2bb92f09e121 DIFF: https://github.com/llvm/llvm-project/commit/63d75641054afb0fe43928e9430a2bb92f09e121.diff

[Lldb-commits] [PATCH] D98822: [lldb] [Process] Watch for fork/vfork notifications

labath added a comment. In D98822#2685256 , @mgorny wrote: > In D98822#2685246 , @labath wrote: > >> I've reverted this (121cff78a8032a73aa4fb820625dc1ecae8e3997 >>

[Lldb-commits] [PATCH] D100256: [gdb-remote server] Abstract away getting current process

mgorny updated this revision to Diff 337188. mgorny added a comment. Rebase and make linter happier. Now let's re-test and push. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100256/new/ https://reviews.llvm.org/D100256 Files:

[Lldb-commits] [lldb] 8a5af9e - [debugserver] Fix unintialized member variable

Author: Jonas Devlieghere Date: 2021-04-13T09:46:59-07:00 New Revision: 8a5af9e28443ce8290388439f9e36cf2727d7761 URL: https://github.com/llvm/llvm-project/commit/8a5af9e28443ce8290388439f9e36cf2727d7761 DIFF:

[Lldb-commits] [lldb] f1812a2 - [lldb] [gdb-remote server] Abstract away getting current process

Author: Michał Górny Date: 2021-04-13T18:53:32+02:00 New Revision: f1812a284f28e5b142e63d5deeb340be3ca5d4b3 URL: https://github.com/llvm/llvm-project/commit/f1812a284f28e5b142e63d5deeb340be3ca5d4b3 DIFF: https://github.com/llvm/llvm-project/commit/f1812a284f28e5b142e63d5deeb340be3ca5d4b3.diff

[Lldb-commits] [PATCH] D100338: Add a setting that enables memory to be read from the file cache instead of process when the section LLDB is reading from is read-only

augusto2112 added a comment. @jasonmolenda actually, most of them are passing `prefer_file_cache = false`, unfortunately. But they might be doing this because there's they weren't sure if the memory was writable, so this was the safer option. I want to change all the ones we deem safe to

[Lldb-commits] [PATCH] D100384: [lldb/Plugins] Update ScriptedProcess Process Plugin

mib updated this revision to Diff 337184. mib added a comment. Dead-code removal Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100384/new/ https://reviews.llvm.org/D100384 Files: lldb/include/lldb/Interpreter/ScriptInterpreter.h

[Lldb-commits] [PATCH] D100256: [gdb-remote server] Abstract away getting current process

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf1812a284f28: [lldb] [gdb-remote server] Abstract away getting current process (authored by mgorny). Herald added a project: LLDB. Changed prior to

[Lldb-commits] [PATCH] D100338: Add a setting that enables memory to be read from the file cache instead of process when the section LLDB is reading from is read-only

augusto2112 added a comment. Thanks for the input @jasonmolenda. FWIW I also think it's worth implementing this correctly. Could you help me figure out which callers I should change to `force_live_memory` though? Here's a list of everywhere ReadMemory is called: SBTarget.cpp

Re: [Lldb-commits] [lldb] 8a5af9e - [debugserver] Fix unintialized member variable

I might be missing something here but I think m_launch_flavor Is also uninitialized. It looks like using in class member initialization would be a better fix for any case where the constructor is just a member initialization list with an empty body. > On Apr 13, 2021, at 9:47 AM, Jonas

[Lldb-commits] [PATCH] D100384: [lldb/Plugins] Update ScriptedProcess Process Plugin

JDevlieghere added inline comments. Comment at: lldb/source/Plugins/Process/scripted/ScriptedProcess.cpp:93 + + Log *log(GetLogIfAllCategoriesSet(LIBLLDB_LOG_PROCESS)); + You can move this into the `if` on line 98, or even just inline it.

Re: [Lldb-commits] [lldb] 8a5af9e - [debugserver] Fix unintialized member variable

Thanks Shafik, addressed in ae8a5c68523c1d23dec721e28f89084d6561522a On Tue, Apr 13, 2021 at 9:56 AM Shafik Yaghmour wrote: > I might be missing something here but I think > > m_launch_flavor > > Is also uninitialized. > > It looks like using in class member initialization would be a better fix

[Lldb-commits] [lldb] ae8a5c6 - [debugserver] Use class member initialization for RNBContext

Author: Jonas Devlieghere Date: 2021-04-13T10:39:27-07:00 New Revision: ae8a5c68523c1d23dec721e28f89084d6561522a URL: https://github.com/llvm/llvm-project/commit/ae8a5c68523c1d23dec721e28f89084d6561522a DIFF:

[Lldb-commits] [PATCH] D100338: Add a setting that enables memory to be read from the file cache instead of process when the section LLDB is reading from is read-only

aprantl added a comment. > Let's think about what the default behavior of Target::ReadMemory should be. > The majority use case is that we prefer the file cache if it is a read-only > section. It's a performance bug in almost every case to behave differently, I > maintain. There are times when

[Lldb-commits] [PATCH] D100338: Add a setting that enables memory to be read from the file cache instead of process when the section LLDB is reading from is read-only

jasonmolenda added a comment. I should say, my suggestion of changing Target::ReadMemory is just an opinion, please do feel free to disagree! I think if you look at the callers, I suspect all (or nearly all) of them are passing prefer_file_cache == true right now, which is the

[Lldb-commits] [PATCH] D100191: [lldb] [llgs] Support owning and detaching extra processes

mgorny updated this revision to Diff 337228. mgorny added a comment. Unset `m_current_process` and `m_continue_process` if we're about to detach it. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100191/new/ https://reviews.llvm.org/D100191 Files:

[Lldb-commits] [PATCH] D100191: [lldb] [llgs] Support owning and detaching extra processes

mgorny updated this revision to Diff 337236. mgorny added a comment. Now in a version that actually compiles. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100191/new/ https://reviews.llvm.org/D100191 Files: lldb/include/lldb/Host/common/NativeProcessProtocol.h

[Lldb-commits] [PATCH] D100261: [lldb] [gdb-remote server] Support selecting process via Hg

mgorny updated this revision to Diff 337241. mgorny added a comment. Rebase. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100261/new/ https://reviews.llvm.org/D100261 Files: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp

[Lldb-commits] [PATCH] D100338: Add a setting that enables memory to be read from the file cache instead of process when the section LLDB is reading from is read-only

jasonmolenda added a comment. In D100338#2686410 , @augusto2112 wrote: > Thanks for the input @jasonmolenda. FWIW I also think it's worth implementing > this correctly. > > Could you help me figure out which callers I should change to >

[Lldb-commits] [PATCH] D98370: [lldb] Fix SBValue::Persist() for constant values

jingham added a comment. Sorry for the delay! From my playing around it look like if you do all the same steps as you show in your example, except that you leave out the call to "Persist" and instead directly use the SBValue from the expression directly, then everything works correctly. If

[Lldb-commits] [PATCH] D100384: [lldb/Plugins] Update ScriptedProcess Process Plugin

mib updated this revision to Diff 337226. mib added a comment. Address @JDevlieghere feedbacks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100384/new/ https://reviews.llvm.org/D100384 Files: lldb/include/lldb/Interpreter/ScriptInterpreter.h

[Lldb-commits] [PATCH] D100208: [lldb] [Process/Linux] Report fork/vfork stop reason to client

mgorny updated this revision to Diff 337238. mgorny added a comment. Rebase. Store `mainloop` arg of the original process, and pass it to the children to make them independent of the 'main' process. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100208/new/

[Lldb-commits] [PATCH] D98822: [lldb] [Process] Watch for fork/vfork notifications

mgorny added a comment. In D98822#2685246 , @labath wrote: > I've reverted this (121cff78a8032a73aa4fb820625dc1ecae8e3997 > ) > because it made the linux bot super-flaky. I think it's

[Lldb-commits] [PATCH] D98822: [lldb] [Process] Watch for fork/vfork notifications

labath added a comment. I don't really understand what's going on, but in the one case I was able to catch this "in the act" the inferior process had one thread which was stopped one byte after the breakpoint location (there's no valid instruction there). This leads me to believe that the

[Lldb-commits] [PATCH] D100194: [lldb] Require x86 for various NativePDB, Breakpad and Minidump tests

labath added inline comments. Comment at: lldb/test/Shell/SymbolFile/Breakpad/unwind-via-stack-win-no-memory-info.yaml:13 # CHECK: frame #2: 0x000b1085 unwind-via-stack-win-no-memory-info.exe`main + 5 # CHECK: frame #3: 0x77278494 kernel32.dll # CHECK-NOT: frame

[Lldb-commits] [lldb] c8d18cb - Reland "[lldb] [Process] Watch for fork/vfork notifications" for Linux

Author: Michał Górny Date: 2021-04-13T14:38:31+02:00 New Revision: c8d18cba4e2f63f2135749ef87d09e7f4f405712 URL: https://github.com/llvm/llvm-project/commit/c8d18cba4e2f63f2135749ef87d09e7f4f405712 DIFF: https://github.com/llvm/llvm-project/commit/c8d18cba4e2f63f2135749ef87d09e7f4f405712.diff

[Lldb-commits] [PATCH] D100191: [lldb] [llgs] Support owning and detaching extra processes

mgorny added a comment. In D100191#2685039 , @labath wrote: > I like this a lot more than the previous version. The thing I'd like to know > is, whether we can replace `m_additional_processes` with something like > `m_debugged_processes` (i.e., just

[Lldb-commits] [PATCH] D100153: [lldb] [Process] Introduce protocol extension support API

mgorny updated this revision to Diff 337122. mgorny added a comment. Rebase + clang-format. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100153/new/ https://reviews.llvm.org/D100153 Files: lldb/include/lldb/Host/common/NativeProcessProtocol.h

[Lldb-commits] [PATCH] D100191: [lldb] [llgs] Support owning and detaching extra processes

mgorny added inline comments. Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp:1036 +std::unique_ptr _process) { + // Apparently the process has been dealt with by another delegate. + if (!child_process) labath

[Lldb-commits] [lldb] 7da3b44 - Reland "[lldb] [Process] Watch for fork/vfork notifications" for NetBSD

Author: Michał Górny Date: 2021-04-13T14:35:44+02:00 New Revision: 7da3b44d67f81e4cff3ac4f72888e667bd9e6adb URL: https://github.com/llvm/llvm-project/commit/7da3b44d67f81e4cff3ac4f72888e667bd9e6adb DIFF: https://github.com/llvm/llvm-project/commit/7da3b44d67f81e4cff3ac4f72888e667bd9e6adb.diff

[Lldb-commits] [lldb] f152472 - [lldb] Require x86 for various NativePDB, Breakpad and Minidump tests

Author: David Spickett Date: 2021-04-13T12:51:48Z New Revision: f152472af576e77f9b8736dafaffd31fce7b13b0 URL: https://github.com/llvm/llvm-project/commit/f152472af576e77f9b8736dafaffd31fce7b13b0 DIFF: https://github.com/llvm/llvm-project/commit/f152472af576e77f9b8736dafaffd31fce7b13b0.diff

[Lldb-commits] [PATCH] D100194: [lldb] Require x86 for various NativePDB, Breakpad and Minidump tests

This revision was automatically updated to reflect the committed changes. Closed by commit rGf152472af576: [lldb] Require x86 for various NativePDB, Breakpad and Minidump tests (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] aab81c2 - [lldb] [gdb-remote server] Refactor handling qSupported

Author: Michał Górny Date: 2021-04-13T12:12:25+02:00 New Revision: aab81c2f40d2098f9014473a1e7c8fb7b074360b URL: https://github.com/llvm/llvm-project/commit/aab81c2f40d2098f9014473a1e7c8fb7b074360b DIFF: https://github.com/llvm/llvm-project/commit/aab81c2f40d2098f9014473a1e7c8fb7b074360b.diff

[Lldb-commits] [PATCH] D100140: [lldb] [gdb-remote server] Refactor handling qSupported

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. mgorny marked an inline comment as done. Closed by commit rGaab81c2f40d2: [lldb] [gdb-remote server] Refactor handling qSupported (authored by mgorny). Herald added a

[Lldb-commits] [PATCH] D98822: [lldb] [Process] Watch for fork/vfork notifications

mgorny marked an inline comment as done. mgorny added inline comments. Comment at: lldb/source/Plugins/Process/Linux/NativeProcessLinux.cpp:904-905 + NativeThreadLinux _thread = AddThread(child_pid, /*resume*/ true); + // Resume the newly created thread. +

[Lldb-commits] [PATCH] D100418: [lldb] [MainLoop] Support multiple callbacks per signal

mgorny created this revision. mgorny added reviewers: labath, emaste, krytarowski. mgorny requested review of this revision. Support registering multiple callbacks for a single signal. This is necessary to support multiple co-existing native process instances, with separate SIGCHLD handlers.

[Lldb-commits] [lldb] 479b672 - [lldb] Pretend host architecture is arm64 on AS

Author: Jonas Devlieghere Date: 2021-04-13T18:57:23-07:00 New Revision: 479b672ff9a9230dee37fad97413a88bc0ab362b URL: https://github.com/llvm/llvm-project/commit/479b672ff9a9230dee37fad97413a88bc0ab362b DIFF: