[Lldb-commits] [PATCH] D101539: Add null-pointer checks when accessing a TypeSystem's SymbolFile

augusto2112 updated this revision to Diff 344151. augusto2112 added a comment. Add GetExeModuleWhenMissingSymbolFile tesst. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101539/new/ https://reviews.llvm.org/D101539 Files:

[Lldb-commits] [PATCH] D101539: Add null-pointer checks when accessing a TypeSystem's SymbolFile

teemperor accepted this revision. teemperor added a comment. LGTM, just some nits and please address the clang-format issue. Comment at: lldb/unittests/Symbol/TestTypeSystemClang.cpp:747 +TEST_F(TestTypeSystemClang, GetExeModuleWhenMissingSymbolFile) { + auto compiler_type =

[Lldb-commits] [lldb] 6dc2a6a - Remove some unnecessary explicit defaulted copy ctors to cleanup -Wdeprecated-copy

Author: David Blaikie Date: 2021-05-10T14:31:11-07:00 New Revision: 6dc2a6a8c9a0e4f8b46a0ba05430b77229789b8e URL: https://github.com/llvm/llvm-project/commit/6dc2a6a8c9a0e4f8b46a0ba05430b77229789b8e DIFF: https://github.com/llvm/llvm-project/commit/6dc2a6a8c9a0e4f8b46a0ba05430b77229789b8e.diff

[Lldb-commits] [PATCH] D102085: Add an "interrupt timeout" to Process, fix a bug in handling interrupt timeouts in

jingham updated this revision to Diff 344213. jingham added a comment. When the ReadPacket call in SendContinuePacketAndWaitForResponse wakes up due to the wakeup timeout, and there's an interrupt which hasn't reached it's endpoint, shorten the wakeup interval so we don't wait longer than the

[Lldb-commits] [PATCH] D102085: Add an "interrupt timeout" to Process, fix a bug in handling interrupt timeouts in

jingham marked an inline comment as done. jingham added a comment. Was that what you had in mind, Greg? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102085/new/ https://reviews.llvm.org/D102085 ___

[Lldb-commits] [PATCH] D102085: Add an "interrupt timeout" to Process, fix a bug in handling interrupt timeouts in

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. In D102085#2749112 , @jingham wrote: > Was that what you had in mind, Greg? Yes! Thanks for all the changes. LGTM Repository: rG LLVM Github

[Lldb-commits] [PATCH] D101539: Add null-pointer checks when accessing a TypeSystem's SymbolFile

augusto2112 added a comment. @teemperor let me know if this test is OK, or if there's a better way to test this :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101539/new/ https://reviews.llvm.org/D101539

[Lldb-commits] [PATCH] D102140: [ppc64le] [lldb] [testsuite] Fix false FAILs on ppc64* with no hw watchpoints

jankratochvil updated this revision to Diff 344000. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102140/new/ https://reviews.llvm.org/D102140 Files: lldb/packages/Python/lldbsuite/test/concurrent_base.py

[Lldb-commits] [PATCH] D102140: [ppc64le] [lldb] [testsuite] Fix false FAILs on ppc64* with no hw watchpoints

jankratochvil planned changes to this revision. jankratochvil added a comment. I forgot it should be also checking it is PowerPC. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102140/new/ https://reviews.llvm.org/D102140

[Lldb-commits] [PATCH] D102085: Add an "interrupt timeout" to Process, fix a bug in handling interrupt timeouts in

shafik added inline comments. Comment at: lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp:3129 uint8_t error_no = m_gdb_comm.SendGDBStoppointTypePacket( -eBreakpointSoftware, true, addr, bp_op_size); +eBreakpointSoftware, true, addr, bp_op_size,

[Lldb-commits] [PATCH] D102092: [lldb] Enable -Wmisleading-indentation

This revision was automatically updated to reflect the committed changes. Closed by commit rGf44c6f20f5e9: [cmake] Enable -Wmisleading-indentation (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102092/new/

[Lldb-commits] [PATCH] D102092: [lldb] Enable -Wmisleading-indentation

kastiglione added a comment. Will keep an eye on buildbots, thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102092/new/ https://reviews.llvm.org/D102092 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D102085: Add an "interrupt timeout" to Process, fix a bug in handling interrupt timeouts in

clayborg added a comment. Thanks for combining the functions and fine not to use Optional is we have a good value to indicate no timeout. Just one inline comment where we can hopefully get rid of kWakeupInterval being a constant. Comment at: