[Lldb-commits] [lldb] 5e32778 - [lldb] Match test dependencies name to other LLVM projects.

Author: Daniel Rodríguez Troitiño Date: 2021-05-21T00:10:27-07:00 New Revision: 5e327785da36fa3a00767cfea0a47fcb0f0814aa URL: https://github.com/llvm/llvm-project/commit/5e327785da36fa3a00767cfea0a47fcb0f0814aa DIFF:

[Lldb-commits] [PATCH] D102889: [lldb] Match test dependencies name to other LLVM projects.

This revision was automatically updated to reflect the committed changes. Closed by commit rG5e327785da36: [lldb] Match test dependencies name to other LLVM projects. (authored by drodriguez, committed by smeenai). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D102872: Fix lldb-server build failure on mips

DavidSpickett added a comment. I assume this is caused by the removal of the specific `NativeRegisterContextLinux_mips` and you are building lldb on MIPS but you're going to connect to another debug server (gdb, custom stub etc.). The problem with doing it this way is then if you build on a

[Lldb-commits] [PATCH] D102872: Fix lldb-server build failure on mips

raj.khem added a comment. In D102872#2773106 , @DavidSpickett wrote: > I assume this is caused by the removal of the specific > `NativeRegisterContextLinux_mips` and you are building lldb on MIPS but > you're going to connect to another debug server

[Lldb-commits] [PATCH] D102140: [ppc64le] [lldb] [testsuite] Fix false FAILs on ppc64* with no hw watchpoints

DavidSpickett added a comment. Is there any command we can run to directly get the number of h/w watchpoints? I'm thinking that a lot of these are: try: doThing() except: if we got this specific error Then you could have this at the start of each test instead: if not

[Lldb-commits] [PATCH] D102140: [ppc64le] [lldb] [testsuite] Fix false FAILs on ppc64le with no hw watchpoints

DavidSpickett added inline comments. Comment at: lldb/test/API/commands/watchpoints/hello_watchpoint/TestMyFirstWatchpoint.py:68 +except: +if self.getArchitecture() == 'powerpc64le' \ + and "\nerror: Target supports (0) hardware watchpoint

[Lldb-commits] [PATCH] D102140: [ppc64le] [lldb] [testsuite] Fix false FAILs on ppc64* with no hw watchpoints

jankratochvil planned changes to this revision. jankratochvil marked an inline comment as done. jankratochvil added a comment. In D102140#2768660 , @DavidSpickett wrote: > Is there any command we can run to directly get the number of h/w watchpoints?

[Lldb-commits] [PATCH] D102630: [lit] Stop using PATH to lookup clang/lld/lldb unless requested

thopre added a comment. In D102630#2764705 , @dblaikie wrote: > @thopre - as an aside: It'd be helpful if you could include some text in the > text box when marking something "approved" through phabricator. There's a > bug/limitation that approvals

[Lldb-commits] [PATCH] D102140: [ppc64le] [lldb] [testsuite] Fix false FAILs on ppc64le with no hw watchpoints

DavidSpickett added a comment. > If there isn't a specific command you could do something silly like watch > main and see if it succeeds then remove the watchpoint. Or you could watch address 0, there's no requirement for it to be a symbol. Repository: rG LLVM Github Monorepo CHANGES SINCE

[Lldb-commits] [PATCH] D101921: [MC] Make it possible for targets to define their own MCObjectFileInfo

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. LGTM. This looks like an improvement because it avoids a temporary `MCObjectFileInfo MOFI;` (which appeared to be initialized in two subsequent calls) in numerous places. Repository: rG

[Lldb-commits] [PATCH] D100581: [Clang] -Wunused-but-set-parameter and -Wunused-but-set-variable

mbenfield updated this revision to Diff 346904. mbenfield added a comment. Herald added subscribers: llvm-commits, lldb-commits, kbarton, hiraditya, nemanjai. Herald added projects: LLDB, LLVM. Don't warn for reference or dependent types (fixing false positives). Also fix a few places where

[Lldb-commits] [PATCH] D100581: [Clang] -Wunused-but-set-parameter and -Wunused-but-set-variable

xbolva00 added a comment. >> Also fix a few places where this warning is correctly triggered. Create new patch please - dont mix fixes with new warning within one patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100581/new/

[Lldb-commits] [PATCH] D102904: [LoopNest][LoopFlatten] Change LoopFlattenPass to LoopNest pass

eopXD updated this revision to Diff 346965. eopXD added a comment. Herald added subscribers: cfe-commits, libcxx-commits, openmp-commits, lldb-commits, Sanitizers, shabalin, jsmolens, eric-k256, dcaballe, cota, mravishankar, teijeong, frasercrmck, dexonsmith, rdzhabarov, tatianashp, wenlei,

[Lldb-commits] [PATCH] D101921: [MC] Make it possible for targets to define their own MCObjectFileInfo

MaskRay added a comment. Can `createMCObjectFileInfo` return `MCObjectFileInfo` instead of `std::unique_ptr`? Comment at: clang/lib/Parse/ParseStmtAsm.cpp:590 + if (!MAI || !MII || !MOFI || !STI) { Diag(AsmLoc, diag::err_msasm_unable_to_create_target)

[Lldb-commits] [PATCH] D101921: [MC] Make it possible for targets to define their own MCObjectFileInfo

flip1995 updated this revision to Diff 344849. flip1995 added a comment. Herald added subscribers: lldb-commits, atanasyan, jrtc27. Herald added a project: LLDB. rebased and addressed review comments: - [MC] Remove MOFI argument from MCContext constructor - [MC] Remove getTextSectionAlignment

[Lldb-commits] [PATCH] D101921: [MC] Make it possible for targets to define their own MCObjectFileInfo

flip1995 added a comment. In D101921#2754426 , @MaskRay wrote: > Can `createMCObjectFileInfo` return `MCObjectFileInfo` instead of > `std::unique_ptr`? `createMCObjectfileInfo` returns a `MCObjectFileInfo *` similar to every other `create*` function

[Lldb-commits] [PATCH] D101921: [MC] Make it possible for targets to define their own MCObjectFileInfo

flip1995 updated this revision to Diff 345432. flip1995 added a comment. - [MC] Don't check if constructed MOFI is a nullptr Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101921/new/ https://reviews.llvm.org/D101921 Files:

[Lldb-commits] [PATCH] D102630: [lit] Stop using PATH to lookup clang/lld/lldb unless requested

This revision was automatically updated to reflect the committed changes. Closed by commit rGa1e656585578: [lit] Stop using PATH to lookup clang/lld/lldb unless requested (authored by jhenderson). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D102630: [lit] Stop using PATH to lookup clang/lld/lldb unless requested

jhenderson created this revision. jhenderson added reviewers: JDevlieghere, aprantl, MaskRay, thopre, dblaikie, teemperor. Herald added subscribers: usaxena95, kadircet, delcypher. jhenderson requested review of this revision. Herald added subscribers: lldb-commits, ilya-biryukov, aheejin. Herald

[Lldb-commits] [PATCH] D102208: Remove Windows editline from LLDB

nealsid created this revision. nealsid added reviewers: LLDB, kparzysz. Herald added subscribers: hiraditya, krytarowski, mgorny. nealsid requested review of this revision. Herald added projects: LLDB, LLVM. Herald added subscribers: llvm-commits, lldb-commits. I don't mean to undo others' work

[Lldb-commits] [PATCH] D102208: Remove Windows editline from LLDB

DavidSpickett added inline comments. Comment at: llvm/lib/Target/Hexagon/HexagonVectorCombine.cpp:302 -#if !defined(_MSC_VER) || _MSC_VER >= 1924 +#if !defined(_MSC_VER) || _MSC_VER >= 1926 // VS2017 has trouble compiling this: This should be done in a

[Lldb-commits] [PATCH] D97449: [Diagnose] Unify MCContext and LLVMContext diagnosing

DavidSpickett added a comment. @ychen Since this change the warning emitted in `AsmPrinterInlineAsm.cpp` about reserved registers no longer has location information for the file that the inline asm is in. Here's an example: void bar(void) { __asm__ __volatile__ ( "nop" : : : "sp");

[Lldb-commits] [PATCH] D102208: Remove Windows editline from LLDB

teemperor added reviewers: stella.stamenova, amccarth. teemperor added a comment. No idea about how/if this is used, but I think Stella or Adrian are the ones that might be able to answer this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D97449: [Diagnose] Unify MCContext and LLVMContext diagnosing

DavidSpickett added a comment. Can you guide me on how I might correct this? Actually, now I see that MCContext has reportWarning/reportError and just needs a reportNote. I'll have something for you to review shortly. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D102208: Remove Windows editline from LLDB

amccarth added a subscriber: zturner. amccarth added a comment. It looks like this EditLine port was added before I joined this project. @zturner may have worked on it, but I don't know/remember. If it's actually unused, I have no objection to removing it. I harbor some hope that Windows's

[Lldb-commits] [PATCH] D102208: Remove Windows editline from LLDB

nealsid updated this revision to Diff 344489. nealsid added a comment. Updated the diff after moving an unrelated change into another revision. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102208/new/ https://reviews.llvm.org/D102208 Files:

[Lldb-commits] [PATCH] D102208: Remove Windows editline from LLDB

nealsid added a comment. I ran LLDB tests from a clean tree and with my change and the failures seemed to be the same, but there is a large amount of them. I also did manual testing with the changes. Build is still green. Editline is only used when Cmake can find the editline libraries,

[Lldb-commits] [PATCH] D102208: Remove Windows editline from LLDB

stella.stamenova added a comment. I don't have context into this either. Does this cause any test failures or is everything still green after the change? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102208/new/ https://reviews.llvm.org/D102208

[Lldb-commits] [PATCH] D102208: Remove Windows editline from LLDB

nealsid added a comment. Thanks, all. If there are no more comments, could someone land it for me? I don't have commit access. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102208/new/ https://reviews.llvm.org/D102208

[Lldb-commits] [PATCH] D102208: Remove Windows editline from LLDB

amccarth accepted this revision. amccarth added a comment. This revision is now accepted and ready to land. LGTM. Dead code should go. If somebody wants to own a Windows port of EditLine, they can re-instate it and put some tests on it. Thanks. Repository: rG LLVM Github Monorepo CHANGES

[Lldb-commits] [PATCH] D102208: Remove Windows editline from LLDB

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5af3a6645f38: Remove Windows editline from LLDB (authored by nealsid, committed by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES

[Lldb-commits] [PATCH] D102208: Remove Windows editline from LLDB

DavidSpickett added a comment. > Thanks, all. If there are no more comments, could someone land it for me? I > don't have commit access. Done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102208/new/ https://reviews.llvm.org/D102208

[Lldb-commits] [PATCH] D101128: [lldb-vscode] only report long running progress events

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. The only last nit is we are passing the report progress callback around all over the place. I think it would be nicer to just make a static function that we can call and remove

[Lldb-commits] [PATCH] D102942: Remove or use variables which are unused but set.

mbenfield added a comment. Herald added a subscriber: JDevlieghere. Several variables I have just removed outright, including llvm/lib/Target/X86/X86FloatingPoint.cpp: STDeadDefs lldb/source/Plugins/ABI/PowerPC/ABISysV_ppc.cpp: fp_bytes lldb/source/Interpreter/CommandInterpreter.cpp:

[Lldb-commits] [PATCH] D102942: Remove or use variables which are unused but set.

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Sure, all sounds good - if you can, please reach out to the authors of any of the semantics changing changes (the ones related to the `Changed` values in transformations) to see if they

[Lldb-commits] [PATCH] D102942: Remove or use variables which are unused but set.

mbenfield created this revision. Herald added subscribers: pengfei, lebedev.ri, kbarton, hiraditya, nemanjai. Herald added a reviewer: lebedev.ri. mbenfield requested review of this revision. Herald added projects: LLDB, LLVM. Herald added subscribers: llvm-commits, lldb-commits. This is in

[Lldb-commits] [PATCH] D100243: [LLDB][GUI] Expand selected thread tree item by default

wallace added inline comments. Herald added a reviewer: teemperor. Comment at: lldb/test/API/commands/gui/expand-threads-tree/TestGuiExpandThreadsTree.py:38 +# Exit GUI. +self.child.send(escape_key) +self.expect_prompt() create a method

Re: [Lldb-commits] [lldb] 8dd1060 - [debugserver] Add platform cache support to improve performance.

So I guess we don’t use in class member initialization for m_platform b/c GetPlatform() can never be called before either Clear() or Detach()? > On May 20, 2021, at 7:10 PM, Jonas Devlieghere via lldb-commits > wrote: > > > Author: kuperxu > Date: 2021-05-20T19:10:46-07:00 > New Revision: