[Lldb-commits] [PATCH] D106553: [LLDB][GUI] Resolve paths in file/directory fields

OmarEmaraDev added inline comments. Comment at: lldb/source/Core/IOHandlerCursesGUI.cpp:1308 } if (FileSystem::Instance().IsDirectory(file)) { SetError("Not a file!"); clayborg wrote: > This is checking for a directory, not a file Not sure what y

[Lldb-commits] [PATCH] D106584: [lldb] Improve checking of file cache read eligibility for mach-O

jasonmolenda added a comment. Sorry for the delay in replying, I needed to think & look at this a bit. In D106584#2900239 , @augusto2112 wrote: > Hi Jason, > > I could place this check on the caller, but I think here is the right place > for it, maybe

[Lldb-commits] [PATCH] D106584: [lldb] Improve checking of file cache read eligibility for mach-O

jasonmolenda added a comment. In D106584#2902200 , @jasonmolenda wrote: > > In D106584#2900239 , @augusto2112 > wrote: > >> Hi Jason, >> >> At least that we can keep then :) Do you think it's should be a cra

[Lldb-commits] [PATCH] D105741: [trace] Add `thread trace export` command for Intel PT trace visualization

jj10306 updated this revision to Diff 361460. jj10306 edited the summary of this revision. jj10306 added a comment. Rebase and address comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105741/new/ https://reviews.llvm.org/D105741 Files: lldb/docs/htr.rst lldb/docs/media/basic_

[Lldb-commits] [PATCH] D105741: [trace] Add `thread trace export` command for Intel PT trace visualization

jj10306 added a comment. Looks like I pulled in some unwanted changes related to the traceinstruction dumper and tsc when I rebased - will resolve this issue before landing CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105741/new/ https://reviews.llvm.org/D105741 _