[Lldb-commits] [PATCH] D111209: Don't push null ExecutionContext on CommandInterpreter exectx stack

jasonmolenda created this revision. jasonmolenda added a reviewer: tatyana-krasnukha. jasonmolenda added a project: LLDB. Herald added subscribers: JDevlieghere, GorNishanov. jasonmolenda requested review of this revision. Part of Tatyana's patch in https://reviews.llvm.org/D92164 added a stack of

[Lldb-commits] [PATCH] D111209: Don't push null ExecutionContext on CommandInterpreter exectx stack

jasonmolenda added a comment. Another possible approach would be to allow an ExecutionContext with a nullptr Target to push on to the stack, but then in CommandInterpeter::GetExecutionContext skip over those until we find one with a Target, or fall back to the Debugger::GetSelectedExecutionCont

[Lldb-commits] [PATCH] D111214: [lldb] [FreeBSD] Fix building on systems without PT_COREDUMP

mgorny created this revision. mgorny added reviewers: krytarowski, emaste, labath, teemperor, brooks. mgorny requested review of this revision. PT_COREDUMP is a relatively recent addition. Use an #ifdef to skip it if the underlying system does not support it. https://reviews.llvm.org/D111214 F

[Lldb-commits] [PATCH] D111131: [LLDB] Round XML register bitsize to byte boundary

omjavaid updated this revision to Diff 377470. omjavaid added a comment. This addresses review comments converts printfs to log messages. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D31/new/ https://reviews.llvm.org/D31 Files: lldb/source/Plugins/Process/gdb-remote/ProcessGD

[Lldb-commits] [PATCH] D110570: [lldb] Refactor variable parsing in DWARF symbol file

jarin updated this revision to Diff 377474. jarin marked 2 inline comments as done. jarin added a comment. Avoid nullptr deref/ref. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110570/new/ https://reviews.llvm.org/D110570 Files: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.c

[Lldb-commits] [lldb] d2b9d0f - Round XML register bitsize to byte boundary

Author: Muhammad Omair Javaid Date: 2021-10-06T14:03:49+05:00 New Revision: d2b9d0fdda5e8295a2a81276fa6be8ea8d1fd022 URL: https://github.com/llvm/llvm-project/commit/d2b9d0fdda5e8295a2a81276fa6be8ea8d1fd022 DIFF: https://github.com/llvm/llvm-project/commit/d2b9d0fdda5e8295a2a81276fa6be8ea8d1fd0

[Lldb-commits] [PATCH] D111131: [LLDB] Round XML register bitsize to byte boundary

This revision was automatically updated to reflect the committed changes. Closed by commit rGd2b9d0fdda5e: Round XML register bitsize to byte boundary (authored by omjavaid). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[Lldb-commits] [PATCH] D110570: [lldb] Refactor variable parsing in DWARF symbol file

jarin added a comment. Pavel, could you take another look? Interestingly the null-deref problem was already fixed in the follow-up patch , maybe I just did not land quickly enough :-)). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110570/new/ https:/

[Lldb-commits] [PATCH] D111216: [lldb] [ABI/X86] Split plugin class and base i386 class

mgorny created this revision. mgorny added reviewers: labath, teemperor, krytarowski, emaste. Herald added a subscriber: pengfei. mgorny requested review of this revision. Split the ABIX86 class into two classes: ABIX86 class used to define the plugin, and ABIX86_i386 class that is the base for 32

[Lldb-commits] [PATCH] D111216: [lldb] [ABI/X86] Split plugin class and base i386 class

mgorny added inline comments. Comment at: lldb/source/Plugins/ABI/X86/ABIX86_i386.h:14 + +class ABIX86_i386 : public lldb_private::MCBasedABI { +public: For the record, I'm not married to this name ;-). I was originally thinking of `ABIX86_32` but it felt weird

[Lldb-commits] [PATCH] D110570: [lldb] Refactor variable parsing in DWARF symbol file

labath added a comment. looks good CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110570/new/ https://reviews.llvm.org/D110570 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commi

[Lldb-commits] [PATCH] D111216: [lldb] [ABI/X86] Split plugin class and base i386 class

labath accepted this revision. labath added inline comments. This revision is now accepted and ready to land. Comment at: lldb/source/Plugins/ABI/X86/ABIX86.h:12 -#include "lldb/Target/ABI.h" - -class ABIX86 : public lldb_private::MCBasedABI { +class ABIX86 { public: -

[Lldb-commits] [PATCH] D111136: [lldb] [DynamicRegisterInfo] Support iterating over Registers()

labath added inline comments. Comment at: lldb/include/lldb/Target/DynamicRegisterInfo.h:81 + typedef std::vector reg_collection; + llvm::iterator_range Registers() { +return llvm::iterator_range(m_regs); mgorny wrote: > labath wrote: > > llvm (and, surpris

[Lldb-commits] [PATCH] D111216: [lldb] [ABI/X86] Split plugin class and base i386 class

mgorny marked an inline comment as done. mgorny added inline comments. Comment at: lldb/source/Plugins/ABI/X86/ABIX86.h:12 -#include "lldb/Target/ABI.h" - -class ABIX86 : public lldb_private::MCBasedABI { +class ABIX86 { public: labath wrote: > Now it's weird

[Lldb-commits] [lldb] a30a36f - [lldb] [ABI/X86] Split base x86 and i386 classes

Author: Michał Górny Date: 2021-10-06T13:59:21+02:00 New Revision: a30a36f66aea459337999a000c7997b220b25227 URL: https://github.com/llvm/llvm-project/commit/a30a36f66aea459337999a000c7997b220b25227 DIFF: https://github.com/llvm/llvm-project/commit/a30a36f66aea459337999a000c7997b220b25227.diff

[Lldb-commits] [PATCH] D111216: [lldb] [ABI/X86] Split plugin class and base i386 class

This revision was automatically updated to reflect the committed changes. mgorny marked an inline comment as done. Closed by commit rGa30a36f66aea: [lldb] [ABI/X86] Split base x86 and i386 classes (authored by mgorny). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.

[Lldb-commits] [lldb] 02e690b - [lldb] [FreeBSD] Fix building on systems without PT_COREDUMP

Author: Michał Górny Date: 2021-10-06T14:05:07+02:00 New Revision: 02e690ba0b10c422cbec77105eb40835dab57092 URL: https://github.com/llvm/llvm-project/commit/02e690ba0b10c422cbec77105eb40835dab57092 DIFF: https://github.com/llvm/llvm-project/commit/02e690ba0b10c422cbec77105eb40835dab57092.diff

[Lldb-commits] [PATCH] D111214: [lldb] [FreeBSD] Fix building on systems without PT_COREDUMP

This revision was automatically updated to reflect the committed changes. Closed by commit rG02e690ba0b10: [lldb] [FreeBSD] Fix building on systems without PT_COREDUMP (authored by mgorny). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://re

[Lldb-commits] [PATCH] D111136: [lldb] [DynamicRegisterInfo] Support iterating over Registers()

mgorny added inline comments. Comment at: lldb/include/lldb/Target/DynamicRegisterInfo.h:82 + llvm::iterator_range Registers() { +return llvm::iterator_range(m_regs); + } labath wrote: > mgorny wrote: > > ted wrote: > > > mgorny wrote: > > > > labath wrote:

[Lldb-commits] [PATCH] D110914: [lldb] Remove "dwarf dynamic register size expressions" from RegisterInfo

jrtc27 added a comment. In D110914#3036085 , @labath wrote: > In D110914#3036079 , @jrtc27 wrote: > >> Is this removing this going to be a problem for RISC-V, where the >> floating-point registers could be 32-bit

[Lldb-commits] [lldb] fd185cf - Reland "[lldb] Refactor variable parsing"

Author: Jaroslav Sevcik Date: 2021-10-06T14:25:47+02:00 New Revision: fd185cfc513c4e5e280acc6d4e7248b773285798 URL: https://github.com/llvm/llvm-project/commit/fd185cfc513c4e5e280acc6d4e7248b773285798 DIFF: https://github.com/llvm/llvm-project/commit/fd185cfc513c4e5e280acc6d4e7248b773285798.dif

[Lldb-commits] [lldb] 7862728 - [lldb] Rewrite and extend TestConstThis

Author: Raphael Isemann Date: 2021-10-06T14:51:00+02:00 New Revision: 7862728cab1b7724d2adf0f0075a3289d87ec20c URL: https://github.com/llvm/llvm-project/commit/7862728cab1b7724d2adf0f0075a3289d87ec20c DIFF: https://github.com/llvm/llvm-project/commit/7862728cab1b7724d2adf0f0075a3289d87ec20c.dif

[Lldb-commits] [PATCH] D111136: [lldb] [DynamicRegisterInfo] Support iterating over Registers()

mgorny updated this revision to Diff 377516. mgorny added a comment. Switch to a `const_iterator`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D36/new/ https://reviews.llvm.org/D36 Files: lldb/include/lldb/Target/DynamicRegisterInfo.h lldb/source/Plugins/Process/gdb-remote

[Lldb-commits] [PATCH] D111136: [lldb] [DynamicRegisterInfo] Support iterating over registers()

mgorny updated this revision to Diff 377520. mgorny retitled this revision from "[lldb] [DynamicRegisterInfo] Support iterating over Registers()" to "[lldb] [DynamicRegisterInfo] Support iterating over registers()". mgorny edited the summary of this revision. mgorny added a comment. Switch to lo

[Lldb-commits] [lldb] f98df8a - [lldb] Make 'this' substituton error more verbose.

Author: Raphael Isemann Date: 2021-10-06T15:07:19+02:00 New Revision: f98df8a38b00b207b5f5deda607fd6862ad550f0 URL: https://github.com/llvm/llvm-project/commit/f98df8a38b00b207b5f5deda607fd6862ad550f0 DIFF: https://github.com/llvm/llvm-project/commit/f98df8a38b00b207b5f5deda607fd6862ad550f0.dif

[Lldb-commits] [PATCH] D108953: [lldb/Plugins] Add memory region support in ScriptedProcess

mib added inline comments. Comment at: lldb/source/Plugins/Process/scripted/ScriptedProcess.cpp:278 +if (error.Fail()) + return error; + JDevlieghere wrote: > If this is the only way out of this loop, does that mean we always return an > error here? In

[Lldb-commits] [PATCH] D111142: [lldb] [ABI] Apply AugmentRegisterInfo() to RemoteRegisterInfos

mgorny updated this revision to Diff 377538. mgorny retitled this revision from "[lldb] [ABI] Make AugmentRegisterInfo() take whole DynamicRegisterInfo" to "[lldb] [ABI] Apply AugmentRegisterInfo() to RemoteRegisterInfos". mgorny edited the summary of this revision. mgorny added a comment. Pass

[Lldb-commits] [PATCH] D111136: [lldb] [DynamicRegisterInfo] Support iterating over registers()

mgorny added inline comments. Comment at: lldb/include/lldb/Target/DynamicRegisterInfo.h:82 + llvm::iterator_range Registers() { +return llvm::iterator_range(m_regs); + } mgorny wrote: > labath wrote: > > mgorny wrote: > > > ted wrote: > > > > mgorny wrote:

[Lldb-commits] [lldb] 10f16bc - Revert "[lldb] [ABI/X86] Split base x86 and i386 classes"

Author: Stella Stamenova Date: 2021-10-06T10:56:45-07:00 New Revision: 10f16bc7b2bfa0fb3589ac62fc8392854a3a2226 URL: https://github.com/llvm/llvm-project/commit/10f16bc7b2bfa0fb3589ac62fc8392854a3a2226 DIFF: https://github.com/llvm/llvm-project/commit/10f16bc7b2bfa0fb3589ac62fc8392854a3a2226.di

[Lldb-commits] [lldb] 6723165 - [lldb] [ABI/X86] Split base x86 and i386 classes

Author: Michał Górny Date: 2021-10-06T22:21:48+02:00 New Revision: 67231650e6ef2dda02838cf9146a200ba7e08a84 URL: https://github.com/llvm/llvm-project/commit/67231650e6ef2dda02838cf9146a200ba7e08a84 DIFF: https://github.com/llvm/llvm-project/commit/67231650e6ef2dda02838cf9146a200ba7e08a84.diff

[Lldb-commits] [lldb] 14aa3f3 - Use llvm::VersionTuple to store DWARF producer info (NFC)

Author: Adrian Prantl Date: 2021-10-06T14:56:16-07:00 New Revision: 14aa3f3703b54854dcd5aa270f68515388420e6f URL: https://github.com/llvm/llvm-project/commit/14aa3f3703b54854dcd5aa270f68515388420e6f DIFF: https://github.com/llvm/llvm-project/commit/14aa3f3703b54854dcd5aa270f68515388420e6f.diff

[Lldb-commits] [lldb] 2edb905 - Simplify control flow (NFC)

Author: Adrian Prantl Date: 2021-10-06T14:56:17-07:00 New Revision: 2edb9058ea635f950f67bf7cb52f76588d362dfc URL: https://github.com/llvm/llvm-project/commit/2edb9058ea635f950f67bf7cb52f76588d362dfc DIFF: https://github.com/llvm/llvm-project/commit/2edb9058ea635f950f67bf7cb52f76588d362dfc.diff

[Lldb-commits] [lldb] 8c5f334 - Add a unit test for llvm-gcc producer strings and cleanup code. (NFC)

Author: Adrian Prantl Date: 2021-10-06T14:56:17-07:00 New Revision: 8c5f3348af38843b5f0ca13e82cc285af4e3582d URL: https://github.com/llvm/llvm-project/commit/8c5f3348af38843b5f0ca13e82cc285af4e3582d DIFF: https://github.com/llvm/llvm-project/commit/8c5f3348af38843b5f0ca13e82cc285af4e3582d.diff

[Lldb-commits] [PATCH] D111200: Use llvm::VersionTuple to store DWARF producer info (NFC)

This revision was automatically updated to reflect the committed changes. Closed by commit rG14aa3f3703b5: Use llvm::VersionTuple to store DWARF producer info (NFC) (authored by aprantl). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D111200?vs=377403&id=377699

[Lldb-commits] [PATCH] D111278: Recognize the Swift compiler in DW_AT_producer

aprantl created this revision. aprantl added reviewers: JDevlieghere, kastiglione, jingham. aprantl requested review of this revision. This patch adds support for Swift compiler producer strings to DWARFUnit. https://reviews.llvm.org/D111278 Files: lldb/source/Plugins/SymbolFile/DWARF/DWARFUn

[Lldb-commits] [PATCH] D111278: Recognize the Swift compiler in DW_AT_producer

aprantl updated this revision to Diff 377702. aprantl added a comment. Sort variables in a more logical order. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111278/new/ https://reviews.llvm.org/D111278 Files: lldb/source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp lldb/source/Plugins/Sy

[Lldb-commits] [lldb] f6a561c - DebugInfo: Use clang's preferred names for integer types

Author: David Blaikie Date: 2021-10-06T16:02:34-07:00 New Revision: f6a561c4d6754b13165a49990e8365d819f64c86 URL: https://github.com/llvm/llvm-project/commit/f6a561c4d6754b13165a49990e8365d819f64c86 DIFF: https://github.com/llvm/llvm-project/commit/f6a561c4d6754b13165a49990e8365d819f64c86.diff

[Lldb-commits] [PATCH] D110455: DebugInfo: Use clang's preferred names for integer types

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf6a561c4d675: DebugInfo: Use clang's preferred names for integer types (authored by dblaikie). Herald added subscribers: llvm-commits, lldb-commits,

[Lldb-commits] [PATCH] D108953: [lldb/Plugins] Add memory region support in ScriptedProcess

mib updated this revision to Diff 377724. mib added a comment. Return an Optional to stop fetching memory regions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108953/new/ https://reviews.llvm.org/D108953 Files: lldb/bindings/interface/SBMemory

[Lldb-commits] [PATCH] D111278: Recognize the Swift compiler in DW_AT_producer

JDevlieghere added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp:684 + llvm::SmallVector matches; + if (g_swiftlang_version_regex.Execute(producer, &matches)) { + m_producer_version.tryParse(matches[1]); For consistency wi

[Lldb-commits] [PATCH] D110535: [llvm] [ADT] Update llvm::Split() per Pavel Labath's suggestions

joerg added a comment. Can't you wrap `iterator_range` and possibly even support Twines like that? That is, don't extend the life time of the iterators, but store it in the range? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110535/new/ https://reviews.llvm.org/D110535 __

[Lldb-commits] [PATCH] D111278: Recognize the Swift compiler in DW_AT_producer

shafik added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp:674 + static RegularExpression g_swiftlang_version_regex( + llvm::StringRef(R"(swiftlang-([0-9]+\.[0-9]+\.[0-9]+(\.[0-9]+)?))")); `const`? CHANGES SINCE LAST AC

[Lldb-commits] [lldb] 809652c - Update TODO noting that DriverKit should be added too

Author: Jason Molenda Date: 2021-10-06T20:12:21-07:00 New Revision: 809652c93ba6b0fe6b01f935cc3da88d26a6714d URL: https://github.com/llvm/llvm-project/commit/809652c93ba6b0fe6b01f935cc3da88d26a6714d DIFF: https://github.com/llvm/llvm-project/commit/809652c93ba6b0fe6b01f935cc3da88d26a6714d.diff

[Lldb-commits] [lldb] 62d9163 - Don't register mem segments that aren't present in a corefile

Author: Jason Molenda Date: 2021-10-06T20:12:21-07:00 New Revision: 62d9163830d0b8b09e1e6d6a43c99c1371091c65 URL: https://github.com/llvm/llvm-project/commit/62d9163830d0b8b09e1e6d6a43c99c1371091c65 DIFF: https://github.com/llvm/llvm-project/commit/62d9163830d0b8b09e1e6d6a43c99c1371091c65.diff