[Lldb-commits] [PATCH] D112691: Include target settings in "statistics dump" output.

clayborg created this revision. clayborg added reviewers: wallace, aadsm, jingham, JDevlieghere. clayborg requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Many target settings can be set that can affect how breakpoints are found during a

[Lldb-commits] [PATCH] D112629: [lldb] [Host/Socket] Make DecodeHostAndPort() return a dedicated struct

labath accepted this revision. labath added inline comments. This revision is now accepted and ready to land. Comment at: lldb/source/Host/common/Socket.cpp:198-199 } else { // If this was unsuccessful, then check if it's simply a signed 32-bit // integer,

[Lldb-commits] [PATCH] D112658: [lldb] Refactor C/C++ string and char summary providers

labath added a comment. Thanks for doing this. Just a couple of small remarks. Comment at: lldb/source/Plugins/Language/CPlusPlus/CxxStringTypes.cpp:35 -bool lldb_private::formatters::Char8StringSummaryProvider( -ValueObject , Stream , const TypeSummaryOptions &) { -

[Lldb-commits] [lldb] 073c5d0 - [lldb] [Host/Socket] Make DecodeHostAndPort() return a dedicated struct

Author: Michał Górny Date: 2021-10-28T09:57:50+02:00 New Revision: 073c5d0e4706f14b599f62c7bb115b843d0e4962 URL: https://github.com/llvm/llvm-project/commit/073c5d0e4706f14b599f62c7bb115b843d0e4962 DIFF: https://github.com/llvm/llvm-project/commit/073c5d0e4706f14b599f62c7bb115b843d0e4962.diff

[Lldb-commits] [PATCH] D112629: [lldb] [Host/Socket] Make DecodeHostAndPort() return a dedicated struct

This revision was automatically updated to reflect the committed changes. Closed by commit rG073c5d0e4706: [lldb] [Host/Socket] Make DecodeHostAndPort() return a dedicated struct (authored by mgorny). Herald added a project: LLDB. Changed prior to commit:

[Lldb-commits] [lldb] 5f4980f - [lldb] Remove ConstString from Process, ScriptInterpreter and StructuredData plugin names

Author: Pavel Labath Date: 2021-10-28T10:15:03+02:00 New Revision: 5f4980f004f052367b947ff3aa6cc142cea1c23f URL: https://github.com/llvm/llvm-project/commit/5f4980f004f052367b947ff3aa6cc142cea1c23f DIFF: https://github.com/llvm/llvm-project/commit/5f4980f004f052367b947ff3aa6cc142cea1c23f.diff

[Lldb-commits] [PATCH] D112709: [lldb] Fix matchers for char array formatters

labath created this revision. labath added reviewers: teemperor, jingham. labath requested review of this revision. Herald added a project: LLDB. They were being applied too narrowly (they didn't cover signed char *, for instance), and too broadly (they covered SomeTemplate) at the same time.

[Lldb-commits] [PATCH] D112708: [lldb] Make TypeSystemClang::GetFullyUnqualifiedType work for constant arrays

labath updated this revision to Diff 383009. labath added a comment. new version Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112708/new/ https://reviews.llvm.org/D112708 Files: lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp

[Lldb-commits] [PATCH] D112708: [lldb] Make TypeSystemClang::GetFullyUnqualifiedType work for constant arrays

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. In D112708#3093318 , @labath wrote: > In D112708#3093252 , @teemperor > wrote: > >> LGTM, could you

[Lldb-commits] [PATCH] D112706: [lldb/test] Allow indentation in inline tests

labath created this revision. labath added reviewers: teemperor, mgorny. labath requested review of this revision. Herald added a project: LLDB. This makes it possible to use for loops (and other language constructs) in inline tests. Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D112708: [lldb] Make TypeSystemClang::GetFullyUnqualifiedType work for constant arrays

labath created this revision. labath added reviewers: teemperor, shafik. labath requested review of this revision. Herald added a project: LLDB. Unqualify (constant) arrays recursively, just like we do for pointers. This allows for better pretty printer matching. Repository: rG LLVM Github

[Lldb-commits] [PATCH] D112708: [lldb] Make TypeSystemClang::GetFullyUnqualifiedType work for constant arrays

labath marked 2 inline comments as done. labath added a comment. In D112708#3093252 , @teemperor wrote: > LGTM, could you also extend a non-unit test to test the change within the > whole FormatManager/etc. setup? I think `TestDataFormatterAdv.py`

[Lldb-commits] [PATCH] D112708: [lldb] Make TypeSystemClang::GetFullyUnqualifiedType work for constant arrays

teemperor requested changes to this revision. teemperor added a comment. This revision now requires changes to proceed. LGTM, could you also extend a non-unit test to test the change within the whole FormatManager/etc. setup? I think `TestDataFormatterAdv.py` already has a very similar section

[Lldb-commits] [lldb] 349295f - [lldb/test] Allow indentation in inline tests

Author: Pavel Labath Date: 2021-10-28T14:39:02+02:00 New Revision: 349295fcf37ed1ff1ea98c18ea1b391741823916 URL: https://github.com/llvm/llvm-project/commit/349295fcf37ed1ff1ea98c18ea1b391741823916 DIFF: https://github.com/llvm/llvm-project/commit/349295fcf37ed1ff1ea98c18ea1b391741823916.diff

[Lldb-commits] [PATCH] D112706: [lldb/test] Allow indentation in inline tests

This revision was automatically updated to reflect the committed changes. Closed by commit rG349295fcf37e: [lldb/test] Allow indentation in inline tests (authored by labath). Changed prior to commit: https://reviews.llvm.org/D112706?vs=382991=383000#toc Repository: rG LLVM Github Monorepo

[Lldb-commits] [lldb] f5c65be - [lldb][NFC] Improve CppModuleConfiguration documentation a bit

Author: Raphael Isemann Date: 2021-10-28T16:39:06+02:00 New Revision: f5c65be510430605829f8ccf46b855e39b424d1e URL: https://github.com/llvm/llvm-project/commit/f5c65be510430605829f8ccf46b855e39b424d1e DIFF:

[Lldb-commits] [PATCH] D112706: [lldb/test] Allow indentation in inline tests

labath marked 2 inline comments as done. labath added inline comments. Comment at: lldb/test/API/test_utils/TestInlineTest.py:10 + +def test(self): +filename = self.getBuildArtifact("test_file.cpp") teemperor wrote: > teemperor wrote: > > nit: maybe

Re: [Lldb-commits] [lldb] aee4925 - Recommit: Compress formatting of array type names (int [4] -> int[4])

On 26/10/2021 23:14, Jim Ingham via lldb-commits wrote: On Oct 26, 2021, at 12:45 PM, David Blaikie wrote: On Tue, Oct 26, 2021 at 12:15 PM Raphael Isemann wrote: Not sure how many LLDB users would (or can) write AST matchers though. And (lldb) type summary add "foo[4]" ... is

[Lldb-commits] [PATCH] D112706: [lldb/test] Allow indentation in inline tests

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. LGTM, thanks. On a more general note: I wish we would just kill off inline tests instead of trying to make them usable. But I think that's a discussion for the mailing lists...

[Lldb-commits] [PATCH] D112586: [lldb] Remove forgotten FIXME on CPlusPlus formatters

teemperor added subscribers: labath, teemperor. teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. LGTM, thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112586/new/

[Lldb-commits] [PATCH] D112706: [lldb/test] Allow indentation in inline tests

labath marked an inline comment as done. labath added a comment. In D112706#3093179 , @teemperor wrote: > On a more general note: I wish we would just kill off inline tests instead of > trying to make them usable. But I think that's a discussion for the

[Lldb-commits] [PATCH] D111890: [lldb] [Host] Make Terminal methods return llvm::Error

thakis added a comment. In D111890#3090653 , @mgorny wrote: > In D111890#3090632 , @thakis wrote: > >> This causes lots of warnings on Windows, where TERMIOS is false: >> http://45.33.8.238/win/47744/step_4.txt

[Lldb-commits] [lldb] e50f02b - [lldb] [Host/ConnectionFileDescriptor] Refactor to improve code reuse

Author: Michał Górny Date: 2021-10-28T19:24:10+02:00 New Revision: e50f02ba7ed846f944a369e6738174a5eabfbdcc URL: https://github.com/llvm/llvm-project/commit/e50f02ba7ed846f944a369e6738174a5eabfbdcc DIFF: https://github.com/llvm/llvm-project/commit/e50f02ba7ed846f944a369e6738174a5eabfbdcc.diff

[Lldb-commits] [PATCH] D110827: [LLDB] Provide target specific directories to libclang

teemperor requested changes to this revision. teemperor added a comment. This revision now requires changes to proceed. Apologies for the delay, this slipped out of my review queue by accident. The patch looks in general pretty much ready, I just have a few nits here and there. (Also just to

[Lldb-commits] [PATCH] D112439: normalize file path when searching the source map

xujuntwt95329 updated this revision to Diff 383083. xujuntwt95329 added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112439/new/ https://reviews.llvm.org/D112439 Files: lldb/source/Target/PathMappingList.cpp

[Lldb-commits] [PATCH] D112691: Include target settings in "statistics dump" output.

JDevlieghere added a comment. I understand the need for something like this to make some of the statistics more meaningful, but this is stretching the notion of statistics. Conceptually, this is approaching something like a dump of the debugger for issue/performance analysis. I think that idea

[Lldb-commits] [PATCH] D111890: [lldb] [Host] Make Terminal methods return llvm::Error

mgorny added a comment. Thanks, that sounds like a good idea. Changed D112632 to do that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111890/new/ https://reviews.llvm.org/D111890

[Lldb-commits] [PATCH] D112658: [lldb] Refactor C/C++ string and char summary providers

ljmf00 updated this revision to Diff 383121. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112658/new/ https://reviews.llvm.org/D112658 Files: lldb/source/Plugins/Language/CPlusPlus/CxxStringTypes.cpp Index: lldb/source/Plugins/Language/CPlusPlus/CxxStringTypes.cpp

[Lldb-commits] [PATCH] D112586: [lldb] Remove forgotten FIXME on CPlusPlus formatters

ljmf00 added a comment. In D112586#3093490 , @teemperor wrote: > LGTM, thanks. Note: I can't land it Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112586/new/ https://reviews.llvm.org/D112586

[Lldb-commits] [PATCH] D112658: [lldb] Refactor C/C++ string and char summary providers

ljmf00 added a comment. In D112658#3092586 , @labath wrote: > Thanks for doing this. Just a couple of small remarks. Can you re-review? Comment at: lldb/source/Plugins/Language/CPlusPlus/CxxStringTypes.cpp:35 -bool

[Lldb-commits] [PATCH] D112752: [formatters] Add a libstdcpp formatter for multimap and unify tests across stdlibs

danilashtefan created this revision. danilashtefan requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D112752 Files:

[Lldb-commits] [PATCH] D112691: Include target settings in "statistics dump" output.

clayborg added a comment. In D112691#3093889 , @JDevlieghere wrote: > I understand the need for something like this to make some of the statistics > more meaningful, but this is stretching the notion of statistics. > Conceptually, this is approaching

[Lldb-commits] [PATCH] D112747: Restore process events after a launch that stopped at the entry point

jingham created this revision. jingham added reviewers: clayborg, JDevlieghere, mib. jingham requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. We found a bug introduced by changes for the ScriptedProcess. It only manifests itself is you

[Lldb-commits] [PATCH] D112632: [lldb] [Host/Terminal] Fix warnings with termios disabled

mgorny updated this revision to Diff 383112. mgorny retitled this revision from "[lldb] [Host/Terminal] Add llvm_unreachable() to appease Windows" to "[lldb] [Host/Terminal] Fix warnings with termios disabled". mgorny edited the summary of this revision. mgorny added a comment. Create the error

[Lldb-commits] [PATCH] D112586: [lldb] Remove forgotten FIXME on CPlusPlus formatters

teemperor added a comment. In D112586#3094519 , @ljmf00 wrote: > In D112586#3093490 , @teemperor > wrote: > >> LGTM, thanks. > > Note: I can't land it I can land it for you tomorrow (unless someone beats me to

[Lldb-commits] [PATCH] D112691: Include target settings in "statistics dump" output.

jingham added a comment. Do you care about the history of these settings? After all, the problem might arise because someone set a setting then unset it. If you are really trying to build an architecture where we can track this sort of problem down, then you might need more of a history

[Lldb-commits] [PATCH] D112691: Include target settings in "statistics dump" output.

clayborg added a comment. In D112691#3095010 , @jingham wrote: > Do you care about the history of these settings? After all, the problem > might arise because someone set a setting then unset it. Your statistics > approach wouldn't catch that. If

Re: [Lldb-commits] [PATCH] D112691: Include target settings in "statistics dump" output.

> On Oct 28, 2021, at 3:18 PM, Greg Clayton via Phabricator > wrote: > > clayborg added a comment. > > In D112691#3095010 , @jingham wrote: > >> Do you care about the history of these settings? After all, the problem >> might arise because someone

[Lldb-commits] [PATCH] D112747: Restore process events after a launch that stopped at the entry point

mib accepted this revision. mib added a comment. This revision is now accepted and ready to land. LGTM besides some minor things. Thanks for fixing this @jingham ! Comment at: lldb/test/API/functionalities/launch_stop_at_entry/TestStopAtEntry.py:85 +

[Lldb-commits] [lldb] 1227fa7 - Remove unused ValueObjectDynamicValue::SetOwningSP & backing ivar

Author: Jim Ingham Date: 2021-10-28T16:06:01-07:00 New Revision: 1227fa7e9040469d648cc7709a298901002f4c27 URL: https://github.com/llvm/llvm-project/commit/1227fa7e9040469d648cc7709a298901002f4c27 DIFF: https://github.com/llvm/llvm-project/commit/1227fa7e9040469d648cc7709a298901002f4c27.diff

[Lldb-commits] [PATCH] D112677: Remove unused ValueObjectDynamicValue::SetOwningSP & backing ivar

This revision was automatically updated to reflect the committed changes. Closed by commit rG1227fa7e9040: Remove unused ValueObjectDynamicValue::SetOwningSP backing ivar (authored by jingham). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D112691: Include target settings in "statistics dump" output.

clayborg added a comment. > In D112691#3095010 , @jingham wrote: > I can see wanting to dump statistics at various points in the running of a > process, maybe triggered by breakpoints, for instance. In that case I > wouldn't want to dump the settings

[Lldb-commits] [lldb] e655769 - Fix a bug in Launch when using an async debugger & remote platform.

Author: Jim Ingham Date: 2021-10-28T17:02:43-07:00 New Revision: e655769c4a7b5a17b17eace3bd160b3b015b75ed URL: https://github.com/llvm/llvm-project/commit/e655769c4a7b5a17b17eace3bd160b3b015b75ed DIFF: https://github.com/llvm/llvm-project/commit/e655769c4a7b5a17b17eace3bd160b3b015b75ed.diff

[Lldb-commits] [lldb] d1e9514 - To avoid the obvious problem, use a different port...

Author: Jim Ingham Date: 2021-10-28T17:45:31-07:00 New Revision: d1e9514ac89b1ceed51114159b7dd4888ce58974 URL: https://github.com/llvm/llvm-project/commit/d1e9514ac89b1ceed51114159b7dd4888ce58974 DIFF: https://github.com/llvm/llvm-project/commit/d1e9514ac89b1ceed51114159b7dd4888ce58974.diff

[Lldb-commits] [PATCH] D112632: [lldb] [Host/Terminal] Fix warnings with termios disabled

thakis accepted this revision. thakis added a comment. This revision is now accepted and ready to land. Thanks! Comment at: lldb/source/Host/common/Terminal.cpp:39 + llvm::Expected Terminal::GetData() { if (!FileDescriptorIsValid()) nit: should GetData()

[Lldb-commits] [PATCH] D112747: Restore process events after a launch that stopped at the entry point

jingham updated this revision to Diff 383184. jingham added a comment. Address Ismail's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112747/new/ https://reviews.llvm.org/D112747 Files: lldb/source/Target/Process.cpp

[Lldb-commits] [PATCH] D112747: Restore process events after a launch that stopped at the entry point

jingham marked 3 inline comments as done. jingham added a comment. Thanks for pointing these out. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112747/new/ https://reviews.llvm.org/D112747 ___

Re: [Lldb-commits] [PATCH] D112691: Include target settings in "statistics dump" output.

> On Oct 28, 2021, at 4:10 PM, Greg Clayton via Phabricator > wrote: > > clayborg added a comment. > >> In D112691#3095010 , @jingham >> wrote: >> I can see wanting to dump statistics at various points in the running of a >> process, maybe

[Lldb-commits] [PATCH] D112747: Restore process events after a launch that stopped at the entry point

jingham added inline comments. Comment at: lldb/test/API/functionalities/launch_stop_at_entry/TestStopAtEntry.py:21 +# The port used by debugserver. +PORT = 54637 + clayborg wrote: > This hard coded port worries me for buildbot flakiness. Do other tests

[Lldb-commits] [PATCH] D112747: Restore process events after a launch that stopped at the entry point

This revision was automatically updated to reflect the committed changes. Closed by commit rGe655769c4a7b: Fix a bug in Launch when using an async debugger remote platform. (authored by jingham). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D112747: Restore process events after a launch that stopped at the entry point

clayborg added inline comments. Comment at: lldb/test/API/functionalities/launch_stop_at_entry/TestStopAtEntry.py:21 +# The port used by debugserver. +PORT = 54637 + This hard coded port worries me for buildbot flakiness. Do other tests do this?

[Lldb-commits] [PATCH] D112747: Restore process events after a launch that stopped at the entry point

jingham added inline comments. Comment at: lldb/test/API/functionalities/launch_stop_at_entry/TestStopAtEntry.py:21 +# The port used by debugserver. +PORT = 54637 + jingham wrote: > clayborg wrote: > > This hard coded port worries me for buildbot

[Lldb-commits] [PATCH] D112747: Restore process events after a launch that stopped at the entry point

clayborg accepted this revision. clayborg added a comment. ok, lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112747/new/ https://reviews.llvm.org/D112747 ___ lldb-commits mailing list

[Lldb-commits] [lldb] 2aa3b56 - [lldb] Fix TestMacCatalyst.py

Author: Jonas Devlieghere Date: 2021-10-28T17:57:55-07:00 New Revision: 2aa3b56339423969f0c89fe10d81f32ff77db2d2 URL: https://github.com/llvm/llvm-project/commit/2aa3b56339423969f0c89fe10d81f32ff77db2d2 DIFF:

[Lldb-commits] [PATCH] D112212: [lldb/test] Print build commands in trace mode

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Thanks everyone. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112212/new/ https://reviews.llvm.org/D112212

[Lldb-commits] [PATCH] D112709: [lldb] Fix matchers for char array formatters

shafik added a comment. Nice catch! Comment at: lldb/test/API/functionalities/data-formatter/stringprinter/main.cpp:21 +MAKE_VARS(); +MAKE_VARS(const); + It feels like writing out the decls by hand would have been quicker but perhaps less satisfying...

[Lldb-commits] [PATCH] D112708: [lldb] Make TypeSystemClang::GetFullyUnqualifiedType work for constant arrays

shafik accepted this revision. shafik added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112708/new/ https://reviews.llvm.org/D112708 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D112706: [lldb/test] Allow indentation in inline tests

shafik added a comment. I agree, we should be trying to get ride of inline tests. The last time I had to debug one it was not a fun experience. Maybe some of the recent improvements have helped there though. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION