[Lldb-commits] [PATCH] D119155: [lldb] Print message after loading 'crashlog' command

JDevlieghere added a comment. We have (shell) tests that import the crashlog command. Can you add a check line to make sure the message gets printed? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119155/new/ https://reviews.llvm.org/D119155

Re: [Lldb-commits] [lldb] 20e1732 - [lldb] Fix a few lldb-server tests on Apple Silicon

The inferior already has an assembly-coded version of this, which should not be dependent on codegen details, so I'm surprised that this does not work. Is it possible that the #ifdefs need adjustment? On 07/02/2022 18:35, Jonas Devlieghere via lldb-commits wrote: Author: Jonas Devlieghere

[Lldb-commits] [PATCH] D119170: [lldb] Skip ScriptInterpreter/Lua/watchpoint_callback.test on Apple Silicon

JDevlieghere created this revision. JDevlieghere requested review of this revision. The watchpoint isn't hit the first time, resulting is us only printing "val =2". XFAIL the test until the underlying watchpoint issue gets fixed. https://reviews.llvm.org/D119170 Files:

[Lldb-commits] [lldb] a5a71b1 - [lldb] Fix Lua/watchpoint_callback.test on Apple Silicon

Author: Jonas Devlieghere Date: 2022-02-07T12:08:24-08:00 New Revision: a5a71b139c6b3cb2cc569c81f91210dede2f1f4c URL: https://github.com/llvm/llvm-project/commit/a5a71b139c6b3cb2cc569c81f91210dede2f1f4c DIFF:

[Lldb-commits] [PATCH] D119170: [lldb] Skip ScriptInterpreter/Lua/watchpoint_callback.test on Apple Silicon

JDevlieghere abandoned this revision. JDevlieghere added a comment. In D119170#3302067 , @labath wrote: > If I had to guess, I'd say this is because "b main" stops at a point after > the variable has already been initialized. If true, it should be

[Lldb-commits] [PATCH] D119009: [Support] Ensure handlers are set up before printing the stacktrace

JDevlieghere added a comment. I believe it's generally considered bad practice to install signal handlers in a library. This is why the initialization currently happens in the driver. If you look at other tools in LLVM you'll notice they do the same thing. Can we address this issue by (1)

[Lldb-commits] [PATCH] D119044: Add a case for Rust in LLDB's PDB reader

arlosi added a comment. Thanks for the review rnk. Could someone complete this for me? I do not have commit access. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119044/new/ https://reviews.llvm.org/D119044

[Lldb-commits] [PATCH] D119009: [Support] Ensure handlers are set up before printing the stacktrace

werat added a comment. In D119009#3302004 , @labath wrote: > I don't think this is a good idea. I'm very much against libraries randomly > installing signal handlers, and I think that is the reason this function is > called from the main program in

[Lldb-commits] [PATCH] D119155: [lldb] Print message after loading 'crashlog' command

kastiglione updated this revision to Diff 406565. kastiglione added a comment. remove changes to createPythonInit.py Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119155/new/ https://reviews.llvm.org/D119155 Files:

[Lldb-commits] [PATCH] D119179: [lldb] Call __lldb_init_module from __init__

kastiglione created this revision. kastiglione added a reviewer: JDevlieghere. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Update `__init__.py` generation to implement `__lldb_init_module`, which calls `__lldb_init_module`

[Lldb-commits] [PATCH] D119046: Add a repeat command option for "thread backtrace --count N".

JDevlieghere added a comment. API and code change make sense, but I think we should be able to simplify the test. Comment at: lldb/test/API/commands/thread/backtrace/TestThreadBacktraceRepeat.py:18-28 +# Test occasionally times out on the Linux build bot +

[Lldb-commits] [PATCH] D119186: [lldb][gdb-remote] Fix linking of gdb-remote when LLVM_ENABLE_ZLIB is ON

mceier created this revision. mceier added a reviewer: LLVM. Herald added a subscriber: mgorny. mceier requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. When LLVM_ENABLE_ZLIB is ON gdb-remote should link with ZLIB::ZLIB. Fixes

[Lldb-commits] [PATCH] D119186: [lldb][gdb-remote] Fix linking of gdb-remote when LLVM_ENABLE_ZLIB is ON

JDevlieghere requested changes to this revision. JDevlieghere added a comment. This revision now requires changes to proceed. We should add this to `LLDB_SYSTEM_LIBS` in `lldb/source/Host/CMakeLists.txt` and include `${LLDB_SYSTEM_LIBS}` for `lldbPluginProcessGDBRemote`. Repository: rG LLVM

[Lldb-commits] [PATCH] D119186: [lldb][gdb-remote] Fix linking of gdb-remote when LLVM_ENABLE_ZLIB is ON

JDevlieghere added a comment. Basically it should mirror what we have for LZMA: if (LLDB_ENABLE_LZMA) list(APPEND EXTRA_LIBS ${LIBLZMA_LIBRARIES}) endif() Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119186/new/

[Lldb-commits] [PATCH] D119155: [lldb] Print message after loading 'crashlog' command

JDevlieghere added a comment. In D119155#3301826 , @kastiglione wrote: >> We have (shell) tests that import the crashlog command. Can you add a check >> line to make sure the message gets printed? > > The message isn't printed for a Python `import`,

[Lldb-commits] [PATCH] D119044: Add a case for Rust in LLDB's PDB reader

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119044/new/ https://reviews.llvm.org/D119044 ___

[Lldb-commits] [PATCH] D119178: Add support for generating debug-info for structured bindings of structs and arrays

shafik created this revision. shafik added reviewers: aprantl, dblaikie. shafik requested review of this revision. Currently we are not emitting debug-info for all cases of structured bindings a C++17 feature which allows us to bind names to subobjects in an initializer. A structured binding is

[Lldb-commits] [PATCH] D119155: [lldb] Print message after loading 'crashlog' command

kastiglione added a comment. > We have (shell) tests that import the crashlog command. Can you add a check > line to make sure the message gets printed? The message isn't printed for a Python `import`, only for an lldb `command script import`. Repository: rG LLVM Github Monorepo CHANGES

[Lldb-commits] [PATCH] D119179: [lldb] Call __lldb_init_module from __init__

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Ship it Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119179/new/ https://reviews.llvm.org/D119179

[Lldb-commits] [PATCH] D119168: [lldb/crashlog] Fix arm64 register parsing on crashlog.py

mib created this revision. mib added a reviewer: JDevlieghere. mib added a project: LLDB. Herald added subscribers: omjavaid, pengfei, kristof.beyls. mib requested review of this revision. Herald added a subscriber: lldb-commits. This patch fixes the register parser for arm64 crashlogs. Compared

[Lldb-commits] [PATCH] D119168: [lldb/crashlog] Fix arm64 register parsing on crashlog.py

JDevlieghere added a comment. I recently modified this function to support parsing the rosetta registers. To do that I call `parse_thread_registers` recursively, and I think we should do the same here and add an optional argument for the prefix. So the result would look something like: def

[Lldb-commits] [lldb] f8d889a - [lldb] Print message after loading 'crashlog' command

Author: Dave Lee Date: 2022-02-07T12:34:12-08:00 New Revision: f8d889a789e2ac7012d202971d4e214d0b13949c URL: https://github.com/llvm/llvm-project/commit/f8d889a789e2ac7012d202971d4e214d0b13949c DIFF: https://github.com/llvm/llvm-project/commit/f8d889a789e2ac7012d202971d4e214d0b13949c.diff

[Lldb-commits] [PATCH] D119170: [lldb] Skip ScriptInterpreter/Lua/watchpoint_callback.test on Apple Silicon

labath added a comment. If I had to guess, I'd say this is because "b main" stops at a point after the variable has already been initialized. If true, it should be fairly easy to modify the test to not do that. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119170/new/

[Lldb-commits] [PATCH] D119155: [lldb] Print message after loading 'crashlog' command

kastiglione updated this revision to Diff 406548. kastiglione added a comment. Update tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119155/new/ https://reviews.llvm.org/D119155 Files: lldb/bindings/python/createPythonInit.py

[Lldb-commits] [PATCH] D119009: [Support] Ensure handlers are set up before printing the stacktrace

aganea added a comment. In that case @werat can you get the caller application to call `llvm::InitLLVM`? That plus the snippet in https://reviews.llvm.org/D119009#3297591 should shield from crashes if the handler isn't installed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[Lldb-commits] [PATCH] D119155: [lldb] Print message after loading 'crashlog' command

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119155/new/ https://reviews.llvm.org/D119155

[Lldb-commits] [PATCH] D119155: [lldb] Print message after loading 'crashlog' command

This revision was automatically updated to reflect the committed changes. Closed by commit rGf8d889a789e2: [lldb] Print message after loading crashlog command (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119155/new/

[Lldb-commits] [PATCH] D119155: [lldb] Print message after loading 'crashlog' command

kastiglione updated this revision to Diff 406523. kastiglione added a comment. Update createPythonInit.py Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119155/new/ https://reviews.llvm.org/D119155 Files: lldb/bindings/python/createPythonInit.py

[Lldb-commits] [PATCH] D119167: [lldb/test] Remove sleeps from some lldb-server tests

labath created this revision. labath added reviewers: mgorny, DavidSpickett. labath requested review of this revision. Herald added a project: LLDB. Instead of using sleeps, have the inferior notify us (via a signal) that the requested number of threads have been created. This allows us to get

[Lldb-commits] [PATCH] D119009: [Support] Ensure handlers are set up before printing the stacktrace

labath added a comment. I don't think this is a good idea. I'm very much against libraries randomly installing signal handlers, and I think that is the reason this function is called from the main program in lldb (and elsewhere in llvm afaik). If there's no way to get a backtrace without this

[Lldb-commits] [PATCH] D119009: [Support] Ensure handlers are set up before printing the stacktrace

werat added a comment. In D119009#3302354 , @JDevlieghere wrote: > I believe it's generally considered bad practice to install signal handlers > in a library. This is why the initialization currently happens in the driver. > If you look at other tools

[Lldb-commits] [PATCH] D119168: [lldb/crashlog] Fix arm64 register parsing on crashlog.py

mib updated this revision to Diff 40. mib added a comment. Use the same approach as rosetta. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119168/new/ https://reviews.llvm.org/D119168 Files: lldb/examples/python/crashlog.py Index: lldb/examples/python/crashlog.py

[Lldb-commits] [PATCH] D119186: [lldb][gdb-remote] Fix linking of gdb-remote when LLVM_ENABLE_ZLIB is ON

mceier added a comment. In D119186#3302612 , @JDevlieghere wrote: > We should add this to `LLDB_SYSTEM_LIBS` like we do in > `lldb/source/Host/CMakeLists.txt` and include `${LLDB_SYSTEM_LIBS}` for > `lldbPluginProcessGDBRemote`. So should I add:

[Lldb-commits] [lldb] bf02586 - [lldb] Call __lldb_init_module from __init__

Author: Dave Lee Date: 2022-02-07T14:43:44-08:00 New Revision: bf02586c57ced32ca66fd98fa3208b632820b1c6 URL: https://github.com/llvm/llvm-project/commit/bf02586c57ced32ca66fd98fa3208b632820b1c6 DIFF: https://github.com/llvm/llvm-project/commit/bf02586c57ced32ca66fd98fa3208b632820b1c6.diff

[Lldb-commits] [PATCH] D119179: [lldb] Call __lldb_init_module from __init__

This revision was automatically updated to reflect the committed changes. Closed by commit rGbf02586c57ce: [lldb] Call __lldb_init_module from __init__ (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119179/new/

[Lldb-commits] [PATCH] D119186: [lldb][gdb-remote] Fix linking of gdb-remote when LLVM_ENABLE_ZLIB is ON

JDevlieghere added a comment. In D119186#3302765 , @mceier wrote: > In D119186#3302612 , @JDevlieghere > wrote: > >> We should add this to `LLDB_SYSTEM_LIBS` like we do in >> `lldb/source/Host/CMakeLists.txt`

[Lldb-commits] [PATCH] D119186: [lldb][gdb-remote] Fix linking of gdb-remote when LLVM_ENABLE_ZLIB is ON

raj.khem added a comment. I tested this patch and it fixes lldb build. Thanks for taking care of this,. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119186/new/ https://reviews.llvm.org/D119186 ___

[Lldb-commits] [PATCH] D119046: Add a repeat command option for "thread backtrace --count N".

jingham added inline comments. Comment at: lldb/test/API/commands/thread/backtrace/TestThreadBacktraceRepeat.py:18-28 +# Test occasionally times out on the Linux build bot +@skipIfLinux +@expectedFailureAll( +oslist=["linux"], +

[Lldb-commits] [PATCH] D119092: Cleanup LLVMDebugInfoCodeView headers

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119092/new/ https://reviews.llvm.org/D119092

[Lldb-commits] [lldb] 385f5c4 - [lldb][CMake] Fix linking of gdb-remote when LLVM_ENABLE_ZLIB is ON

Author: Mariusz Ceier Date: 2022-02-07T23:26:22-08:00 New Revision: 385f5c4d33799df25a85ceb54b6232499cb8a78d URL: https://github.com/llvm/llvm-project/commit/385f5c4d33799df25a85ceb54b6232499cb8a78d DIFF: https://github.com/llvm/llvm-project/commit/385f5c4d33799df25a85ceb54b6232499cb8a78d.diff

[Lldb-commits] [PATCH] D119186: [lldb][gdb-remote] Fix linking of gdb-remote when LLVM_ENABLE_ZLIB is ON

This revision was automatically updated to reflect the committed changes. Closed by commit rG385f5c4d3379: [lldb][CMake] Fix linking of gdb-remote when LLVM_ENABLE_ZLIB is ON (authored by mceier, committed by MaskRay). Changed prior to commit:

[Lldb-commits] [lldb] 9b1cb0e - Platform gdb RSP packet doc fixes based on implementation behavior

Author: Jason Molenda Date: 2022-02-07T23:51:46-08:00 New Revision: 9b1cb0e171a35bf9034663566bb3400f668769b0 URL: https://github.com/llvm/llvm-project/commit/9b1cb0e171a35bf9034663566bb3400f668769b0 DIFF: https://github.com/llvm/llvm-project/commit/9b1cb0e171a35bf9034663566bb3400f668769b0.diff

[Lldb-commits] [PATCH] D118842: Small fixes to platform packet documentation

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG9b1cb0e171a3: Platform gdb RSP packet doc fixes based on implementation behavior (authored by jasonmolenda). Repository:

[Lldb-commits] [PATCH] D119186: [lldb][gdb-remote] Fix linking of gdb-remote when LLVM_ENABLE_ZLIB is ON

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Thanks! LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119186/new/ https://reviews.llvm.org/D119186

[Lldb-commits] [PATCH] D119186: [lldb][gdb-remote] Fix linking of gdb-remote when LLVM_ENABLE_ZLIB is ON

mceier updated this revision to Diff 406706. mceier added a comment. Updated diff to use LLDB_SYSTEM_LIBS Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119186/new/ https://reviews.llvm.org/D119186 Files:

[Lldb-commits] [PATCH] D119186: [lldb][gdb-remote] Fix linking of gdb-remote when LLVM_ENABLE_ZLIB is ON

mceier accepted this revision. mceier added a comment. I need someone to merge it for me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119186/new/ https://reviews.llvm.org/D119186 ___ lldb-commits

[Lldb-commits] [PATCH] D119186: [lldb][gdb-remote] Fix linking of gdb-remote when LLVM_ENABLE_ZLIB is ON

MaskRay added a comment. In D119186#3303530 , @mceier wrote: > I need someone to merge it for me. Testing and merging. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119186/new/

[Lldb-commits] [PATCH] D118794: [lldb][AArch64] Remove non-address bits from addresses passed to ptrace on Linux

labath added a comment. In D118794#3290552 , @DavidSpickett wrote: > Also if anyone does know how or if debugserver handles this situation, that > would be good to know. I don't know about debugserver, but it would definitely be interesting to check

[Lldb-commits] [lldb] 20e1732 - [lldb] Fix a few lldb-server tests on Apple Silicon

Author: Jonas Devlieghere Date: 2022-02-07T09:35:12-08:00 New Revision: 20e17323cd90d04f38cf35d70a3b7cac37d2e15d URL: https://github.com/llvm/llvm-project/commit/20e17323cd90d04f38cf35d70a3b7cac37d2e15d DIFF:

[Lldb-commits] [lldb] 677182f - Revert "Add llgs category to all tests in TestLldbGdbServer that attach to the process."

Author: Adrian Prantl Date: 2022-02-07T09:42:07-08:00 New Revision: 677182fe98d147d3a36cf3d35c1cbbce909c9c30 URL: https://github.com/llvm/llvm-project/commit/677182fe98d147d3a36cf3d35c1cbbce909c9c30 DIFF: https://github.com/llvm/llvm-project/commit/677182fe98d147d3a36cf3d35c1cbbce909c9c30.diff

[Lldb-commits] [PATCH] D119009: [Support] Ensure handlers are set up before printing the stacktrace

werat updated this revision to Diff 406487. werat added a comment. Restore accidentally removed code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119009/new/ https://reviews.llvm.org/D119009 Files: lldb/source/API/SystemInitializerFull.cpp

[Lldb-commits] [PATCH] D118794: [lldb][AArch64] Remove non-address bits from addresses passed to ptrace on Linux

DavidSpickett planned changes to this revision. DavidSpickett added a comment. > check what gdb(server) does here Will do. > One side-effect of doing it server-side is that this would interfere with our > memory caching code Yes I also wanted to fix the memory cache in lldb but you're right

[Lldb-commits] [lldb] d63dfa1 - [lldb] Update outdated comment in TestDyldTrieSymbols.py

Author: Jonas Devlieghere Date: 2022-02-07T08:13:54-08:00 New Revision: d63dfa14d629efe9d85de07abeae7b58a76d52cd URL: https://github.com/llvm/llvm-project/commit/d63dfa14d629efe9d85de07abeae7b58a76d52cd DIFF:

[Lldb-commits] [PATCH] D119009: [Support] Ensure handlers are set up before printing the stacktrace

werat added a comment. In D119009#3297591 , @aganea wrote: > I'm not sure it's a good idea to start loading DLLs when we get to this point. > I would rather suggest calling `sys::PrintStackTraceOnErrorSignal({});` in > `SBDebugger::Initialize()`.

[Lldb-commits] [PATCH] D119146: [lldb/Platform] Decouple instance and plugin names

labath created this revision. labath added reviewers: clayborg, jingham, JDevlieghere. Herald added a subscriber: emaste. labath requested review of this revision. Herald added a project: LLDB. Platform class has two methods (GetName, GetPluginName) which were hardwired to return the same thing.

[Lldb-commits] [lldb] d42765b - Add llgs category to all tests in TestLldbGdbServer that attach to the process.

Author: Adrian Prantl Date: 2022-02-07T08:26:48-08:00 New Revision: d42765b3bea5ee90426c49f35b0b5654de82a4f9 URL: https://github.com/llvm/llvm-project/commit/d42765b3bea5ee90426c49f35b0b5654de82a4f9 DIFF: https://github.com/llvm/llvm-project/commit/d42765b3bea5ee90426c49f35b0b5654de82a4f9.diff

[Lldb-commits] [PATCH] D119146: [lldb/Platform] Decouple instance and plugin names

JDevlieghere added a comment. Returning a StringRef from GetName makes sense, but in the constructor, if you're eventually going to store it, why not pass and `std::string` in and `std::move` it into place? Other than that this LGTM, but I'll refrain from accepting so it continues to show up

[Lldb-commits] [PATCH] D119009: [Support] Ensure handlers are set up before printing the stacktrace

werat updated this revision to Diff 406480. werat added a comment. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Call `sys::PrintStackTraceOnErrorSignal()` in `SBDebugger::Initialize()`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D119009: [Support] Ensure handlers are set up before printing the stacktrace

werat updated this revision to Diff 406485. werat added a comment. Remove accidental old code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119009/new/ https://reviews.llvm.org/D119009 Files: lldb/source/API/SystemInitializerFull.cpp

[Lldb-commits] [lldb] 0d16652 - [lldb] Skip part of TestGdbRemoteMemoryAllocation.py on Apple Silicon

Author: Jonas Devlieghere Date: 2022-02-07T09:41:38-08:00 New Revision: 0d166520217bb839ffe888036ce3f38b35f87bbf URL: https://github.com/llvm/llvm-project/commit/0d166520217bb839ffe888036ce3f38b35f87bbf DIFF:

[Lldb-commits] [lldb] a53c5c6 - [lldb/Platform] s/m_name/m_hostname

Author: Pavel Labath Date: 2022-02-07T14:58:55+01:00 New Revision: a53c5c66b3b1f576902154af2ecdac3bd2d5d556 URL: https://github.com/llvm/llvm-project/commit/a53c5c66b3b1f576902154af2ecdac3bd2d5d556 DIFF: https://github.com/llvm/llvm-project/commit/a53c5c66b3b1f576902154af2ecdac3bd2d5d556.diff

[Lldb-commits] [PATCH] D119009: [Support] Ensure handlers are set up before printing the stacktrace

werat updated this revision to Diff 406483. werat added a comment. Herald added subscribers: JDevlieghere, mstorsjo. Initialize signal handlers in `PrintStackTraceOnErrorSignal()` only once. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119009/new/

[Lldb-commits] [PATCH] D119009: [Support] Ensure handlers are set up before printing the stacktrace

werat updated this revision to Diff 406484. werat added a comment. Revert accidental formatting changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119009/new/ https://reviews.llvm.org/D119009 Files: lldb/source/API/SystemInitializerFull.cpp

[Lldb-commits] [PATCH] D119155: [lldb] Print message after loading 'crashlog' command

kastiglione created this revision. kastiglione added a reviewer: JDevlieghere. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Previously, importing `crashlog` resulted in a message being printed. The message was about other

[Lldb-commits] [PATCH] D119009: [Support] Ensure handlers are set up before printing the stacktrace

aganea added a comment. Could you please apply clang format just for the changed lines? You can do that usually through `git clang-format`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119009/new/ https://reviews.llvm.org/D119009

[Lldb-commits] [PATCH] D118814: [lldb] Don't keep demangled names in memory after indexing

labath added a comment. In D118814#3297198 , @JDevlieghere wrote: > In D118814#3297075 , @jingham wrote: > >> In D118814#3296008 , @labath wrote: >> >>> This seems fine,

[Lldb-commits] [PATCH] D114627: [lldb] add new overload for SymbolFile::FindTypes that accepts a scope

lassefolger updated this revision to Diff 406355. lassefolger marked 2 inline comments as done. lassefolger added a comment. update according to comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114627/new/ https://reviews.llvm.org/D114627

[Lldb-commits] [PATCH] D114627: [lldb] add new overload for SymbolFile::FindTypes that accepts a scope

lassefolger added inline comments. Comment at: lldb/include/lldb/Symbol/SymbolFile.h:241 + virtual void + FindTypes(ConstString name, ConstString scope, +const CompilerDeclContext _decl_ctx, uint32_t max_matches, JDevlieghere wrote: > Does the

[Lldb-commits] [PATCH] D119131: [lldb] List platform plugin *instances* in "platform list"

labath created this revision. labath added reviewers: jingham, clayborg, JDevlieghere. labath requested review of this revision. Herald added a project: LLDB. Following up on the discussion on the mailing list https://discourse.llvm.org/t/multiple-platforms-with-the-same-name/59594, this patch is