[Lldb-commits] [PATCH] D117559: [lldb] Remove forward-connect ability from lldb-server tests

2022-03-16 Thread David Spickett via Phabricator via lldb-commits
DavidSpickett added a comment. FYI I am testing this locally, didn't work straight away but I think this might be networking issues on my part. Taking some time to check that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117559/new/

[Lldb-commits] [PATCH] D121786: [LLDB] Update inspect getargspec to getfullargspec

2022-03-16 Thread Muhammad Omair Javaid via Phabricator via lldb-commits
omjavaid created this revision. omjavaid added a reviewer: labath. omjavaid added a project: LLDB. Herald added subscribers: JDevlieghere, kristof.beyls. Herald added a project: All. omjavaid requested review of this revision. This patch replaces getargspec with getfullargspec in funcutils.py.

[Lldb-commits] [PATCH] D117559: [lldb] Remove forward-connect ability from lldb-server tests

2022-03-16 Thread David Spickett via Phabricator via lldb-commits
DavidSpickett added a comment. I was able to use the commands I showed before successfully but only after making these changes: --- a/lldb/packages/Python/lldbsuite/test/tools/lldb-server/gdbremote_testcase.py +++

[Lldb-commits] [PATCH] D121800: [LLDB] Change enumaration to enumeration

2022-03-16 Thread Will Hawkins via Phabricator via lldb-commits
hawkinsw created this revision. hawkinsw added reviewers: clayborg, zequanwu, labath. Herald added a project: All. hawkinsw requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Change enumaration to enumeration in code handling LLDB help

[Lldb-commits] [PATCH] D121802: [LLDB] Fix typos in LLDB help output.

2022-03-16 Thread Will Hawkins via Phabricator via lldb-commits
hawkinsw added a comment. In D121802#3386012 , @labath wrote: > I think you're doing everything right. Thanks for the fixes. I can commit > this together with the other patch. Thanks again for being so welcoming. Definitely encourages me to continue

[Lldb-commits] [PATCH] D121802: [LLDB] Fix typos in LLDB help output.

2022-03-16 Thread Will Hawkins via Phabricator via lldb-commits
hawkinsw created this revision. hawkinsw added reviewers: clayborg, zequanwu, DavidSpickett. Herald added a project: All. hawkinsw requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Correct a few spelling errors and typos in the LLDB help

[Lldb-commits] [PATCH] D121802: [LLDB] Fix typos in LLDB help output.

2022-03-16 Thread Pavel Labath via Phabricator via lldb-commits
labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. I think you're doing everything right. Thanks for the fixes. I can commit this together with the other patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] ccba163 - [lldb] Change back LLDBLog::Commands->Types in a couple more places

2022-03-16 Thread Pavel Labath via lldb-commits
Author: Pavel Labath Date: 2022-03-16T15:46:17+01:00 New Revision: ccba163d85675f6e882f2a1a79e438ff8c0b30d0 URL: https://github.com/llvm/llvm-project/commit/ccba163d85675f6e882f2a1a79e438ff8c0b30d0 DIFF: https://github.com/llvm/llvm-project/commit/ccba163d85675f6e882f2a1a79e438ff8c0b30d0.diff

[Lldb-commits] [PATCH] D121631: Introduce new symbol on-demand for debug info

2022-03-16 Thread Pavel Labath via Phabricator via lldb-commits
labath added a comment. In D121631#3384124 , @yinghuitan wrote: >> unify with `target.preload-symbols` feature > > I do not have strong opinion on this. One concern is that > `target.preload-symbols` provides full experience but >

[Lldb-commits] [PATCH] D121800: [LLDB] Change enumaration to enumeration

2022-03-16 Thread Will Hawkins via Phabricator via lldb-commits
hawkinsw added a comment. In D121800#3385982 , @labath wrote: > Looks good. I presume you need someone to commit this for you (?) What's the > name I can use for commit attribution? Thanks for the quick review!! So glad to be able to help. I do need

[Lldb-commits] [PATCH] D121511: [lldb] Report debugger diagnostics as events

2022-03-16 Thread Pavel Labath via Phabricator via lldb-commits
labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. cool Comment at: lldb/unittests/Core/DiagnosticEventTest.cpp:53-54 +TEST_F(DiagnosticEventTest, Warning) { + ArchSpec arch("x86_64-apple-macosx-"); +

[Lldb-commits] [PATCH] D121786: [LLDB] Update inspect getargspec to getfullargspec

2022-03-16 Thread Muhammad Omair Javaid via Phabricator via lldb-commits
omjavaid added a comment. In D121786#3385619 , @DavidSpickett wrote: >> by python 11x release > > Is this a typo or some numbering system not related to the 2.x/3.x cadence? This is a typo. Sorry I missed 3.11x CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D121786: [LLDB] Update inspect getargspec to getfullargspec

2022-03-16 Thread David Spickett via Phabricator via lldb-commits
DavidSpickett added a comment. > by python 11x release Is this a typo or some numbering system not related to the 2.x/3.x cadence? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121786/new/ https://reviews.llvm.org/D121786 ___ lldb-commits

[Lldb-commits] [PATCH] D121802: [LLDB] Fix typos in LLDB help output.

2022-03-16 Thread Will Hawkins via Phabricator via lldb-commits
hawkinsw added a comment. Herald added a subscriber: JDevlieghere. I hope I didn't spam you all with asking for a review. It seems you are recently committers to this file. I am a long-time user, first-time contributor. I hope I am following best practices. Repository: rG LLVM Github

[Lldb-commits] [PATCH] D121800: [LLDB] Change enumaration to enumeration

2022-03-16 Thread Pavel Labath via Phabricator via lldb-commits
labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Looks good. I presume you need someone to commit this for you (?) What's the name I can use for commit attribution? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D121802: [LLDB] Fix typos in LLDB help output.

2022-03-16 Thread Pavel Labath via Phabricator via lldb-commits
labath added a comment. Yeah, the overhead is pretty large for trivial patches like this, but it's the best we have, so just keep them coming. :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121802/new/ https://reviews.llvm.org/D121802

[Lldb-commits] [lldb] d58ef6d - [LLDB] Change enumaration to enumeration

2022-03-16 Thread Pavel Labath via lldb-commits
Author: Will Hawkins Date: 2022-03-16T15:31:25+01:00 New Revision: d58ef6df0d4a248404810bd1b048a0a8a63cd62b URL: https://github.com/llvm/llvm-project/commit/d58ef6df0d4a248404810bd1b048a0a8a63cd62b DIFF: https://github.com/llvm/llvm-project/commit/d58ef6df0d4a248404810bd1b048a0a8a63cd62b.diff

[Lldb-commits] [lldb] fe93395 - [LLDB] Fix typos in LLDB help output.

2022-03-16 Thread Pavel Labath via lldb-commits
Author: Will Hawkins Date: 2022-03-16T15:31:25+01:00 New Revision: fe93395b92d5e0bdb41871335d1695d8a67142fa URL: https://github.com/llvm/llvm-project/commit/fe93395b92d5e0bdb41871335d1695d8a67142fa DIFF: https://github.com/llvm/llvm-project/commit/fe93395b92d5e0bdb41871335d1695d8a67142fa.diff

[Lldb-commits] [PATCH] D121802: [LLDB] Fix typos in LLDB help output.

2022-03-16 Thread Pavel Labath via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGfe93395b92d5: [LLDB] Fix typos in LLDB help output. (authored by hawkinsw, committed by labath). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121802/new/

[Lldb-commits] [PATCH] D121800: [LLDB] Change enumaration to enumeration

2022-03-16 Thread Pavel Labath via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGd58ef6df0d4a: [LLDB] Change enumaration to enumeration (authored by hawkinsw, committed by labath). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D121802: [LLDB] Fix typos in LLDB help output.

2022-03-16 Thread David Spickett via Phabricator via lldb-commits
DavidSpickett added a comment. Thanks for the corrections! If you didn't already know, you can request commit access https://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access for future patches. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D121631: Introduce new symbol on-demand for debug info

2022-03-16 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere added a comment. In D121631#3386244 , @labath wrote: > In D121631#3384124 , @yinghuitan > wrote: > >>> unify with `target.preload-symbols` feature >> >> I do not have strong opinion on this. One

[Lldb-commits] [PATCH] D121826: [lldb/crashlog] Create artificial frames for non-crashed scripted threads

2022-03-16 Thread Med Ismail Bennani via Phabricator via lldb-commits
mib created this revision. mib added a reviewer: JDevlieghere. mib added a project: LLDB. Herald added a project: All. mib requested review of this revision. Herald added a subscriber: lldb-commits. This patch pipes down the `-a|--load-all` crashlog command option to the Scripted Process

[Lldb-commits] [PATCH] D121818: [lldb] Expose diagnostic events through the SB API

2022-03-16 Thread Med Ismail Bennani via Phabricator via lldb-commits
mib accepted this revision. mib added a comment. This revision is now accepted and ready to land. LGTM! We should have chosen to return a StructuredData for ProgressEvents as well CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121818/new/ https://reviews.llvm.org/D121818

[Lldb-commits] [PATCH] D121826: [lldb/crashlog] Create artificial frames for non-crashed scripted threads

2022-03-16 Thread Med Ismail Bennani via Phabricator via lldb-commits
mib added a comment. In D121826#338 , @JDevlieghere wrote: > Can we cover this case in the existing test? We need to make it multi-threaded. I'll do it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D121831: Modifying expression code in MakeLoadImageUtilityFunction to be more consistent

2022-03-16 Thread Shafik Yaghmour via Phabricator via lldb-commits
shafik added a comment. Note, we have a few tests that cover `LoadImage`: TestCompletion.py TestLoadUsingLazyBind.py TestLoadUsingPaths.py So they should be covering this code. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121831/new/ https://reviews.llvm.org/D121831

[Lldb-commits] [PATCH] D121711: [trace][intelpt] Rename IntelPTManager and change TraceCursor::GetTimestampCounter API to general trace counter API

2022-03-16 Thread Jakob Johnson via Phabricator via lldb-commits
jj10306 updated this revision to Diff 415918. jj10306 added a comment. Fix minor comment issues CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121711/new/ https://reviews.llvm.org/D121711 Files: lldb/include/lldb/Target/TraceCursor.h lldb/include/lldb/lldb-enumerations.h

[Lldb-commits] [lldb] 2fc38b2 - [lldb] Report debugger diagnostics as events

2022-03-16 Thread Jonas Devlieghere via lldb-commits
Author: Jonas Devlieghere Date: 2022-03-16T08:33:01-07:00 New Revision: 2fc38b2b7bf9896806749655124ea5f13cc6d383 URL: https://github.com/llvm/llvm-project/commit/2fc38b2b7bf9896806749655124ea5f13cc6d383 DIFF:

[Lldb-commits] [PATCH] D121425: [VFS] Add a new getVFSFromYAMLs API

2022-03-16 Thread Duncan P. N. Exon Smith via Phabricator via lldb-commits
dexonsmith added a comment. In D121425#3384188 , @bnbarham wrote: > There's two failing tests with this change: > > - VFSFromYAMLTest.ReturnsExternalPathVFSHit > - VFSFromYAMLTest.ReturnsInternalPathVFSHit > > Apparently we allow relative paths in

[Lldb-commits] [PATCH] D121746: Use lit_config.substitute instead of foo % lit_config.params everywhere

2022-03-16 Thread Haojian Wu via Phabricator via lldb-commits
hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. The change looks good. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121746/new/ https://reviews.llvm.org/D121746

[Lldb-commits] [PATCH] D121746: Use lit_config.substitute instead of foo % lit_config.params everywhere

2022-03-16 Thread Sam McCall via Phabricator via lldb-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG75acad41bcd6: Use lit_config.substitute instead of foo % lit_config.params everywhere (authored by sammccall). Repository: rG LLVM Github

[Lldb-commits] [PATCH] D121425: [VFS] Add a new getVFSFromYAMLs API

2022-03-16 Thread Ben Barham via Phabricator via lldb-commits
bnbarham added a comment. In D121425#3384492 , @dexonsmith wrote: > Can you be more detailed about the overall state at the time of `cat`, which > causes it to fail? Sure. I think there's also some confusion with names here but I'm generally trying

[Lldb-commits] [PATCH] D121425: [VFS] Add a new getVFSFromYAMLs API

2022-03-16 Thread Duncan P. N. Exon Smith via Phabricator via lldb-commits
dexonsmith added a comment. In D121425#3384479 , @bnbarham wrote: > In D121425#3384188 , @bnbarham > wrote: > >> There's two failing tests with this change: >> >> - VFSFromYAMLTest.ReturnsExternalPathVFSHit >> -

[Lldb-commits] [PATCH] D121818: [lldb] Expose diagnostic events through the SB API

2022-03-16 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere updated this revision to Diff 415894. JDevlieghere added a comment. Use the minidump warning to check for an actual event. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121818/new/ https://reviews.llvm.org/D121818 Files: lldb/bindings/interface/SBDebugger.i

[Lldb-commits] [PATCH] D121818: [lldb] Expose diagnostic events through the SB API

2022-03-16 Thread Jim Ingham via Phabricator via lldb-commits
jingham added a comment. Yes, if we had had the SBStructuredData class from the start, that would have been a clearer, more robust and flexible way to do the event data in general. But at this point the event data word meanings are API so we can't really remove the old way. CHANGES SINCE

[Lldb-commits] [PATCH] D121511: [lldb] Report debugger diagnostics as events

2022-03-16 Thread Jonas Devlieghere via Phabricator via lldb-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2fc38b2b7bf9: [lldb] Report debugger diagnostics as events (authored by JDevlieghere). Herald added a project: LLDB. Changed prior to commit:

[Lldb-commits] [lldb] 3f0e050 - [lldb] Fix Minidump/no-process-id.yaml

2022-03-16 Thread Jonas Devlieghere via lldb-commits
Author: Jonas Devlieghere Date: 2022-03-16T09:32:06-07:00 New Revision: 3f0e0508420e5d0db95c15ff36db758921c084d9 URL: https://github.com/llvm/llvm-project/commit/3f0e0508420e5d0db95c15ff36db758921c084d9 DIFF:

[Lldb-commits] [PATCH] D121818: [lldb] Expose diagnostic events through the SB API

2022-03-16 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere updated this revision to Diff 415895. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121818/new/ https://reviews.llvm.org/D121818 Files: lldb/bindings/interface/SBDebugger.i lldb/include/lldb/API/SBDebugger.h lldb/include/lldb/Core/DebuggerEvents.h

[Lldb-commits] [PATCH] D121831: Modifying expression code in MakeLoadImageUtilityFunction to be more consistent

2022-03-16 Thread Shafik Yaghmour via Phabricator via lldb-commits
shafik created this revision. shafik added reviewers: aprantl, JDevlieghere. Herald added a subscriber: emaste. Herald added a project: All. shafik requested review of this revision. `MakeLoadImageUtilityFunction()` is not using `extern "C"` for external C functions and it is not using

[Lldb-commits] [PATCH] D121818: [lldb] Expose diagnostic events through the SB API

2022-03-16 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere created this revision. JDevlieghere added reviewers: labath, mib. Herald added a project: All. JDevlieghere requested review of this revision. Expose diagnostic events through the SB API. Unlike the progress events, I chose to use a SBStructuredData so that we can add fields in the

[Lldb-commits] [PATCH] D121826: [lldb/crashlog] Create artificial frames for non-crashed scripted threads

2022-03-16 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere added a comment. Can we cover this case in the existing test? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121826/new/ https://reviews.llvm.org/D121826 ___ lldb-commits mailing list

[Lldb-commits] [lldb] 212f714 - [lldb] add missed handling for new BTFTagAttributed type

2022-03-16 Thread Yonghong Song via lldb-commits
Author: Yonghong Song Date: 2022-03-16T11:00:35-07:00 New Revision: 212f714ff75e2869b051ff381ceb9a16b994adad URL: https://github.com/llvm/llvm-project/commit/212f714ff75e2869b051ff381ceb9a16b994adad DIFF: https://github.com/llvm/llvm-project/commit/212f714ff75e2869b051ff381ceb9a16b994adad.diff

[Lldb-commits] [PATCH] D121711: [trace][intelpt] Rename IntelPTManager and change TraceCursor::GetTimestampCounter API to general trace counter API

2022-03-16 Thread walter erquinigo via Phabricator via lldb-commits
wallace accepted this revision. wallace added a comment. This revision is now accepted and ready to land. just fix these two simple comments and good to go Comment at: lldb/include/lldb/Target/TraceCursor.h:188-189 + /// \param[in] counter_type + ///The counter type

[Lldb-commits] [PATCH] D121631: Introduce new symbol on-demand for debug info

2022-03-16 Thread Greg Clayton via Phabricator via lldb-commits
clayborg added inline comments. Comment at: lldb/include/lldb/Symbol/SymbolFileOnDemand.h:202-203 +private: + bool m_debug_info_enabled{false}; + bool m_preload_symbols{false}; + std::unique_ptr m_sym_file_impl; Comment at:

[Lldb-commits] [PATCH] D121844: Applying clang-tidy modernize-use-equals-default over LLDB

2022-03-16 Thread Shafik Yaghmour via Phabricator via lldb-commits
shafik added inline comments. Comment at: lldb/source/Core/Value.cpp:667 -const ValueList ::operator=(const ValueList ) { +const ValueList ::operator=(const ValueList ) { // NOLINT(modernize-use-equals-default) m_values = rhs.m_values; I have to look into

[Lldb-commits] [PATCH] D121844: Applying clang-tidy modernize-use-equals-default over LLDB

2022-03-16 Thread Shafik Yaghmour via Phabricator via lldb-commits
shafik added a comment. We sure do have a lot of `CommandOptions` classes out there. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121844/new/ https://reviews.llvm.org/D121844 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D121818: [lldb] Expose diagnostic events through the SB API

2022-03-16 Thread Jonas Devlieghere via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGff9e596b1006: [lldb] Expose diagnostic events through the SB API (authored by JDevlieghere). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D121818?vs=415895=415996#toc

[Lldb-commits] [lldb] ff9e596 - [lldb] Expose diagnostic events through the SB API

2022-03-16 Thread Jonas Devlieghere via lldb-commits
Author: Jonas Devlieghere Date: 2022-03-16T15:03:31-07:00 New Revision: ff9e596b1006fb01fb999c300a298b8e43cfd0ee URL: https://github.com/llvm/llvm-project/commit/ff9e596b1006fb01fb999c300a298b8e43cfd0ee DIFF:

[Lldb-commits] [lldb] 2207762 - Minor refactor and renaming:

2022-03-16 Thread Jakob Johnson via lldb-commits
Author: Jakob Johnson Date: 2022-03-16T15:35:36-07:00 New Revision: 22077627ae20d5a6e50f43337e8ad2e23f1fa3ff URL: https://github.com/llvm/llvm-project/commit/22077627ae20d5a6e50f43337e8ad2e23f1fa3ff DIFF: https://github.com/llvm/llvm-project/commit/22077627ae20d5a6e50f43337e8ad2e23f1fa3ff.diff

[Lldb-commits] [PATCH] D121711: [trace][intelpt] Rename IntelPTManager and change TraceCursor::GetTimestampCounter API to general trace counter API

2022-03-16 Thread Jakob Johnson via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG22077627ae20: Minor refactor and renaming: (authored by jj10306). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121711/new/

[Lldb-commits] [PATCH] D121844: Applying clang-tidy modernize-use-equals-default over LLDB

2022-03-16 Thread Shafik Yaghmour via Phabricator via lldb-commits
shafik created this revision. shafik added reviewers: labath, aprantl, JDevlieghere. Herald added a project: All. shafik requested review of this revision. Applied `modernize-use-equals-default ` clang-tidy check over LLDB. This check is already present in the lldb/.clang-tidy config.

[Lldb-commits] [PATCH] D121711: [trace][intelpt] Rename IntelPTManager and change TraceCursor::GetTimestampCounter API to general trace counter API

2022-03-16 Thread Jakob Johnson via Phabricator via lldb-commits
jj10306 updated this revision to Diff 415960. jj10306 added a comment. rebase CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121711/new/ https://reviews.llvm.org/D121711 Files: lldb/include/lldb/Target/TraceCursor.h lldb/include/lldb/lldb-enumerations.h

[Lldb-commits] [PATCH] D121831: Modifying expression code in MakeLoadImageUtilityFunction to be more consistent

2022-03-16 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. We do the same thing for parsing the classes from the Objective-C runtime so this makes sense to me. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121831/new/

[Lldb-commits] [PATCH] D121826: [lldb/crashlog] Create artificial frames for non-crashed scripted threads

2022-03-16 Thread Med Ismail Bennani via Phabricator via lldb-commits
mib updated this revision to Diff 416001. mib added a comment. Add multithreaded crashlog test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121826/new/ https://reviews.llvm.org/D121826 Files: lldb/examples/python/crashlog.py

[Lldb-commits] [PATCH] D121826: [lldb/crashlog] Create artificial frames for non-crashed scripted threads

2022-03-16 Thread Med Ismail Bennani via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG0a65112cf710: [lldb/crashlog] Create artificial frames for non-crashed scripted threads (authored by mib). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] 0a65112 - [lldb/crashlog] Create artificial frames for non-crashed scripted threads

2022-03-16 Thread Med Ismail Bennani via lldb-commits
Author: Med Ismail Bennani Date: 2022-03-16T15:50:10-07:00 New Revision: 0a65112cf710945fa5cfc0d0be6ff84eba5adb3a URL: https://github.com/llvm/llvm-project/commit/0a65112cf710945fa5cfc0d0be6ff84eba5adb3a DIFF:

[Lldb-commits] [PATCH] D121844: Applying clang-tidy modernize-use-equals-default over LLDB

2022-03-16 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121844/new/ https://reviews.llvm.org/D121844 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D121826: [lldb/crashlog] Create artificial frames for non-crashed scripted threads

2022-03-16 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM. I think we've reached a point where the test binary has become complex enough that we should check it in instead of hoping that the offsets will match, but that's something

[Lldb-commits] [PATCH] D121631: Introduce new symbol on-demand for debug info

2022-03-16 Thread Greg Clayton via Phabricator via lldb-commits
clayborg added a comment. In D121631#3386244 , @labath wrote: > In D121631#3384124 , @yinghuitan > wrote: > >>> unify with `target.preload-symbols` feature >> >> I do not have strong opinion on this. One concern

[Lldb-commits] [PATCH] D121408: Fixing DWARFExpression handling of ValueType::FileAddress case for DW_OP_deref_size

2022-03-16 Thread Greg Clayton via Phabricator via lldb-commits
clayborg added a comment. Sorry for the late comments. Looks like it got checked in already, but will submit inline comments anyway. Comment at: lldb/source/Expression/DWARFExpression.cpp:963 +static llvm::Optional +ResolveAndLoadFileAddress(ExecutionContext *exe_ctx,

[Lldb-commits] [PATCH] D121826: [lldb/crashlog] Create artificial frames for non-crashed scripted threads

2022-03-16 Thread Med Ismail Bennani via Phabricator via lldb-commits
mib updated this revision to Diff 416006. mib added a comment. Simplify test source checks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121826/new/ https://reviews.llvm.org/D121826 Files: lldb/examples/python/crashlog.py

[Lldb-commits] [lldb] 8e893df - [lldb] Fix flakyness in Minidump/no-process-id.yaml

2022-03-16 Thread Jonas Devlieghere via lldb-commits
Author: Jonas Devlieghere Date: 2022-03-16T21:21:11-07:00 New Revision: 8e893dfed5f9ae0aaebf528d12dccd109f17f2ee URL: https://github.com/llvm/llvm-project/commit/8e893dfed5f9ae0aaebf528d12dccd109f17f2ee DIFF:

[Lldb-commits] [lldb] 557a0e7 - [lldb] Fix flakyness in command-disassemble-process.yaml

2022-03-16 Thread Jonas Devlieghere via lldb-commits
Author: Jonas Devlieghere Date: 2022-03-16T21:27:54-07:00 New Revision: 557a0e7b96680a10f311d39c446967f2d500 URL: https://github.com/llvm/llvm-project/commit/557a0e7b96680a10f311d39c446967f2d500 DIFF:

[Lldb-commits] [lldb] d10c0c7 - [lldb] Migrate condition evaluation failure to ReportError

2022-03-16 Thread Jonas Devlieghere via lldb-commits
Author: Jonas Devlieghere Date: 2022-03-16T22:54:02-07:00 New Revision: d10c0c7b187d6a5d7a24544d70998f8d348b4dfd URL: https://github.com/llvm/llvm-project/commit/d10c0c7b187d6a5d7a24544d70998f8d348b4dfd DIFF:

[Lldb-commits] [lldb] c354f13 - [lldb] Update TargetProperties::CheckJITObjectsDir to use ReportError

2022-03-16 Thread Jonas Devlieghere via lldb-commits
Author: Jonas Devlieghere Date: 2022-03-16T21:11:53-07:00 New Revision: c354f13e6995f092edccfca7653fdd1a656b25f2 URL: https://github.com/llvm/llvm-project/commit/c354f13e6995f092edccfca7653fdd1a656b25f2 DIFF:

[Lldb-commits] [lldb] 8212b41 - [lldb] Fix flakiness in command-disassemble-process.yaml (2/2)

2022-03-16 Thread Jonas Devlieghere via lldb-commits
Author: Jonas Devlieghere Date: 2022-03-16T22:12:39-07:00 New Revision: 8212b41b7b7d76d18b29494cd0f141959e27c187 URL: https://github.com/llvm/llvm-project/commit/8212b41b7b7d76d18b29494cd0f141959e27c187 DIFF:

[Lldb-commits] [PATCH] D121875: [BOLT][DWARF] Re-enable DWARF5 tests.

2022-03-16 Thread Alexander Yermolovich via Phabricator via lldb-commits
ayermolo created this revision. Herald added subscribers: hoy, modimo, wenlei. Herald added a project: All. ayermolo requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Test Plan: Repository: rG LLVM Github Monorepo