[Lldb-commits] [PATCH] D127922: [lldb] Introduce the concept of a log handler (NFC)

JDevlieghere added a comment. In D127922#3595530 , @labath wrote: > I think we should talk about the threadsafe flag. The reason that the > non-threadsafe mode is safe now is because we're using unbuffered streams, > where each stream operation will

[Lldb-commits] [PATCH] D128268: [lldb] Fix reading i686-windows executables with GNU environment

DavidSpickett accepted this revision. DavidSpickett added a comment. This revision is now accepted and ready to land. LGTM. I like the ifs the way I suggested but up to you, either way it's not the easiest logic to parse. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D128268: [lldb] Fix reading i686-windows executables with GNU environment

mstorsjo updated this revision to Diff 438951. mstorsjo added a comment. Refactored the code to add the `both_windows` variable as suggested (which turned out much nicer, thanks!). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128268/new/

[Lldb-commits] [PATCH] D127234: [lldb] Add setting to override PE/COFF ABI by module name

DavidSpickett accepted this revision. DavidSpickett added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127234/new/ https://reviews.llvm.org/D127234

[Lldb-commits] [PATCH] D128268: [lldb] Fix reading i686-windows executables with GNU environment

mstorsjo added a comment. In D128268#3601104 , @DavidSpickett wrote: > LGTM. I like the ifs the way I suggested but up to you, either way it's not > the easiest logic to parse. Oh, sorry, I forgot about that comment. Yes, that does indeed look even

[Lldb-commits] [PATCH] D127436: [lldb] Resolve exe location for `target create`

DavidSpickett accepted this revision. DavidSpickett added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127436/new/ https://reviews.llvm.org/D127436

[Lldb-commits] [lldb] 9846a1f - [lldb] Remove an outdated comment. NFC.

Author: Martin Storsjö Date: 2022-06-22T16:11:59+03:00 New Revision: 9846a1f2d4723a8c060370638bbd52360638d0fc URL: https://github.com/llvm/llvm-project/commit/9846a1f2d4723a8c060370638bbd52360638d0fc DIFF:

[Lldb-commits] [PATCH] D128226: [lldb] Remove an outdated comment. NFC.

This revision was automatically updated to reflect the committed changes. Closed by commit rG9846a1f2d472: [lldb] Remove an outdated comment. NFC. (authored by mstorsjo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128226/new/

[Lldb-commits] [lldb] 8a64dd5 - [lldb] Fix reading i686-windows executables with GNU environment

Author: Martin Storsjö Date: 2022-06-22T17:16:05+03:00 New Revision: 8a64dd5b06146f073a4a326f0e24fa18e571b281 URL: https://github.com/llvm/llvm-project/commit/8a64dd5b06146f073a4a326f0e24fa18e571b281 DIFF:

[Lldb-commits] [lldb] 2bae956 - [lldb] Resolve exe location for `target create`

Author: Alvin Wong Date: 2022-06-22T17:16:05+03:00 New Revision: 2bae9560575362ffd756f193efa1de2d5c2f4cfd URL: https://github.com/llvm/llvm-project/commit/2bae9560575362ffd756f193efa1de2d5c2f4cfd DIFF: https://github.com/llvm/llvm-project/commit/2bae9560575362ffd756f193efa1de2d5c2f4cfd.diff

[Lldb-commits] [lldb] 4d12378 - [lldb][windows] Fix crash on getting nested exception

Author: Alvin Wong Date: 2022-06-22T17:16:06+03:00 New Revision: 4d123783957e547009e55346bf3a8ae43a88fa14 URL: https://github.com/llvm/llvm-project/commit/4d123783957e547009e55346bf3a8ae43a88fa14 DIFF: https://github.com/llvm/llvm-project/commit/4d123783957e547009e55346bf3a8ae43a88fa14.diff

[Lldb-commits] [PATCH] D128268: [lldb] Fix reading i686-windows executables with GNU environment

This revision was automatically updated to reflect the committed changes. Closed by commit rG8a64dd5b0614: [lldb] Fix reading i686-windows executables with GNU environment (authored by mstorsjo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] 3c86789 - [lldb] Add setting to override PE/COFF ABI by module name

Author: Alvin Wong Date: 2022-06-22T17:16:06+03:00 New Revision: 3c867898c7be7ed2b5d119a2478a836a0c85f19b URL: https://github.com/llvm/llvm-project/commit/3c867898c7be7ed2b5d119a2478a836a0c85f19b DIFF: https://github.com/llvm/llvm-project/commit/3c867898c7be7ed2b5d119a2478a836a0c85f19b.diff

[Lldb-commits] [PATCH] D128201: [lldb][windows] Fix crash on getting nested exception

This revision was automatically updated to reflect the committed changes. Closed by commit rG4d123783957e: [lldb][windows] Fix crash on getting nested exception (authored by alvinhochun, committed by mstorsjo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D127234: [lldb] Add setting to override PE/COFF ABI by module name

This revision was automatically updated to reflect the committed changes. Closed by commit rG3c867898c7be: [lldb] Add setting to override PE/COFF ABI by module name (authored by alvinhochun, committed by mstorsjo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D127436: [lldb] Resolve exe location for `target create`

This revision was automatically updated to reflect the committed changes. Closed by commit rG2bae95605753: [lldb] Resolve exe location for `target create` (authored by alvinhochun, committed by mstorsjo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D128316: [trace] Add an option to dump instructions in json and to a file

jj10306 requested changes to this revision. jj10306 added a comment. This revision now requires changes to proceed. looks great overall, just a couple minor comments! Comment at: lldb/include/lldb/Target/TraceInstructionDumper.h:46 /// state and granularity. class

[Lldb-commits] [PATCH] D128292: [lldb/Fuzzer] Add command interpreter fuzzer for LLDB

cassanova updated this revision to Diff 439021. cassanova added a comment. Updated ASCII header to work with 80-column limit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128292/new/ https://reviews.llvm.org/D128292 Files:

[Lldb-commits] [PATCH] D128316: [trace] Add an option to dump instructions in json and to a file

wallace updated this revision to Diff 439072. wallace added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128316/new/ https://reviews.llvm.org/D128316 Files: lldb/include/lldb/Target/TraceCursor.h

[Lldb-commits] [PATCH] D128316: [trace] Add an option to dump instructions in json and to a file

wallace marked 4 inline comments as done. wallace added inline comments. Comment at: lldb/include/lldb/Target/TraceInstructionDumper.h:46 /// state and granularity. class TraceInstructionDumper { public: jj10306 wrote: > nit: wdyt ab renaming this to

[Lldb-commits] [PATCH] D127436: [lldb] Resolve exe location for `target create`

mstorsjo added a comment. In D127436#3602224 , @stella.stamenova wrote: > This broke the Windows LLDB bot: > > https://lab.llvm.org/buildbot/#/builders/83/builds/20295/steps/7/logs/stdio Yep, noted. It worked for me in my MSVC build configuration -

[Lldb-commits] [PATCH] D128324: [lldb] [llgs] Introduce a AppendThreadIDToResponse() helper

mgorny created this revision. mgorny added reviewers: labath, krytarowski, emaste, jingham. Herald added a subscriber: arichardson. Herald added a project: All. mgorny requested review of this revision. Introduce a helper function to append GDB Remote Serial Protocol "thread IDs", with optional

[Lldb-commits] [lldb] 0bc7105 - [lldb] Tentative attempt to fix command-target-create-resolve-exe.test on buildbot

Author: Martin Storsjö Date: 2022-06-22T18:48:04+03:00 New Revision: 0bc7105cd1447c2d85716c3dcd2924595decc939 URL: https://github.com/llvm/llvm-project/commit/0bc7105cd1447c2d85716c3dcd2924595decc939 DIFF:

[Lldb-commits] [PATCH] D127436: [lldb] Resolve exe location for `target create`

stella.stamenova added a comment. This broke the Windows LLDB bot: https://lab.llvm.org/buildbot/#/builders/83/builds/20295/steps/7/logs/stdio Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127436/new/ https://reviews.llvm.org/D127436

[Lldb-commits] [PATCH] D128316: [trace] Add an option to dump instructions in json and to a file

jj10306 accepted this revision. jj10306 added inline comments. This revision is now accepted and ready to land. Comment at: lldb/source/Target/TraceInstructionDumper.cpp:193-194 + OutputWriterJSON(Stream , const TraceInstructionDumperOptions ) + : m_s(s),

[Lldb-commits] [PATCH] D126513: Add -b (--continue-to-breakpoint) option to the "process continue" command

mstorsjo added subscribers: stella.stamenova, mstorsjo. mstorsjo added a comment. I think this might have broken a bunch of testcases on the lldb-x64-windows-ninja buildbot too, e.g. https://lab.llvm.org/buildbot/#/builders/83/builds/20304 (CC @stella.stamenova) Repository: rG LLVM Github

[Lldb-commits] [PATCH] D128316: [trace] Add an option to dump instructions in json and to a file

wallace added inline comments. Comment at: lldb/source/Target/TraceInstructionDumper.cpp:193-194 + OutputWriterJSON(Stream , const TraceInstructionDumperOptions ) + : m_s(s), m_options(options), m_j(/*IndentSize=*/m_s.AsRawOstream(), +

[Lldb-commits] [PATCH] D128361: [lldb] [test] Move part of fork tests to common helper

mgorny created this revision. mgorny added reviewers: labath, krytarowski, emaste, jingham. Herald added a subscriber: arichardson. Herald added a project: All. mgorny requested review of this revision. Sponsored by: The FreeBSD Foundation https://reviews.llvm.org/D128361 Files:

[Lldb-commits] [PATCH] D128292: [lldb/Fuzzer] Add command interpreter fuzzer for LLDB

mib accepted this revision. mib added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128292/new/ https://reviews.llvm.org/D128292 ___

[Lldb-commits] [PATCH] D127436: [lldb] Resolve exe location for `target create`

mstorsjo added a comment. In D127436#3602224 , @stella.stamenova wrote: > This broke the Windows LLDB bot: > > https://lab.llvm.org/buildbot/#/builders/83/builds/20295/steps/7/logs/stdio The second fix attempt, in

[Lldb-commits] [PATCH] D126513: Add -b (--continue-to-breakpoint) option to the "process continue" command

wallace added a comment. This just broke trunk. Look at this repro: #include #include void f3() { int m; m = 2; // thread 3 - line 6 } void f2() { int n; n = 1; // thread 2 - line 11 std::thread t3(f3); t3.join(); } int main() { // main

[Lldb-commits] [PATCH] D128323: [lldb] Add support for specifying a log handler

mib added inline comments. Comment at: lldb/source/Core/Debugger.cpp:1409-1411 +static std::shared_ptr +CreateLogHandler(LogHandlerKind log_handler_kind, int fd, bool should_close, + size_t buffer_size) { Many (or most) arguments passed to this

[Lldb-commits] [PATCH] D128366: [lldb] Make Module::LookupInfo::Prune language-agnostic

bulbazord created this revision. bulbazord added reviewers: JDevlieghere, clayborg, jingham, labath. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Module::LookupInfo::Prune tries to prune results from lookups that don't match the

[Lldb-commits] [PATCH] D128321: [lldb] Add OSLog log handler

clayborg added a comment. I think we should allow this class to always exist and not conditionally compile it in or out. Then we add a new Host.h method to emit a log message in "lldb/Host/Host.h" and allow each host OS to emit a message. Maybe there is a default implementation that emits the

[Lldb-commits] [PATCH] D126513: Add -b (--continue-to-breakpoint) option to the "process continue" command

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4298b1b8d137: Add a -b option to process continue to run to a set of breakpoints, (authored by jingham). Repository: rG LLVM Github Monorepo

[Lldb-commits] [lldb] 4298b1b - Add a "-b" option to "process continue" to run to a set of breakpoints,

Author: Jim Ingham Date: 2022-06-22T09:55:30-07:00 New Revision: 4298b1b8d13715963cc1a917bc122208a29710fb URL: https://github.com/llvm/llvm-project/commit/4298b1b8d13715963cc1a917bc122208a29710fb DIFF: https://github.com/llvm/llvm-project/commit/4298b1b8d13715963cc1a917bc122208a29710fb.diff

[Lldb-commits] [PATCH] D128069: [lldb] add SBSection.alignment to python bindings

dmlary added a comment. > We should test any APIs we add in a python test IMHO. Also testing that the > ".alignment" property works Ok, I'll add tests for the added python function and property. Now for the hard part, what's the recommended way to access elf section details within python

[Lldb-commits] [lldb] a1ee0b9 - [lldb] Second attempt at fixing command-target-create-resolve-exe.test on the buildbot

Author: Alvin Wong Date: 2022-06-22T20:49:30+03:00 New Revision: a1ee0b947d46c9be1cc2ea8db21603bac84efb18 URL: https://github.com/llvm/llvm-project/commit/a1ee0b947d46c9be1cc2ea8db21603bac84efb18 DIFF: https://github.com/llvm/llvm-project/commit/a1ee0b947d46c9be1cc2ea8db21603bac84efb18.diff

[Lldb-commits] [lldb] 130167e - [LLDB] Handle DIE with DW_AT_low_pc and empty ranges

Author: Alexander Yermolovich Date: 2022-06-22T10:54:25-07:00 New Revision: 130167ed1effa36aa56c83c4293e732e5163d993 URL: https://github.com/llvm/llvm-project/commit/130167ed1effa36aa56c83c4293e732e5163d993 DIFF:

[Lldb-commits] [PATCH] D127889: [LLDB] Handle DIE with DW_AT_low_pc and empty ranges

This revision was automatically updated to reflect the committed changes. Closed by commit rG130167ed1eff: [LLDB] Handle DIE with DW_AT_low_pc and empty ranges (authored by ayermolo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127889/new/

[Lldb-commits] [PATCH] D128316: [trace] Add an option to dump instructions in json and to a file

This revision was automatically updated to reflect the committed changes. Closed by commit rGefbfde0dd0f9: [trace] Add an option to dump instructions in json and to a file (authored by Walter Erquinigo wall...@fb.com). Changed prior to commit:

[Lldb-commits] [lldb] efbfde0 - [trace] Add an option to dump instructions in json and to a file

Author: Walter Erquinigo Date: 2022-06-22T11:14:22-07:00 New Revision: efbfde0dd0f92d89767df53cbfb883ecf93ffa83 URL: https://github.com/llvm/llvm-project/commit/efbfde0dd0f92d89767df53cbfb883ecf93ffa83 DIFF:

[Lldb-commits] [PATCH] D128323: [lldb] Add support for specifying a log handler

mib added inline comments. Comment at: lldb/source/Commands/CommandObjectLog.cpp:167 buffer_size.Clear(); + handler = eLogHandlerStream; log_options = 0; clayborg wrote: > Do we want to define a "eLogHandlerDefault" which points to >

[Lldb-commits] [PATCH] D128292: [lldb/Fuzzer] Add command interpreter fuzzer for LLDB

cassanova updated this revision to Diff 439111. cassanova added a comment. Updated CMakeLists file to save fuzzer artifacts (the files that the fuzzer writes when an input causes the program being fuzzed to fail) to a directory in the user's build directory, instead of saving them in the user's

[Lldb-commits] [lldb] bae10a6 - Fix a bug with "process continue -b" when no breakpoints are

Author: Jim Ingham Date: 2022-06-22T12:18:07-07:00 New Revision: bae10a6bbb1ed6ba8185884e3239fe3556602dab URL: https://github.com/llvm/llvm-project/commit/bae10a6bbb1ed6ba8185884e3239fe3556602dab DIFF: https://github.com/llvm/llvm-project/commit/bae10a6bbb1ed6ba8185884e3239fe3556602dab.diff

[Lldb-commits] [PATCH] D128377: [lldb] Fix off-by-one error in the AppleObjCRuntimeV2 utility function

JDevlieghere created this revision. JDevlieghere added a reviewer: aprantl. Herald added a project: All. JDevlieghere requested review of this revision. Fix an off-by-one error in the utility function used to extract the dynamic class info. This resulted in a buffer overflow in the inferior

[Lldb-commits] [PATCH] D128378: [lldb] Return the correct utility function in AppleObjCRuntimeV2

JDevlieghere created this revision. JDevlieghere added a reviewer: aprantl. Herald added a project: All. JDevlieghere requested review of this revision. A copy/paste error in GetClassInfoUtilityFunction resulted in the wrong utility function being returned: copyRealizedClassList instead of

[Lldb-commits] [PATCH] D128377: [lldb] Fix off-by-one error in the AppleObjCRuntimeV2 utility function

JDevlieghere added a comment. In D128377#3602856 , @aprantl wrote: > I'm curious now why there is both `count` and `max_class_infos` and if the > second is workaround for this bug? Anyway, this *looks* plausible! `count` is the actual value reported by

[Lldb-commits] [PATCH] D128321: [lldb] Add OSLog log handler

JDevlieghere added a comment. In D128321#3602129 , @clayborg wrote: > I think we should allow this class to always exist and not conditionally > compile it in or out. Then we add a new Host.h method to emit a log message > in "lldb/Host/Host.h" and

[Lldb-commits] [PATCH] D128386: [lldb] Make thread safety the responsibility of the log handlers

JDevlieghere created this revision. JDevlieghere added reviewers: labath, clayborg, mib. Herald added a project: All. JDevlieghere requested review of this revision. As per Pavel's suggestion in D127922 , make thread safety the responsibility of the log

[Lldb-commits] [PATCH] D128321: [lldb] Add OSLog log handler

aprantl added inline comments. Comment at: lldb/include/lldb/Utility/Log.h:98 +class SystemLogHandler : public LogHandler { +public: Doxygen comment? Comment at: lldb/source/Utility/Log.cpp:406 + if (__builtin_available(macos 10.12, iOS 10,

[Lldb-commits] [PATCH] D128377: [lldb] Fix off-by-one error in the AppleObjCRuntimeV2 utility function

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. I'm curious now why there is both `count` and `max_class_infos` and if the second is workaround for this bug? Anyway, this *looks* plausible! CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D128292: [lldb/Fuzzer] Add command interpreter fuzzer for LLDB

mib added inline comments. Comment at: lldb/tools/lldb-fuzzer/lldb-commandinterpreter-fuzzer/CMakeLists.txt:17 + + # This will create a directory specifially for the fuzzer's artifacts, go to that + # directory and run the fuzzer from there. When the fuzzer exits the input

[Lldb-commits] [PATCH] D128292: [lldb/Fuzzer] Add command interpreter fuzzer for LLDB

mib accepted this revision. mib added a comment. Ship it! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128292/new/ https://reviews.llvm.org/D128292 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D128292: [lldb/Fuzzer] Add command interpreter fuzzer for LLDB

This revision was automatically updated to reflect the committed changes. Closed by commit rG46be5faaf034: [lldb/Fuzzer] Add command interpreter fuzzer for LLDB (authored by cassanova). Changed prior to commit: https://reviews.llvm.org/D128292?vs=439158=439163#toc Repository: rG LLVM Github

[Lldb-commits] [lldb] 46be5fa - [lldb/Fuzzer] Add command interpreter fuzzer for LLDB

Author: Chelsea Cassanova Date: 2022-06-22T17:42:55-04:00 New Revision: 46be5faaf03466c3751f8a2882bef5a217e15926 URL: https://github.com/llvm/llvm-project/commit/46be5faaf03466c3751f8a2882bef5a217e15926 DIFF:

[Lldb-commits] [PATCH] D128378: [lldb] Return the correct utility function in AppleObjCRuntimeV2

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. Oh boy, these are scary. Should LLDB fail harder when the utility expression fails, so we can detect these earlier? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128378/new/

[Lldb-commits] [PATCH] D128378: [lldb] Return the correct utility function in AppleObjCRuntimeV2

JDevlieghere added a comment. In D128378#3602888 , @aprantl wrote: > Oh boy, these are scary. Should LLDB fail harder when the utility expression > fails, so we can detect these earlier? Fortunately we print an error, but we're also pretty resilient

[Lldb-commits] [PATCH] D128378: [lldb] Return the correct utility function in AppleObjCRuntimeV2

This revision was automatically updated to reflect the committed changes. Closed by commit rGf0d87dfe30e8: [lldb] Return the correct utility function in AppleObjCRuntimeV2 (authored by JDevlieghere). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] f0d87df - [lldb] Return the correct utility function in AppleObjCRuntimeV2

Author: Jonas Devlieghere Date: 2022-06-22T13:57:23-07:00 New Revision: f0d87dfe30e86d701034af9320b29d3e2e3a12b3 URL: https://github.com/llvm/llvm-project/commit/f0d87dfe30e86d701034af9320b29d3e2e3a12b3 DIFF:

[Lldb-commits] [lldb] d95c406 - [lldb] Fix off-by-one error in the AppleObjCRuntimeV2 utility function

Author: Jonas Devlieghere Date: 2022-06-22T13:57:24-07:00 New Revision: d95c406c20ef8135fae74cc82406f498084749a0 URL: https://github.com/llvm/llvm-project/commit/d95c406c20ef8135fae74cc82406f498084749a0 DIFF:

[Lldb-commits] [PATCH] D128377: [lldb] Fix off-by-one error in the AppleObjCRuntimeV2 utility function

This revision was automatically updated to reflect the committed changes. Closed by commit rGd95c406c20ef: [lldb] Fix off-by-one error in the AppleObjCRuntimeV2 utility function (authored by JDevlieghere). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[Lldb-commits] [PATCH] D128292: [lldb/Fuzzer] Add command interpreter fuzzer for LLDB

cassanova updated this revision to Diff 439158. cassanova added a comment. Added a subdirectory to the top-level build directory. This directory will hold directories for the artifacts of various fuzzers. Also corrected a typo in the command interpreter CMakeLists file. Repository: rG LLVM

[Lldb-commits] [PATCH] D128321: [lldb] Add OSLog log handler

JDevlieghere updated this revision to Diff 439164. JDevlieghere marked 5 inline comments as done. JDevlieghere added a comment. Address remaining code review feedback CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128321/new/ https://reviews.llvm.org/D128321 Files:

[Lldb-commits] [PATCH] D128323: [lldb] Add support for specifying a log handler

JDevlieghere updated this revision to Diff 439170. JDevlieghere marked 2 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128323/new/ https://reviews.llvm.org/D128323 Files: lldb/include/lldb/Core/Debugger.h lldb/include/lldb/lldb-private-enumerations.h

[Lldb-commits] [PATCH] D128323: [lldb] Add support for specifying a log handler

JDevlieghere marked 11 inline comments as done. JDevlieghere added inline comments. Comment at: lldb/source/Commands/Options.td:436-437 Desc<"Set the log to be buffered, using the specified buffer size.">; + def log_handler : Option<"handler", "h">, Group<1>, +

[Lldb-commits] [PATCH] D128321: [lldb] Add OSLog log handler

JDevlieghere marked 2 inline comments as done. JDevlieghere added inline comments. Comment at: lldb/source/Utility/Log.cpp:406 + if (__builtin_available(macos 10.12, iOS 10, tvOS 10, watchOS 3, *)) { +os_log(g_os_log, "%{public}s", str.c_str()); + } else {

[Lldb-commits] [PATCH] D128321: [lldb] Add OSLog log handler

JDevlieghere marked an inline comment as done. JDevlieghere added inline comments. Comment at: lldb/source/Utility/Log.cpp:406 + if (__builtin_available(macos 10.12, iOS 10, tvOS 10, watchOS 3, *)) { +os_log(g_os_log, "%{public}s", str.c_str()); + } else {