[Lldb-commits] [PATCH] D128268: [lldb] Fix reading i686-windows executables with GNU environment

labath added a comment. In D128268#3604077 , @mstorsjo wrote: > In D128268#3603931 , @labath wrote: > >>> As a separate path forward, one could also consider to stop returning >>> two architecture specs from

[Lldb-commits] [PATCH] D128264: [lldb/dyld-posix] Avoid reading the module list in inconsistent states

labath marked an inline comment as done. labath added inline comments. Comment at: lldb/source/Plugins/DynamicLoader/POSIX-DYLD/DynamicLoaderPOSIXDYLD.cpp:441 + _process->GetTarget()) == m_interpreter_base) { +ModuleSP interpreter_sp =

[Lldb-commits] [lldb] 5e7ddb0 - Revert "[LLDB] Handle DIE with DW_AT_low_pc and empty ranges"

Author: David Spickett Date: 2022-06-23T10:33:05Z New Revision: 5e7ddb0ddfe81b704dd52f725e159fec7e20eba5 URL: https://github.com/llvm/llvm-project/commit/5e7ddb0ddfe81b704dd52f725e159fec7e20eba5 DIFF: https://github.com/llvm/llvm-project/commit/5e7ddb0ddfe81b704dd52f725e159fec7e20eba5.diff

[Lldb-commits] [PATCH] D128268: [lldb] Fix reading i686-windows executables with GNU environment

labath added a comment. > As a separate path forward, one could also consider to stop returning > two architecture specs from ObjectFilePECOFF::GetModuleSpecifications > for i386 files. I think that would be much more preferable. I think the current implementation GetModuleSpecifications is

[Lldb-commits] [PATCH] D127889: [LLDB] Handle DIE with DW_AT_low_pc and empty ranges

DavidSpickett added a comment. I've reverted this due to failures on our bots: https://lab.llvm.org/buildbot/#/builders/96/builds/25032/steps/6/logs/stdio /usr/bin/ld:

[Lldb-commits] [PATCH] D128410: [lldb] Add a testcase for nested exceptions on Windows

mstorsjo added a comment. In D128410#3604083 , @mstorsjo wrote: > I'm not all that familiar with exactly what happens in these APIs here that > makes this a nested exception and what other non-GUI APIs would produce the > same effect. Maybe any API

[Lldb-commits] [PATCH] D128321: [lldb] Add OSLog log handler

labath added a comment. In D128321#3603007 , @JDevlieghere wrote: > In D128321#3602129 , @clayborg > wrote: > >> I think we should allow this class to always exist and not conditionally >> compile it in or

[Lldb-commits] [PATCH] D128268: [lldb] Fix reading i686-windows executables with GNU environment

mstorsjo added a comment. In D128268#3603931 , @labath wrote: >> As a separate path forward, one could also consider to stop returning >> two architecture specs from ObjectFilePECOFF::GetModuleSpecifications >> for i386 files. > > I think that would be

[Lldb-commits] [PATCH] D128410: [lldb] Add a testcase for nested exceptions on Windows

mstorsjo created this revision. mstorsjo added reviewers: labath, alvinhochun, DavidSpickett. Herald added a project: All. mstorsjo requested review of this revision. Herald added a project: LLDB. This adds a testcase for 4d123783957e547009e55346bf3a8ae43a88fa14

[Lldb-commits] [PATCH] D128268: [lldb] Fix reading i686-windows executables with GNU environment

mstorsjo added a comment. In D128268#3603931 , @labath wrote: >> As a separate path forward, one could also consider to stop returning >> two architecture specs from ObjectFilePECOFF::GetModuleSpecifications >> for i386 files. > > I think that would be

[Lldb-commits] [PATCH] D128410: [lldb] Add a testcase for nested exceptions on Windows

labath added a comment. In D128410#3604066 , @mstorsjo wrote: > For this testcase to work, it needs to be able to open a window - so it can't > run entirely in headless mode. But I guess that a bunch of other tests in > LLDB also already do that, since

[Lldb-commits] [PATCH] D128324: [lldb] [llgs] Introduce a AppendThreadIDToResponse() helper

mgorny marked an inline comment as done. mgorny added inline comments. Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp:4162 +void GDBRemoteCommunicationServerLLGS::AppendThreadIDToResponse( +StreamString , lldb::pid_t pid, lldb::tid_t

[Lldb-commits] [PATCH] D128324: [lldb] [llgs] Introduce an AppendThreadIDToResponse() helper

mgorny updated this revision to Diff 439286. mgorny marked an inline comment as done. mgorny added a comment. Allow any `Stream` object. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128324/new/ https://reviews.llvm.org/D128324 Files:

[Lldb-commits] [PATCH] D128069: [lldb] add SBSection.alignment to python bindings

labath added a comment. In D128069#3602256 , @dmlary wrote: >> We should test any APIs we add in a python test IMHO. Also testing that the >> ".alignment" property works > > Ok, I'll add tests for the added python function and property. > > Now for the

[Lldb-commits] [PATCH] D128264: [lldb/dyld-posix] Avoid reading the module list in inconsistent states

labath updated this revision to Diff 439277. labath added a comment. reuse the module pointer Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128264/new/ https://reviews.llvm.org/D128264 Files:

[Lldb-commits] [PATCH] D128410: [lldb] Add a testcase for nested exceptions on Windows

mstorsjo added a subscriber: stella.stamenova. mstorsjo added a comment. In D128410#3604075 , @labath wrote: > In D128410#3604066 , @mstorsjo > wrote: > >> For this testcase to work, it needs to be able to open

[Lldb-commits] [PATCH] D128410: [lldb] Add a testcase for nested exceptions on Windows

alvinhochun added a comment. It may be possible to stuff a pointer to an `EXCEPTION_RECORD` into another `EXCEPTION_RECORD` and use `RtlRaiseException` to generate the exception, but you'll have to test how it actually works. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D128366: [lldb] Make Module::LookupInfo::Prune language-agnostic

labath added a comment. How hot is this code? Parsing a demangled name isn't entirely cheap, and the fact that the objc++ class calls back into the c++ version means that the c++ name will be parsed twice. Could we move this pruning elsewhere? These values come from the symbol file plugins

[Lldb-commits] [PATCH] D128201: [lldb][windows] Fix crash on getting nested exception

labath added a comment. How can one trigger this behavior? Adding a test would be preferable to a long comment (we can have both, but the need for a (long) comment diminishes if you have a test which will break if someone implements it the wrong way. Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D128410: [lldb] Add a testcase for nested exceptions on Windows

mstorsjo added a comment. Herald added a subscriber: JDevlieghere. For this testcase to work, it needs to be able to open a window - so it can't run entirely in headless mode. But I guess that a bunch of other tests in LLDB also already do that, since running the LLDB tests on Windows pops up a

[Lldb-commits] [PATCH] D128268: [lldb] Fix reading i686-windows executables with GNU environment

mstorsjo added a subscriber: zturner. mstorsjo added a comment. In D128268#3604081 , @labath wrote: >> If we'd just set this to the baseline, i386, would that have any effect for >> how lldb e.g. is able to disassemble/interpret instructions that don't

[Lldb-commits] [PATCH] D128450: [lldb/Fuzzer] Have target fuzzer write artifacts to specific directory

JDevlieghere requested changes to this revision. JDevlieghere added a comment. This revision now requires changes to proceed. Instead of bundling together multiple shell commands into a single one, you should break them down so CMake can have the build system (e.g. ninja) schedule the different

[Lldb-commits] [PATCH] D127500: [lldb] [llgs] Make `k` kill all processes, and fix multiple exits

mgorny updated this revision to Diff 439433. mgorny edited the summary of this revision. mgorny added a comment. Remove the extra check from `StopSTDIOForwarding()` — we currently don't have to account for multiple processes actually running simultaneously (only the weird Linux

[Lldb-commits] [PATCH] D128450: [lldb/Fuzzer] Have target fuzzer write artifacts to specific directory

cassanova added a comment. Yes, I can include the command interpreter's cmake file in the diff. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128450/new/ https://reviews.llvm.org/D128450 ___

[Lldb-commits] [lldb] 09dea54 - [lldb] Support a buffered logging mode

Author: Jonas Devlieghere Date: 2022-06-23T09:12:01-07:00 New Revision: 09dea546692f4e9f32bf16f1a9d5d0de52a64691 URL: https://github.com/llvm/llvm-project/commit/09dea546692f4e9f32bf16f1a9d5d0de52a64691 DIFF:

[Lldb-commits] [lldb] 70841b9 - [lldb] Make thread safety the responsibility of the log handlers

Author: Jonas Devlieghere Date: 2022-06-23T09:12:05-07:00 New Revision: 70841b97eb2e5c68d46b70579877e378511a47b4 URL: https://github.com/llvm/llvm-project/commit/70841b97eb2e5c68d46b70579877e378511a47b4 DIFF:

[Lldb-commits] [PATCH] D127986: [lldb] Support a buffered logging mode

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG09dea546692f: [lldb] Support a buffered logging mode (authored by JDevlieghere). Herald added a project: LLDB. Changed prior to commit:

[Lldb-commits] [PATCH] D128386: [lldb] Make thread safety the responsibility of the log handlers

JDevlieghere closed this revision. JDevlieghere added a comment. Landed as 70841b97eb2e5c68d46b70579877e378511a47b4 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128386/new/ https://reviews.llvm.org/D128386

[Lldb-commits] [PATCH] D127500: [lldb] [llgs] Make `k` kill all processes, and fix multiple exits

mgorny added inline comments. Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp:1196 + if (!bool(m_extensions_supported & +NativeProcessProtocol::Extension::multiprocess)) +assert(!m_stdio_handle_up);

[Lldb-commits] [PATCH] D128321: [lldb] Add OSLog log handler

JDevlieghere added a comment. In D128321#3603947 , @labath wrote: > In D128321#3603007 , @JDevlieghere > wrote: > >> In D128321#3602129 , @clayborg >> wrote: >> >>> I

[Lldb-commits] [PATCH] D128453: Automate checking for "command that takes no arguments" being passed arguments in CommandObjectParsed

jingham created this revision. jingham added reviewers: JDevlieghere, clayborg, kastiglione, ADodds. Herald added a project: All. jingham requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. At present, if a command takes no arguments, it's

[Lldb-commits] [PATCH] D127500: [lldb] [llgs] Make `k` kill all processes, and fix multiple exits

mgorny updated this revision to Diff 439405. mgorny marked an inline comment as done. mgorny added a comment. Limited variables passed into the lambda. Reworked starting stdio forwarding per the suggestion. TODO: rework stopping. CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D128366: [lldb] Make Module::LookupInfo::Prune language-agnostic

bulbazord added a comment. In D128366#3603943 , @labath wrote: > How hot is this code? Parsing a demangled name isn't entirely cheap, and the > fact that the objc++ class calls back into the c++ version means that the c++ > name will be parsed twice.

[Lldb-commits] [PATCH] D128450: [lldb/Fuzzer] Have fuzzers write artifacts to specific directory

cassanova updated this revision to Diff 439454. cassanova retitled this revision from "[lldb/Fuzzer] Have target fuzzer write artifacts to specific directory" to "[lldb/Fuzzer] Have fuzzers write artifacts to specific directory". cassanova edited the summary of this revision. cassanova added a

[Lldb-commits] [PATCH] D128450: [lldb/Fuzzer] Have target fuzzer write artifacts to specific directory

cassanova created this revision. cassanova added reviewers: JDevlieghere, mib. cassanova added a project: LLDB. Herald added a subscriber: mgorny. Herald added a project: All. cassanova requested review of this revision. Herald added a subscriber: lldb-commits. This makes the LLDB target fuzzer

[Lldb-commits] [PATCH] D128450: [lldb/Fuzzer] Have target fuzzer write artifacts to specific directory

mib added a comment. @cassanova You probably also want to implement this for the `command-interpreter-fuzzer` target Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128450/new/ https://reviews.llvm.org/D128450

[Lldb-commits] [PATCH] D128410: [lldb] Add a testcase for nested exceptions on Windows

alvinhochun added inline comments. Comment at: lldb/test/Shell/Process/Windows/wndproc_exception.cpp:7 +// RUN: %clangxx_host -o %t.exe -luser32 -v -- %s +// RUN: %lldb -f %t.exe -o "run" + mstorsjo wrote: > mstorsjo wrote: > > labath wrote: > > > Is there

[Lldb-commits] [PATCH] D128410: [lldb] Add a testcase for nested exceptions on Windows

alvinhochun added inline comments. Comment at: lldb/test/Shell/Process/Windows/wndproc_exception.cpp:7 +// RUN: %clangxx_host -o %t.exe -luser32 -v -- %s +// RUN: %lldb -f %t.exe -o "run" + alvinhochun wrote: > mstorsjo wrote: > > mstorsjo wrote: > > > labath

[Lldb-commits] [PATCH] D127667: [lldb] [llgs] Implement the vKill packet

mgorny added a comment. In D127667#3603910 , @labath wrote: > Do we need the kill command to be asynchronous (return before the process > actually dies) for anything. Could we just make it synchronous instead (call > wait inside the process plugin, and

[Lldb-commits] [PATCH] D127889: [LLDB] Handle DIE with DW_AT_low_pc and empty ranges

ayermolo added a comment. In D127889#3604421 , @DavidSpickett wrote: > I've reverted this due to failures on our bots: > https://lab.llvm.org/buildbot/#/builders/96/builds/25032/steps/6/logs/stdio > > /usr/bin/ld: >

[Lldb-commits] [PATCH] D127500: [lldb] [llgs] Make `k` kill all processes, and fix multiple exits

mgorny added inline comments. Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp:1196 + if (!bool(m_extensions_supported & +NativeProcessProtocol::Extension::multiprocess)) +assert(!m_stdio_handle_up);

[Lldb-commits] [PATCH] D128450: [lldb/Fuzzer] Have target fuzzer write artifacts to specific directory

cassanova added a comment. This is a lot cleaner than chaining shell commands, I just implemented the second solution on my end. To clarify, it would create the directory before running the `fuzz-lldb-target` and within the `fuzz-lldb-target` we would just change the working directory to the

[Lldb-commits] [lldb] 6fa9120 - [lldb] Fix up Objective-C ISA pointers

Author: Jonas Devlieghere Date: 2022-06-23T14:16:29-07:00 New Revision: 6fa9120080c35a5ff851c3fc3358692c4ef7ce0d URL: https://github.com/llvm/llvm-project/commit/6fa9120080c35a5ff851c3fc3358692c4ef7ce0d DIFF:

[Lldb-commits] [PATCH] D126513: Add -b (--continue-to-breakpoint) option to the "process continue" command

cmtice added a comment. Ignore my revert request; Your later commit seems to have fixed most of my issues. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126513/new/ https://reviews.llvm.org/D126513 ___

[Lldb-commits] [PATCH] D128477: [trace] Add a flag to the decoder to output the instruction type

jingham added a comment. This categorization seems like it is relevant for any instruction, not just instructions found in a trace buffer. Is there any reason why this isn't just an annotation added by the standard instruction printer, that you then turn on with the -k flag to thread trace

[Lldb-commits] [PATCH] D128321: [lldb] Add OSLog log handler

JDevlieghere added a comment. In D128321#3606172 , @clayborg wrote: > So it seems like we are catering to our code organization here instead of > doing the right thing and relying on the host layer. I would rather move the > log code into the host

[Lldb-commits] [PATCH] D128321: [lldb] Add OSLog log handler

JDevlieghere updated this revision to Diff 439583. JDevlieghere added a comment. - Move SystemLogHandler into Host - Create a new SystemLog helper function CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128321/new/ https://reviews.llvm.org/D128321 Files: lldb/include/lldb/Host/Host.h

[Lldb-commits] [PATCH] D128321: [lldb] Add OSLog log handler

clayborg added a comment. If we do add plug-ins, you could make an Apple specific plug-in named "darwin-os-log" or something that would only be compiled in for Apple builds, or we can do a generic "os-log" plug-in that uses the host layer. CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] 40aace5 - [lldb/Fuzzer] Have fuzzers write artifacts to specific directory

Author: Chelsea Cassanova Date: 2022-06-23T16:55:23-04:00 New Revision: 40aace59cc58ca438060cf4dfd97ba01ff4f0ebc URL: https://github.com/llvm/llvm-project/commit/40aace59cc58ca438060cf4dfd97ba01ff4f0ebc DIFF:

[Lldb-commits] [PATCH] D128450: [lldb/Fuzzer] Have fuzzers write artifacts to specific directory

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG40aace59cc58: [lldb/Fuzzer] Have fuzzers write artifacts to specific directory (authored by cassanova). Repository: rG

[Lldb-commits] [lldb] a1f20da - The help string for stop-on-shared-library-load was copied to stop-on-exec.

Author: Jim Ingham Date: 2022-06-23T13:54:50-07:00 New Revision: a1f20da315c8f9aa109b49c47797898ad6559d1a URL: https://github.com/llvm/llvm-project/commit/a1f20da315c8f9aa109b49c47797898ad6559d1a DIFF: https://github.com/llvm/llvm-project/commit/a1f20da315c8f9aa109b49c47797898ad6559d1a.diff

[Lldb-commits] [PATCH] D128453: Automate checking for "command that takes no arguments" being passed arguments in CommandObjectParsed

JDevlieghere accepted this revision. JDevlieghere added a subscriber: labath. JDevlieghere added a comment. This revision is now accepted and ready to land. This is great, it both guarantees consistently and enforces command objects registering their arguments. LGTM. For the RenderScript

[Lldb-commits] [PATCH] D128386: [lldb] Make thread safety the responsibility of the log handlers

clayborg added a comment. Maybe we should leave the option in the command for history purposes??? Taking it out will now make anyone's log enable lines fail when they didn't use to... CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128386/new/ https://reviews.llvm.org/D128386

[Lldb-commits] [PATCH] D128323: [lldb] Add support for specifying a log handler

clayborg added inline comments. Comment at: lldb/source/Commands/CommandObjectLog.cpp:26 +static constexpr OptionEnumValueElement g_log_handler_type[] = { +{ Question: how does one see these values and their descriptions? Do the descriptions get displayed

[Lldb-commits] [PATCH] D128480: [lldb] Replace Host::SystemLog with Debugger::Report{Error, Warning}

JDevlieghere updated this revision to Diff 439577. JDevlieghere added a comment. Remove spurious "error:" strings. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128480/new/ https://reviews.llvm.org/D128480 Files: lldb/include/lldb/Host/Host.h lldb/source/Core/Module.cpp

[Lldb-commits] [PATCH] D128321: [lldb] Add OSLog log handler

clayborg added a comment. So it seems like we are catering to our code organization here instead of doing the right thing and relying on the host layer. I would rather move the log code into the host layer or make log handlers actual plug-ins so that we can do the right thing here. If we can

[Lldb-commits] [PATCH] D128477: [trace] Add a flag to the decoder to output the instruction type

persona0220 created this revision. persona0220 added reviewers: wallace, jj10306. Herald added a project: All. persona0220 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. To build complex binding upon instruction trace, additional metadata

[Lldb-commits] [PATCH] D128480: [lldb] Replace Host::SystemLog with Debugger::Report{Error, Warning}

JDevlieghere added a comment. In D128480#3606598 , @clayborg wrote: > I don't have anything against this, though I still think the LogHandlers > should use the Host layer by making the LogHandler objects into real LLDB > plug-ins. But if everyone else

[Lldb-commits] [PATCH] D128480: [lldb] Replace Host::SystemLog with Debugger::Report{Error, Warning}

mib added inline comments. Comment at: lldb/source/Core/Module.cpp:1187 + +Debugger::ReportError(std::string(strm.GetString())); + } mib wrote: > It's unrelated to this patch, but it looks like > `Debugger::HandleDiagnosticEvent` dumps everything to the

[Lldb-commits] [PATCH] D128480: [lldb] Replace Host::SystemLog with Debugger::Report{Error, Warning}

JDevlieghere added inline comments. Comment at: lldb/source/Core/Module.cpp:1187 + +Debugger::ReportError(std::string(strm.GetString())); + } mib wrote: > mib wrote: > > It's unrelated to this patch, but it looks like > > `Debugger::HandleDiagnosticEvent`

[Lldb-commits] [PATCH] D128480: [lldb] Replace Host::SystemLog with Debugger::Report{Error, Warning}

clayborg added a comment. I don't have anything against this, though I still think the LogHandlers should use the Host layer by making the LogHandler objects into real LLDB plug-ins. But if everyone else feels otherwise, I won't object. CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D128484: [NFC][lldb][trace] Rename trace session to trace bundle

wallace created this revision. wallace added reviewers: persona0220, jj10306. Herald added a subscriber: mgorny. Herald added a project: All. wallace requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. As previously discussed with @jj10306, we

[Lldb-commits] [PATCH] D126513: Add -b (--continue-to-breakpoint) option to the "process continue" command

cmtice added a comment. This appears to have broken a lot of LLDB tests in our bootstrap as well. Is there any chance this might get reverted? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126513/new/ https://reviews.llvm.org/D126513

[Lldb-commits] [PATCH] D128480: [lldb] Replace Host::SystemLog with Debugger::Report{Error, Warning}

JDevlieghere created this revision. JDevlieghere added reviewers: labath, clayborg, aprantl, mib. Herald added a project: All. JDevlieghere requested review of this revision. Herald added a reviewer: jdoerfert. Herald added a subscriber: sstefan1. As it exists today, Host::SystemLog is used

[Lldb-commits] [PATCH] D128480: [lldb] Replace Host::SystemLog with Debugger::Report{Error, Warning}

JDevlieghere added a comment. In D128480#3606632 , @JDevlieghere wrote: > In D128480#3606598 , @clayborg > wrote: > >> I don't have anything against this, though I still think the LogHandlers >> should use the

[Lldb-commits] [PATCH] D128477: [trace] Add a flag to the decoder to output the instruction type

wallace requested changes to this revision. wallace added a comment. This revision now requires changes to proceed. @jingham, that's a pretty good idea. We'll see how to implement it Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128477/new/

[Lldb-commits] [PATCH] D128321: [lldb] Add OSLog log handler

JDevlieghere updated this revision to Diff 439588. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128321/new/ https://reviews.llvm.org/D128321 Files: lldb/include/lldb/Host/Host.h lldb/source/Host/common/Host.cpp lldb/source/Host/macosx/objcxx/Host.mm Index:

[Lldb-commits] [PATCH] D128450: [lldb/Fuzzer] Have fuzzers write artifacts to specific directory

mib accepted this revision. mib added a comment. This looks way better :) ! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128450/new/ https://reviews.llvm.org/D128450 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D128480: [lldb] Replace Host::SystemLog with Debugger::Report{Error, Warning}

mib added inline comments. Comment at: lldb/source/Core/Module.cpp:1187 + +Debugger::ReportError(std::string(strm.GetString())); + } It's unrelated to this patch, but it looks like `Debugger::HandleDiagnosticEvent` dumps everything to the error stream

[Lldb-commits] [PATCH] D128323: [lldb] Add support for specifying a log handler

JDevlieghere updated this revision to Diff 439575. JDevlieghere marked 2 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128323/new/ https://reviews.llvm.org/D128323 Files: lldb/include/lldb/Core/Debugger.h lldb/include/lldb/lldb-enumerations.h

[Lldb-commits] [PATCH] D128323: [lldb] Add support for specifying a log handler

JDevlieghere marked 6 inline comments as done. JDevlieghere added a subscriber: jingham. JDevlieghere added inline comments. Comment at: lldb/source/Commands/CommandObjectLog.cpp:26 +static constexpr OptionEnumValueElement g_log_handler_type[] = { +{

[Lldb-commits] [PATCH] D128386: [lldb] Make thread safety the responsibility of the log handlers

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Cool, thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128386/new/ https://reviews.llvm.org/D128386 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D128410: [lldb] Add a testcase for nested exceptions on Windows

mstorsjo added inline comments. Comment at: lldb/test/Shell/Process/Windows/wndproc_exception.cpp:7 +// RUN: %clangxx_host -o %t.exe -luser32 -v -- %s +// RUN: %lldb -f %t.exe -o "run" + mstorsjo wrote: > labath wrote: > > Is there something reasonable we could

[Lldb-commits] [PATCH] D127500: [lldb] [llgs] Make `k` kill all processes, and fix multiple exits

labath added inline comments. Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp:1050 + lldb::pid_t pid = process->GetID(); + m_mainloop.AddPendingCallback([&, pid](MainLoopBase ) { +m_debugged_processes.erase(pid);

[Lldb-commits] [PATCH] D127667: [lldb] [llgs] Implement the vKill packet

labath added a comment. Do we need the kill command to be asynchronous (return before the process actually dies) for anything. Could we just make it synchronous instead (call wait inside the process plugin, and return the wait result)? CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D127986: [lldb] Support a buffered logging mode

labath accepted this revision. labath added a comment. In D127986#3600665 , @JDevlieghere wrote: > @labath let me know if this is what you had in mind Yes, that's pretty much it. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127986/new/

[Lldb-commits] [PATCH] D128324: [lldb] [llgs] Introduce a AppendThreadIDToResponse() helper

labath accepted this revision. labath added inline comments. This revision is now accepted and ready to land. Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp:4162 +void GDBRemoteCommunicationServerLLGS::AppendThreadIDToResponse( +