[Lldb-commits] [PATCH] D133858: [lldb] Reset breakpoint hit count before new runs

fdeazeve added a comment. In D133858#3791290 , @mib wrote: > I don't think it's necessary to add the `DoWillAttachToProcessWithID` method > and override it in each process plugin. I think you could have just reset the > `hit_counter` in the top-level

[Lldb-commits] [PATCH] D133906: [lldb] Generate lldb-forward with .def file

labath added a comment. In D133906#3791352 , @JDevlieghere wrote: > In D133906#3791153 , @jingham wrote: > >> This patch makes me a little sad because it breaks the "Jump to Definition" >> chain in Xcode (and I

[Lldb-commits] [PATCH] D112374: [clang] Implement ElaboratedType sugaring for types written bare

mizvekov added a comment. In D112374#3792825 , @Abramo-Bagnara wrote: > These changes introduce a subtle bug in template instantiation of newly added > ElaboratedType around TypedefType: > > bool refersInstantiatedDecl(QualType T) in

[Lldb-commits] [PATCH] D133945: [clang][ASTImporter] Continue with slow lookup in DeclContext::localUncachedLookup when regular lookup fails

Michael137 created this revision. Michael137 added reviewers: aprantl, martong. Herald added a subscriber: rnkovacs. Herald added a reviewer: a.sidorin. Herald added a reviewer: shafik. Herald added a project: All. Michael137 requested review of this revision. Herald added projects: clang, LLDB.

[Lldb-commits] [PATCH] D133906: [lldb] Generate lldb-forward with .def file

kastiglione added a comment. SP and UP templates seems fine to me. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133906/new/ https://reviews.llvm.org/D133906 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D112374: [clang] Implement ElaboratedType sugaring for types written bare

Abramo-Bagnara added a comment. I have to doubly apologize: 1. my reference to refersInstantiatedDecl is completely wrong and I have been mislead by an old patch on my machine. 2. the problem despite being very real is independent by your changes If you are still interested this is the repro

[Lldb-commits] [PATCH] D133945: [clang][ASTImporter] Continue with slow lookup in DeclContext::localUncachedLookup when regular lookup fails

Michael137 added inline comments. Herald added a subscriber: JDevlieghere. Comment at: clang/lib/AST/DeclBase.cpp:1781 if (Name && !hasLazyLocalLexicalLookups() && !hasLazyExternalLexicalLookups()) { if (StoredDeclsMap *Map = LookupPtr) { Could

[Lldb-commits] [PATCH] D133906: [lldb] Generate lldb-forward with .def file

JDevlieghere added a comment. In D133906#3792230 , @labath wrote: > In D133906#3791352 , @JDevlieghere > wrote: > >> In D133906#3791153 , @jingham >> wrote: >> >>> This

[Lldb-commits] [PATCH] D133944: [lldb][tests][gmodules] Test for expression evaluator crash for types with template base class

Michael137 created this revision. Michael137 added reviewers: aprantl, martong. Herald added a subscriber: rnkovacs. Herald added a project: All. Michael137 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The problem here is that the

[Lldb-commits] [PATCH] D133945: [clang][ASTImporter] DeclContext::localUncachedLookup: Continue lookup into decl chain when regular lookup fails

Michael137 updated this revision to Diff 460429. Michael137 added a comment. - Undo incorrect previous change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133945/new/ https://reviews.llvm.org/D133945 Files: clang/lib/AST/DeclBase.cpp

[Lldb-commits] [PATCH] D133906: [lldb] Generate lldb-forward with .def file

jingham added a comment. To some extent, the fact that we define an XxxSP for a class is saying "This is a thing we mostly pass around as a shared pointer" which would be lost if every time we make an SP or UP we use the same syntax. But I'm not sure that that's a terribly strong objection.

[Lldb-commits] [PATCH] D112374: [clang] Implement ElaboratedType sugaring for types written bare

Abramo-Bagnara reopened this revision. Abramo-Bagnara added a comment. These changes introduce a subtle bug in template instantiation of newly added ElaboratedType around TypedefType: bool refersInstantiatedDecl(QualType T) in SemaTemplateInstantiate.cpp does not handle this ElaboratedType

[Lldb-commits] [PATCH] D133945: [clang][ASTImporter] Continue with slow lookup in DeclContext::localUncachedLookup when regular lookup fails

Michael137 updated this revision to Diff 460420. Michael137 added a comment. - Merge if-blocks - Reword commit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133945/new/ https://reviews.llvm.org/D133945 Files: clang/lib/AST/DeclBase.cpp

[Lldb-commits] [PATCH] D133945: [clang][ASTImporter] DeclContext::localUncachedLookup: Continue lookup into decl chain when regular lookup fails

Michael137 added inline comments. Comment at: clang/lib/AST/DeclBase.cpp:1781 if (Name && !hasLazyLocalLexicalLookups() && !hasLazyExternalLexicalLookups()) { if (StoredDeclsMap *Map = LookupPtr) { Michael137 wrote: > Could merge the two if-blocks

[Lldb-commits] [PATCH] D133961: [lldb] Use SWIG_fail in python-typemaps.swig (NFC)

kastiglione created this revision. kastiglione added a reviewer: JDevlieghere. Herald added a project: All. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. When attempting to use SWIG's `-builtin` flag, there were a few compile

[Lldb-commits] [PATCH] D133961: [lldb] Use SWIG_fail in python-typemaps.swig (NFC)

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133961/new/ https://reviews.llvm.org/D133961

[Lldb-commits] [PATCH] D133973: [test] Fix LLDB tests with just-built libcxx when using a target directory.

rupprecht created this revision. rupprecht added reviewers: JDevlieghere, fdeazeve. Herald added a subscriber: mgorny. Herald added a project: All. rupprecht requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. In certain configurations, libc++

[Lldb-commits] [PATCH] D133906: [lldb] Generate lldb-forward with .def file

clayborg added a comment. I really wish the .def files would actually generate a header file in the output directory. I am not a fan of using code navigation when saying "take me to the definition of "class Block;" and it shows: #define LLDB_FORWARD_CLASS(Name) class Name; #include

[Lldb-commits] [PATCH] D133973: [test] Fix LLDB tests with just-built libcxx when using a target directory.

JDevlieghere added a comment. Do we need both `LIBCPP_INCLUDE_DIR` and `LIBCPP_INCLUDE_TARGET_DIR`? I see we pass another `-cxx-isystem` flag, does this result in another search path or does that replace the former? If we only need one, we could set `LIBCPP_INCLUDE_DIR` to

[Lldb-commits] [PATCH] D133042: Add auto deduce source map setting

clayborg added a comment. In D133042#3791146 , @yinghuitan wrote: > @clayborg , it is my intention to make `target.auto-deduce-source-map` > boolean flag ultimately working for both relative paths and two full paths > (two full paths are really

[Lldb-commits] [PATCH] D133042: Add auto deduce source map setting

yinghuitan added a comment. @clayborg, now I see you want to make this option true by default while full paths one to be optional. Then sure, it makes sense. Comment at: lldb/source/Breakpoint/BreakpointResolverFileLine.cpp:225 + const bool case_sensitive =

[Lldb-commits] [PATCH] D133042: Add auto deduce source map setting

clayborg added inline comments. Comment at: lldb/source/Breakpoint/BreakpointResolverFileLine.cpp:225 + const bool case_sensitive = request_file.IsCaseSensitive(); + const bool full = !request_file.GetDirectory().IsEmpty(); + for (uint32_t i = 0; i < sc_list.GetSize(); ++i) {

[Lldb-commits] [PATCH] D133973: [test] Fix LLDB tests with just-built libcxx when using a target directory.

rupprecht added a comment. In D133973#3793398 , @JDevlieghere wrote: > Do we need both `LIBCPP_INCLUDE_DIR` and `LIBCPP_INCLUDE_TARGET_DIR`? I see > we pass another `-cxx-isystem` flag, does this result in another search path > or does that replace

[Lldb-commits] [lldb] 8704281 - [LLDB][NativePDB] Global ctor and dtor should be global decls.

Author: Zequan Wu Date: 2022-09-15T22:35:58-07:00 New Revision: 8704281c567705822a1c23b9ec40f5bdc5d58352 URL: https://github.com/llvm/llvm-project/commit/8704281c567705822a1c23b9ec40f5bdc5d58352 DIFF: https://github.com/llvm/llvm-project/commit/8704281c567705822a1c23b9ec40f5bdc5d58352.diff

[Lldb-commits] [PATCH] D133446: [LLDB][NativePDB] Global ctor and dtor should be global decls.

This revision was automatically updated to reflect the committed changes. Closed by commit rG8704281c5677: [LLDB][NativePDB] Global ctor and dtor should be global decls. (authored by zequanwu). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D133601: [LLDB][NativePDB] ResolveSymbolContext should return the innermost block

zequanwu updated this revision to Diff 460644. zequanwu added a comment. Rebase and update test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133601/new/ https://reviews.llvm.org/D133601 Files:

[Lldb-commits] [PATCH] D133944: [lldb][tests][gmodules] Test for expression evaluator crash for types with template base class

Michael137 updated this revision to Diff 460615. Michael137 added a comment. - Add check on structure of AST in API test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133944/new/ https://reviews.llvm.org/D133944 Files:

[Lldb-commits] [PATCH] D132300: [clang][lldb][cmake] Use new `*_INSTALL_LIBDIR_BASENAME` CPP macro

MaskRay added a comment. In the long term we should just remove the `CLANG_INSTALL_LIBDIR_BASENAME` customization. This is supposed for GCC multilib lib32 lib64 names but we don't necessarily use it for Clang + compiler-rt files. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[Lldb-commits] [PATCH] D134011: [lldb] Fix parentheses placement in GetExpressionPath

kastiglione added a comment. I noticed this when running `v *SomeVar` and the variable contained a `llvm::PointerUnion`. The synthetic provider for `PointerUnion` uses `GetExpressionPath`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134011/new/

[Lldb-commits] [PATCH] D134011: [lldb] Fix parentheses placement in GetExpressionPath

kastiglione created this revision. kastiglione added a reviewer: jingham. Herald added a project: All. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Adjust the placement of parentheses around a pointer dereference in

[Lldb-commits] [lldb] ab755e6 - [lldb] Improve formatting of skipped categories message (NFC)

Author: Dave Lee Date: 2022-09-15T20:39:25-07:00 New Revision: ab755e65629ea098cb6faa77b13ac087849ffc67 URL: https://github.com/llvm/llvm-project/commit/ab755e65629ea098cb6faa77b13ac087849ffc67 DIFF: https://github.com/llvm/llvm-project/commit/ab755e65629ea098cb6faa77b13ac087849ffc67.diff

[Lldb-commits] [PATCH] D133042: Add auto deduce source map setting

yinghuitan updated this revision to Diff 460578. yinghuitan added a comment. Address review feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133042/new/ https://reviews.llvm.org/D133042 Files:

[Lldb-commits] [PATCH] D111509: [clang] use getCommonSugar in an assortment of places

mizvekov updated this revision to Diff 460587. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111509/new/ https://reviews.llvm.org/D111509 Files: clang-tools-extra/clangd/unittests/tweaks/ExtractVariableTests.cpp

[Lldb-commits] [PATCH] D133790: Fix heap-use-after-free when clearing DIEs in fission compile units.

clayborg added a comment. Thanks for following up on this and fixing the issue! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133790/new/ https://reviews.llvm.org/D133790 ___ lldb-commits mailing list