[Lldb-commits] [PATCH] D134842: Improve dynamic loader support in DynamicLoaderPOSIXDYLD when using core files.

clayborg updated this revision to Diff 463962. clayborg added a comment. Switch DYLDRendezvous::GetAction() to return eTakeSnapshot when we have a core file and don't modify m_current.state. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D134873: [LLDB] Add "process status" as equivalent of GDB's "frame" command

jingham added a comment. `f` with no input does this job: (lldb) f frame #1: 0x00013f70 callem`nothing at callem.c:3 1 int nothing(int input) { 2if (input < 10) { -> 3 return nothing(++input); ^ 4}

[Lldb-commits] [PATCH] D134878: Update developer policy on potentially breaking changes

ldionne accepted this revision. ldionne added inline comments. Comment at: llvm/docs/DeveloperPolicy.rst:140 + +* After the change has been committed to the repository, the potentially + disruptive changes described in the release notes should be posted to the

[Lldb-commits] [PATCH] D134882: [lldb] Move breakpoint hit reset code to Target::CreateProcess

jingham added a comment. If there's some guarantee that Target::CreateProcess HAS to be the way that a process is created, then this is fine. Is there such a guarantee - the function is pretty trivial so somebody might be tempted to do the work in some other place but miss the breakpoint

[Lldb-commits] [PATCH] D134882: [lldb] Move breakpoint hit reset code to Target::CreateProcess

labath added a comment. I'm not sure what kind of guarantees are you looking for. `m_process_sp` is a private member of the Target class, so it's not like just anyone can come in and change it. There's no way to stop code from inside the Target class from changing it without going through the

[Lldb-commits] [PATCH] D134877: [lldb] Get rid of __STDC_LIMIT_MACROS and __STDC_CONSTANT_MACROS

serge-sans-paille updated this revision to Diff 463999. serge-sans-paille retitled this revision from "[lldb] Fixes for swig-4.1.0 macro definition correction" to "[lldb] Get rid of __STDC_LIMIT_MACROS and __STDC_CONSTANT_MACROS". serge-sans-paille edited the summary of this revision.

[Lldb-commits] [PATCH] D134878: Update developer policy on potentially breaking changes

Mordante accepted this revision. Mordante added a comment. This revision is now accepted and ready to land. Thanks a lot for working on this! A few small nits, otherwise LGTM. Comment at: llvm/docs/DeveloperPolicy.rst:112 + +Please help notify users of potential disruptions

[Lldb-commits] [PATCH] D134878: Update developer policy on potentially breaking changes

aaron.ballman updated this revision to Diff 463949. aaron.ballman marked 3 inline comments as done. aaron.ballman added a comment. Applying review feedback. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134878/new/ https://reviews.llvm.org/D134878 Files:

[Lldb-commits] [PATCH] D134878: Update developer policy on potentially breaking changes

aaron.ballman added inline comments. Comment at: llvm/docs/DeveloperPolicy.rst:129 + + People interested in joining the vendors group can do so by clicking the + "Join Project" link on the vendor's "Members" page in Phabricator. Mordante wrote: > I didn't

[Lldb-commits] [PATCH] D134878: Update developer policy on potentially breaking changes

Mordante added inline comments. Comment at: llvm/docs/DeveloperPolicy.rst:129 + + People interested in joining the vendors group can do so by clicking the + "Join Project" link on the vendor's "Members" page in Phabricator. aaron.ballman wrote: > Mordante

[Lldb-commits] [PATCH] D134333: When there are variable errors, display an error in VS Code's local variables view.

This revision was automatically updated to reflect the committed changes. Closed by commit rG4017d86df98f: When there are variable errors, display an error in VS Codes local variables… (authored by clayborg). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] 4017d86 - When there are variable errors, display an error in VS Code's local variables view.

Author: Greg Clayton Date: 2022-09-29T10:55:16-07:00 New Revision: 4017d86df98faa53bbb1a0acc4e8e58d2b6f2608 URL: https://github.com/llvm/llvm-project/commit/4017d86df98faa53bbb1a0acc4e8e58d2b6f2608 DIFF: https://github.com/llvm/llvm-project/commit/4017d86df98faa53bbb1a0acc4e8e58d2b6f2608.diff

[Lldb-commits] [PATCH] D134846: [NFC] Add header documentation to the SBError::GetCString() to clarify ownwership of the returned string.

This revision was automatically updated to reflect the committed changes. Closed by commit rGb3a0bed5fb87: [NFC] Add header documentation to the SBError::GetCString() to clarify… (authored by clayborg). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] b3a0bed - [NFC] Add header documentation to the SBError::GetCString() to clarify ownwership of the returned string.

Author: Greg Clayton Date: 2022-09-29T10:54:31-07:00 New Revision: b3a0bed5fb8766dcf27583ab1f73edc6e7232657 URL: https://github.com/llvm/llvm-project/commit/b3a0bed5fb8766dcf27583ab1f73edc6e7232657 DIFF: https://github.com/llvm/llvm-project/commit/b3a0bed5fb8766dcf27583ab1f73edc6e7232657.diff

[Lldb-commits] [PATCH] D134906: Have MemoryCache cache addresses that were unreadable, so duplicate read attempts can be suppressed

jasonmolenda created this revision. jasonmolenda added reviewers: jingham, JDevlieghere. jasonmolenda added a project: LLDB. Herald added a project: All. jasonmolenda requested review of this revision. Herald added a subscriber: lldb-commits. This patch is to address an issue hit by one of our

[Lldb-commits] [PATCH] D134927: Make the sanitizer Notify callbacks asynchronous

jingham created this revision. jingham added reviewers: JDevlieghere, kubamracek. Herald added a project: All. jingham requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. lldb handles breakpoints in two phases, the "sync" and "async" phase.

[Lldb-commits] [PATCH] D134842: Improve dynamic loader support in DynamicLoaderPOSIXDYLD when using core files.

clayborg added inline comments. Comment at: lldb/source/Plugins/DynamicLoader/POSIX-DYLD/DYLDRendezvous.cpp:174-181 + // If we have a core file, we will read the current rendezvous state + // from the core file's memory which will indicate there is nothing + // to do, but we

[Lldb-commits] [PATCH] D134842: Improve dynamic loader support in DynamicLoaderPOSIXDYLD when using core files.

clayborg added a comment. In D134842#3823497 , @labath wrote: > In D134842#3822740 , @yinghuitan > wrote: > >> I am surprised other major companies did not hit this issue. > > That could be because this is

[Lldb-commits] [PATCH] D134920: [lldb] Remove scoped timer from high firing and fast running ExtractUnitDIENoDwoIfNeeded

kastiglione created this revision. kastiglione added a reviewer: JDevlieghere. Herald added a project: All. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Profiles show that `DWARFUnit::ExtractUnitDIENoDwoIfNeeded` is both

[Lldb-commits] [PATCH] D134922: [lldb] Remove scoped timer from high firing and fast running SymbolFileDWARF::FindFunctions

kastiglione created this revision. kastiglione added a reviewer: JDevlieghere. Herald added a project: All. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Profiles show that `SymbolFileDWARF::FindFunctions` is both high firing

[Lldb-commits] [PATCH] D134842: Improve dynamic loader support in DynamicLoaderPOSIXDYLD when using core files.

clayborg updated this revision to Diff 464097. clayborg added a comment. Fix typo in comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134842/new/ https://reviews.llvm.org/D134842 Files:

[Lldb-commits] [PATCH] D134877: [lldb] Get rid of __STDC_LIMIT_MACROS and __STDC_CONSTANT_MACROS

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. ship it. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134877/new/ https://reviews.llvm.org/D134877 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D134873: [LLDB] Add "process status" as equivalent of GDB's "frame" command

DavidSpickett created this revision. Herald added a project: All. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This is useful for answering the question "where am I?" and is surprisingly difficult to figure out without

[Lldb-commits] [PATCH] D134849: [LLDB][NativePDB] Fix struct layout when it has anonymous unions.

labath added a comment. The fact that MSVC does not store all of the anonymous union data is unfortunate, though not entirely surprising, given that the goal of debug info never was to offer an exact reconstruction of the source AST. That, I'm not sure if checking for matching initial offsets

[Lldb-commits] [PATCH] D134751: [lldb] Fix running tests when LLVM target triple is different from host

alvinhochun added a comment. Thanks for the review. In D134751#3818743 , @JDevlieghere wrote: > Supporting builds with different host and target triples makes sense. > However, I have a few concerns about the current patch: > > - I wouldn't cal it the

[Lldb-commits] [PATCH] D134842: Improve dynamic loader support in DynamicLoaderPOSIXDYLD when using core files.

labath added a comment. In D134842#3822740 , @yinghuitan wrote: > I am surprised other major companies did not hit this issue. That could be because this is something specific to your environment. Just to be clear, is this happening for *all* core

[Lldb-commits] [PATCH] D134873: [LLDB] Add "process status" as equivalent of GDB's "frame" command

DavidSpickett added a comment. https://lldb.llvm.org/use/map.html#examining-thread-state if you want to see the current page. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134873/new/ https://reviews.llvm.org/D134873

[Lldb-commits] [PATCH] D134877: [lldb] Fixes for swig-4.1.0 macro definition correction

serge-sans-paille created this revision. serge-sans-paille added reviewers: clayborg, jingham. Herald added a project: All. serge-sans-paille requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. For swig-4.1.0 change: #2193 -DFOO on the SWIG

[Lldb-commits] [PATCH] D134878: Update developer policy on potentially breaking changes

aaron.ballman added a subscriber: mehdi_amini. aaron.ballman added a comment. Note: I would love to add a vendors group to Phabricator for LLVM and lldb (and any other project we think has vendors), but this requires admin privileges to do. @mehdi_amini, is this something you could help out

[Lldb-commits] [PATCH] D134878: Update developer policy on potentially breaking changes

ldionne added a comment. Thanks for working on this! FWIW, this more or less standardizes what we've been doing in libc++ for the past ~1.5 years and it's been pretty low effort for us to do. And putting my vendor hat on, it's been extremely useful for me to track down potential issues when

[Lldb-commits] [PATCH] D134878: Update developer policy on potentially breaking changes

aaron.ballman added inline comments. Comment at: llvm/docs/DeveloperPolicy.rst:140 + +* After the change has been committed to the repository, the potentially + disruptive changes described in the release notes should be posted to the ldionne wrote: > I wonder

[Lldb-commits] [PATCH] D134878: Update developer policy on potentially breaking changes

aaron.ballman added a reviewer: JDevlieghere. aaron.ballman added a comment. Adding someone from lldb as a review for awareness. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134878/new/ https://reviews.llvm.org/D134878

[Lldb-commits] [PATCH] D134873: [LLDB] Add "process status" as equivalent of GDB's "frame" command

awarzynski accepted this revision. awarzynski added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134873/new/ https://reviews.llvm.org/D134873

[Lldb-commits] [PATCH] D134878: Update developer policy on potentially breaking changes

aaron.ballman created this revision. aaron.ballman added reviewers: rnk, lattner, ldionne, rjmccall, Mordante, tahonermann, bruno, tonic. Herald added a project: All. aaron.ballman requested review of this revision. Herald added a project: LLVM. We've recently had issues appropriately notifying

[Lldb-commits] [PATCH] D134877: [lldb] Fixes for swig-4.1.0 macro definition correction

labath added a comment. Looking at https://bugzilla.redhat.com/show_bug.cgi?id=2128646, I'd say that the real bug is that we're defining this macro in two places. How about we leave these definitions as they are, and remove the one at `bindings/interfaces.swig:5` ? Repository: rG LLVM

[Lldb-commits] [PATCH] D134882: [lldb] Move breakpoint hit reset code to Target::CreateProcess

labath created this revision. labath added reviewers: fdeazeve, jingham. Herald added a project: All. labath requested review of this revision. Herald added a project: LLDB. This ensures it is run regardless of the method we use to initiate the session (previous version did not handle connects).

[Lldb-commits] [PATCH] D134877: [lldb] Fixes for swig-4.1.0 macro definition correction

serge-sans-paille added a comment. In D134877#3823855 , @labath wrote: > Looking at https://bugzilla.redhat.com/show_bug.cgi?id=2128646, I'd say that > the real bug is that we're defining this macro in two places. How about we > leave these definitions

[Lldb-commits] [PATCH] D134877: [lldb] Fixes for swig-4.1.0 macro definition correction

labath added a comment. sure, sounds good. TBH, I am not sure if either of those is really needed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134877/new/ https://reviews.llvm.org/D134877 ___