[Lldb-commits] [PATCH] D135170: [LLDB] Fix crash when printing a struct with a static signed char member

DavidSpickett added inline comments. Comment at: lldb/test/API/lang/cpp/const_static_integral_member/main.cpp:39 const static auto char_min = std::numeric_limits::min(); const static auto uchar_min = std::numeric_limits::min(); shafik wrote: > We use

[Lldb-commits] [PATCH] D134378: [lldb] Support simplified template names

Michael137 added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:1528 +DWARFASTParserClang::GetTemplateParametersString(const DWARFDIE ) { + if (llvm::StringRef(die.GetName()).contains("<")) +return std::string();

[Lldb-commits] [PATCH] D134962: [LLDB] Change pointer to ref in EmulateInstruction::ReadRegister methods

DavidSpickett added a comment. ping! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134962/new/ https://reviews.llvm.org/D134962 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D134963: [LLDB] Switch to RegisterInfo& for EmulateInstruction::WriteRegister

DavidSpickett added a comment. ping! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134963/new/ https://reviews.llvm.org/D134963 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D134965: [LLDB] Change RegisterValue::GetAsMemoryData to const RegisterInfo

DavidSpickett added a comment. ping! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134965/new/ https://reviews.llvm.org/D134965 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D135352: [LLDB] Complete set of char tests for static integral members

DavidSpickett created this revision. Herald added a project: All. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Previously we had a bit of a mix of "signed char" "unsigned char" and "char". This adds seperate min and max

[Lldb-commits] [PATCH] D134378: [lldb] Support simplified template names

Michael137 added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:1528 +DWARFASTParserClang::GetTemplateParametersString(const DWARFDIE ) { + if (llvm::StringRef(die.GetName()).contains("<")) +return std::string();

[Lldb-commits] [PATCH] D134378: [lldb] Support simplified template names

Michael137 added inline comments. Comment at: lldb/test/API/lang/cpp/unique-types2/TestUniqueTypes.py:1 +""" +Test that we return only the requested template instantiation. I think it would be good to test this with

[Lldb-commits] [PATCH] D134771: [NFCI] Simplify TypeCategoryImpl for-each callbacks.

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. (it looks like I did not click "submit" for some reason) Comment at: lldb/include/lldb/DataFormatters/TypeCategory.h:169 +template ForEachCallback(Callable c) :

[Lldb-commits] [PATCH] D134378: [lldb] Support simplified template names

Michael137 added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:1528 +DWARFASTParserClang::GetTemplateParametersString(const DWARFDIE ) { + if (llvm::StringRef(die.GetName()).contains("<")) +return std::string();

[Lldb-commits] [PATCH] D134849: [LLDB][NativePDB] Fix struct layout when it has anonymous unions.

labath added inline comments. Comment at: lldb/source/Plugins/SymbolFile/NativePDB/UdtRecordCompleter.cpp:331 + clang::DeclContext *parent_decl_ctx) { + static lldb::user_id_t anonymous_id = LLDB_INVALID_UID - 1; + clang::FieldDecl *field_decl =

[Lldb-commits] [PATCH] D134041: [LLDB] Enable non-trivial types in EmulateInstruction::Context

DavidSpickett abandoned this revision. DavidSpickett added a comment. https://reviews.llvm.org/D135015 landed using std::variant and no one has complained so far, so this whole patch is now irrelevant. If it comes back, I'll just use variant. I agree that there are reasons to keep things POD

[Lldb-commits] [lldb] 870b74d - Revert "Remove the dependency between lib/DebugInfoDWARF and MC."

Author: Shubham Sandeep Rastogi Date: 2022-10-06T09:30:46-07:00 New Revision: 870b74d59052143c6e3a3e70d6e5c17cd43ff58f URL: https://github.com/llvm/llvm-project/commit/870b74d59052143c6e3a3e70d6e5c17cd43ff58f DIFF:

[Lldb-commits] [lldb] 8d1de7b - [lldb/gdb-server] Better reporting of launch errors

Author: Pavel Labath Date: 2022-10-06T17:18:51+02:00 New Revision: 8d1de7b34af46a089eb5433c700419ad9b2923ee URL: https://github.com/llvm/llvm-project/commit/8d1de7b34af46a089eb5433c700419ad9b2923ee DIFF: https://github.com/llvm/llvm-project/commit/8d1de7b34af46a089eb5433c700419ad9b2923ee.diff

[Lldb-commits] [PATCH] D134754: [lldb/gdb-server] Better reporting of launch errors

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG8d1de7b34af4: [lldb/gdb-server] Better reporting of launch errors (authored by labath). Repository: rG LLVM Github

[Lldb-commits] [lldb] 08c4a67 - [lldb] Move breakpoint hit reset code to Target::CleanupProcess

Author: Pavel Labath Date: 2022-10-06T17:18:51+02:00 New Revision: 08c4a6795ac40f14d8a4385d28bc4f266ba895f1 URL: https://github.com/llvm/llvm-project/commit/08c4a6795ac40f14d8a4385d28bc4f266ba895f1 DIFF: https://github.com/llvm/llvm-project/commit/08c4a6795ac40f14d8a4385d28bc4f266ba895f1.diff

[Lldb-commits] [PATCH] D134882: [lldb] Move breakpoint hit reset code to Target::CleanupProcess

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG08c4a6795ac4: [lldb] Move breakpoint hit reset code to Target::CleanupProcess (authored by labath). Repository: rG

[Lldb-commits] [PATCH] D134570: [lldb] Skip check for conflicting filter/synth when adding a new regex.

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Let's just skip this check. Though it might be fun to implement an emptyness-of-intersection check for two regular expressions, that's: a) overkill; b) impossible if you include

[Lldb-commits] [lldb] 0008990 - Remove the dependency between lib/DebugInfoDWARF and MC.

Author: Shubham Sandeep Rastogi Date: 2022-10-06T09:25:57-07:00 New Revision: 0008990479a2daf587c2a4f274384b2fb87247fb URL: https://github.com/llvm/llvm-project/commit/0008990479a2daf587c2a4f274384b2fb87247fb DIFF:

[Lldb-commits] [PATCH] D134817: Remove the dependency between lib/DebugInfoDWARF and MC

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0008990479a2: Remove the dependency between lib/DebugInfoDWARF and MC. (authored by rastogishubham). Herald added a project: LLDB. Herald added a

[Lldb-commits] [lldb] 69c661a - [lldb] Skip check for conflicting filter/synth when adding a new regex.

Author: Jorge Gorbe Moya Date: 2022-10-06T13:27:11-07:00 New Revision: 69c661a65ff8c04ce9408a788a77df67481545a1 URL: https://github.com/llvm/llvm-project/commit/69c661a65ff8c04ce9408a788a77df67481545a1 DIFF:

[Lldb-commits] [PATCH] D134570: [lldb] Skip check for conflicting filter/synth when adding a new regex.

This revision was automatically updated to reflect the committed changes. Closed by commit rG69c661a65ff8: [lldb] Skip check for conflicting filter/synth when adding a new regex. (authored by jgorbe). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] d96ade0 - Remove the dependency between lib/DebugInfoDWARF and MC.

Author: Shubham Sandeep Rastogi Date: 2022-10-06T14:46:01-07:00 New Revision: d96ade00c3c96bd451c60e34a17e613cdd5fdc38 URL: https://github.com/llvm/llvm-project/commit/d96ade00c3c96bd451c60e34a17e613cdd5fdc38 DIFF:

[Lldb-commits] [lldb] f491b89 - Revert "Remove the dependency between lib/DebugInfoDWARF and MC."

Author: Shubham Sandeep Rastogi Date: 2022-10-06T14:58:34-07:00 New Revision: f491b898c5d1312112d14f02d9cbdea7a4b4dc9d URL: https://github.com/llvm/llvm-project/commit/f491b898c5d1312112d14f02d9cbdea7a4b4dc9d DIFF:

[Lldb-commits] [PATCH] D135400: [clang][LTO] Remove the use of `--` for arange option

MaskRay added a comment. I missed https://reviews.llvm.org/D134668 . See my comment there I don't think the change is necessary. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135400/new/ https://reviews.llvm.org/D135400 ___ lldb-commits

[Lldb-commits] [lldb] dee9c7f - [NFCI] Simplify TypeCategoryImpl for-each callbacks.

Author: Jorge Gorbe Moya Date: 2022-10-06T12:11:27-07:00 New Revision: dee9c7f5d7e53aa6a9e7f85cdf9935341ba7e636 URL: https://github.com/llvm/llvm-project/commit/dee9c7f5d7e53aa6a9e7f85cdf9935341ba7e636 DIFF:

[Lldb-commits] [PATCH] D134771: [NFCI] Simplify TypeCategoryImpl for-each callbacks.

This revision was automatically updated to reflect the committed changes. Closed by commit rGdee9c7f5d7e5: [NFCI] Simplify TypeCategoryImpl for-each callbacks. (authored by jgorbe). Changed prior to commit: https://reviews.llvm.org/D134771?vs=463624=465824#toc Repository: rG LLVM Github

[Lldb-commits] [PATCH] D135400: [clang][LTO] Remove the use of `--` for arange option

qiongsiwu1 created this revision. qiongsiwu1 added reviewers: w2yehia, MaskRay, azat, dblaikie. qiongsiwu1 added projects: clang, LLVM. Herald added subscribers: ormris, StephenFan, inglorion. Herald added a project: All. qiongsiwu1 requested review of this revision. Herald added subscribers:

[Lldb-commits] [PATCH] D135400: [clang][LTO] Remove the use of `--` for arange option

qiongsiwu1 updated this revision to Diff 465872. qiongsiwu1 added a comment. Fix a patch upload error. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135400/new/ https://reviews.llvm.org/D135400 Files: clang/lib/Driver/ToolChains/CommonArgs.cpp

[Lldb-commits] [PATCH] D135400: [clang][LTO] Remove the use of `--` for arange option

qiongsiwu1 added a comment. In D135400#3841321 , @MaskRay wrote: > I missed https://reviews.llvm.org/D134668 . See my comment there I don't > think the change is necessary. Thanks for the comment! I posted a reply there. CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] 01470b6 - [lldb] Fix hard-coded argument to set_target_properties

Author: Jonas Devlieghere Date: 2022-10-06T11:43:52-07:00 New Revision: 01470b68f392af8bbf95b2ab48253b1662e2cdc7 URL: https://github.com/llvm/llvm-project/commit/01470b68f392af8bbf95b2ab48253b1662e2cdc7 DIFF:

[Lldb-commits] [PATCH] D135399: [NFCI] More TypeCategoryImpl refactoring.

jgorbe created this revision. jgorbe added reviewers: labath, jingham. jgorbe added a project: LLDB. Herald added a subscriber: JDevlieghere. Herald added a project: All. jgorbe requested review of this revision. The main aim of this patch is to delete the remaining instances of code reaching

[Lldb-commits] [PATCH] D134378: [lldb] Support simplified template names

aeubanks updated this revision to Diff 465926. aeubanks added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134378/new/ https://reviews.llvm.org/D134378 Files:

[Lldb-commits] [PATCH] D135400: [clang][LTO] Remove the use of `--` for arange option

MaskRay accepted this revision. MaskRay added inline comments. This revision is now accepted and ready to land. Comment at: clang/test/Driver/debug-options-aranges.c:6 // RUN: %clang -### -g --target=x86_64-linux -flto=thin -gdwarf-aranges %s 2>&1 | FileCheck %s -// CHECK:

[Lldb-commits] [PATCH] D135413: [lldb][CPlusPlusLanguage] Respect the step-avoid-regex for functions with auto return types

Michael137 created this revision. Michael137 added reviewers: jingham, aprantl, labath. Herald added a project: All. Michael137 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. **Summary** The primary motivation for this patch is to make

[Lldb-commits] [PATCH] D135413: [lldb][CPlusPlusLanguage] Respect the step-avoid-regex for functions with auto return types

Michael137 added inline comments. Herald added a subscriber: JDevlieghere. Comment at: lldb/unittests/Language/CPlusPlus/CPlusPlusLanguageTest.cpp:68 // Lambda - {"main::{lambda()#1}::operator()() const::{lambda()#1}::operator()() const", -

[Lldb-commits] [PATCH] D134849: [LLDB][NativePDB] Fix struct layout when it has anonymous unions.

zequanwu added inline comments. Comment at: lldb/source/Plugins/SymbolFile/NativePDB/UdtRecordCompleter.cpp:392-443 + // For anonymous unions in a struct, msvc generated pdb doesn't have the + // entity for that union. So, we need to construct anonymous union and struct + //

[Lldb-commits] [PATCH] D135400: [clang][LTO] Remove the use of `--` for arange option

This revision was automatically updated to reflect the committed changes. Closed by commit rGb924c8c71daa: [clang][LTO] Remove the use of `--` for arange option (authored by Qiongsi Wu qiongs...@gmail.com). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D135400: [clang][LTO] Remove the use of `--` for arange option

qiongsiwu1 updated this revision to Diff 465910. qiongsiwu1 added a comment. Thanks for the review! Comment addressed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135400/new/ https://reviews.llvm.org/D135400 Files:

[Lldb-commits] [PATCH] D134378: [lldb] Support simplified template names

aeubanks added inline comments. Comment at: lldb/test/API/lang/cpp/unique-types2/TestUniqueTypes.py:1 +""" +Test that we return only the requested template instantiation. Michael137 wrote: > I think it would be good to test this with >

[Lldb-commits] [PATCH] D134849: [LLDB][NativePDB] Fix struct layout when it has anonymous unions.

zequanwu updated this revision to Diff 465933. zequanwu marked 5 inline comments as done. zequanwu added a comment. Add unittests and address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134849/new/ https://reviews.llvm.org/D134849