@@ -0,0 +1,87 @@
+// RUN: %clangxx -target arm64-apple-macosx11.0.0 -g %s -emit-llvm -S -o - |
FileCheck --check-prefixes=CHECK %s
+
+enum class Enum : int {
+ VAL = -1
+};
+
+struct Empty {};
+
+constexpr auto func() { return 25; }
+
+struct Foo {
+static constexpr int
Michael137 wrote:
> size report sounds generally OK - but there's a bunch of what look like
> unrelated or strange results in there, perhaps they weren't compared at
> exactly the same version? (like why did the apple_names size go down? How did
> the .text and .debuG_line size change at all?
Author: Adrian Prantl
Date: 2023-10-31T15:36:06-07:00
New Revision: 15733fe5f3cbf36ad1c9fbb0c6e4f31fdec224fa
URL:
https://github.com/llvm/llvm-project/commit/15733fe5f3cbf36ad1c9fbb0c6e4f31fdec224fa
DIFF:
https://github.com/llvm/llvm-project/commit/15733fe5f3cbf36ad1c9fbb0c6e4f31fdec224fa.diff
@@ -274,7 +317,7 @@ struct RecordReplayTy {
void saveKernelOutputInfo(const char *Name) {
SmallString<128> OutputFilename = {
Name, (isRecording() ? ".original.output" : ".replay.output")};
-dumpDeviceMemory(OutputFilename);
+
https://github.com/adrian-prantl closed
https://github.com/llvm/llvm-project/pull/70716
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -614,6 +614,8 @@ class Process : public
std::enable_shared_from_this,
return error;
}
+ virtual void DidLoadCore() {}
JDevlieghere wrote:
Okay, so if semantically this doesn't make sense (which is what I'm hearing)
then I don't why we would reuse
https://github.com/JDevlieghere approved this pull request.
LGTM per my last comment.
https://github.com/llvm/llvm-project/pull/70351
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
@@ -274,7 +317,7 @@ struct RecordReplayTy {
void saveKernelOutputInfo(const char *Name) {
SmallString<128> OutputFilename = {
Name, (isRecording() ? ".original.output" : ".replay.output")};
nmustakin wrote:
The motivation was to save the disk
Author: Med Ismail Bennani
Date: 2023-10-31T20:35:25-07:00
New Revision: 455098d8073483e0fa40557100cfb717ea466818
URL:
https://github.com/llvm/llvm-project/commit/455098d8073483e0fa40557100cfb717ea466818
DIFF:
https://github.com/clayborg commented:
One question I have here: where will the DW_TAG_variable get emitted for these
`constexpr`? For actual static member variables we emit a single
DW_TAG_variable in the file that declares the global variable, but for
`constexpr` we won't be able to do this
@@ -614,6 +614,8 @@ class Process : public
std::enable_shared_from_this,
return error;
}
+ virtual void DidLoadCore() {}
medismailben wrote:
I agree with @clayborg: attaching to a process and loading a core file are
mutually exclusive actions so I
Michael137 wrote:
> > Few minor issues, but looks good to me. (you metnioned somewhere an lldb
> > issue I think with this patch when the value is removed from the static
> > member declaration inside the class? If that's a problem - probably hold
> > off on committing this until lldb's been
https://github.com/medismailben edited
https://github.com/llvm/llvm-project/pull/70793
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -271,9 +271,9 @@ void ObjectFileCOFF::ParseSymtab(lldb_private::Symtab
) {
const auto COFFSymRef = m_object->getCOFFSymbol(SymRef);
Expected NameOrErr = SymRef.getName();
-if (auto error = NameOrErr.takeError()) {
- LLDB_LOG(log, "ObjectFileCOFF: failed
@@ -791,11 +791,10 @@ void ObjectFilePECOFF::AppendFromCOFFSymbolTable(
for (const auto _ref : m_binary->symbols()) {
const auto coff_sym_ref = m_binary->getCOFFSymbol(sym_ref);
auto name_or_error = sym_ref.getName();
-if (auto err = name_or_error.takeError()) {
https://github.com/medismailben requested changes to this pull request.
https://github.com/llvm/llvm-project/pull/70793
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/dwblaikie approved this pull request.
Few minor issues, but looks good to me.
(you metnioned somewhere an lldb issue I think with this patch when the value
is removed from the static member declaration inside the class? If that's a
problem - probably hold off on committing
clayborg wrote:
> > > Few minor issues, but looks good to me. (you metnioned somewhere an lldb
> > > issue I think with this patch when the value is removed from the static
> > > member declaration inside the class? If that's a problem - probably hold
> > > off on committing this until lldb's
@@ -614,6 +614,8 @@ class Process : public
std::enable_shared_from_this,
return error;
}
+ virtual void DidLoadCore() {}
JDevlieghere wrote:
Would it be worth to rename that function to `DidAttachOrLoadCore` (or just
`DidAttachOrLoad`) to make it
https://github.com/jasonmolenda edited
https://github.com/llvm/llvm-project/pull/70205
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/jasonmolenda approved this pull request.
Looks good to me, a few small comments inlined. Mostly the problem I have is
that every time I see "ZA" I think of old teenage mutant ninja turtles who
referred to pizza as "za" and it makes it very difficult to read this patch.
@@ -488,6 +508,12 @@ bool RegisterInfoPOSIX_arm64::IsSMERegZA(unsigned reg)
const {
return reg == m_sme_regnum_collection[2];
}
+bool RegisterInfoPOSIX_arm64::IsSMERegZT(unsigned reg) const {
+ // ZT0 is part of the SME register set only if SME2 is present.
+ return
@@ -624,6 +661,21 @@
NativeRegisterContextLinux_arm64::CacheAllRegisters(uint32_t _size) {
error = ReadZA();
if (error.Fail())
return error;
+
+// We will only be restoring ZT data if ZA is active. As writing to an
+// inactive ZT enables ZA, which may
@@ -580,7 +616,8 @@ enum RegisterSetType : uint32_t {
// Pointer authentication registers are read only, so not included here.
MTE,
TLS,
- SME, // ZA only, SVCR and SVG are pseudo registers.
+ SME, // ZA only , SVCR and SVG are pseudo registers.
medismailben wrote:
Reverting because this broke some tests:
```
Failed Tests (5):
lldb-api :: functionalities/postmortem/elf-core/TestLinuxCore.py
lldb-api :: functionalities/postmortem/mach-core/TestMachCore.py
lldb-api ::
Author: Tulio Magno Quites Machado Filho
Date: 2023-10-31T17:08:55-03:00
New Revision: 2260ebf7b6df15db96c76039758dd9dbf009c334
URL:
https://github.com/llvm/llvm-project/commit/2260ebf7b6df15db96c76039758dd9dbf009c334
DIFF:
https://github.com/tuliom closed https://github.com/llvm/llvm-project/pull/70443
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -3061,7 +3061,8 @@ void DWARFASTParserClang::ParseSingleMember(
// artificial member with (unnamed bitfield) padding.
// FIXME: This check should verify that this is indeed an artificial member
// we are supposed to ignore.
- if (attrs.is_artificial) {
+ if
https://github.com/nmustakin edited
https://github.com/llvm/llvm-project/pull/70667
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/70639
>From 18db082fc5008283f77cc98d9c733a47c63b7096 Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Fri, 27 Oct 2023 16:19:47 +0100
Subject: [PATCH 1/7] [clang][DebugInfo] Emit global variable definitions for
https://github.com/clayborg approved this pull request.
https://github.com/llvm/llvm-project/pull/70351
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Michael137 wrote:
> The DWARFASTParserClang.cpp will try to create the class from the DWARF for
> the class definition. You will need to find the DW_TAG_variable when we are
> creating the static field if there is no DW_AT_const_value in the
> DW_TAG_member. But we also need to support the
@@ -141,13 +141,56 @@ struct RecordReplayTy {
if (Err)
report_fatal_error("Error retrieving data for target pointer");
-StringRef DeviceMemory(DeviceMemoryMB.get()->getBufferStart(), MemorySize);
std::error_code EC;
raw_fd_ostream OS(Filename, EC);
clayborg wrote:
> Few minor issues, but looks good to me. (you metnioned somewhere an lldb
> issue I think with this patch when the value is removed from the static
> member declaration inside the class? If that's a problem - probably hold off
> on committing this until lldb's been fixed so
@@ -41,7 +41,10 @@ CPPLanguageRuntime::CPPLanguageRuntime(Process *process)
: LanguageRuntime(process) {}
bool CPPLanguageRuntime::IsAllowedRuntimeValue(ConstString name) {
- return name == g_this;
+ // FIXME: use a list when the list grows more.
+ return name ==
https://github.com/JDevlieghere approved this pull request.
Thanks Stefan!
https://github.com/llvm/llvm-project/pull/70793
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/70443
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -614,6 +614,8 @@ class Process : public
std::enable_shared_from_this,
return error;
}
+ virtual void DidLoadCore() {}
clayborg wrote:
I think it makes sense in the process plug-in landscape. We are attaching to a
core file image from a process
@@ -130,7 +130,7 @@ struct RecordReplayTy {
return preAllocateHeuristic(DevMemSize, ReqVAddr);
}
- void dumpDeviceMemory(StringRef Filename) {
+ void dumpDeviceMemory(StringRef Filename, bool saveDiff) {
ggeorgakoudis wrote:
rename saveDiff ->
https://github.com/ggeorgakoudis edited
https://github.com/llvm/llvm-project/pull/70667
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -141,13 +141,56 @@ struct RecordReplayTy {
if (Err)
report_fatal_error("Error retrieving data for target pointer");
-StringRef DeviceMemory(DeviceMemoryMB.get()->getBufferStart(), MemorySize);
std::error_code EC;
raw_fd_ostream OS(Filename, EC);
@@ -141,13 +141,56 @@ struct RecordReplayTy {
if (Err)
report_fatal_error("Error retrieving data for target pointer");
-StringRef DeviceMemory(DeviceMemoryMB.get()->getBufferStart(), MemorySize);
std::error_code EC;
raw_fd_ostream OS(Filename, EC);
@@ -141,13 +141,56 @@ struct RecordReplayTy {
if (Err)
report_fatal_error("Error retrieving data for target pointer");
-StringRef DeviceMemory(DeviceMemoryMB.get()->getBufferStart(), MemorySize);
std::error_code EC;
raw_fd_ostream OS(Filename, EC);
@@ -274,7 +317,7 @@ struct RecordReplayTy {
void saveKernelOutputInfo(const char *Name) {
SmallString<128> OutputFilename = {
Name, (isRecording() ? ".original.output" : ".replay.output")};
ggeorgakoudis wrote:
Create a new extensions when
@@ -274,7 +317,7 @@ struct RecordReplayTy {
void saveKernelOutputInfo(const char *Name) {
SmallString<128> OutputFilename = {
Name, (isRecording() ? ".original.output" : ".replay.output")};
-dumpDeviceMemory(OutputFilename);
+
https://github.com/ggeorgakoudis requested changes to this pull request.
https://github.com/llvm/llvm-project/pull/70667
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -67,15 +67,15 @@ int C::a = 4;
// CHECK-NOT:size:
// CHECK-NOT:align:
// CHECK-NOT:offset:
-// CHECK-SAME: flags: DIFlagStaticMember,
-// CHECK-SAME: extraData: i1 true)
+// CHECK-SAME: flags:
Author: Med Ismail Bennani
Date: 2023-10-31T19:56:02-07:00
New Revision: 3c727a959d1c479ef284471701faa0e8ac6f427e
URL:
https://github.com/llvm/llvm-project/commit/3c727a959d1c479ef284471701faa0e8ac6f427e
DIFF:
https://github.com/medismailben closed
https://github.com/llvm/llvm-project/pull/70351
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/bulbazord approved this pull request.
Thanks for taking the time to make sure it works with Python 3.6! I'm a big fan
of this kind of modernization/cleanup work.
https://github.com/llvm/llvm-project/pull/70443
___
lldb-commits
bulbazord wrote:
Looks fine to me, though I'm not an expert in this area. If nobody else reviews
or approves soon, I can do so.
https://github.com/llvm/llvm-project/pull/70205
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
@@ -67,15 +67,15 @@ int C::a = 4;
// CHECK-NOT:size:
// CHECK-NOT:align:
// CHECK-NOT:offset:
-// CHECK-SAME: flags: DIFlagStaticMember,
-// CHECK-SAME: extraData: i1 true)
+// CHECK-SAME: flags:
@@ -5883,6 +5907,18 @@ void CGDebugInfo::finalize() {
DBuilder.replaceTemporary(std::move(FwdDecl), cast(Repl));
}
+ for (auto const *VD : StaticDataMemberDefinitionsToEmit) {
+assert(VD->isStaticDataMember());
+
+if (auto It = DeclCache.find(VD); It !=
clayborg wrote:
@DanielCChen see above
https://github.com/llvm/llvm-project/pull/67599
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
jimingham wrote:
You should never revert a commit without saying why in your revert-commit
message.
https://github.com/llvm/llvm-project/pull/67599
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
clayborg wrote:
Maybe this was only reverted in his branch?
https://github.com/llvm/llvm-project/pull/67599
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
jimingham wrote:
I hope that's not the case... It would be really noisy to see what goes on on
people's private forks in a PR on the main repo.
Jim
> On Oct 31, 2023, at 10:42 AM, Greg Clayton ***@***.***> wrote:
>
>
> Maybe this was only reverted in his branch?
>
> —
> Reply to this
clayborg wrote:
Phew! Still getting. used to this new workflow. Thanks for the confirmation
https://github.com/llvm/llvm-project/pull/67599
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://github.com/tuliom updated
https://github.com/llvm/llvm-project/pull/70443
>From 16fd09f102eff20825847e32f225715960d1c082 Mon Sep 17 00:00:00 2001
From: Tulio Magno Quites Machado Filho
Date: Wed, 25 Oct 2023 10:48:53 -0300
Subject: [PATCH 1/2] [lldb] Replace the usage of module imp
https://github.com/bulbazord approved this pull request.
https://github.com/llvm/llvm-project/pull/70793
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
clayborg wrote:
How do we find out why something was reverted? I didn't get any emails and this
got reverted. Is there a new workflow to find out this info when using github?
https://github.com/llvm/llvm-project/pull/67599
___
lldb-commits mailing
clayborg wrote:
> You should never revert a commit without saying why in your revert-commit
> message.
I just synced with top of tree and it seems to still be there??
https://github.com/llvm/llvm-project/pull/67599
___
lldb-commits mailing list
bulbazord wrote:
The change was not reverted upstream. It was reverted in that @DanielCChen 's
llvm-project fork. Unfortunately that's the nature of GitHub.
https://github.com/llvm/llvm-project/pull/67599
___
lldb-commits mailing list
tuliom wrote:
I confirmed the new code works with Python 3.6 and removed the conditional.
https://github.com/llvm/llvm-project/pull/70443
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/70641
>From 7de2335efd85ae6058705a6a6cd9c5b160aef757 Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Sat, 28 Oct 2023 15:24:47 +0100
Subject: [PATCH 1/2] [lldb][test] Add FindGlobalVariables tests for C++
https://github.com/DavidSpickett updated
https://github.com/llvm/llvm-project/pull/70205
>From da28585bcb47732ee54e8bd8e5b483c797f9f1d8 Mon Sep 17 00:00:00 2001
From: David Spickett
Date: Tue, 3 Oct 2023 13:24:39 +0100
Subject: [PATCH 1/4] [lldb][AArch64] Add SME2's ZT0 register
SME2 is
DavidSpickett wrote:
> That results in lldb having to read each register value one at a time while
> at that stop location, which will be a performance problem on non-local debug
> setups.
And given that SVE/SME size can change every time we stop, "this stop" means
"all stops". So yeah I can
@@ -5723,16 +5723,14 @@ void Clang::ConstructJob(Compilation , const
JobAction ,
if (Arg *A = Args.getLastArg(options::OPT_mcmodel_EQ)) {
StringRef CM = A->getValue();
bool Ok = false;
-if (Triple.isOSAIX() && CM == "medium") {
+if (Triple.isOSAIX() && CM ==
DavidSpickett wrote:
Rebased this to include the `IsPresent` change, otherwise it's the same as
before.
https://github.com/llvm/llvm-project/pull/70205
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
@@ -5723,16 +5723,14 @@ void Clang::ConstructJob(Compilation , const
JobAction ,
if (Arg *A = Args.getLastArg(options::OPT_mcmodel_EQ)) {
StringRef CM = A->getValue();
bool Ok = false;
-if (Triple.isOSAIX() && CM == "medium") {
+if (Triple.isOSAIX() && CM ==
taalhaataahir0102 wrote:
Hi David!
> That file does essentially what you're doing using it. You'd use the strings
> found
> [here](https://github.com/llvm/llvm-project/blob/cbbb545c4618969850d88bb008ab7f1c2918d5c3/lldb/include/lldb/Utility/AnsiTerminal.h#L83)
> instead of the ASNI_...
>
>
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 00a831421fdd94aec65221bdb37042c1aacfe8e0
4cc40aafef4db5133f4360b2fb367e1776dc2901 --
DavidSpickett wrote:
> Parse the expedited registers once, reconfigure then parse them again. On the
> assumption that no scalable register will ever be in the expedited set.
This works but due to more pessimism in:
https://github.com/hokein created
https://github.com/llvm/llvm-project/pull/70779
Fixes #69309
* always populate all fields for the generated coroutine frame type;
* make the artificial variables `__promise`, `__coro_frame` visible, so that
they are present in the `frame var` command;
>From
https://github.com/weliveindetail created
https://github.com/llvm/llvm-project/pull/70793
I actually ran into it with a downstream fork:
```
llvm::Error::fatalUncheckedError(), llvm-project\llvm\lib\Support\Error.cpp,
line 117
ObjectFilePECOFF::AppendFromCOFFSymbolTable(),
DavidSpickett wrote:
> Invalidate only registers we know can change size.
This one doesn't work because in changing the size of any register in the
context, you invalidate the offsets of the rest. We also cannot be sure that
the scalable registers are in a certain place in that context.
https://github.com/DavidSpickett approved this pull request.
Assuming I understand correctly that previously, the error was only consumed
when logging was enabled, this LGTM.
https://github.com/llvm/llvm-project/pull/70793
___
lldb-commits mailing
tuliom wrote:
Thank you!
https://github.com/llvm/llvm-project/pull/70732
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/jayfoad updated
https://github.com/llvm/llvm-project/pull/70644
>From bfc7b2041f5a05105808b0b1ee0427d9c9eb9f4b Mon Sep 17 00:00:00 2001
From: Jay Foad
Date: Mon, 30 Oct 2023 15:23:48 +
Subject: [PATCH 1/4] Precommit test
---
.../AMDGPU/fix-sgpr-copies-nondeterminism.ll
DavidSpickett wrote:
This passed all the tests, and I see a reduction in the packets sent for a
single step.
The value of vg is 8 and svg 4 is 4 in this case.
Before:
```
(lldb) b-remote.async> < 800> read packet:
weliveindetail wrote:
Sorry, I had a few unrelated patched in the pipe. I force-pushed to fix that.
https://github.com/llvm/llvm-project/pull/70793
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
jasonmolenda wrote:
> So, as silly as it sounds this might be the way to go:
>
> * Parse expedited registers.
> * Reconfigure if needed and invalidate all registers.
> * Parse expedited registers again.
I'm fine with that, it doesn't require packets over the wire so the perf hit is
tiny. Or
https://github.com/DavidSpickett closed
https://github.com/llvm/llvm-project/pull/70742
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Jason Molenda
Date: 2023-10-31T15:38:42Z
New Revision: d4026458d4ced8471cc0fcbf3a1a4cd1944ebea9
URL:
https://github.com/llvm/llvm-project/commit/d4026458d4ced8471cc0fcbf3a1a4cd1944ebea9
DIFF:
https://github.com/llvm/llvm-project/commit/d4026458d4ced8471cc0fcbf3a1a4cd1944ebea9.diff
DavidSpickett wrote:
I'm gonna merge this so I can do a patch on top of this where we both
understand the starting point. I think I've got to the bottom of the issues my
workarounds were addressing.
https://github.com/llvm/llvm-project/pull/70742
jasonmolenda wrote:
> Or fishing the vg and svg register values of of the expedited register list
> if they're there.
ignore that suggestion, we can't hardcode a register number here, the stub is
allowed to use whatever numbers it wants for the registers and the expedited
register numbers
dwblaikie wrote:
size report sounds generally OK - but there's a bunch of what look like
unrelated or strange results in there, perhaps they weren't compared at exactly
the same version? (like why did the apple_names size go down? How did the .text
and .debuG_line size change at all? )
https://github.com/vogelsgesang edited
https://github.com/llvm/llvm-project/pull/70779
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/vogelsgesang commented:
I can't provide feedback on the lldb integration aspects, as I don't know the
lldb code base well enough
https://github.com/llvm/llvm-project/pull/70779
___
lldb-commits mailing list
@@ -41,7 +41,10 @@ CPPLanguageRuntime::CPPLanguageRuntime(Process *process)
: LanguageRuntime(process) {}
bool CPPLanguageRuntime::IsAllowedRuntimeValue(ConstString name) {
- return name == g_this;
+ // FIXME: use a list when the list grows more.
+ return name ==
DavidSpickett wrote:
Ping!
If you are short on time, maybe just look at `LinuxArm64RegisterFlags` which is
the core of the change. The rest is the field information itself.
https://github.com/llvm/llvm-project/pull/70300
___
lldb-commits mailing
https://github.com/jayfoad closed
https://github.com/llvm/llvm-project/pull/70644
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DavidSpickett approved this pull request.
Happy for this to land as is given that it is a strict improvement over the
current state (however weird that is).
https://github.com/llvm/llvm-project/pull/70742
___
lldb-commits mailing
https://github.com/weliveindetail updated
https://github.com/llvm/llvm-project/pull/70793
From a4fecdd4bd9b12b1151d62892bcad7bab6833ce0 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Stefan=20Gr=C3=A4nitz?=
Date: Tue, 31 Oct 2023 13:12:21 +0100
Subject: [PATCH] [lldb] Fix missing comsumeError() with
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Stefan Gränitz (weliveindetail)
Changes
I actually ran into it with a downstream fork:
```
llvm::Error::fatalUncheckedError(), llvm-project\llvm\lib\Support\Error.cpp,
line 117
ObjectFilePECOFF::AppendFromCOFFSymbolTable(),
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff c280bed85a8b9cd6ebf48f9f2923890edc7039f0
5091d1ffec05ec65e4e762d2bea8735d0de7b6fb --
https://github.com/compnerd approved this pull request.
https://github.com/llvm/llvm-project/pull/70793
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Vlad Serebrennikov
Date: 2023-10-31T18:21:36+03:00
New Revision: f5f4c5b313fc809b9b1b9d600d0ec3cec0d12941
URL:
https://github.com/llvm/llvm-project/commit/f5f4c5b313fc809b9b1b9d600d0ec3cec0d12941
DIFF:
@@ -1642,9 +1642,22 @@ ThreadSP ProcessGDBRemote::SetThreadStopInfo(
}
ThreadGDBRemote *gdb_thread = static_cast(thread_sp.get());
- RegisterContextSP gdb_reg_ctx_sp(gdb_thread->GetRegisterContext());
+ RegisterContextSP reg_ctx_sp(gdb_thread->GetRegisterContext());
-
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/70639
>From 18db082fc5008283f77cc98d9c733a47c63b7096 Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Fri, 27 Oct 2023 16:19:47 +0100
Subject: [PATCH 1/4] [clang][DebugInfo] Emit global variable definitions for
100 matches
Mail list logo
