[Lldb-commits] [lldb] [Demangling] Refactor Demangler range tracking (PR #140762)

2025-05-28 Thread Charles Zablit via lldb-commits
https://github.com/charles-zablit updated https://github.com/llvm/llvm-project/pull/140762 >From cc3c6d1c86ae0ed579c4f325778ee1b4cd90d6be Mon Sep 17 00:00:00 2001 From: Charles Zablit Date: Tue, 20 May 2025 17:45:20 +0100 Subject: [PATCH 1/9] refactor demangler range tracking --- lldb/include

[Lldb-commits] [lldb] [lldb][test] Add stack frame padding to fix flaky DIL array subscript test (PR #141738)

2025-05-28 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett created https://github.com/llvm/llvm-project/pull/141738 This test has been flaky on Linaro's Windows on Arm bot and I was able to reproduce it within 10 or so runs locally. When it fails it's because we failed to read the value of int_arr[100]. When that happ

[Lldb-commits] [lldb] [LLDB] Avoid crashes when inspecting MSVC STL types (PR #140761)

2025-05-28 Thread David Spickett via lldb-commits
@@ -0,0 +1,57 @@ +// clang-format off + +// REQUIRES: target-windows +// RUN: %build --compiler=clang-cl -o %t.exe --std c++20 -- %s +// RUN: env LLDB_USE_NATIVE_PDB_READER=1 %lldb -f %t.exe -o "b main" -o "run" -o "fr v" -o c | FileCheck %s + +#include DavidSpi

[Lldb-commits] [lldb] [Demangling] Refactor Demangler range tracking (PR #140762)

2025-05-28 Thread Charles Zablit via lldb-commits
https://github.com/charles-zablit updated https://github.com/llvm/llvm-project/pull/140762 >From cc3c6d1c86ae0ed579c4f325778ee1b4cd90d6be Mon Sep 17 00:00:00 2001 From: Charles Zablit Date: Tue, 20 May 2025 17:45:20 +0100 Subject: [PATCH 1/8] refactor demangler range tracking --- lldb/include

[Lldb-commits] [lldb] [LLDB] Add array subscription and integer parsing to DIL (PR #138551)

2025-05-28 Thread David Spickett via lldb-commits
DavidSpickett wrote: One of the tests added by this was flaky on Linaro's Windows on Arm bot, I've skipped it for now and https://github.com/llvm/llvm-project/pull/141738 will fix it properly. https://github.com/llvm/llvm-project/pull/138551 ___ lldb

[Lldb-commits] [lldb] [lldb][test] Add stack frame padding to fix flaky DIL array subscript test (PR #141738)

2025-05-28 Thread David Spickett via lldb-commits
DavidSpickett wrote: This does not fix the test that is xfailed, where you can't read the first element of a vector. That's something entirely different. https://github.com/llvm/llvm-project/pull/141738 ___ lldb-commits mailing list lldb-commits@lists

[Lldb-commits] [lldb] [lldb][test] Add stack frame padding to fix flaky DIL array subscript test (PR #141738)

2025-05-28 Thread Michael Buch via lldb-commits
@@ -19,8 +19,6 @@ def expect_var_path(self, expr, compare_to_framevar=False, value=None, type=None self.runCmd("settings set target.experimental.use-DIL true") self.assertEqual(value_dil.GetValue(), value_frv.GetValue()) -# int_arr[100] sometimes p

[Lldb-commits] [lldb] [lldb][AIX] get host info for AIX (cont..) (PR #138687)

2025-05-28 Thread Hemang Gadhavi via lldb-commits
https://github.com/HemangGadhavi updated https://github.com/llvm/llvm-project/pull/138687 >From a47e4642e6ebcbe6b5466ff118968bac83ccf1e9 Mon Sep 17 00:00:00 2001 From: HemangGadhavi Date: Tue, 6 May 2025 07:59:45 -0500 Subject: [PATCH 1/3] [lldb][AIX] get host info for AIX (cont..) --- lldb/s

[Lldb-commits] [lldb] [LLDB] Avoid crashes when inspecting MSVC STL types (PR #140761)

2025-05-28 Thread Michael Buch via lldb-commits
https://github.com/Michael137 approved this pull request. https://github.com/llvm/llvm-project/pull/140761 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Avoid crashes when inspecting MSVC STL types (PR #140761)

2025-05-28 Thread Michael Buch via lldb-commits
@@ -0,0 +1,57 @@ +// clang-format off Michael137 wrote: ```suggestion // clang-format off ``` https://github.com/llvm/llvm-project/pull/140761 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llv

[Lldb-commits] [lldb] [LLDB] Avoid crashes when inspecting MSVC STL types (PR #140761)

2025-05-28 Thread Michael Buch via lldb-commits
https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/140761 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][AIX] get host info for AIX (cont..) (PR #138687)

2025-05-28 Thread Hemang Gadhavi via lldb-commits
@@ -90,6 +92,30 @@ TEST(Host, LaunchProcessSetsArgv0) { ASSERT_THAT(exit_status.get_future().get(), 0); } +TEST(Host, FindProcesses) { + SubsystemRAII subsystems; + + if (test_arg != 0) +exit(0); HemangGadhavi wrote: Done https://github.com/llvm/llvm

[Lldb-commits] [lldb] [LLDB] Avoid crashes when inspecting MSVC STL types (PR #140761)

2025-05-28 Thread Michael Buch via lldb-commits
@@ -0,0 +1,57 @@ +// clang-format off + +// REQUIRES: target-windows Michael137 wrote: Can you add a comment here to explain why this test exists? I.e., that this just ensures that debugging with MSVC STL doesn't crash, etc. https://github.com/llvm/llvm-project

[Lldb-commits] [lldb] [LLDB] Avoid crashes when inspecting MSVC STL types (PR #140761)

2025-05-28 Thread Michael Buch via lldb-commits
https://github.com/Michael137 approved this pull request. LGTM (just left small test comments) https://github.com/llvm/llvm-project/pull/140761 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/ll

[Lldb-commits] [lldb] [LLDB] Avoid crashes when inspecting MSVC STL types (PR #140761)

2025-05-28 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett requested changes to this pull request. Request changes just so the remaining comment doesn't get forgotten, the rest Michael has approved and if he's cool with it so am I. https://github.com/llvm/llvm-project/pull/140761

[Lldb-commits] [lldb] [LLDB] Avoid crashes when inspecting MSVC STL types (PR #140761)

2025-05-28 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett edited https://github.com/llvm/llvm-project/pull/140761 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Avoid crashes when inspecting MSVC STL types (PR #140761)

2025-05-28 Thread David Spickett via lldb-commits
@@ -683,14 +683,14 @@ def _get_compilation_command(self, source, obj): args.append("-fms-compatibility-version=19") args.append("/c") +if self.std: DavidSpickett wrote: This still needs to be done. https://github.com/llvm/llvm-pro

[Lldb-commits] [lldb] [lldb][test] Add stack frame padding to fix flaky DIL array subscript test (PR #141738)

2025-05-28 Thread David Spickett via lldb-commits
@@ -19,8 +19,6 @@ def expect_var_path(self, expr, compare_to_framevar=False, value=None, type=None self.runCmd("settings set target.experimental.use-DIL true") self.assertEqual(value_dil.GetValue(), value_frv.GetValue()) -# int_arr[100] sometimes p

[Lldb-commits] [lldb] [lldb][test] Add stack frame padding to fix flaky DIL array subscript test (PR #141738)

2025-05-28 Thread David Spickett via lldb-commits
@@ -19,8 +19,6 @@ def expect_var_path(self, expr, compare_to_framevar=False, value=None, type=None self.runCmd("settings set target.experimental.use-DIL true") self.assertEqual(value_dil.GetValue(), value_frv.GetValue()) -# int_arr[100] sometimes p

[Lldb-commits] [lldb] [lldb][AIX] get host info for AIX (cont..) (PR #138687)

2025-05-28 Thread Hemang Gadhavi via lldb-commits
@@ -90,6 +92,30 @@ TEST(Host, LaunchProcessSetsArgv0) { ASSERT_THAT(exit_status.get_future().get(), 0); } +TEST(Host, FindProcesses) { + SubsystemRAII subsystems; + + if (test_arg != 0) +exit(0); + + ProcessLaunchInfo info; + ProcessInstanceInfoList processes; + Pro

[Lldb-commits] [lldb] [lldb][test] Add stack frame padding to fix flaky DIL array subscript test (PR #141738)

2025-05-28 Thread Michael Buch via lldb-commits
@@ -19,8 +19,6 @@ def expect_var_path(self, expr, compare_to_framevar=False, value=None, type=None self.runCmd("settings set target.experimental.use-DIL true") self.assertEqual(value_dil.GetValue(), value_frv.GetValue()) -# int_arr[100] sometimes p

[Lldb-commits] [lldb] [lldb][test] Add stack frame padding to fix flaky DIL array subscript test (PR #141738)

2025-05-28 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: David Spickett (DavidSpickett) Changes This test has been flaky on Linaro's Windows on Arm bot and I was able to reproduce it within 10 or so runs locally. When it fails it's because we failed to read the value of int_arr[100]. When that

[Lldb-commits] [lldb] [lldb] Show coro_frame in `std::coroutine_handle` pretty printer (PR #141516)

2025-05-28 Thread Chuanqi Xu via lldb-commits
ChuanqiXu9 wrote: > CC @ChuanqiXu9 @hokein, since the both of you also looked into debuggability > of C++20 coroutines earlier CC @labath @adrian-prantl as reviewers of the > latest significant changes in this area (https://reviews.llvm.org/D132624, > https://reviews.llvm.org/D132735, https://

[Lldb-commits] [lldb] [lldb][AIX] get host info for AIX (cont..) (PR #138687)

2025-05-28 Thread Hemang Gadhavi via lldb-commits
@@ -90,6 +92,30 @@ TEST(Host, LaunchProcessSetsArgv0) { ASSERT_THAT(exit_status.get_future().get(), 0); } +TEST(Host, FindProcesses) { + SubsystemRAII subsystems; + + if (test_arg != 0) +exit(0); + + ProcessLaunchInfo info; + ProcessInstanceInfoList processes; + Pro

[Lldb-commits] [lldb] [lldb] Show coro_frame in `std::coroutine_handle` pretty printer (PR #141516)

2025-05-28 Thread Haojian Wu via lldb-commits
hokein wrote: The enhancement to the pretty-printer looks reasonable to me. I'm not familiar with the LLDB codebase, so I'll leave the approval to the LLDB maintainers. https://github.com/llvm/llvm-project/pull/141516 ___ lldb-commits mailing list l

[Lldb-commits] [lldb] [lldb][test] Add stack frame padding to fix flaky DIL array subscript test (PR #141738)

2025-05-28 Thread Michael Buch via lldb-commits
https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/141738 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Reuse source object logics (PR #141426)

2025-05-28 Thread Ely Ronnen via lldb-commits
https://github.com/eronnen updated https://github.com/llvm/llvm-project/pull/141426 >From 79a0a7b83360a517b090dad297ccb5a5a7849d0f Mon Sep 17 00:00:00 2001 From: Ely Ronnen Date: Wed, 21 May 2025 23:39:56 +0200 Subject: [PATCH 1/3] Reuse creation of Source objects for assembly and normal sourc

[Lldb-commits] [lldb] [lldb] Make AddressRange dump easier on the eye (PR #141062)

2025-05-28 Thread Pavel Labath via lldb-commits
https://github.com/labath closed https://github.com/llvm/llvm-project/pull/141062 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Reapply "[LLDB][ELF Core] Support all the Generic (Negative) SI Codes." (PR #141670)

2025-05-28 Thread Pavel Labath via lldb-commits
labath wrote: > @labath > > We need to handle situations where the core won't have a valid platform, and > then fallback to other info (like PRSTATUS). > > Please check the last commit in this patch. I think this will almost > exclusively be an artifact of our tests, but I'm not sure how else

[Lldb-commits] [clang] [compiler-rt] [lldb] [LLDB] [NFC] - Remove duplicate #include headers from the files of lldb dir & few other files (PR #141478)

2025-05-28 Thread Pavel Labath via lldb-commits
https://github.com/labath approved this pull request. Looks good. Thanks for the fix. https://github.com/llvm/llvm-project/pull/141478 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commit

[Lldb-commits] [lldb] [lldb] Fix warnings (PR #141687)

2025-05-28 Thread Walter Lee via lldb-commits
googlewalt wrote: I don't have any expertise in this code, but it looks like it shouldn't break anything and fixes a bunch of build breakages, so I'm going to check it in. https://github.com/llvm/llvm-project/pull/141687 ___ lldb-commits mailing list

[Lldb-commits] [lldb] [lldb] Fix warnings (PR #141687)

2025-05-28 Thread Walter Lee via lldb-commits
https://github.com/googlewalt closed https://github.com/llvm/llvm-project/pull/141687 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] a69487d - [lldb] Fix warnings (#141687)

2025-05-28 Thread via lldb-commits
Author: Kazu Hirata Date: 2025-05-28T04:00:18-04:00 New Revision: a69487da2e746d747fc0dc19d416a7d654c8c148 URL: https://github.com/llvm/llvm-project/commit/a69487da2e746d747fc0dc19d416a7d654c8c148 DIFF: https://github.com/llvm/llvm-project/commit/a69487da2e746d747fc0dc19d416a7d654c8c148.diff L

[Lldb-commits] [lldb] [LLDB][ELF Core] Support all the Generic (Negative) SI Codes. (PR #140150)

2025-05-28 Thread Pavel Labath via lldb-commits
labath wrote: > > @petrhosek Hey Petr, can you provide more information? For Linux > > environments, SI_DETHREAD should be present. The commit for this signal > > specifically is 13 years old, @DavidSpickett do you have any insight as to > > why this is happening? > > [SI_DETHREAD](https://git

[Lldb-commits] [lldb] [lldb] Fix warnings (PR #141687)

2025-05-28 Thread Walter Lee via lldb-commits
https://github.com/googlewalt approved this pull request. https://github.com/llvm/llvm-project/pull/141687 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 8b6e985 - [lldb][test] Skip DIL array subscript test on Windows

2025-05-28 Thread David Spickett via lldb-commits
Author: David Spickett Date: 2025-05-28T10:14:28Z New Revision: 8b6e98559de15dc75edddf616ed37c5b6e23dfba URL: https://github.com/llvm/llvm-project/commit/8b6e98559de15dc75edddf616ed37c5b6e23dfba DIFF: https://github.com/llvm/llvm-project/commit/8b6e98559de15dc75edddf616ed37c5b6e23dfba.diff LOG

[Lldb-commits] [lldb] [lldb] Use if-with-initializer pattern in SBTarget (NFC) (PR #141284)

2025-05-28 Thread Pavel Labath via lldb-commits
@@ -1926,20 +1863,21 @@ SBValueList SBTarget::FindGlobalVariables(const char *name, SBValueList sb_value_list; - TargetSP target_sp(GetSP()); - if (name && target_sp) { -VariableList variable_list; -target_sp->GetImages().FindGlobalVariables(ConstString(name), ma

[Lldb-commits] [lldb] [lldb] Use if-with-initializer pattern in SBTarget (NFC) (PR #141284)

2025-05-28 Thread Pavel Labath via lldb-commits
@@ -1593,11 +1545,12 @@ SBModule SBTarget::FindModule(const SBFileSpec &sb_file_spec) { LLDB_INSTRUMENT_VA(this, sb_file_spec); SBModule sb_module; - TargetSP target_sp(GetSP()); - if (target_sp && sb_file_spec.IsValid()) { -ModuleSpec module_spec(*sb_file_spec); -

[Lldb-commits] [lldb] [lldb] Use if-with-initializer pattern in SBTarget (NFC) (PR #141284)

2025-05-28 Thread Pavel Labath via lldb-commits
@@ -1113,10 +1082,11 @@ SBBreakpoint SBTarget::FindBreakpointByID(break_id_t bp_id) { LLDB_INSTRUMENT_VA(this, bp_id); SBBreakpoint sb_breakpoint; - TargetSP target_sp(GetSP()); - if (target_sp && bp_id != LLDB_INVALID_BREAK_ID) { -std::lock_guard guard(target_sp->G

[Lldb-commits] [lldb] [lldb] Use if-with-initializer pattern in SBTarget (NFC) (PR #141284)

2025-05-28 Thread Pavel Labath via lldb-commits
@@ -1954,41 +1892,42 @@ SBValueList SBTarget::FindGlobalVariables(const char *name, SBValueList sb_value_list; - TargetSP target_sp(GetSP()); - if (name && target_sp) { -llvm::StringRef name_ref(name); -VariableList variable_list; + if (TargetSP target_sp = GetS

[Lldb-commits] [lldb] [lldb] Use if-with-initializer pattern in SBTarget (NFC) (PR #141284)

2025-05-28 Thread Pavel Labath via lldb-commits
@@ -1887,34 +1823,35 @@ lldb::SBTypeList SBTarget::FindTypes(const char *typename_cstr) { LLDB_INSTRUMENT_VA(this, typename_cstr); SBTypeList sb_type_list; - TargetSP target_sp(GetSP()); - if (typename_cstr && typename_cstr[0] && target_sp) { -ModuleList &images = t

[Lldb-commits] [lldb] [lldb] Use if-with-initializer pattern in SBTarget (NFC) (PR #141284)

2025-05-28 Thread Pavel Labath via lldb-commits
@@ -1606,66 +1559,60 @@ SBSymbolContextList SBTarget::FindCompileUnits(const SBFileSpec &sb_file_spec) { LLDB_INSTRUMENT_VA(this, sb_file_spec); SBSymbolContextList sb_sc_list; - const TargetSP target_sp(GetSP()); - if (target_sp && sb_file_spec.IsValid()) -target_s

[Lldb-commits] [lldb] [lldb] Use if-with-initializer pattern in SBTarget (NFC) (PR #141284)

2025-05-28 Thread Pavel Labath via lldb-commits
https://github.com/labath approved this pull request. https://github.com/llvm/llvm-project/pull/141284 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Use if-with-initializer pattern in SBTarget (NFC) (PR #141284)

2025-05-28 Thread Pavel Labath via lldb-commits
@@ -1841,31 +1776,33 @@ lldb::SBSymbolContextList SBTarget::FindGlobalFunctions(const char *name, lldb::SBType SBTarget::FindFirstType(const char *typename_cstr) { LLDB_INSTRUMENT_VA(this, typename_cstr); - TargetSP target_sp(GetSP()); - if (typename_cstr && typename_cstr

[Lldb-commits] [lldb] [lldb] Use if-with-initializer pattern in SBTarget (NFC) (PR #141284)

2025-05-28 Thread Pavel Labath via lldb-commits
@@ -1355,29 +1312,30 @@ SBTarget::WatchpointCreateByAddress(lldb::addr_t addr, size_t size, SBWatchpoint sb_watchpoint; lldb::WatchpointSP watchpoint_sp; - TargetSP target_sp(GetSP()); - uint32_t watch_type = 0; - if (options.GetWatchpointTypeRead()) -watch_type |=

[Lldb-commits] [lldb] [lldb] Use if-with-initializer pattern in SBTarget (NFC) (PR #141284)

2025-05-28 Thread Pavel Labath via lldb-commits
@@ -2393,62 +2321,53 @@ lldb::addr_t SBTarget::GetStackRedZoneSize() { bool SBTarget::IsLoaded(const SBModule &module) const { LLDB_INSTRUMENT_VA(this, module); - TargetSP target_sp(GetSP()); - if (!target_sp) -return false; - - ModuleSP module_sp(module.GetSP()); -

[Lldb-commits] [lldb] 4528942 - [lldb] Make AddressRange dump easier on the eye (#141062)

2025-05-28 Thread via lldb-commits
Author: Pavel Labath Date: 2025-05-28T09:02:36+02:00 New Revision: 452894207ae28cde9c22e2935df2d960fa7585a9 URL: https://github.com/llvm/llvm-project/commit/452894207ae28cde9c22e2935df2d960fa7585a9 DIFF: https://github.com/llvm/llvm-project/commit/452894207ae28cde9c22e2935df2d960fa7585a9.diff

[Lldb-commits] [lldb] 3d0f885 - [AArch64][LLDB] Add missing AArch64SVEACLETypes.def rename

2025-05-28 Thread David Green via lldb-commits
Author: David Green Date: 2025-05-28T13:16:25+01:00 New Revision: 3d0f88552a43533799d9bf24cf4f61c89dd8af46 URL: https://github.com/llvm/llvm-project/commit/3d0f88552a43533799d9bf24cf4f61c89dd8af46 DIFF: https://github.com/llvm/llvm-project/commit/3d0f88552a43533799d9bf24cf4f61c89dd8af46.diff L

[Lldb-commits] [libcxx] [lldb] [libc++][lldb-dap][test] Fix CI for bootstrapping-build (PR #141543)

2025-05-28 Thread A. Jiang via lldb-commits
https://github.com/frederick-vs-ja updated https://github.com/llvm/llvm-project/pull/141543 >From 75f0f1463c7bcabb5ffef34c0f1e1c0b4ca91b04 Mon Sep 17 00:00:00 2001 From: "A. Jiang" Date: Tue, 27 May 2025 12:10:36 +0800 Subject: [PATCH 1/2] [libc++][lldb-dap][test] Fix CI for bootstrapping-build

[Lldb-commits] [lldb] [lldb][AIX] Added XCOFF ParseSymtab handling (PR #141577)

2025-05-28 Thread Dhruv Srivastava via lldb-commits
https://github.com/DhruvSrivastavaX updated https://github.com/llvm/llvm-project/pull/141577 >From a62cd7b510f3cf74ee356a95a26e0f9922f4b39c Mon Sep 17 00:00:00 2001 From: DhruvSrivastavaX Date: Tue, 27 May 2025 05:44:55 -0500 Subject: [PATCH 1/2] Added XCOFF ParseSymtab handling --- .../Objec

[Lldb-commits] [lldb] [lldb] Expose language plugin commands based based on language of current frame (PR #136766)

2025-05-28 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl approved this pull request. https://github.com/llvm/llvm-project/pull/136766 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 7ed185a - [lldb] Expose language plugin commands based based on language of current frame (#136766)

2025-05-28 Thread via lldb-commits
Author: Dave Lee Date: 2025-05-28T11:04:57-07:00 New Revision: 7ed185a8f2b9f2436db1ccd82964424f641917e9 URL: https://github.com/llvm/llvm-project/commit/7ed185a8f2b9f2436db1ccd82964424f641917e9 DIFF: https://github.com/llvm/llvm-project/commit/7ed185a8f2b9f2436db1ccd82964424f641917e9.diff LOG:

[Lldb-commits] [lldb] [lldb] Expose language plugin commands based based on language of current frame (PR #136766)

2025-05-28 Thread Dave Lee via lldb-commits
https://github.com/kastiglione closed https://github.com/llvm/llvm-project/pull/136766 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Show more children of top level values (PR #140938)

2025-05-28 Thread Dave Lee via lldb-commits
https://github.com/kastiglione updated https://github.com/llvm/llvm-project/pull/140938 >From f07c408bcbc221e69f56459d0cca27a27ed8551c Mon Sep 17 00:00:00 2001 From: Dave Lee Date: Wed, 21 May 2025 09:44:16 -0700 Subject: [PATCH 1/3] [lldb] Show more children of top level values This changes p

[Lldb-commits] [libcxx] [lldb] [libc++][lldb-dap][test] Fix CI for bootstrapping-build (PR #141543)

2025-05-28 Thread Louis Dionne via lldb-commits
ldionne wrote: I'm going to land this to attempt to unbreak libc++'s CI, which is in a really bad shape right now. From the comments above, this seems to have consensus to move forward. https://github.com/llvm/llvm-project/pull/141543 ___ lldb-commit

[Lldb-commits] [lldb] add explicit default initialization to DemangledNameInfo to remove warning (PR #141790)

2025-05-28 Thread Kazu Hirata via lldb-commits
kazutakahirata wrote: @charles-zablit I've verified that this PR fixes `check-lldb-unit` in my local build. Thank you for fixing this! https://github.com/llvm/llvm-project/pull/141790 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://

[Lldb-commits] [lldb] 4304d90 - [libc++][lldb-dap][test] Fix CI for bootstrapping-build (#141543)

2025-05-28 Thread via lldb-commits
Author: A. Jiang Date: 2025-05-28T14:30:45-04:00 New Revision: 4304d90f0ac171f86c26d7d2da4fd03b336957bb URL: https://github.com/llvm/llvm-project/commit/4304d90f0ac171f86c26d7d2da4fd03b336957bb DIFF: https://github.com/llvm/llvm-project/commit/4304d90f0ac171f86c26d7d2da4fd03b336957bb.diff LOG:

[Lldb-commits] [libcxx] [lldb] [libc++][lldb-dap][test] Fix CI for bootstrapping-build (PR #141543)

2025-05-28 Thread Louis Dionne via lldb-commits
https://github.com/ldionne closed https://github.com/llvm/llvm-project/pull/141543 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [libcxx] [lldb] [libc++][lldb-dap][test] Fix CI for bootstrapping-build (PR #141543)

2025-05-28 Thread Louis Dionne via lldb-commits
ldionne wrote: Thanks a lot for investigating this folks, in particular @frederick-vs-ja for jumping on the issue to restore libc++'s CI. https://github.com/llvm/llvm-project/pull/141543 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https:

[Lldb-commits] [lldb] [lldb][Formatters] Add --pointer-match-depth option to `type summary add` command. (PR #138209)

2025-05-28 Thread Zequan Wu via lldb-commits
ZequanWu wrote: Ping. https://github.com/llvm/llvm-project/pull/138209 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [libcxx] [lldb] [libc++][lldb-dap][test] Fix CI for bootstrapping-build (PR #141543)

2025-05-28 Thread Louis Dionne via lldb-commits
https://github.com/ldionne updated https://github.com/llvm/llvm-project/pull/141543 >From 75f0f1463c7bcabb5ffef34c0f1e1c0b4ca91b04 Mon Sep 17 00:00:00 2001 From: "A. Jiang" Date: Tue, 27 May 2025 12:10:36 +0800 Subject: [PATCH 1/3] [libc++][lldb-dap][test] Fix CI for bootstrapping-build --- l

[Lldb-commits] [lldb] [lldb][Formatters] Add --pointer-match-depth option to `type summary add` command. (PR #138209)

2025-05-28 Thread via lldb-commits
https://github.com/jimingham approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/138209 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Reuse source object logics (PR #141426)

2025-05-28 Thread via lldb-commits
@@ -58,6 +59,9 @@ class LLDB_API SBAddress { // "lldb::SBAddress SBTarget::ResolveLoadAddress (...)". lldb::SBSymbolContext GetSymbolContext(uint32_t resolve_scope); + lldb::SBSymbolContext GetSymbolContext(const SBTarget &target, +

[Lldb-commits] [lldb] [lldb] Refactor away UB in SBValue::GetLoadAddress (PR #141799)

2025-05-28 Thread via lldb-commits
jimingham wrote: It always makes me a little sad to see `.first` or `.second` showing up - they are so non-self-documenting. How horrible would this be if you used a `struct AddrAndType { AddressType type; lldb::addr_t address}` (I'm a bit surprised we don't have one already) instead so that

[Lldb-commits] [lldb] [lldb][RPC] Upstream Python scripts (PR #138028)

2025-05-28 Thread Chelsea Cassanova via lldb-commits
chelcassanova wrote: I think this could be ready to land now @DavidSpickett and @JDevlieghere, could you give this another once over? https://github.com/llvm/llvm-project/pull/138028 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://li

[Lldb-commits] [lldb] add explicit default initialization to DemangledNameInfo to remove warning (PR #141790)

2025-05-28 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. Thanks! LGTM. https://github.com/llvm/llvm-project/pull/141790 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Show more children of top level values (PR #140938)

2025-05-28 Thread Dave Lee via lldb-commits
kastiglione wrote: I've updated the help description for `max-children-count` to reflect how it is applied. https://github.com/llvm/llvm-project/pull/140938 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailm

[Lldb-commits] [lldb] [lldb] Show more children of top level values (PR #140938)

2025-05-28 Thread Dave Lee via lldb-commits
https://github.com/kastiglione updated https://github.com/llvm/llvm-project/pull/140938 >From f07c408bcbc221e69f56459d0cca27a27ed8551c Mon Sep 17 00:00:00 2001 From: Dave Lee Date: Wed, 21 May 2025 09:44:16 -0700 Subject: [PATCH 1/2] [lldb] Show more children of top level values This changes p

[Lldb-commits] [lldb] [lldb-dap] Treat empty thread names as unset (PR #141529)

2025-05-28 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: > > (on Windows)? > > That's the hard part 😅. I tried to get > https://github.com/llvm/llvm-project/blob/main/lldb/test/API/tools/lldb-dap/threads/TestDAP_threads.py > to run on Windows, but it's too flaky. From my observation, the debug > adapter is too fast at launching

[Lldb-commits] [lldb] [lldb] Expose language plugin commands based based on language of current frame (PR #136766)

2025-05-28 Thread Dave Lee via lldb-commits
kastiglione wrote: > If would be really cool if when I'm in a C++ frame and I did: > > `(lldb) help demangle` > > I would get a preface like: > > Chosen from 'language cplusplus demangle' because the current frame's > language is cplusplus. I plan to do this in a follow up. Note that `help dem

[Lldb-commits] [lldb] e653dc9 - [lldb] Fix TestFrameLanguageCommands.py build (#141829)

2025-05-28 Thread via lldb-commits
Author: Dave Lee Date: 2025-05-28T12:25:49-07:00 New Revision: e653dc9ca00819dc7767dbde4422e96ddc296d03 URL: https://github.com/llvm/llvm-project/commit/e653dc9ca00819dc7767dbde4422e96ddc296d03 DIFF: https://github.com/llvm/llvm-project/commit/e653dc9ca00819dc7767dbde4422e96ddc296d03.diff LOG:

[Lldb-commits] [lldb] [lldb] Fix TestFrameLanguageCommands.py build (PR #141829)

2025-05-28 Thread Dave Lee via lldb-commits
https://github.com/kastiglione closed https://github.com/llvm/llvm-project/pull/141829 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix TestFrameLanguageCommands.py build (PR #141829)

2025-05-28 Thread Dave Lee via lldb-commits
https://github.com/kastiglione edited https://github.com/llvm/llvm-project/pull/141829 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix TestFrameLanguageCommands.py build (PR #141829)

2025-05-28 Thread Dave Lee via lldb-commits
https://github.com/kastiglione created https://github.com/llvm/llvm-project/pull/141829 None >From f46ad6b01c84dce72cf1547acd2a877f4a8b1dbe Mon Sep 17 00:00:00 2001 From: Dave Lee Date: Wed, 28 May 2025 12:24:16 -0700 Subject: [PATCH] [lldb] Fix TestFrameLanguageCommands.py build --- lldb/te

[Lldb-commits] [lldb] [lldb] Fix TestFrameLanguageCommands.py build (PR #141829)

2025-05-28 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Dave Lee (kastiglione) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/141829.diff 1 Files Affected: - (modified) lldb/test/API/commands/command/language/Makefile (-1) ``diff diff --git a/lldb/test/API/comman

[Lldb-commits] [lldb] [lldb] Fix TestFrameLanguageCommands.py build (PR #141829)

2025-05-28 Thread Dave Lee via lldb-commits
kastiglione wrote: See https://github.com/llvm/llvm-project/pull/136766 https://github.com/llvm/llvm-project/pull/141829 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][Expression] Remove m_found_function_with_type_info in favour of boolean return (PR #141774)

2025-05-28 Thread Pavel Labath via lldb-commits
https://github.com/labath approved this pull request. :+1: https://github.com/llvm/llvm-project/pull/141774 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][Expression] Remove m_found_function_with_type_info in favour of boolean return (PR #141774)

2025-05-28 Thread Michael Buch via lldb-commits
https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/141774 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][test] Add stack frame padding to fix flaky DIL array subscript test (PR #141738)

2025-05-28 Thread David Spickett via lldb-commits
@@ -19,8 +19,6 @@ def expect_var_path(self, expr, compare_to_framevar=False, value=None, type=None self.runCmd("settings set target.experimental.use-DIL true") self.assertEqual(value_dil.GetValue(), value_frv.GetValue()) -# int_arr[100] sometimes p

[Lldb-commits] [lldb] [LLDB] Avoid crashes when inspecting MSVC STL types (PR #140761)

2025-05-28 Thread via lldb-commits
https://github.com/Nerixyz updated https://github.com/llvm/llvm-project/pull/140761 >From af77293d36a6eeec3d06ded70ebdc2dcc5e97873 Mon Sep 17 00:00:00 2001 From: Nerixyz Date: Wed, 21 May 2025 17:32:48 +0200 Subject: [PATCH] [LLDB] Avoid crashes when inspecting MS STL types --- .../Language/C

[Lldb-commits] [lldb] [LLDB] Pass `/std:...` before `--` on MSVC (PR #141782)

2025-05-28 Thread via lldb-commits
https://github.com/Nerixyz created https://github.com/llvm/llvm-project/pull/141782 >From https://github.com/llvm/llvm-project/pull/140761. `MsvcBuilder` passed >`/std:` (if specified) after `--`, so the compiler would interpret this >as a file. This moves the argument before the `--`. >From

[Lldb-commits] [lldb] [LLDB] Pass `/std:...` before `--` on MSVC (PR #141782)

2025-05-28 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: nerix (Nerixyz) Changes >From https://github.com/llvm/llvm-project/pull/140761. `MsvcBuilder` passed >`/std:` (if specified) after `--`, so the compiler would >interpret this as a file. This moves the argument before the `--`. ---

[Lldb-commits] [lldb] [LLDB] Avoid crashes when inspecting MSVC STL types (PR #140761)

2025-05-28 Thread via lldb-commits
@@ -683,14 +683,14 @@ def _get_compilation_command(self, source, obj): args.append("-fms-compatibility-version=19") args.append("/c") +if self.std: Nerixyz wrote: Sorry, I should've asked if it's supposed to be a separate PR or com

[Lldb-commits] [lldb] [LLDB] Pass `/std:...` before `--` on MSVC (PR #141782)

2025-05-28 Thread Michael Buch via lldb-commits
https://github.com/Michael137 approved this pull request. https://github.com/llvm/llvm-project/pull/141782 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Use if-with-initializer pattern in SBTarget (NFC) (PR #141284)

2025-05-28 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/141284 >From 2735f5ad08bd6ac5bdf31104af452f6a1abf0920 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Fri, 23 May 2025 12:20:52 -0700 Subject: [PATCH 1/2] [lldb] Use if-with-initializer pattern in SBTarget

[Lldb-commits] [lldb] add explicit default initialization to DemangledNameInfo to remove warning (PR #141790)

2025-05-28 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: The warning in question is `-Wmissing-field-initializers`, which is warning that in the unit test not all fields of this struct are explicitly initialized. Even if these fields are optional, I think this is the wrong way to address this: we should either update the unit tes

[Lldb-commits] [lldb] [lldb][headers] Create script to fix up versioning (PR #141116)

2025-05-28 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova updated https://github.com/llvm/llvm-project/pull/141116 >From 40793cd53f94744ee157865b579ff01eb5776f59 Mon Sep 17 00:00:00 2001 From: Chelsea Cassanova Date: Thu, 22 May 2025 11:00:06 -0700 Subject: [PATCH] [lldb][headers] Create script to fix up versioning Th

[Lldb-commits] [lldb] 02916a4 - [lldb][Formatters] Add --pointer-match-depth option to `type summary add` command. (#138209)

2025-05-28 Thread via lldb-commits
Author: Zequan Wu Date: 2025-05-28T16:04:24-04:00 New Revision: 02916a432ca6465e2e45f67be94f1c89c9cd425d URL: https://github.com/llvm/llvm-project/commit/02916a432ca6465e2e45f67be94f1c89c9cd425d DIFF: https://github.com/llvm/llvm-project/commit/02916a432ca6465e2e45f67be94f1c89c9cd425d.diff LOG

[Lldb-commits] [lldb] [lldb][Formatters] Add --pointer-match-depth option to `type summary add` command. (PR #138209)

2025-05-28 Thread Zequan Wu via lldb-commits
https://github.com/ZequanWu closed https://github.com/llvm/llvm-project/pull/138209 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][Formatters] Do not recursively dereference pointer type when creating formatter candicates list. (PR #124048)

2025-05-28 Thread Zequan Wu via lldb-commits
https://github.com/ZequanWu closed https://github.com/llvm/llvm-project/pull/124048 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][Formatters] Do not recursively dereference pointer type when creating formatter candicates list. (PR #124048)

2025-05-28 Thread Zequan Wu via lldb-commits
ZequanWu wrote: Closed this as #138209 is preferred. https://github.com/llvm/llvm-project/pull/124048 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Reuse source object logics (PR #141426)

2025-05-28 Thread Ely Ronnen via lldb-commits
https://github.com/eronnen updated https://github.com/llvm/llvm-project/pull/141426 >From 79a0a7b83360a517b090dad297ccb5a5a7849d0f Mon Sep 17 00:00:00 2001 From: Ely Ronnen Date: Wed, 21 May 2025 23:39:56 +0200 Subject: [PATCH 1/4] Reuse creation of Source objects for assembly and normal sourc

[Lldb-commits] [lldb] [lldb-dap] Reuse source object logics (PR #141426)

2025-05-28 Thread Ely Ronnen via lldb-commits
@@ -58,6 +59,9 @@ class LLDB_API SBAddress { // "lldb::SBAddress SBTarget::ResolveLoadAddress (...)". lldb::SBSymbolContext GetSymbolContext(uint32_t resolve_scope); + lldb::SBSymbolContext GetSymbolContext(const SBTarget &target, +

[Lldb-commits] [lldb] add explicit default initialization to DemangledNameInfo to remove warning (PR #141790)

2025-05-28 Thread Charles Zablit via lldb-commits
charles-zablit wrote: Please feel free to merge when possible, as I do not have commit access yet. https://github.com/llvm/llvm-project/pull/141790 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinf

[Lldb-commits] [lldb] 711a177 - add explicit default initialization to DemangledNameInfo to remove warning (#141790)

2025-05-28 Thread via lldb-commits
Author: Charles Zablit Date: 2025-05-28T21:41:45+01:00 New Revision: 711a1779dcb4ed5616d5727d990b642a3593855f URL: https://github.com/llvm/llvm-project/commit/711a1779dcb4ed5616d5727d990b642a3593855f DIFF: https://github.com/llvm/llvm-project/commit/711a1779dcb4ed5616d5727d990b642a3593855f.diff

[Lldb-commits] [lldb] add explicit default initialization to DemangledNameInfo to remove warning (PR #141790)

2025-05-28 Thread Michael Buch via lldb-commits
https://github.com/Michael137 closed https://github.com/llvm/llvm-project/pull/141790 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Test Gardening, improving DebugCommunication. (PR #141689)

2025-05-28 Thread John Harrison via lldb-commits
https://github.com/ashgti updated https://github.com/llvm/llvm-project/pull/141689 >From ad0a9cd321d260cd87b852b335da9565f8326449 Mon Sep 17 00:00:00 2001 From: John Harrison Date: Tue, 27 May 2025 16:40:10 -0700 Subject: [PATCH 1/2] [lldb-dap] Test Gardening, improving DebugCommunication. Imp

[Lldb-commits] [lldb] [lldb-dap] Reuse source object logics (PR #141426)

2025-05-28 Thread John Harrison via lldb-commits
@@ -58,6 +59,9 @@ class LLDB_API SBAddress { // "lldb::SBAddress SBTarget::ResolveLoadAddress (...)". lldb::SBSymbolContext GetSymbolContext(uint32_t resolve_scope); + lldb::SBSymbolContext GetSymbolContext(const SBTarget &target, +

[Lldb-commits] [lldb] [lldb-dap] Reuse source object logics (PR #141426)

2025-05-28 Thread John Harrison via lldb-commits
ashgti wrote: nit: Should this live in the lldb-dap top level folder? I could go either way on that, but it matches the existing helpers. https://github.com/llvm/llvm-project/pull/141426 ___ lldb-commits mailing list

[Lldb-commits] [lldb] [lldb-dap] Test Gardening, improving DebugCommunication. (PR #141689)

2025-05-28 Thread John Harrison via lldb-commits
@@ -104,6 +103,17 @@ def waitUntil(self, condition_callback): time.sleep(0.5) return False +def assertResponseSuccess(self, response: Response): +self.assertIsNotNone(response) +if not response.get("success", False): ash

  1   2   >