[Lldb-commits] [lldb] [lldb][CPlusPlusLanguage] Create public accessors for getting DemangledNameInfo components and use them in tests (PR #152134)

2025-08-05 Thread Charles Zablit via lldb-commits
https://github.com/charles-zablit approved this pull request. https://github.com/llvm/llvm-project/pull/152134 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] ab6923b - [lldb] add TemplateRange and NameQualifiersRange to DemangledNameInfo (#150999)

2025-08-05 Thread via lldb-commits
Author: Charles Zablit Date: 2025-08-05T14:07:35+02:00 New Revision: ab6923b9b7a75de79ee06b400ae73771e130339e URL: https://github.com/llvm/llvm-project/commit/ab6923b9b7a75de79ee06b400ae73771e130339e DIFF: https://github.com/llvm/llvm-project/commit/ab6923b9b7a75de79ee06b400ae73771e130339e.diff

[Lldb-commits] [lldb] [lldb] add TemplateRange and NameQualifiersRange to DemangledNameInfo (PR #150999)

2025-08-05 Thread Charles Zablit via lldb-commits
https://github.com/charles-zablit closed https://github.com/llvm/llvm-project/pull/150999 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][CPlusPlusLanguage] Create public accessors for getting DemangledNameInfo components and use them in tests (PR #152134)

2025-08-05 Thread Michael Buch via lldb-commits
https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/152134 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Update JSONTransport to use MainLoop for reading. (PR #148300)

2025-08-05 Thread LLVM Continuous Integration via lldb-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `lldb-x86_64-win` running on `as-builder-10` while building `lldb` at step 8 "test-check-lldb-unit". Full details are available at: https://lab.llvm.org/buildbot/#/builders/211/builds/1101 Here is the relevant piece of the bu

[Lldb-commits] [lldb] [vscode-lldb] Fix `yarn package` (PR #152002)

2025-08-05 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: > Asking just for this first time: In this code base (vscode-lldb), do you > recommend me to go ahead and merge with your approval, or should I wait for > @JDevlieghere to take a look, too? Thanks for asking! The [Code Review Policy](https://llvm.org/docs/CodeReview.html#l

[Lldb-commits] [lldb] [LLDB] Complete a missing register format mapping in the gdb-remote p… (PR #152170)

2025-08-05 Thread Walter Erquinigo via lldb-commits
https://github.com/walter-erquinigo created https://github.com/llvm/llvm-project/pull/152170 …rotocol When writing a custom gdb-remote server I realized that the encoder and decoder of register formats is incomplete. - Add the encoder on the server side and add an llvm_unreachable is there's

[Lldb-commits] [lldb] [LLDB] Complete a missing register format mapping in the gdb-remote p… (PR #152170)

2025-08-05 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Walter Erquinigo (walter-erquinigo) Changes …rotocol When writing a custom gdb-remote server I realized that the encoder and decoder of register formats is incomplete. - Add the encoder on the server side and add an llvm_unreachable is th

[Lldb-commits] [lldb] [lldb] Fix object format in the Triple of Mach-O files (approach 3) (PR #144177)

2025-08-05 Thread via lldb-commits
https://github.com/royitaqi closed https://github.com/llvm/llvm-project/pull/144177 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [llvm] [lldb] Fix object format in the Triple of Mach-O files (approach 2) (PR #143633)

2025-08-05 Thread via lldb-commits
https://github.com/royitaqi closed https://github.com/llvm/llvm-project/pull/143633 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [Minidump] Update Minidump file builder to continue when the Module's section cannot be found (PR #152009)

2025-08-05 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff HEAD~1 HEAD --extensions cpp -- lldb/source/Plugins/ObjectFile/Minidump/MinidumpFileB

[Lldb-commits] [lldb] [vscode-lldb] Add VS Code commands for high level debug workflow (PR #151827)

2025-08-05 Thread via lldb-commits
royitaqi wrote: @walter-erquinigo > Please write a section in the lldb-dap documentation on how to integrate with > other debugger extensions via these commands? That was a great suggestion. Added text to near the end of the `README.md`. Please feel free to LMK if you have different wording/f

[Lldb-commits] [lldb] [lldb][CPlusPlusLanguage] Create public accessors for getting DemangledNameInfo components and use them in tests (PR #152134)

2025-08-05 Thread Michael Buch via lldb-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/152134 >From d8d8e1dccecb941ff44cd820c0a8f6f238ec6726 Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Tue, 5 Aug 2025 17:37:39 +0100 Subject: [PATCH] [lldb][CPlusPlusLanguage] Create public accessors for getting

[Lldb-commits] [lldb] [vscode-lldb] Add VS Code commands for high level debug workflow (PR #151827)

2025-08-05 Thread via lldb-commits
https://github.com/royitaqi updated https://github.com/llvm/llvm-project/pull/151827 >From 14c3fc997de307c00199e22e23b2f665147964fc Mon Sep 17 00:00:00 2001 From: Roy Shi Date: Sat, 2 Aug 2025 09:04:18 -0700 Subject: [PATCH 1/2] [lldb] [vscode-lldb] Add VS Code commands that can be leveraged b

[Lldb-commits] [lldb] [vscode-lldb] Add VS Code commands for high level debug workflow (PR #151827)

2025-08-05 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: > @walter-erquinigo > > > Please write a section in the lldb-dap documentation on how to integrate > > with other debugger extensions via these commands? > > That was a great suggestion. Added text to near the end of the `README.md`. > Please feel free to LMK if you have d

[Lldb-commits] [lldb] [lldb] Use Python Bytes instead of Buffer for Binary I/O (NFC) (PR #152031)

2025-08-05 Thread Alex Langford via lldb-commits
https://github.com/bulbazord approved this pull request. https://github.com/llvm/llvm-project/pull/152031 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][rpc] Add sysroot to lldb-rpc-gen test suite invocation (PR #151291)

2025-08-05 Thread Chelsea Cassanova via lldb-commits
chelcassanova wrote: > Was this always happening before? Yes, so we had to disable the tests downstream. Giving this patch another look though, I think this can be closed and we can run the tests for RPC without needing this extra infrastructure. There's 2 main reasons that we would need this

[Lldb-commits] [lldb] [LLDB] Complete a missing register format mapping in the gdb-remote p… (PR #152170)

2025-08-05 Thread Greg Clayton via lldb-commits
https://github.com/clayborg approved this pull request. FYI: This could be upstreamed now https://github.com/llvm/llvm-project/pull/152170 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-co

[Lldb-commits] [lldb] [lldb] Introduce ScriptedFrame (PR #149622)

2025-08-05 Thread Med Ismail Bennani via lldb-commits
@@ -0,0 +1,192 @@ +//===-- ScriptedFrame.cpp -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [lldb] Guard SBFrame/SBThread methods against running processes (PR #152020)

2025-08-05 Thread Felipe de Azevedo Piovezan via lldb-commits
https://github.com/felipepiovezan updated https://github.com/llvm/llvm-project/pull/152020 >From 9be92f8ead1294cc1931fe68c13dbaa8c5945423 Mon Sep 17 00:00:00 2001 From: Felipe de Azevedo Piovezan Date: Mon, 4 Aug 2025 08:32:20 -0700 Subject: [PATCH 1/2] [lldb] Guard SBFrame/SBThread methods aga

[Lldb-commits] [lldb] [lldb] Introduce ScriptedFrame (PR #149622)

2025-08-05 Thread Med Ismail Bennani via lldb-commits
@@ -0,0 +1,192 @@ +//===-- ScriptedFrame.cpp -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [lldb] Introduce ScriptedFrame (PR #149622)

2025-08-05 Thread Med Ismail Bennani via lldb-commits
@@ -0,0 +1,192 @@ +//===-- ScriptedFrame.cpp -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [Minidump] Update Minidump file builder to continue when the Module's section cannot be found (PR #152009)

2025-08-05 Thread via lldb-commits
https://github.com/barsolo2000 updated https://github.com/llvm/llvm-project/pull/152009 >From 91ad83c794eeaed56297aa43a6d36e8c7572e18e Mon Sep 17 00:00:00 2001 From: Bar Soloveychik Date: Mon, 4 Aug 2025 10:13:37 -0700 Subject: [PATCH 1/6] Update Minidump file builder to continue when the Modu

[Lldb-commits] [lldb] [lldb] Introduce ScriptedFrame (PR #149622)

2025-08-05 Thread Med Ismail Bennani via lldb-commits
@@ -0,0 +1,192 @@ +//===-- ScriptedFrame.cpp -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [Minidump] Update Minidump file builder to continue when the Module's section cannot be found (PR #152009)

2025-08-05 Thread via lldb-commits
https://github.com/barsolo2000 updated https://github.com/llvm/llvm-project/pull/152009 >From 91ad83c794eeaed56297aa43a6d36e8c7572e18e Mon Sep 17 00:00:00 2001 From: Bar Soloveychik Date: Mon, 4 Aug 2025 10:13:37 -0700 Subject: [PATCH 1/6] Update Minidump file builder to continue when the Modu

[Lldb-commits] [lldb] [lldb] Introduce ScriptedFrame (PR #149622)

2025-08-05 Thread Med Ismail Bennani via lldb-commits
@@ -204,9 +209,64 @@ bool ScriptedThread::LoadArtificialStackFrames() { SymbolContext sc; symbol_addr.CalculateSymbolContext(&sc); -StackFrameSP synth_frame_sp = std::make_shared( +return std::make_shared( this->shared_from_this(), idx, idx, cfa, cfa_i

[Lldb-commits] [lldb] [lldb] Guard SBFrame/SBThread methods against running processes (PR #152020)

2025-08-05 Thread Felipe de Azevedo Piovezan via lldb-commits
felipepiovezan wrote: I think I've addressed the vast majority of comments here. @jimingham I may have added "error messages" at a finer granularity than what you were expecting in the constructor. Were you thinking of limiting it to _only_ when we had a process and it was not stopped? If so,

[Lldb-commits] [lldb] [lldb] Guard SBFrame/SBThread methods against running processes (PR #152020)

2025-08-05 Thread Felipe de Azevedo Piovezan via lldb-commits
@@ -782,27 +809,26 @@ SBValueList SBFrame::GetVariables(const lldb::SBVariablesOptions &options) { SBValueList value_list; std::unique_lock lock; - ExecutionContext exe_ctx(m_opaque_sp.get(), lock); + Process::StopLocker stop_locker; felipepiovezan wrot

[Lldb-commits] [lldb] [lldb] Guard SBFrame/SBThread methods against running processes (PR #152020)

2025-08-05 Thread Felipe de Azevedo Piovezan via lldb-commits
@@ -125,17 +125,21 @@ ExecutionContext::ExecutionContext(const ExecutionContextRef *exe_ctx_ref_ptr, } } -ExecutionContext::ExecutionContext(const ExecutionContextRef *exe_ctx_ref_ptr, - std::unique_lock &lock) +ExecutionContext::Execution

[Lldb-commits] [lldb] [lldb] Guard SBFrame/SBThread methods against running processes (PR #152020)

2025-08-05 Thread Felipe de Azevedo Piovezan via lldb-commits
@@ -125,17 +125,21 @@ ExecutionContext::ExecutionContext(const ExecutionContextRef *exe_ctx_ref_ptr, } } -ExecutionContext::ExecutionContext(const ExecutionContextRef *exe_ctx_ref_ptr, - std::unique_lock &lock) +ExecutionContext::Execution

[Lldb-commits] [lldb] [lldb] Guard SBFrame/SBThread methods against running processes (PR #152020)

2025-08-05 Thread Felipe de Azevedo Piovezan via lldb-commits
@@ -139,19 +140,19 @@ SBModule SBFrame::GetModule() const { SBModule sb_module; ModuleSP module_sp; std::unique_lock lock; - ExecutionContext exe_ctx(m_opaque_sp.get(), lock); + Process::StopLocker stop_locker; + ExecutionContext exe_ctx(m_opaque_sp.get(), lock, stop_l

[Lldb-commits] [lldb] [lldb] Guard SBFrame/SBThread methods against running processes (PR #152020)

2025-08-05 Thread Felipe de Azevedo Piovezan via lldb-commits
@@ -981,7 +1018,10 @@ SBError SBThread::UnwindInnermostExpression() { SBError sb_error; std::unique_lock lock; - ExecutionContext exe_ctx(m_opaque_sp.get(), lock); + Process::StopLocker stop_locker; + ExecutionContext exe_ctx(m_opaque_sp.get(), lock, stop_locker); + if

[Lldb-commits] [lldb] [lldb] Move the generic MCP code into Protocol/MCP (NFC) (PR #152188)

2025-08-05 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere created https://github.com/llvm/llvm-project/pull/152188 This moves all the generic MCP code into the new ProtocolMCP library so it can be shared between the MCP implementation in LLDB (built on the private API) and lldb-mcp (built on the public API). This PR d

[Lldb-commits] [lldb] [lldb] Move the generic MCP code into Protocol/MCP (NFC) (PR #152188)

2025-08-05 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jonas Devlieghere (JDevlieghere) Changes This moves all the generic MCP code into the new ProtocolMCP library so it can be shared between the MCP implementation in LLDB (built on the private API) and lldb-mcp (built on the public API). Th

[Lldb-commits] [lldb] [vscode-lldb] Add VS Code commands for high level debug workflow (PR #151827)

2025-08-05 Thread via lldb-commits
royitaqi wrote: BTW, how to add to https://lldb.llvm.org/resources/lldbdap.html?Is that something that I do in this PR (which file?), or I don't have access and maybe one of you guys will help with this? https://github.com/llvm/llvm-project/pull/151827

[Lldb-commits] [lldb] [vscode-lldb] Add VS Code commands for high level debug workflow (PR #151827)

2025-08-05 Thread via lldb-commits
https://github.com/royitaqi updated https://github.com/llvm/llvm-project/pull/151827 >From 14c3fc997de307c00199e22e23b2f665147964fc Mon Sep 17 00:00:00 2001 From: Roy Shi Date: Sat, 2 Aug 2025 09:04:18 -0700 Subject: [PATCH 1/3] [lldb] [vscode-lldb] Add VS Code commands that can be leveraged b

[Lldb-commits] [lldb] [vscode-lldb] Add VS Code commands for high level debug workflow (PR #151827)

2025-08-05 Thread via lldb-commits
https://github.com/royitaqi updated https://github.com/llvm/llvm-project/pull/151827 >From 14c3fc997de307c00199e22e23b2f665147964fc Mon Sep 17 00:00:00 2001 From: Roy Shi Date: Sat, 2 Aug 2025 09:04:18 -0700 Subject: [PATCH 1/3] [lldb] [vscode-lldb] Add VS Code commands that can be leveraged b

[Lldb-commits] [lldb] [lldb][rpc] Upstream RPC Client Library Emitters (PR #147655)

2025-08-05 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova updated https://github.com/llvm/llvm-project/pull/147655 >From 431333fb171671a508999ef5e5e9677f0f3c6a1a Mon Sep 17 00:00:00 2001 From: Chelsea Cassanova Date: Thu, 24 Jul 2025 14:05:55 -0700 Subject: [PATCH 1/4] [lldb][rpc] Add RPC client library tests Adds she

[Lldb-commits] [lldb] [vscode-lldb] Add VS Code commands for high level debug workflow (PR #151827)

2025-08-05 Thread via lldb-commits
kusmour wrote: > BTW, how to add to https://lldb.llvm.org/resources/lldbdap.html? Is that > something that I do in this PR (which file?), or I don't have access and > maybe one of you guys will help with this? The page source is this: https://github.com/llvm/llvm-project/edit/main/lldb/docs/r

[Lldb-commits] [lldb] [LLDB][NativePDB] Use undecorated name for types if UniqueName isn't mangled (PR #152114)

2025-08-05 Thread via lldb-commits
https://github.com/Nerixyz updated https://github.com/llvm/llvm-project/pull/152114 >From 9818fda9a4254196a18285b5a8d87fd4b25dedbf Mon Sep 17 00:00:00 2001 From: Nerixyz Date: Tue, 5 Aug 2025 11:53:55 +0200 Subject: [PATCH 1/2] [LLDB][NativePDB] Use undecorated name for types if UniqueName isn

[Lldb-commits] [lldb] [LLDB][NativePDB] Use undecorated name for types if UniqueName isn't mangled (PR #152114)

2025-08-05 Thread via lldb-commits
Nerixyz wrote: > Can you add a test for this if it's not hard to create one? Found a way to make the IR a bit smaller by compiling an rlib with a `main()`. https://github.com/llvm/llvm-project/pull/152114 ___ lldb-commits mailing list lldb-commits@lis

[Lldb-commits] [lldb] [lldb] Move the generic MCP code into Protocol/MCP (NFC) (PR #152188)

2025-08-05 Thread John Harrison via lldb-commits
https://github.com/ashgti approved this pull request. https://github.com/llvm/llvm-project/pull/152188 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Move the generic MCP code into Protocol/MCP (NFC) (PR #152188)

2025-08-05 Thread John Harrison via lldb-commits
@@ -8,10 +8,12 @@ #include "lldb/Protocol/MCP/Protocol.h" #include "llvm/Support/Error.h" -#include "llvm/Support/FormatVariadic.h" #include -namespace lldb_private::mcp { +#ifndef LLDB_PROTOCOL_MCP_MCPERROR_H +#define LLDB_PROTOCOL_MCP_MCPERROR_H ashgti w

[Lldb-commits] [lldb] [lldb] Move the generic MCP code into Protocol/MCP (NFC) (PR #152188)

2025-08-05 Thread John Harrison via lldb-commits
@@ -1,4 +1,4 @@ -//===-- MCPError.h ===// +//===--===// ashgti wrote: Is this not required for the header anymore? If so, thats good to kn

[Lldb-commits] [lldb] f8a4f61 - [lldb] Avoid a crash after selecting an unknown platform (#151803)

2025-08-05 Thread via lldb-commits
Author: Igor Kudrin Date: 2025-08-05T12:42:38-07:00 New Revision: f8a4f61101bbed236adfeca58e59cac4b95afe15 URL: https://github.com/llvm/llvm-project/commit/f8a4f61101bbed236adfeca58e59cac4b95afe15 DIFF: https://github.com/llvm/llvm-project/commit/f8a4f61101bbed236adfeca58e59cac4b95afe15.diff L

[Lldb-commits] [lldb] [lldb] Avoid a crash after selecting an unknown platform (PR #151803)

2025-08-05 Thread Igor Kudrin via lldb-commits
https://github.com/igorkudrin closed https://github.com/llvm/llvm-project/pull/151803 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB][NativePDB] Use undecorated name for types if UniqueName isn't mangled (PR #152114)

2025-08-05 Thread Zequan Wu via lldb-commits
https://github.com/ZequanWu approved this pull request. https://github.com/llvm/llvm-project/pull/152114 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Move the generic MCP code into Protocol/MCP (NFC) (PR #152188)

2025-08-05 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/152188 >From 6519cdaa2339e78ed7f7d5ef58b3978746646b75 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Tue, 5 Aug 2025 11:26:27 -0700 Subject: [PATCH 1/2] [lldb] Move the generic MCP code into Protocol/MCP (

[Lldb-commits] [lldb] [lldb] add TemplateRange and NameQualifiersRange to DemangledNameInfo (PR #150999)

2025-08-05 Thread Michael Buch via lldb-commits
https://github.com/Michael137 approved this pull request. https://github.com/llvm/llvm-project/pull/150999 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB][NativePDB] Use undecorated name for types if UniqueName isn't mangled (PR #152114)

2025-08-05 Thread via lldb-commits
https://github.com/Nerixyz created https://github.com/llvm/llvm-project/pull/152114 Languages other than C/C++ don't necessarily emit mangled names in the `UniqueName` field of type records. Rust specifically emits a unique ID that doesn't contain the name. For example, `(i32, i32)` is emitt

[Lldb-commits] [lldb] [LLDB][NativePDB] Use undecorated name for types if UniqueName isn't mangled (PR #152114)

2025-08-05 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: nerix (Nerixyz) Changes Languages other than C/C++ don't necessarily emit mangled names in the `UniqueName` field of type records. Rust specifically emits a unique ID that doesn't contain the name. For example, `(i32, i32)` is emitted as

[Lldb-commits] [lldb] [lldb] Move MCP protocol into its own library (NFC) (PR #152059)

2025-08-05 Thread David Spickett via lldb-commits
DavidSpickett wrote: > lldb-mcp And this is what exactly? A binary that automatically starts the mcp server and does not show the interactive command line, because you'll be using the mcp server via. some client program like you use lldb-dap via. an IDE. I don't object to that, just not seen

[Lldb-commits] [lldb] [lldb] Add a CMake option to build agains the Python limited API (PR #152034)

2025-08-05 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett approved this pull request. I'm assuming this will be: * Can't enable it now because we use non-limited API things, but will be used locally for fixing that. * Once that's done, enable it where we have SWIG 4.2 * Eventually require SWIG >= 4.2, default to ON * Fo

[Lldb-commits] [lldb] [NFC][lldb] Speed up lookup of shared modules (PR #152054)

2025-08-05 Thread Michael Buch via lldb-commits
Michael137 wrote: > By profiling LLDB debugging a Swift application without a dSYM and a large > amount of .o files, I identified that querying shared modules was the biggest > bottleneck when running "frame variable", and Clang types need to be searched. Could you elaborate why this is Swift

[Lldb-commits] [lldb] [LLDB][NativePDB] Implement `FindNamespace` (PR #151950)

2025-08-05 Thread Michael Buch via lldb-commits
https://github.com/Michael137 approved this pull request. SGTM Would be nice to share code between the PDB plugins, but then again, if we're going to get rid of the PDB plugin, duplicating this bit isn't that big of a deal https://github.com/llvm/llvm-project/pull/151950 _

[Lldb-commits] [lldb] 852cc92 - [LLDB][NativePDB] Implement `FindNamespace` (#151950)

2025-08-05 Thread via lldb-commits
Author: nerix Date: 2025-08-05T11:10:27+01:00 New Revision: 852cc9200f7c7cc76bc61ac2aa42712c94793f0d URL: https://github.com/llvm/llvm-project/commit/852cc9200f7c7cc76bc61ac2aa42712c94793f0d DIFF: https://github.com/llvm/llvm-project/commit/852cc9200f7c7cc76bc61ac2aa42712c94793f0d.diff LOG: [L

[Lldb-commits] [lldb] [LLDB][NativePDB] Implement `FindNamespace` (PR #151950)

2025-08-05 Thread Michael Buch via lldb-commits
https://github.com/Michael137 closed https://github.com/llvm/llvm-project/pull/151950 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 4b31b4e - [lldb][DWARFIndex][NFC] Remove DWARFIndex::IterationActionAdaptor

2025-08-05 Thread Michael Buch via lldb-commits
Author: Michael Buch Date: 2025-08-05T10:30:46+01:00 New Revision: 4b31b4ebdd923dccc89fbb4904a8378658b466a6 URL: https://github.com/llvm/llvm-project/commit/4b31b4ebdd923dccc89fbb4904a8378658b466a6 DIFF: https://github.com/llvm/llvm-project/commit/4b31b4ebdd923dccc89fbb4904a8378658b466a6.diff

[Lldb-commits] [lldb] [lldb][AArch64] Fix arm64 hardware breakpoint/watchpoint to arm32 process. (PR #147198)

2025-08-05 Thread David Spickett via lldb-commits
DavidSpickett wrote: > Once that's in, I will rebase my changes on top. I needed to read them > through carefully anyway, so I can do both at the same time. I want to be > sure I don't drop any Arm/Thumb handling details along the way. I have rebased those changes to include this and found ht

[Lldb-commits] [lldb] [lldb] Update JSONTransport to use MainLoop for reading. (PR #148300)

2025-08-05 Thread LLVM Continuous Integration via lldb-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `lldb-remote-linux-ubuntu` running on `as-builder-9` while building `lldb` at step 15 "test-check-lldb-unit". Full details are available at: https://lab.llvm.org/buildbot/#/builders/195/builds/12836 Here is the relevant piec

[Lldb-commits] [lldb] [lldb][CPlusPlusLanguage] Create public accessors for getting DemangledNameInfo components and use them in tests (PR #152134)

2025-08-05 Thread Charles Zablit via lldb-commits
https://github.com/charles-zablit requested changes to this pull request. https://github.com/llvm/llvm-project/pull/152134 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][CPlusPlusLanguage] Create public accessors for getting DemangledNameInfo components and use them in tests (PR #152134)

2025-08-05 Thread Charles Zablit via lldb-commits
@@ -6,6 +6,8 @@ // //===--===// +#include "Plugins/Language/CPlusPlus/CPlusPlusLanguage.h" +#include "Plugins/Language/CPlusPlus/CPlusPlusNameParser.h" charles-zablit wrote: I think this inc

[Lldb-commits] [lldb] ae7be39 - Logging setup for lldb-dap extension (#146884)

2025-08-05 Thread via lldb-commits
Author: award999 Date: 2025-08-05T08:14:55-07:00 New Revision: ae7be39601496aa8f712672844de82285a227646 URL: https://github.com/llvm/llvm-project/commit/ae7be39601496aa8f712672844de82285a227646 DIFF: https://github.com/llvm/llvm-project/commit/ae7be39601496aa8f712672844de82285a227646.diff LOG:

[Lldb-commits] [lldb] [lldb] Update JSONTransport to use MainLoop for reading. (PR #148300)

2025-08-05 Thread LLVM Continuous Integration via lldb-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `lldb-remote-linux-win` running on `as-builder-10` while building `lldb` at step 16 "test-check-lldb-unit". Full details are available at: https://lab.llvm.org/buildbot/#/builders/197/builds/7757 Here is the relevant piece o

[Lldb-commits] [lldb] c4f7d87 - [lldb] Reimplement PythonObject::Dump using the limited API (#152055)

2025-08-05 Thread via lldb-commits
Author: Jonas Devlieghere Date: 2025-08-05T08:17:01-07:00 New Revision: c4f7d8744ac54bc1ede754e8d10655fb86b47f25 URL: https://github.com/llvm/llvm-project/commit/c4f7d8744ac54bc1ede754e8d10655fb86b47f25 DIFF: https://github.com/llvm/llvm-project/commit/c4f7d8744ac54bc1ede754e8d10655fb86b47f25.d

[Lldb-commits] [lldb] [lldb] Reimplement PythonObject::Dump using the limited API (PR #152055)

2025-08-05 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/152055 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Run API tests with PDB too (PR #149305)

2025-08-05 Thread via lldb-commits
https://github.com/Nerixyz updated https://github.com/llvm/llvm-project/pull/149305 >From a518056df828df3d206d1029875bd576cd9ef568 Mon Sep 17 00:00:00 2001 From: Nerixyz Date: Tue, 5 Aug 2025 17:00:23 +0200 Subject: [PATCH] [LLDB] Run API tests with PDB too --- .../Python/lldbsuite/test/build

[Lldb-commits] [lldb] [LLDB] Run API tests with PDB too (PR #149305)

2025-08-05 Thread via lldb-commits
https://github.com/Nerixyz updated https://github.com/llvm/llvm-project/pull/149305 >From 31a047eeb95e066fc4f287413b39aa0b692f90e5 Mon Sep 17 00:00:00 2001 From: Nerixyz Date: Tue, 5 Aug 2025 17:00:23 +0200 Subject: [PATCH] [LLDB] Run API tests with PDB too --- .../Python/lldbsuite/test/build

[Lldb-commits] [lldb] fa39b67 - [lldb] Add a CMake option to build agains the Python limited API (#152034)

2025-08-05 Thread via lldb-commits
Author: Jonas Devlieghere Date: 2025-08-05T08:16:36-07:00 New Revision: fa39b67de01af189b59f9034ef6228a2951364b0 URL: https://github.com/llvm/llvm-project/commit/fa39b67de01af189b59f9034ef6228a2951364b0 DIFF: https://github.com/llvm/llvm-project/commit/fa39b67de01af189b59f9034ef6228a2951364b0.d

[Lldb-commits] [lldb] [lldb] Add a CMake option to build agains the Python limited API (PR #152034)

2025-08-05 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/152034 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Logging setup for lldb-dap extension (PR #146884)

2025-08-05 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/146884 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Update JSONTransport to use MainLoop for reading. (PR #148300)

2025-08-05 Thread LLVM Continuous Integration via lldb-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `lldb-aarch64-windows` running on `linaro-armv8-windows-msvc-05` while building `lldb` at step 6 "test". Full details are available at: https://lab.llvm.org/buildbot/#/builders/141/builds/10607 Here is the relevant piece of

[Lldb-commits] [clang] [libcxxabi] [lldb] [llvm] [lldb][Expression] Add structor variant to LLDB's function call labels (PR #149827)

2025-08-05 Thread Michael Buch via lldb-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/149827 >From b8f31ec8f556169a45370938cf28bd8582134a5c Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Sun, 3 Aug 2025 11:38:07 +0100 Subject: [PATCH 1/4] [clang][Attr] Remove 'literal label' form of AsmLabelAttr

[Lldb-commits] [lldb] [lldb][CPlusPlusLanguage] Create public accessors for getting DemangledNameInfo components and use them in tests (PR #152134)

2025-08-05 Thread Michael Buch via lldb-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/152134 >From cea620279d53c8ce7e8a4de14ff3238d4d64675e Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Tue, 5 Aug 2025 14:15:51 +0100 Subject: [PATCH 1/2] [lldb][CPlusPlusLanguage] Create public accessors for gett

[Lldb-commits] [lldb] [lldb] Move MCP protocol into its own library (NFC) (PR #152059)

2025-08-05 Thread John Harrison via lldb-commits
ashgti wrote: Yea, https://discourse.llvm.org/t/rfc-adding-mcp-support-to-lldb/86798 discussed this as a future improvement. I started working on trying to make a dedicated lldb-mcp binary in [776128af07e06a2595087ecee6ffadbc2ec6ffa5 ](https://github.com/ashgti/llvm-project/commit/776128af07e

[Lldb-commits] [lldb] b723887 - [lldb] Update JSONTransport to use MainLoop for reading. (#148300)

2025-08-05 Thread via lldb-commits
Author: John Harrison Date: 2025-08-05T07:03:44-07:00 New Revision: b723887224c57ecfd7d8530ad066ee233abf559b URL: https://github.com/llvm/llvm-project/commit/b723887224c57ecfd7d8530ad066ee233abf559b DIFF: https://github.com/llvm/llvm-project/commit/b723887224c57ecfd7d8530ad066ee233abf559b.diff

[Lldb-commits] [lldb] [lldb] Update JSONTransport to use MainLoop for reading. (PR #148300)

2025-08-05 Thread John Harrison via lldb-commits
https://github.com/ashgti closed https://github.com/llvm/llvm-project/pull/148300 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][CPlusPlusLanguage] Create public accessors for getting DemangledNameInfo components (PR #152134)

2025-08-05 Thread Michael Buch via lldb-commits
https://github.com/Michael137 created https://github.com/llvm/llvm-project/pull/152134 This way we make sure that the logic to reconstruct demangled names in the tests is the same as the logic when reconstructing the actual frame-format variable. `DemangledNameInfo::SuffixRange` is currently

[Lldb-commits] [lldb] [lldb][CPlusPlusLanguage] Create public accessors for getting DemangledNameInfo components (PR #152134)

2025-08-05 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Michael Buch (Michael137) Changes This way we make sure that the logic to reconstruct demangled names in the tests is the same as the logic when reconstructing the actual frame-format variable. `DemangledNameInfo::SuffixRange` is currentl

[Lldb-commits] [lldb] [lldb] Move MCP protocol into its own library (NFC) (PR #152059)

2025-08-05 Thread David Spickett via lldb-commits
DavidSpickett wrote: Understood, not needing the forwarder will be nice. https://github.com/llvm/llvm-project/pull/152059 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [vscode-lldb] Fix `yarn package` (PR #152002)

2025-08-05 Thread Walter Erquinigo via lldb-commits
https://github.com/walter-erquinigo approved this pull request. good catch https://github.com/llvm/llvm-project/pull/152002 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Run API tests with PDB too (PR #149305)

2025-08-05 Thread via lldb-commits
https://github.com/Nerixyz edited https://github.com/llvm/llvm-project/pull/149305 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Run API tests with native PDB too (PR #149305)

2025-08-05 Thread via lldb-commits
https://github.com/Nerixyz updated https://github.com/llvm/llvm-project/pull/149305 >From 72efee7f33a0697f7920a4afd2de87f2a2dd3fe8 Mon Sep 17 00:00:00 2001 From: Nerixyz Date: Tue, 5 Aug 2025 17:00:23 +0200 Subject: [PATCH] [LLDB] Run API tests with PDB too --- .../Python/lldbsuite/test/build

[Lldb-commits] [lldb] [vscode-lldb] Fix race condition when changing lldb-dap arguments (PR #151828)

2025-08-05 Thread Walter Erquinigo via lldb-commits
https://github.com/walter-erquinigo requested changes to this pull request. https://github.com/llvm/llvm-project/pull/151828 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [vscode-lldb] Fix race condition when changing lldb-dap arguments (PR #151828)

2025-08-05 Thread Walter Erquinigo via lldb-commits
@@ -39,8 +39,10 @@ export class LLDBDapServer implements vscode.Disposable { const process = child_process.spawn(dapPath, dapArgs, options); process.on("error", (error) => { reject(error); -this.serverProcess = undefined; -this.serverInfo = u

[Lldb-commits] [lldb] [LLDB] Run API tests with PDB too (PR #149305)

2025-08-05 Thread via lldb-commits
https://github.com/Nerixyz edited https://github.com/llvm/llvm-project/pull/149305 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Add readOnly attribute for variables (PR #151884)

2025-08-05 Thread Walter Erquinigo via lldb-commits
https://github.com/walter-erquinigo requested changes to this pull request. https://github.com/llvm/llvm-project/pull/151884 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Add readOnly attribute for variables (PR #151884)

2025-08-05 Thread Walter Erquinigo via lldb-commits
@@ -301,6 +301,14 @@ Variable CreateVariable(lldb::SBValue v, int64_t var_ref, bool format_hex, if (lldb::addr_t addr = v.GetLoadAddress(); addr != LLDB_INVALID_ADDRESS) var.memoryReference = addr; + bool is_readonly = v.GetType().IsAggregateType() ||

[Lldb-commits] [lldb] Revert "[lldb] Update JSONTransport to use MainLoop for reading." (PR #152155)

2025-08-05 Thread John Harrison via lldb-commits
https://github.com/ashgti created https://github.com/llvm/llvm-project/pull/152155 Reverts llvm/llvm-project#148300 This is crashing in the aarch64 linux CI job. I'll revert it while I investigate why this is crashing. >From dc397435f1a15f2cef43123418ca16e27d516eb8 Mon Sep 17 00:00:00 2001 Fr

[Lldb-commits] [lldb] Revert "[lldb] Update JSONTransport to use MainLoop for reading." (PR #152155)

2025-08-05 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: John Harrison (ashgti) Changes Reverts llvm/llvm-project#148300 This is crashing in the aarch64 linux CI job. I'll revert it while I investigate why this is crashing. --- Patch is 53.25 KiB, truncated to 20.00 KiB below, full version: h

[Lldb-commits] [lldb] Revert "[lldb] Update JSONTransport to use MainLoop for reading." (PR #152155)

2025-08-05 Thread John Harrison via lldb-commits
https://github.com/ashgti closed https://github.com/llvm/llvm-project/pull/152155 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] cd40281 - Revert "[lldb] Update JSONTransport to use MainLoop for reading." (#152155)

2025-08-05 Thread via lldb-commits
Author: John Harrison Date: 2025-08-05T08:08:03-07:00 New Revision: cd40281685f642ad879e33f3fda8d1faa136ebf4 URL: https://github.com/llvm/llvm-project/commit/cd40281685f642ad879e33f3fda8d1faa136ebf4 DIFF: https://github.com/llvm/llvm-project/commit/cd40281685f642ad879e33f3fda8d1faa136ebf4.diff

[Lldb-commits] [lldb] [vscode-lldb] Add VS Code commands for high level debug workflow (PR #151827)

2025-08-05 Thread Walter Erquinigo via lldb-commits
https://github.com/walter-erquinigo approved this pull request. I really like this approach for composability. Thanks! https://github.com/llvm/llvm-project/pull/151827 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi

[Lldb-commits] [lldb] [vscode-lldb] Add VS Code commands for high level debug workflow (PR #151827)

2025-08-05 Thread Walter Erquinigo via lldb-commits
https://github.com/walter-erquinigo requested changes to this pull request. Please write a section in the lldb-dap documentation on how to integrate with other debugger extensions via these commands? https://github.com/llvm/llvm-project/pull/151827 __

[Lldb-commits] [lldb] [LLDB] Run API tests with PDB too (PR #149305)

2025-08-05 Thread via lldb-commits
https://github.com/Nerixyz updated https://github.com/llvm/llvm-project/pull/149305 >From 015b97982a98f60c271ef4118ceb76d2dd4ec402 Mon Sep 17 00:00:00 2001 From: Nerixyz Date: Tue, 5 Aug 2025 17:00:23 +0200 Subject: [PATCH] [LLDB] Run API tests with PDB too --- .../Python/lldbsuite/test/build

[Lldb-commits] [lldb] [vscode-lldb] Add VS Code commands for high level debug workflow (PR #151827)

2025-08-05 Thread via lldb-commits
https://github.com/royitaqi updated https://github.com/llvm/llvm-project/pull/151827 >From 14c3fc997de307c00199e22e23b2f665147964fc Mon Sep 17 00:00:00 2001 From: Roy Shi Date: Sat, 2 Aug 2025 09:04:18 -0700 Subject: [PATCH 1/4] [lldb] [vscode-lldb] Add VS Code commands that can be leveraged b

[Lldb-commits] [lldb] [vscode-lldb] Add VS Code commands for high level debug workflow (PR #151827)

2025-08-05 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/151827 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][rpc] Fix build failures when building lldb-rpc-gen (PR #151603)

2025-08-05 Thread Chelsea Cassanova via lldb-commits
chelcassanova wrote: > Yes, as a user, if you want to point to a preexisting executable, you'd still > set it in LLDB_RPC_GEN_EXE, but that variable is empty if the user didn't set > anything, and then when the cmake functions either use the user supplied > value, or a locally compiled one, th

[Lldb-commits] [lldb] dbaa82b - [lldb] Move the generic MCP code into Protocol/MCP (NFC) (#152188)

2025-08-05 Thread via lldb-commits
Author: Jonas Devlieghere Date: 2025-08-05T14:10:31-07:00 New Revision: dbaa82b384a7c7a57a3d9a93c2c968af422e6aa9 URL: https://github.com/llvm/llvm-project/commit/dbaa82b384a7c7a57a3d9a93c2c968af422e6aa9 DIFF: https://github.com/llvm/llvm-project/commit/dbaa82b384a7c7a57a3d9a93c2c968af422e6aa9.d

[Lldb-commits] [lldb] [lldb] Move the generic MCP code into Protocol/MCP (NFC) (PR #152188)

2025-08-05 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/152188 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

  1   2   >