[Lldb-commits] [lldb] dece902 - [lldb][MCP] Fix compiler error in Windows on Arm build

2025-08-13 Thread David Spickett via lldb-commits
Author: David Spickett Date: 2025-08-13T12:55:40Z New Revision: dece902a52c01ed386f63ce0ead6b781a630e580 URL: https://github.com/llvm/llvm-project/commit/dece902a52c01ed386f63ce0ead6b781a630e580 DIFF: https://github.com/llvm/llvm-project/commit/dece902a52c01ed386f63ce0ead6b781a630e580.diff LOG

[Lldb-commits] [lldb] 8968183 - [lldb][ClangASTImporter][NFC] Factor out completion logic out of ClangASTImporterDelegate

2025-08-13 Thread Michael Buch via lldb-commits
Author: Michael Buch Date: 2025-08-13T10:22:23+01:00 New Revision: 89681839e367476e0ff66bec3a3931e1c41c7cb4 URL: https://github.com/llvm/llvm-project/commit/89681839e367476e0ff66bec3a3931e1c41c7cb4 DIFF: https://github.com/llvm/llvm-project/commit/89681839e367476e0ff66bec3a3931e1c41c7cb4.diff

[Lldb-commits] [lldb] c68b4d6 - [lldb][ClangASTImporter][NFC] Create helper for CanImport

2025-08-13 Thread Michael Buch via lldb-commits
Author: Michael Buch Date: 2025-08-13T10:22:23+01:00 New Revision: c68b4d64dd89993468a23dcc1c5deb858d7e3b2f URL: https://github.com/llvm/llvm-project/commit/c68b4d64dd89993468a23dcc1c5deb858d7e3b2f DIFF: https://github.com/llvm/llvm-project/commit/c68b4d64dd89993468a23dcc1c5deb858d7e3b2f.diff

[Lldb-commits] [lldb] 3f61e4e - [LLDB][NativePDB] Resolve declaration for tag types (#152579)

2025-08-13 Thread via lldb-commits
Author: nerix Date: 2025-08-13T14:47:21+01:00 New Revision: 3f61e4eae65fcca0aaef4c726dd8f2ed6b473e7f URL: https://github.com/llvm/llvm-project/commit/3f61e4eae65fcca0aaef4c726dd8f2ed6b473e7f DIFF: https://github.com/llvm/llvm-project/commit/3f61e4eae65fcca0aaef4c726dd8f2ed6b473e7f.diff LOG: [L

[Lldb-commits] [lldb] b3396c5 - [lldb] Account for registers being host endian when casting values (#150011)

2025-08-13 Thread via lldb-commits
Author: David Spickett Date: 2025-08-13T14:58:29+01:00 New Revision: b3396c5e96f366ba85daf5f6404f18eb8a467aea URL: https://github.com/llvm/llvm-project/commit/b3396c5e96f366ba85daf5f6404f18eb8a467aea DIFF: https://github.com/llvm/llvm-project/commit/b3396c5e96f366ba85daf5f6404f18eb8a467aea.diff

[Lldb-commits] [lldb] bfc331e - [lldb] Fix warnings

2025-08-13 Thread Kazu Hirata via lldb-commits
Author: Kazu Hirata Date: 2025-08-13T09:22:25-07:00 New Revision: bfc331e54407085395b45d1bfb9b04833342acdf URL: https://github.com/llvm/llvm-project/commit/bfc331e54407085395b45d1bfb9b04833342acdf DIFF: https://github.com/llvm/llvm-project/commit/bfc331e54407085395b45d1bfb9b04833342acdf.diff L

[Lldb-commits] [lldb] 3a36070 - [lldb] Disable JSONTransportTests on Windows. (#153453)

2025-08-13 Thread via lldb-commits
Author: John Harrison Date: 2025-08-13T11:07:03-07:00 New Revision: 3a3607080eade5f8f4a734b9532e99294322783a URL: https://github.com/llvm/llvm-project/commit/3a3607080eade5f8f4a734b9532e99294322783a DIFF: https://github.com/llvm/llvm-project/commit/3a3607080eade5f8f4a734b9532e99294322783a.diff

[Lldb-commits] [lldb] [lldb] Support parsing data symbols from the Wasm name section (PR #153494)

2025-08-13 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere created https://github.com/llvm/llvm-project/pull/153494 This PR adds support for parsing data symbols from the WebAssembly name section. >From e68b6d31ab7ba418b23c7289e12d0befeb07f6d6 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Wed, 13 Aug 2025 13:44

[Lldb-commits] [lldb] 36c2a66 - [lldb][test] Make TestFindRangesInMemory.py more robust (#152817)

2025-08-13 Thread via lldb-commits
Author: Igor Kudrin Date: 2025-08-13T14:15:45-07:00 New Revision: 36c2a6696853020ffc0072566b1f5e77efe96d0c URL: https://github.com/llvm/llvm-project/commit/36c2a6696853020ffc0072566b1f5e77efe96d0c DIFF: https://github.com/llvm/llvm-project/commit/36c2a6696853020ffc0072566b1f5e77efe96d0c.diff L

[Lldb-commits] [lldb] [lldb][test] Make TestFindRangesInMemory.py more robust (PR #152817)

2025-08-13 Thread Igor Kudrin via lldb-commits
https://github.com/igorkudrin closed https://github.com/llvm/llvm-project/pull/152817 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Support parsing data symbols from the Wasm name section (PR #153494)

2025-08-13 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/153494 >From b12ff1822eaafa93cc818ccaca22d3b59106dbb8 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Wed, 13 Aug 2025 13:44:35 -0700 Subject: [PATCH] [lldb] Support parsing data symbols from the Wasm name

[Lldb-commits] [lldb] [lldb] Support parsing data symbols from the Wasm name section (PR #153494)

2025-08-13 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jonas Devlieghere (JDevlieghere) Changes This PR adds support for parsing data symbols from the WebAssembly name section. --- Full diff: https://github.com/llvm/llvm-project/pull/153494.diff 3 Files Affected: - (modified) lldb/source/Plu

[Lldb-commits] [lldb] [lldb] Support parsing data symbols from the Wasm name section (PR #153494)

2025-08-13 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/153494 >From 2d0a3dad2321cdd34dca93919fab0dd9f0e9ed4f Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Wed, 13 Aug 2025 13:44:35 -0700 Subject: [PATCH] [lldb] Support parsing data symbols from the Wasm name

[Lldb-commits] [lldb] [lldb] Support parsing data symbols from the Wasm name section (PR #153494)

2025-08-13 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere ready_for_review https://github.com/llvm/llvm-project/pull/153494 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] refactor PlatformAndroid and make threadsafe (PR #145382)

2025-08-13 Thread Chad Smith via lldb-commits
cs01 wrote: @labath Is there anything else needed of me? Looks like there are workflows awaiting approval still. https://github.com/llvm/llvm-project/pull/145382 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin

[Lldb-commits] [lldb] [lldb] Refactoring JSONTransport into an abstract RPC Message Handler and transport layer. (PR #153121)

2025-08-13 Thread John Harrison via lldb-commits
https://github.com/ashgti updated https://github.com/llvm/llvm-project/pull/153121 >From 572e2caaff35bb0bed0dc56487cca7ffeeab2b5f Mon Sep 17 00:00:00 2001 From: John Harrison Date: Thu, 7 Aug 2025 08:56:11 -0700 Subject: [PATCH] [lldb] Refactoring JSONTransport into an abstract RPC Message Han

[Lldb-commits] [lldb] [lldb] Refactoring JSONTransport into an abstract RPC Message Handler and transport layer. (PR #153121)

2025-08-13 Thread John Harrison via lldb-commits
@@ -54,112 +50,219 @@ class TransportUnhandledContentsError std::string m_unhandled_contents; }; -class TransportInvalidError : public llvm::ErrorInfo { +/// A transport is responsible for maintaining the connection to a client +/// application, and reading/writing structure

[Lldb-commits] [lldb] [lldb] Refactoring JSONTransport into an abstract RPC Message Handler and transport layer. (PR #153121)

2025-08-13 Thread John Harrison via lldb-commits
https://github.com/ashgti updated https://github.com/llvm/llvm-project/pull/153121 >From d5f998c50d3188fc9eeb94ce80e4d4dfd15d6790 Mon Sep 17 00:00:00 2001 From: John Harrison Date: Thu, 7 Aug 2025 08:56:11 -0700 Subject: [PATCH] [lldb] Refactoring JSONTransport into an abstract RPC Message Han

[Lldb-commits] [lldb] [lldb] Refactoring JSONTransport into an abstract RPC Message Handler and transport layer. (PR #153121)

2025-08-13 Thread John Harrison via lldb-commits
@@ -54,112 +50,219 @@ class TransportUnhandledContentsError std::string m_unhandled_contents; }; -class TransportInvalidError : public llvm::ErrorInfo { +/// A transport is responsible for maintaining the connection to a client +/// application, and reading/writing structure

[Lldb-commits] [lldb] [lldb] Refactoring JSONTransport into an abstract RPC Message Handler and transport layer. (PR #153121)

2025-08-13 Thread John Harrison via lldb-commits
@@ -23,41 +24,59 @@ namespace lldb_protocol::mcp { static llvm::StringLiteral kProtocolVersion = "2024-11-05"; +/// A Request or Response 'id'. +using Id = std::variant; + /// A request that expects a response. struct Request { - uint64_t id = 0; + Id id; // Per the spec,

[Lldb-commits] [lldb] [lldb] Refactoring JSONTransport into an abstract RPC Message Handler and transport layer. (PR #153121)

2025-08-13 Thread John Harrison via lldb-commits
@@ -62,6 +62,7 @@ class TestFile { template static llvm::Expected roundtripJSON(const T &input) { llvm::json::Value value = toJSON(input); + llvm::errs() << "JSON: " << value << "\n"; ashgti wrote: Done. https://github.com/llvm/llvm-project/pull/153121 _

[Lldb-commits] [lldb] [lldb] Refactoring JSONTransport into an abstract RPC Message Handler and transport layer. (PR #153121)

2025-08-13 Thread John Harrison via lldb-commits
ashgti wrote: Rebased on main with #153297 included and reverted the comment changes. https://github.com/llvm/llvm-project/pull/153121 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commit

[Lldb-commits] [lldb] [lldb] refactor PlatformAndroid and make threadsafe (PR #145382)

2025-08-13 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere auto_merge_enabled https://github.com/llvm/llvm-project/pull/145382 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] refactor PlatformAndroid and make threadsafe (PR #145382)

2025-08-13 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: > @labath Is there anything else needed of me? Looks like there are workflows > awaiting approval still. I ran them and enabled auto-merge so this PR will get merged automatically if everything passes. https://github.com/llvm/llvm-project/pull/145382 __

[Lldb-commits] [lldb] [lldb] Refactoring JSONTransport into an abstract RPC Message Handler and transport layer. (PR #153121)

2025-08-13 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. Left some comments with nits but besides that LGTM. https://github.com/llvm/llvm-project/pull/153121 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/ma

[Lldb-commits] [lldb] [lldb] Refactoring JSONTransport into an abstract RPC Message Handler and transport layer. (PR #153121)

2025-08-13 Thread Jonas Devlieghere via lldb-commits
@@ -54,112 +50,220 @@ class TransportUnhandledContentsError std::string m_unhandled_contents; }; -class TransportInvalidError : public llvm::ErrorInfo { +/// A transport is responsible for maintaining the connection to a client +/// application, and reading/writing structure

[Lldb-commits] [lldb] [lldb] Refactoring JSONTransport into an abstract RPC Message Handler and transport layer. (PR #153121)

2025-08-13 Thread Jonas Devlieghere via lldb-commits
@@ -258,36 +259,33 @@ void DAP::SendJSON(const llvm::json::Value &json) { llvm::json::Path::Root root; if (!fromJSON(json, message, root)) { DAP_LOG_ERROR(log, root.getError(), "({1}) encoding failed: {0}", - transport.GetClientName()); +

[Lldb-commits] [lldb] [lldb] Refactoring JSONTransport into an abstract RPC Message Handler and transport layer. (PR #153121)

2025-08-13 Thread Jonas Devlieghere via lldb-commits
@@ -54,112 +50,220 @@ class TransportUnhandledContentsError std::string m_unhandled_contents; }; -class TransportInvalidError : public llvm::ErrorInfo { +/// A transport is responsible for maintaining the connection to a client +/// application, and reading/writing structure

[Lldb-commits] [lldb] [lldb] Refactoring JSONTransport into an abstract RPC Message Handler and transport layer. (PR #153121)

2025-08-13 Thread Jonas Devlieghere via lldb-commits
@@ -344,13 +346,14 @@ serveConnection(const Socket::SocketProtocol &protocol, const std::string &name, bool client_failed = false; { std::scoped_lock lock(dap_sessions_mutex); -for (auto [sock, dap] : dap_sessions) { +for (auto [loop, dap] : dap_sessions) {

[Lldb-commits] [lldb] [lldb] Refactoring JSONTransport into an abstract RPC Message Handler and transport layer. (PR #153121)

2025-08-13 Thread Jonas Devlieghere via lldb-commits
@@ -938,88 +933,74 @@ void DAP::ClearCancelRequest(const CancelArguments &args) { } template -static std::optional getArgumentsIfRequest(const Message &pm, +static std::optional getArgumentsIfRequest(const Request &req, llvm::St

[Lldb-commits] [lldb] [lldb] Refactoring JSONTransport into an abstract RPC Message Handler and transport layer. (PR #153121)

2025-08-13 Thread Jonas Devlieghere via lldb-commits
@@ -54,112 +50,220 @@ class TransportUnhandledContentsError std::string m_unhandled_contents; }; -class TransportInvalidError : public llvm::ErrorInfo { +/// A transport is responsible for maintaining the connection to a client +/// application, and reading/writing structure

[Lldb-commits] [lldb] [lldb] Support parsing data symbols from the Wasm name section (PR #153494)

2025-08-13 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl approved this pull request. https://github.com/llvm/llvm-project/pull/153494 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Refactoring JSONTransport into an abstract RPC Message Handler and transport layer. (PR #153121)

2025-08-13 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere edited https://github.com/llvm/llvm-project/pull/153121 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] bcb48aa - [lldb] refactor PlatformAndroid and make threadsafe (#145382)

2025-08-13 Thread via lldb-commits
Author: Chad Smith Date: 2025-08-13T22:43:45Z New Revision: bcb48aa5b2cfc75967c734a97201e0c91273169d URL: https://github.com/llvm/llvm-project/commit/bcb48aa5b2cfc75967c734a97201e0c91273169d DIFF: https://github.com/llvm/llvm-project/commit/bcb48aa5b2cfc75967c734a97201e0c91273169d.diff LOG: [l

[Lldb-commits] [lldb] [lldb] refactor PlatformAndroid and make threadsafe (PR #145382)

2025-08-13 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/145382 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] refactor PlatformAndroid and make threadsafe (PR #145382)

2025-08-13 Thread via lldb-commits
github-actions[bot] wrote: @cs01 Congratulations on having your first Pull Request (PR) merged into the LLVM Project! Your changes will be combined with recent changes from other authors, then tested by our [build bots](https://lab.llvm.org/buildbot/). If there is a problem with a build, yo

[Lldb-commits] [lldb] [lldb-dap] Migrating 'completions' to structured types. (PR #153317)

2025-08-13 Thread Ely Ronnen via lldb-commits
https://github.com/eronnen approved this pull request. https://github.com/llvm/llvm-project/pull/153317 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Refactoring JSONTransport into an abstract RPC Message Handler and transport layer. (PR #153121)

2025-08-13 Thread John Harrison via lldb-commits
https://github.com/ashgti updated https://github.com/llvm/llvm-project/pull/153121 >From d5f998c50d3188fc9eeb94ce80e4d4dfd15d6790 Mon Sep 17 00:00:00 2001 From: John Harrison Date: Thu, 7 Aug 2025 08:56:11 -0700 Subject: [PATCH 1/2] [lldb] Refactoring JSONTransport into an abstract RPC Message

[Lldb-commits] [lldb] [lldb] Refactoring JSONTransport into an abstract RPC Message Handler and transport layer. (PR #153121)

2025-08-13 Thread John Harrison via lldb-commits
@@ -54,112 +50,220 @@ class TransportUnhandledContentsError std::string m_unhandled_contents; }; -class TransportInvalidError : public llvm::ErrorInfo { +/// A transport is responsible for maintaining the connection to a client +/// application, and reading/writing structure

[Lldb-commits] [lldb] [lldb] Refactoring JSONTransport into an abstract RPC Message Handler and transport layer. (PR #153121)

2025-08-13 Thread John Harrison via lldb-commits
@@ -54,112 +50,220 @@ class TransportUnhandledContentsError std::string m_unhandled_contents; }; -class TransportInvalidError : public llvm::ErrorInfo { +/// A transport is responsible for maintaining the connection to a client +/// application, and reading/writing structure

[Lldb-commits] [lldb] [lldb] Refactoring JSONTransport into an abstract RPC Message Handler and transport layer. (PR #153121)

2025-08-13 Thread John Harrison via lldb-commits
@@ -54,112 +50,220 @@ class TransportUnhandledContentsError std::string m_unhandled_contents; }; -class TransportInvalidError : public llvm::ErrorInfo { +/// A transport is responsible for maintaining the connection to a client +/// application, and reading/writing structure

[Lldb-commits] [lldb] [lldb] Refactoring JSONTransport into an abstract RPC Message Handler and transport layer. (PR #153121)

2025-08-13 Thread John Harrison via lldb-commits
@@ -344,13 +346,14 @@ serveConnection(const Socket::SocketProtocol &protocol, const std::string &name, bool client_failed = false; { std::scoped_lock lock(dap_sessions_mutex); -for (auto [sock, dap] : dap_sessions) { +for (auto [loop, dap] : dap_sessions) {

[Lldb-commits] [lldb] [lldb] Refactoring JSONTransport into an abstract RPC Message Handler and transport layer. (PR #153121)

2025-08-13 Thread John Harrison via lldb-commits
@@ -258,36 +259,33 @@ void DAP::SendJSON(const llvm::json::Value &json) { llvm::json::Path::Root root; if (!fromJSON(json, message, root)) { DAP_LOG_ERROR(log, root.getError(), "({1}) encoding failed: {0}", - transport.GetClientName()); +

[Lldb-commits] [lldb] [lldb] Refactoring JSONTransport into an abstract RPC Message Handler and transport layer. (PR #153121)

2025-08-13 Thread John Harrison via lldb-commits
@@ -938,88 +933,74 @@ void DAP::ClearCancelRequest(const CancelArguments &args) { } template -static std::optional getArgumentsIfRequest(const Message &pm, +static std::optional getArgumentsIfRequest(const Request &req, llvm::St

[Lldb-commits] [lldb] [lldb] refactor PlatformAndroid and make threadsafe (PR #145382)

2025-08-13 Thread LLVM Continuous Integration via lldb-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `lldb-aarch64-ubuntu` running on `linaro-lldb-aarch64-ubuntu` while building `lldb` at step 6 "test". Full details are available at: https://lab.llvm.org/buildbot/#/builders/59/builds/22573 Here is the relevant piece of the b

[Lldb-commits] [lldb] [lldb] refactor PlatformAndroid and make threadsafe (PR #145382)

2025-08-13 Thread LLVM Continuous Integration via lldb-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `lldb-remote-linux-win` running on `as-builder-10` while building `lldb` at step 16 "test-check-lldb-unit". Full details are available at: https://lab.llvm.org/buildbot/#/builders/197/builds/7996 Here is the relevant piece o

[Lldb-commits] [lldb] [lldb][Expression] Avoid creating ValueObjectSyntheticFilter for incomplete C++ types in ObjC++ targets (PR #153454)

2025-08-13 Thread via lldb-commits
https://github.com/jimingham requested changes to this pull request. At the site where you are fixing this, this is a workaround of a workaround, so I don't so much mind that. But you shouldn't be mentioning a specific language in a TypeSystem method, so I don't like the IsCXXClassType. IsC

[Lldb-commits] [lldb] [vscode-lldb] Support lldb-dap environment in debug configuration (PR #153536)

2025-08-13 Thread via lldb-commits
https://github.com/royitaqi created https://github.com/llvm/llvm-project/pull/153536 # Changes 1. Add a new debug configuration field called `debugAdapterEnv`, which accepts a string-valued dictionary. 3. In the adapter descriptor factory, honor the said field before looking at the VS Code set

[Lldb-commits] [lldb] [vscode-lldb] Support lldb-dap environment in debug configuration (PR #153536)

2025-08-13 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: None (royitaqi) Changes # Changes 1. Add a new debug configuration field called `debugAdapterEnv`, which accepts a string-valued dictionary. 3. In the adapter descriptor factory, honor the said field before looking at the VS Code settings

[Lldb-commits] [lldb] b563b27 - [lldb] Convert registers values into target endian for expressions (#148836)

2025-08-13 Thread via lldb-commits
Author: David Spickett Date: 2025-08-13T09:48:29+01:00 New Revision: b563b274b8a8b00dadb63e67d648421c110449ff URL: https://github.com/llvm/llvm-project/commit/b563b274b8a8b00dadb63e67d648421c110449ff DIFF: https://github.com/llvm/llvm-project/commit/b563b274b8a8b00dadb63e67d648421c110449ff.diff