royitaqi wrote:
> do you know if destroying the debugger will free the module cache?
@walter-erquinigo: I assume, by "module cache", you meant the global module
list accessible by `ModuleList::GetSharedModule()` and
`ModuleList::GetSharedModuleList()`.
I think destroying the debugger will NOT
https://github.com/Nerixyz edited
https://github.com/llvm/llvm-project/pull/156370
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Nerixyz edited
https://github.com/llvm/llvm-project/pull/156370
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/asavonic closed
https://github.com/llvm/llvm-project/pull/147289
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Nerixyz wrote:
> It completes the element type.
As in, "if an array type is encountered, it's immediately completed"? Because
in native PDB (with this PR too), it would be delayed.
> Is there a place in the PDB plugin where we can do the same thing we do for
> DWARF?
Yes, in `PdbAstBuilder::
https://github.com/dlav-sc created
https://github.com/llvm/llvm-project/pull/156506
Currently, the tests that check stepping through atomic sequences use a
hardcoded step distance, which is unreliable because this distance depends on
LLVM's codegeneration.
This patch rewrites the test to avoi
https://github.com/charles-zablit closed
https://github.com/llvm/llvm-project/pull/156474
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
amy-kwan wrote:
This is is required to build AIX with the latest CMake versions.
/cherry-pick 63195d3d7a8bde05590f91a38398f986bb4265b2
3e6ec475b756559560cba4a16c2bc755aa8caee5
https://github.com/llvm/llvm-project/pull/154537
___
lldb-commits mailing
https://github.com/kastiglione updated
https://github.com/llvm/llvm-project/pull/155061
>From eff269a2c869b3a3c73ed0198f3b749fd914b2aa Mon Sep 17 00:00:00 2001
From: Dave Lee
Date: Fri, 22 Aug 2025 19:34:57 -0700
Subject: [PATCH 1/4] [lldb] Add Pythonic API to SBStructuredData extension
* Impl
https://github.com/Nerixyz approved this pull request.
(Windows 11, x86) Rendering in the terminal works as expected and the
previously failing tests now pass for me.
https://github.com/llvm/llvm-project/pull/156469
___
lldb-commits mailing list
lldb-
https://github.com/ZequanWu approved this pull request.
LGTM as it aligns with dwarf plugin's behaviour.
https://github.com/llvm/llvm-project/pull/156370
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/
github-actions[bot] wrote:
:warning: Python code formatter, darker found issues in your code. :warning:
You can test this locally with the following command:
``bash
darker --check --diff -r origin/main...HEAD
lldb/test/API/riscv/step/TestSoftwareStep.py
``
:warning:
The
felipepiovezan wrote:
Added a test!
https://github.com/llvm/llvm-project/pull/153585
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
bulbazord wrote:
> This change looks good to me. I might not have read it sufficiently closely,
> but the duplicate symbols we're looking at here are only when there are debug
> map entries for .o file debugging, maybe?
Possibly? I'm definitely doing .o debugging, didn't try with dSYMs at all.
https://github.com/felipepiovezan updated
https://github.com/llvm/llvm-project/pull/153585
>From ce9c2cc6748c22ce4b0f5178b8f5e877d430 Mon Sep 17 00:00:00 2001
From: Felipe de Azevedo Piovezan
Date: Wed, 13 Aug 2025 18:38:23 -0700
Subject: [PATCH 1/5] [lldb] Call FixUpPointer in WritePointer
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff origin/main HEAD --extensions c,cpp --
lldb/test/API/macosx/arm-pointer-metadata-stri
https://github.com/ZequanWu created
https://github.com/llvm/llvm-project/pull/156530
https://github.com/llvm/llvm-project/pull/153160 created those function maps
and uses default sort comparator which is not deterministic when there are
multiple entries with same name because llvm::sort is uns
https://github.com/Nerixyz approved this pull request.
LGTM, thank you for noticing!
The type-name map uses the same map type and [doesn't specify a comparator
either](https://github.com/llvm/llvm-project/blob/3c7bf3b3c3a4871d13f7b7d5d60bbf190eaf8f3a/lldb/source/Plugins/SymbolFile/NativePDB/Sym
Author: nerix
Date: 2025-09-02T22:53:44+02:00
New Revision: 3c7bf3b3c3a4871d13f7b7d5d60bbf190eaf8f3a
URL:
https://github.com/llvm/llvm-project/commit/3c7bf3b3c3a4871d13f7b7d5d60bbf190eaf8f3a
DIFF:
https://github.com/llvm/llvm-project/commit/3c7bf3b3c3a4871d13f7b7d5d60bbf190eaf8f3a.diff
LOG: [L
https://github.com/adrian-prantl approved this pull request.
Otherwise lgtm
https://github.com/llvm/llvm-project/pull/156474
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/adrian-prantl approved this pull request.
https://github.com/llvm/llvm-project/pull/156469
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
felipepiovezan wrote:
> Also is there a store reference to memory and if so does it do its own thing
> or call store pointer?
could you elaborate? Not sure what you meant by "store reference to memory".
https://github.com/llvm/llvm-project/pull/153585
__
santhoshe447 wrote:
Hi @jasonmolenda,
Could we please prioritize merging this PR?
It has been working successfully across our projects without any issues. If
there are no further comments.
https://github.com/llvm/llvm-project/pull/147990
___
lldb-com
@@ -103,3 +120,76 @@ lldb::SBValue Variables::FindVariable(uint64_t
variablesReference,
}
return variable;
}
+
+std::optional
+Variables::GetScopeKind(const int64_t variablesReference) {
+ auto scope_kind_iter = m_scope_kinds.find(variablesReference);
+ if (scope_kind_it
@@ -13,3 +13,8 @@ struct E {
E();
};
E::E() = default;
+
+struct I {
+ I();
+};
+I::I() = default;
Michael137 wrote:
What's this used for?
https://github.com/llvm/llvm-project/pull/156370
___
lldb-commits mailing
https://github.com/Nerixyz updated
https://github.com/llvm/llvm-project/pull/156370
>From 967d3453e997ed25c3548898d69a40d079d307b1 Mon Sep 17 00:00:00 2001
From: Nerixyz
Date: Mon, 1 Sep 2025 21:02:33 +0200
Subject: [PATCH 1/3] [LLDB] Complete constant array member types in class
members
---
DavidSpickett wrote:
Also is there a store reference to memory and if so does it do its own thing or
call store pointer?
https://github.com/llvm/llvm-project/pull/153585
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/
Michael137 wrote:
> > It completes the element type.
>
> As in, "if an array type is encountered, it's immediately completed"? Because
> in native PDB (with this PR too), it would be delayed.
I meant, "completing a ConstantArrayType" is the same as "completing the
element type". This PR imple
@@ -103,3 +120,76 @@ lldb::SBValue Variables::FindVariable(uint64_t
variablesReference,
}
return variable;
}
+
+std::optional
+Variables::GetScopeKind(const int64_t variablesReference) {
+ auto scope_kind_iter = m_scope_kinds.find(variablesReference);
+ if (scope_kind_it
slydiman wrote:
@JDevlieghere, @omjavaid,
Is there any reason why GetDemangledName returns empty on Windows?
The problem is hidden now. Could you create an issue and add the link to
@expectedFailureAll(bugnumber="...") at least, please.
https://github.com/llvm/llvm-project/pull/155939
_
athierry-oct wrote:
@labath ok, thanks for explaining why HandleCommand() works this way
So in synchronous mode, should `EvaluateExpression()` (and more specifically,
`RunThreadPlan()`) avoid rebroadcasting the stop event when expression
evaluation fails due to a process stop? I may be missing
Author: Charles Zablit
Date: 2025-09-03T00:05:22+01:00
New Revision: 1cee0e7b6281e5f82154a101eed09a7197a295a6
URL:
https://github.com/llvm/llvm-project/commit/1cee0e7b6281e5f82154a101eed09a7197a295a6
DIFF:
https://github.com/llvm/llvm-project/commit/1cee0e7b6281e5f82154a101eed09a7197a295a6.diff
https://github.com/Anthony-Eid updated
https://github.com/llvm/llvm-project/pull/124232
>From 30658e994b18b7c0db114a297036421c8de2dea3 Mon Sep 17 00:00:00 2001
From: Anthony
Date: Wed, 27 Aug 2025 13:04:26 -0400
Subject: [PATCH 01/15] Fix variable request from reusing variable_ids
---
.../lld
jasonmolenda wrote:
> > You could imagine someone making an ELF corefile output capability, for
> > instance.
>
> Yes I'd love to be generating the core files eventually. Maybe we can with
> yaml2obj but I never seriously looked into it. As right now, patching in
> notes by hand makes for sma
https://github.com/ZequanWu edited
https://github.com/llvm/llvm-project/pull/155853
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -601,21 +601,26 @@ PdbAstBuilder::CreateModifierType(const ModifierRecord
&modifier) {
}
clang::QualType PdbAstBuilder::CreateRecordType(PdbTypeSymId id,
-const TagRecord &record) {
+
https://github.com/ZequanWu commented:
In terms of testing, we should avoid adding binaries in test suite.
https://github.com/llvm/llvm-project/blob/2fc0e2c888521489f4a286b0902a6896506f8d8e/lldb/source/Plugins/ExpressionParser/Clang/ClangASTMetadata.cpp#L47-L49
dumps dynamic type info, but I'm
https://github.com/tstellar updated
https://github.com/llvm/llvm-project/pull/155274
>From 57697a66cfdddf2028c7260f1ce61ecacc550d00 Mon Sep 17 00:00:00 2001
From: Tom Stellard
Date: Mon, 25 Aug 2025 17:15:36 +
Subject: [PATCH 01/56] Add AArch64 support to the premerge tests
---
.github/wo
https://github.com/dlav-sc updated
https://github.com/llvm/llvm-project/pull/156506
>From d9ede8035d1786a62375295fdb855fb2a08f0c72 Mon Sep 17 00:00:00 2001
From: Daniil Avdeev
Date: Wed, 16 Jul 2025 14:52:27 +
Subject: [PATCH] [lldb][RISCV][test] make atomic region stepping test more
robus
https://github.com/Nerixyz closed
https://github.com/llvm/llvm-project/pull/156370
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/medismailben ready_for_review
https://github.com/llvm/llvm-project/pull/149622
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Anthony-Eid edited
https://github.com/llvm/llvm-project/pull/124232
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
DavidSpickett wrote:
Yes that's right. I'm still a bit unclear how it makes its way to
WritePointerToMemory, but as long as it'll break if we change things, that's
the point.
I think it is that:
* Expression evaluation needs to pass `void* ptr` to the function.
* To do that we allocate a stack
@@ -308,52 +306,24 @@ Environment Host::GetEnvironment() {
return env;
}
-/// Manages the lifecycle of a Windows Event's Source.
-/// The destructor will call DeregisterEventSource.
-/// This class is meant to be used with \ref llvm::ManagedStatic.
-class WindowsEventLog {
-
https://github.com/compnerd approved this pull request.
https://github.com/llvm/llvm-project/pull/156474
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Anthony-Eid wrote:
I just finished merging the `ReadyFrame` and `SwitchFrame` logic. Please let me
know what else I should change
https://github.com/llvm/llvm-project/pull/124232
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.
https://github.com/felipepiovezan commented:
the LLDB changes are ok, but I also support the need to split this; this is
touching some test files (and test names), and I dread to think if the
cross-project revert someone would need to do if we accidentally break a test.
https://github.com/llv
https://github.com/Nerixyz edited
https://github.com/llvm/llvm-project/pull/156370
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Nerixyz updated
https://github.com/llvm/llvm-project/pull/156370
>From 967d3453e997ed25c3548898d69a40d079d307b1 Mon Sep 17 00:00:00 2001
From: Nerixyz
Date: Mon, 1 Sep 2025 21:02:33 +0200
Subject: [PATCH 1/4] [LLDB] Complete constant array member types in class
members
---
@@ -0,0 +1,15 @@
+// This test checks that under implicit modules, different optimization levels
jansvoboda11 wrote:
Thank you for letting me know, @paperchalice. My IDE does this in certain
situations and I didn't notice before committing. Fixed in 96c27761.
h
walter-erquinigo wrote:
Good, this looks good to me!
I'll let @kusmour do the final approval
https://github.com/llvm/llvm-project/pull/156231
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb
@@ -308,52 +306,24 @@ Environment Host::GetEnvironment() {
return env;
}
-/// Manages the lifecycle of a Windows Event's Source.
-/// The destructor will call DeregisterEventSource.
-/// This class is meant to be used with \ref llvm::ManagedStatic.
-class WindowsEventLog {
-
https://github.com/Michael137 commented:
The way we do it for DWARF (for better or for worse) is that we complete the
array element type, not the array type itself. FWIW, that's what completing a
`ConstantArrayType` does anyway. It completes the element type.
Is there a place in the PDB plugin
https://github.com/charles-zablit closed
https://github.com/llvm/llvm-project/pull/156469
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvmbot wrote:
/pull-request llvm/llvm-project#156505
https://github.com/llvm/llvm-project/pull/154537
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/jhuber6 approved this pull request.
libc and openmp LG
https://github.com/llvm/llvm-project/pull/156270
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/kuhar approved this pull request.
Support LGTM, but I'd also prefer for it to be split into a few smaller PRs
https://github.com/llvm/llvm-project/pull/156270
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.ll
@@ -13,3 +13,8 @@ struct E {
E();
};
E::E() = default;
+
+struct I {
+ I();
+};
+I::I() = default;
Nerixyz wrote:
Oops, was testing something unrelated...
https://github.com/llvm/llvm-project/pull/156370
___
lldb
github-actions[bot] wrote:
Thank you for submitting a Pull Request (PR) to the LLVM Project!
This PR will be automatically labeled and the relevant teams will be notified.
If you wish to, you can add reviewers by using the "Reviewers" section on this
page.
If this is not working for you, it
https://github.com/zzjconcent created
https://github.com/llvm/llvm-project/pull/156582
fix(LLDB): Repair OC_Bridge variable display issue when load-on-demand is true
When symbols.load-on-demand is enabled in LLDB, variables from OC-bridged Swift
objects were not being displayed. This was due to
Author: Charles Zablit
Date: 2025-09-02T18:06:15+01:00
New Revision: f0c819868dddc844f7539c532acfc4b7ab956bbe
URL:
https://github.com/llvm/llvm-project/commit/f0c819868dddc844f7539c532acfc4b7ab956bbe
DIFF:
https://github.com/llvm/llvm-project/commit/f0c819868dddc844f7539c532acfc4b7ab956bbe.diff
https://github.com/tblah approved this pull request.
Flang and flang-rt changes LGTM.
https://github.com/llvm/llvm-project/pull/156270
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commit
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/156231
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/zzjconcent closed
https://github.com/llvm/llvm-project/pull/156582
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/medismailben updated
https://github.com/llvm/llvm-project/pull/149622
>From 583a83e1001a824fcfbc9a0811af3fbaf446e5ca Mon Sep 17 00:00:00 2001
From: Med Ismail Bennani
Date: Tue, 2 Sep 2025 17:36:27 -0700
Subject: [PATCH 1/2] [lldb] Mark scripted frames as synthetic instead of
https://github.com/felipepiovezan updated
https://github.com/llvm/llvm-project/pull/153585
>From ce9c2cc6748c22ce4b0f5178b8f5e877d430 Mon Sep 17 00:00:00 2001
From: Felipe de Azevedo Piovezan
Date: Wed, 13 Aug 2025 18:38:23 -0700
Subject: [PATCH 1/5] [lldb] Call FixUpPointer in WritePointer
@@ -11,6 +11,7 @@
#include "ExceptionBreakpoint.h"
#include "LLDBUtils.h"
#include "ProtocolUtils.h"
+#include "Variables.h"
Anthony-Eid wrote:
I also removed it. Thanks for the heads up
https://github.com/llvm/llvm-project/pull/124232
___
asavonic wrote:
@jimingham, thanks a lot for the explanation! I think `MemoryPressureDetected`
is a better solution than what I was trying to do originally.
> I'd suggest adding another API like `RemoveAllSharedModules` that ignores
> reference count - but that API should only ever be called
https://github.com/asavonic created
https://github.com/llvm/llvm-project/pull/156446
DynamicLoaderWindowsDYLD uses pointers to mModules to maintain a map from
modules to their addresses, but it does not need to keep "strong" references to
them. Weak pointers should be enough, and would allow m
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/149827
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Nerixyz updated
https://github.com/llvm/llvm-project/pull/156370
>From 967d3453e997ed25c3548898d69a40d079d307b1 Mon Sep 17 00:00:00 2001
From: Nerixyz
Date: Mon, 1 Sep 2025 21:02:33 +0200
Subject: [PATCH 1/5] [LLDB] Complete constant array member types in class
members
---
71 matches
Mail list logo
