clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
I don't see how passing the target architecture's OS helps here since you
aren't checking it for linux or any of the other OS's where pid == tid. This
arch is likely to be unset
On 10 August 2015 at 05:13, sagar.tha...@imgtec.com wrote:
Hi Ed,
We do not require to handle e_void case in GetData() as we have already
checked if bytes_size greater than zero.
136bool
137Scalar::GetData (DataExtractor data, size_t limit_byte_size)
const
138{
On 7 August 2015 at 02:39, Sagar Thakur via lldb-commits
lldb-commits@lists.llvm.org wrote:
Author: slthakur
Date: Fri Aug 7 01:39:38 2015
New Revision: 244308
URL: http://llvm.org/viewvc/llvm-project?rev=244308view=rev
Log:
[LLDB][MIPS] Fix offsets of all register sets and add MSA regset
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Looks good as long as the code is using the LLDB coding style which I believe
has been addressed.
http://reviews.llvm.org/D10216
___
Author: zturner
Date: Mon Aug 10 12:46:11 2015
New Revision: 244469
URL: http://llvm.org/viewvc/llvm-project?rev=244469view=rev
Log:
Allow dosep.py to print dotest.py output on success.
Previously all test output was reported by each individual
instance of dotest.py. After a recent patch, dosep
clayborg resigned from this revision.
clayborg removed a reviewer: clayborg.
clayborg added a comment.
I will defer to Tamas Berghammer since I have no expertise is arm64 watchpoints.
http://reviews.llvm.org/D11899
___
lldb-commits mailing list
lgtm
On Mon, Aug 10, 2015 at 9:50 AM Chaoren Lin chaor...@google.com wrote:
chaoren created this revision.
chaoren added a reviewer: zturner.
chaoren added a subscriber: lldb-commits.
http://reviews.llvm.org/D11909
Files:
test/dosep.py
Index: test/dosep.py
chaoren updated this revision to Diff 31708.
chaoren added a comment.
Accidentally removed timed_out tests from failed tests.
http://reviews.llvm.org/D11910
Files:
test/dosep.py
Index: test/dosep.py
===
--- test/dosep.py
+++
Hi Jason,
The function sext() for sign extending APInt values requires the new bit
width to be greater than the current bit width. That is the reason I was
just creating a new APInt instead of using sext function in cases where
we need to promote to a type which has same bit width. I will do
loladiro created this revision.
loladiro added a reviewer: zturner.
loladiro added a subscriber: lldb-commits.
loladiro set the repository for this revision to rL LLVM.
We get an assertion otherwise because the None Interpreter cannot be found
Repository:
rL LLVM
tberghammer added a comment.
Generally looks good to me. I am happy to push the 2 cleanup change to a
separate CL but please check that the read/write flag calculation is correct.
Comment at:
source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64.cpp:514-519
@@ -507,8
tberghammer added a comment.
Friendly ping
http://reviews.llvm.org/D11384
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
omjavaid created this revision.
omjavaid added reviewers: tberghammer, clayborg.
omjavaid added a subscriber: lldb-commits.
Herald added subscribers: rengolin, aemerson.
There were some bugs that needed to be fixed in watchpoint handling code on
arm64.
Watchpoints were being written to all
13 matches
Mail list logo
