Re: [Lldb-commits] [PATCH] D12025: Make LLDB URLs to support hex encoding for special symbols

2015-08-14 Thread Oleksiy Vyalov via lldb-commits
ovyalov added a comment. In http://reviews.llvm.org/D12025#224355, @tberghammer wrote: The implementation looks good, but I don't like the approach you try to handle the problem. I think you do far too much work to use UriParser in a case where it isn't necessary and isn't make things

[Lldb-commits] [lldb] r245066 - Update dosep to print unexpected successes at the end.

2015-08-14 Thread Zachary Turner via lldb-commits
Author: zturner Date: Fri Aug 14 11:45:32 2015 New Revision: 245066 URL: http://llvm.org/viewvc/llvm-project?rev=245066view=rev Log: Update dosep to print unexpected successes at the end. Modified: lldb/trunk/test/dosep.py Modified: lldb/trunk/test/dosep.py URL:

Re: [Lldb-commits] [lldb] r245020 - [MIPS]Handle floating point and aggregate return types in SysV-mips [32 bit] ABI

2015-08-14 Thread Hans Wennborg via lldb-commits
Sure, if Greg approves. Thanks, Hans On Thu, Aug 13, 2015 at 11:25 PM, Bhushan Attarde bhushan.atta...@imgtec.com wrote: Hi Hans, Could you please merge this to the release branch? Thanks Bhushan -Original Message- From: lldb-commits [mailto:lldb-commits-boun...@lists.llvm.org]

[Lldb-commits] [PATCH] D12043: Convert all use of pthreads in test executables to std threads

2015-08-14 Thread Zachary Turner via lldb-commits
zturner created this revision. zturner added reviewers: clayborg, jingham. zturner added a subscriber: lldb-commits. This eliminates portability issues among platforms that don't have a pthreads implementation. There was one situation in TestTlsGlobals.py where it seems the intention is to

[Lldb-commits] [lldb] r245121 - Don't crash if we don't have a type system for a language.

2015-08-14 Thread Greg Clayton via lldb-commits
Author: gclayton Date: Fri Aug 14 18:15:48 2015 New Revision: 245121 URL: http://llvm.org/viewvc/llvm-project?rev=245121view=rev Log: Don't crash if we don't have a type system for a language. Modified: lldb/trunk/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp Modified:

Re: [Lldb-commits] [PATCH] D12039: Make @skipUnlessArch actually skip instead of XFAIL

2015-08-14 Thread Zachary Turner via lldb-commits
zturner added inline comments. Comment at: test/lldbtest.py:943 @@ -947,1 +942,3 @@ +def skipUnlessArch(archlist): +def myImpl(func): chaoren wrote: Is there a reason ``` return unittest2.skipUnless(getArchitecture() in archlist, ...) ``` is not

[Lldb-commits] [lldb] r245129 - Fix Android build.

2015-08-14 Thread Oleksiy Vyalov via lldb-commits
Author: ovyalov Date: Fri Aug 14 18:57:15 2015 New Revision: 245129 URL: http://llvm.org/viewvc/llvm-project?rev=245129view=rev Log: Fix Android build. Modified: lldb/trunk/source/Plugins/SymbolFile/DWARF/SymbolFileDWARFDebugMap.h Modified:

Re: [Lldb-commits] [PATCH] D11790: Fix ObjC++ types Class and id being defined in C and C++ expressions.

2015-08-14 Thread Dawn Perchik via lldb-commits
dawn added a comment. See inline comments. Comment at: source/Commands/CommandObjectExpression.cpp:308 @@ -307,3 @@ -else -options.SetLanguage(target-GetLanguage()); - Why was this removed? Doesn't this break the intent of the

[Lldb-commits] [lldb] r244936 - Remove more uses of raw_svector_ostream::flush() call following r244928.

2015-08-14 Thread Yaron Keren via lldb-commits
Author: yrnkrn Date: Thu Aug 13 13:48:44 2015 New Revision: 244936 URL: http://llvm.org/viewvc/llvm-project?rev=244936view=rev Log: Remove more uses of raw_svector_ostream::flush() call following r244928. Modified: lldb/trunk/source/Host/macosx/HostInfoMacOSX.mm

[Lldb-commits] [lldb] r244935 - Remove raw_svector_ostream::flush() call following r244928.

2015-08-14 Thread Yaron Keren via lldb-commits
Author: yrnkrn Date: Thu Aug 13 13:42:29 2015 New Revision: 244935 URL: http://llvm.org/viewvc/llvm-project?rev=244935view=rev Log: Remove raw_svector_ostream::flush() call following r244928. Modified: lldb/trunk/source/Host/posix/HostInfoPosix.cpp Modified: