brucem added a reviewer: clayborg.
brucem added a comment.
I'd like to land this given approval.
Repository:
rL LLVM
http://reviews.llvm.org/D14037
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
brucem added a reviewer: emaste.
brucem added a comment.
emaste, are you okay with this and willing to approve it?
It looks good to me.
Repository:
rL LLVM
http://reviews.llvm.org/D14042
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
zturner added a comment.
Seems ok I suppose, I can't find any functional changes from eyeballing it
aside from the import changes. I'm still confused why `utilsDebug.py` even
worked before
Comment at: scripts/utilsDebug.py:14
@@ -16,2 +13,3 @@
# Python modules:
+import sys
Author: spyffe
Date: Thu Nov 5 13:46:12 2015
New Revision: 252198
URL: http://llvm.org/viewvc/llvm-project?rev=252198=rev
Log:
Better validation when we think a directory might be Xcode.app.
LLDB could otherwise get confused if it is (for example) in a
root that is meant to install into an
chaoren added a comment.
It's not actually CMake complaining but the LLVM cmake scripts.
http://reviews.llvm.org/D14389
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
zturner added a comment.
Isn't this going to have the same problem as before? If CMake finds a source
file in the directory that is not added to one of the targets, it will give you
an error. With this patch, on Linux or Windows `PlatformAppleSimulator.cpp`
will be on disk, but not part of
brucem added inline comments.
Comment at: scripts/Python/buildSwigPython.py:293
@@ +292,3 @@
+# LLDBWrapPython.cpp file.
+# Args:vDictArg - (R) Program input parameters.
+# vstrSwigOpFileNamePath - (R) LLDBWrapPython.cpp file.
I shouldn't
Author: chaoren
Date: Thu Nov 5 12:49:02 2015
New Revision: 252182
URL: http://llvm.org/viewvc/llvm-project?rev=252182=rev
Log:
Revert "Do not build any of the simulator material on non-Darwin"
This breaks the cmake build on all non-darwin platforms.
This reverts commit
Renaming it to .mm would fix it, but I don't know if that extension has
special implications on OSX platforms.
Another fix would be moving the platform-specific files into a subfolder
and then adding them dfrom the subfolder. That way CMake won't see them in
the current directory.
On Thu, Nov
Author: jingham
Date: Thu Nov 5 13:20:39 2015
New Revision: 252188
URL: http://llvm.org/viewvc/llvm-project?rev=252188=rev
Log:
Add a comment explaining TypeImpl.
Modified:
lldb/trunk/include/lldb/Symbol/Type.h
Modified: lldb/trunk/include/lldb/Symbol/Type.h
URL:
chaoren added a comment.
LLVM_OPTIONAL_SOURCES should avoid that.
http://reviews.llvm.org/D14389
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rL252183: Use lldb::pid_t instead of pid_t. (authored by
chaoren).
Changed prior to commit:
http://reviews.llvm.org/D14388?vs=39384=39387#toc
Repository:
rL LLVM
http://reviews.llvm.org/D14388
Author: chaoren
Date: Thu Nov 5 12:49:03 2015
New Revision: 252183
URL: http://llvm.org/viewvc/llvm-project?rev=252183=rev
Log:
Use lldb::pid_t instead of pid_t.
Reviewers: granata.enrico
Subscribers: lldb-commits
Differential Revision: http://reviews.llvm.org/D14388
Modified:
.mm means compile with the ObjectiveC++ compiler, not the ObjectiveC compiler.
Probably wouldn't effect these files but it seems a really bogus way to tell
the build system not to build files...
Jim
> On Nov 5, 2015, at 10:58 AM, Zachary Turner via lldb-commits
>
chaoren created this revision.
chaoren added reviewers: granata.enrico, tberghammer, zturner, jingham.
chaoren added a subscriber: lldb-commits.
This is a resubmission of r252179, but correctly ignores the source
files for other platforms.
http://reviews.llvm.org/D14389
Files:
Author: zturner
Date: Thu Nov 5 12:38:02 2015
New Revision: 252181
URL: http://llvm.org/viewvc/llvm-project?rev=252181=rev
Log:
Python 3 - Apply 2to3 `filter` fixer to unittest2.
Modified:
lldb/trunk/third_party/Python/module/unittest2/unittest2/loader.py
Modified:
Author: zturner
Date: Thu Nov 5 13:21:56 2015
New Revision: 252189
URL: http://llvm.org/viewvc/llvm-project?rev=252189=rev
Log:
Python 3 - Fix usage of `unicode` in unittest2.
Modified:
lldb/trunk/third_party/Python/module/unittest2/unittest2/case.py
Modified:
Author: zturner
Date: Thu Nov 5 13:22:06 2015
New Revision: 252190
URL: http://llvm.org/viewvc/llvm-project?rev=252190=rev
Log:
Fix build on platforms that don't have dlfcn.h
Modified:
lldb/trunk/source/Plugins/Platform/MacOSX/PlatformAppleSimulator.cpp
Modified:
chaoren created this revision.
chaoren added a reviewer: granata.enrico.
chaoren added a subscriber: lldb-commits.
http://reviews.llvm.org/D14388
Files:
source/Plugins/Platform/MacOSX/PlatformiOSSimulatorCoreSimulatorSupport.h
Author: zturner
Date: Thu Nov 5 13:22:28 2015
New Revision: 252191
URL: http://llvm.org/viewvc/llvm-project?rev=252191=rev
Log:
Python 3 - Turn on absolute imports, and fix existing imports.
Absolute imports were introduced in Python 2.5 as a feature
(e.g. from __future__ import
brucem added a comment.
Even if it were, in some of the files, almost every line would change anyway
due to semicolons and then due to incorrect whitespace.
http://reviews.llvm.org/D14375
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
Author: enrico
Date: Thu Nov 5 12:23:10 2015
New Revision: 252179
URL: http://llvm.org/viewvc/llvm-project?rev=252179=rev
Log:
Do not build any of the simulator material on non-Darwin
Modified:
lldb/trunk/source/Plugins/Platform/MacOSX/CMakeLists.txt
Modified:
Author: jingham
Date: Thu Nov 5 12:51:48 2015
New Revision: 252184
URL: http://llvm.org/viewvc/llvm-project?rev=252184=rev
Log:
Remove Copy and Paste error in a comment.
Modified:
lldb/trunk/include/lldb/Symbol/CompileUnit.h
Modified: lldb/trunk/include/lldb/Symbol/CompileUnit.h
URL:
Author: jingham
Date: Thu Nov 5 16:33:17 2015
New Revision: 252224
URL: http://llvm.org/viewvc/llvm-project?rev=252224=rev
Log:
Let the process help figure out the Host OS if nobody else
can figure it out.
Modified:
lldb/trunk/include/lldb/Target/Platform.h
Author: jmolenda
Date: Thu Nov 5 17:03:44 2015
New Revision: 252227
URL: http://llvm.org/viewvc/llvm-project?rev=252227=rev
Log:
Add support for the new (added last week) llvm::Triple::WatchOS and ::TvOS
in places where we check for Triple::IOS. They're mostly the same as far
as lldb is
Author: jmolenda
Date: Thu Nov 5 17:42:18 2015
New Revision: 252234
URL: http://llvm.org/viewvc/llvm-project?rev=252234=rev
Log:
Update for tvos or watchos builds.
Modified:
lldb/trunk/scripts/package-clang-headers.py
Modified: lldb/trunk/scripts/package-clang-headers.py
URL:
Author: jingham
Date: Thu Nov 5 17:52:05 2015
New Revision: 252240
URL: http://llvm.org/viewvc/llvm-project?rev=252240=rev
Log:
Add a generic API to return the Concrete type for a given abstract type
name and the execution context in which it is realized.
Modified:
Author: jmolenda
Date: Thu Nov 5 17:51:05 2015
New Revision: 252239
URL: http://llvm.org/viewvc/llvm-project?rev=252239=rev
Log:
GDBRemoteCommunicationClient::SendEnvironmentPacket should use the hex-encoded
env packet if the '*' character used for run length encoding is present.
Modified:
Author: chaoren
Date: Thu Nov 5 17:19:27 2015
New Revision: 252230
URL: http://llvm.org/viewvc/llvm-project?rev=252230=rev
Log:
Another import fix for OS X.
Modified:
lldb/trunk/packages/Python/lldbsuite/test/dotest.py
Modified: lldb/trunk/packages/Python/lldbsuite/test/dotest.py
URL:
zturner created this revision.
zturner added reviewers: tfiala, tberghammer, labath.
zturner added a subscriber: lldb-commits.
The specific exception types that are thrown internally by unittest2 are
considered implementation details and even documented as such in the source
code of the
Author: jmolenda
Date: Thu Nov 5 17:04:57 2015
New Revision: 252228
URL: http://llvm.org/viewvc/llvm-project?rev=252228=rev
Log:
Add support for one API used to detect if a process
is running under System Integrity Protection on
Mac OS X 10.11. The rootless_allows_task_for_pid() spi
(see
Author: jmolenda
Date: Thu Nov 5 17:44:08 2015
New Revision: 252235
URL: http://llvm.org/viewvc/llvm-project?rev=252235=rev
Log:
Update the invocation to dsymForUUID (a script plugin used
at Apple, called by the DebugSymbols private framework to
find a dSYM for a UUID on mac) to include the
Author: brucem
Date: Thu Nov 5 17:48:41 2015
New Revision: 252238
URL: http://llvm.org/viewvc/llvm-project?rev=252238=rev
Log:
Fix cmake build on Mac OS X.
PlatformDarwin uses Host/XML.h which needs to find libxml2, and
so it needs to be told how to find the headers.
Modified:
Author: jmolenda
Date: Thu Nov 5 17:54:29 2015
New Revision: 252242
URL: http://llvm.org/viewvc/llvm-project?rev=252242=rev
Log:
Use Process::IsAlive instead of just checking for eStateExited.
Two minor tweaks to GetLoadedDynamicLibrariesInfos.
Modified:
zturner created this revision.
zturner added a reviewer: tfiala.
zturner added a subscriber: lldb-commits.
TBH I'm honestly not sure what the problem was before, or why this fixes
it. But what I can tell from debugging is that under Py3,
`sortMethodsUsing` is treated as a class
Author: jmolenda
Date: Thu Nov 5 16:51:29 2015
New Revision: 252225
URL: http://llvm.org/viewvc/llvm-project?rev=252225=rev
Log:
Add support for the armv7k ABI which has some small
changes from the normal armv7 ABI used on darwin.
Modified:
Author: jmolenda
Date: Thu Nov 5 17:59:30 2015
New Revision: 252245
URL: http://llvm.org/viewvc/llvm-project?rev=252245=rev
Log:
Add a warning to TargetList::CreateTargetInternal
so when it is run on a kext (which won't activate
any platform plugins), you'll get a warning message
which may be
krytarowski updated this revision to Diff 39440.
krytarowski added a comment.
Rebase to master
Repository:
rL LLVM
http://reviews.llvm.org/D14037
Files:
source/Core/IOHandler.cpp
Index: source/Core/IOHandler.cpp
===
---
This revision was automatically updated to reflect the committed changes.
Closed by commit rL252250: Reuse native curses(8) library on NetBSD (authored
by brucem).
Changed prior to commit:
http://reviews.llvm.org/D14037?vs=39440=39444#toc
Repository:
rL LLVM
http://reviews.llvm.org/D14037
Author: brucem
Date: Thu Nov 5 18:21:18 2015
New Revision: 252250
URL: http://llvm.org/viewvc/llvm-project?rev=252250=rev
Log:
Reuse native curses(8) library on NetBSD
Summary:
The reason for it is limit of detecting ncurses on various systems. For
example, Ubuntu ships with and linkage from ,
Hi, I think this changed caused all of the OS X tests to fail:
http://lab.llvm.org:8011/builders/lldb-x86_64-darwin-13.4/builds/6969/steps/test1/logs/stdio
with this error:
Traceback (most recent call last):
File "/Users/lldb_build/lldbSlave/buildDir/scripts/../lldb/test/dotest.py",
line 7,
This revision was automatically updated to reflect the committed changes.
Closed by commit rL252205: Completely avoid building Apple simulator on
non-Darwin platforms. (authored by chaoren).
Changed prior to commit:
http://reviews.llvm.org/D14389?vs=39394=39402#toc
Repository:
rL LLVM
chaoren added a comment.
I haven't seen anything else that uses LLVM_OPTIONAL_SOURCES, but it's
conceivable that there might be items in the list already, and I would like to
avoid doing anything to it besides just appending.
http://reviews.llvm.org/D14389
rL252218 should hopefully fix it.
On Thu, Nov 5, 2015 at 1:53 PM, Chaoren Lin wrote:
> Hi, I think this changed caused all of the OS X tests to fail:
>
>
> http://lab.llvm.org:8011/builders/lldb-x86_64-darwin-13.4/builds/6969/steps/test1/logs/stdio
>
> with this error:
>
>
zturner added a comment.
Ahh makes sense, I didn't know about that. I think a cleaner way to do this is
to just add everything to `PLUGIN_PLATFORM_MACOSX_SOURCES` in the very first
`list(APPEND)`. Then just do this:
if (NOT CMAKE_SYSTEM_NAME MATCHES "Darwin")
Thanks, yea that looks like the right fix.
On Thu, Nov 5, 2015 at 2:10 PM Chaoren Lin wrote:
> rL252218 should hopefully fix it.
>
> On Thu, Nov 5, 2015 at 1:53 PM, Chaoren Lin wrote:
>
>> Hi, I think this changed caused all of the OS X tests to fail:
zturner accepted this revision.
zturner added a comment.
This revision is now accepted and ready to land.
I find the code to be a fair bit harder to understand as a result, but I guess
it's not the end of the world.
Searching the source of LLVM's CMake infrastructure, this variable exists
brucem created this revision.
brucem added a reviewer: clayborg.
brucem added a subscriber: lldb-commits.
Herald added a subscriber: emaste.
Since this is within the lldb namespace, the compiler tries to
export a symbol for it. Unfortunately, since it is inlined, the
symbol is hidden and this
labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
From what I can tell, it should just work. I assume you've done the obvious
checks, like deliberately failing a test and seeing it registers as failed,
etc. I think we should just commit it,
labath added a comment.
(The upstream unittest does not seem to have the bugnumber feature. I am
assuming the intention here is to make this upstream compatible, in hope of
moving over there at some point.)
http://reviews.llvm.org/D14406
___
Author: jmolenda
Date: Thu Nov 5 18:55:17 2015
New Revision: 252254
URL: http://llvm.org/viewvc/llvm-project?rev=252254=rev
Log:
Jim thinks we shouldn't bother to pollute the svn repo with these
internal details, so I'll pull it back to just our own branch
of the sources.
Modified:
tberghammer added inline comments.
Comment at: packages/Python/lldbsuite/test/lldbtest.py:605
@@ -611,2 +604,3 @@
if expected_fn(self):
-raise case._UnexpectedSuccess(sys.exc_info(), bugnumber)
+xfail_func =
Author: jmolenda
Date: Thu Nov 5 19:43:36 2015
New Revision: 252264
URL: http://llvm.org/viewvc/llvm-project?rev=252264=rev
Log:
A little more careful handling of platforms and unspecified unknown
vendors & oses, especially on Apple, to handle the new environment
where we have more than macosx
Author: enrico
Date: Thu Nov 5 20:43:32 2015
New Revision: 252269
URL: http://llvm.org/viewvc/llvm-project?rev=252269=rev
Log:
Add data formatters for NSError and NSException
Added:
lldb/trunk/source/Plugins/Language/ObjC/NSError.cpp
brucem created this revision.
brucem added reviewers: zturner, domipheus.
brucem added a subscriber: lldb-commits.
Remove per-platform variants of this in favor of just having
Windows and Unix. The code that was previously specific to
Linux can be further simplified and used on all non-Windows
55 matches
Mail list logo