[Lldb-commits] [PATCH] D14542: [lldb] Fix name lookup in ClangASTContext

evgeny777 created this revision. evgeny777 added a reviewer: clayborg. evgeny777 added subscribers: lldb-commits, KLapshin. The check for already searched namespaces has disappeared from DeclContextFindDeclByName() recently. This breaks variable evaluation in many cases, for example in this one

Re: [Lldb-commits] [PATCH] D14542: [lldb] Fix name lookup in ClangASTContext

tberghammer added a subscriber: tberghammer. tberghammer requested changes to this revision. tberghammer added a reviewer: tberghammer. tberghammer added a comment. This revision now requires changes to proceed. Please create a test case for this scenario so it won't break again

Re: [Lldb-commits] [PATCH] D14531: Add more autotools/gmake NetBSD glue

tberghammer added a comment. If you want to autotools build support fro FenBSD then please go for it, but wanted to mention that it will most likely go away within a few month so you won't invest too much time into it. Repository: rL LLVM http://reviews.llvm.org/D14531

[Lldb-commits] [lldb] r252637 - This test is now passing on Darwin

Author: enrico Date: Tue Nov 10 13:07:42 2015 New Revision: 252637 URL: http://llvm.org/viewvc/llvm-project?rev=252637=rev Log: This test is now passing on Darwin Modified: lldb/trunk/packages/Python/lldbsuite/test/lang/c/const_variables/TestConstVariables.py Modified:

[Lldb-commits] [lldb] r252622 - Fixed TypeMemberFunctionImpl to not use clang types directly but use the new CompilerDecl class to do the job in an abstract way.

Author: gclayton Date: Tue Nov 10 11:47:04 2015 New Revision: 252622 URL: http://llvm.org/viewvc/llvm-project?rev=252622=rev Log: Fixed TypeMemberFunctionImpl to not use clang types directly but use the new CompilerDecl class to do the job in an abstract way. Fixed a crash that would happen if

Re: [Lldb-commits] [PATCH] D13819: LLDBStandalone: Report nice errors on missing vars

This revision was automatically updated to reflect the committed changes. Closed by commit rL252624: LLDBStandalone: Report nice errors on missing vars (authored by artagnon). Changed prior to commit: http://reviews.llvm.org/D13819?vs=37616=39822#toc Repository: rL LLVM

[Lldb-commits] [lldb] r252638 - Upstream changes to the ValueObjectPrinter; nfc

Author: enrico Date: Tue Nov 10 13:07:58 2015 New Revision: 252638 URL: http://llvm.org/viewvc/llvm-project?rev=252638=rev Log: Upstream changes to the ValueObjectPrinter; nfc Modified: lldb/trunk/include/lldb/DataFormatters/DumpValueObjectOptions.h

Re: [Lldb-commits] [PATCH] D14524: Create a `PythonModule` class and add a root-level method for name lookup

tfiala added a subscriber: tfiala. tfiala added a comment. (Which I guess means Greg, seeing Enrico's comment earlier!) http://reviews.llvm.org/D14524 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

Re: [Lldb-commits] [lldb] r252583 - The other half of a change made by Enrico for trying to get a correct

Yeah, we can get some gtests in for this. I'll tail back on it. It'll be a bit before I can put cycles on it but it's on my list. On Mon, Nov 9, 2015 at 9:46 PM, Zachary Turner wrote: > This is really the kind of thing that would be good to write a unit test > for.

[Lldb-commits] [lldb] r252655 - Fixed a bug where the size of a type was used instead of the size of a pointer.

Author: spyffe Date: Tue Nov 10 15:48:05 2015 New Revision: 252655 URL: http://llvm.org/viewvc/llvm-project?rev=252655=rev Log: Fixed a bug where the size of a type was used instead of the size of a pointer. Modified: lldb/trunk/source/Expression/Materializer.cpp Modified:

[Lldb-commits] [PATCH] D14549: Use uniqueness of C++ fully-qualified names to resolve conflicts

artagnon created this revision. artagnon added reviewers: clayborg, tfiala. artagnon added a subscriber: lldb-commits. A very expected layout: source tree is in ~/src/llvm, the build directory is in ~/src/llvm-build, and the install location is in /usr/local/{lib,include}. The DWARF information

[Lldb-commits] [lldb] r252642 - Updated lldb_pylint_helper to work with recent Python package changes.

Author: tfiala Date: Tue Nov 10 14:01:33 2015 New Revision: 252642 URL: http://llvm.org/viewvc/llvm-project?rev=252642=rev Log: Updated lldb_pylint_helper to work with recent Python package changes. Modified: lldb/trunk/packages/Python/lldbsuite/test/lldb_pylint_helper.py Modified:

Re: [Lldb-commits] [PATCH] D14524: Create a `PythonModule` class and add a root-level method for name lookup

tfiala resigned from this revision. tfiala removed a reviewer: tfiala. tfiala added a comment. Zachary, I am going to defer to Enrico on this. He has better context. http://reviews.llvm.org/D14524 ___ lldb-commits mailing list

[Lldb-commits] [lldb] r252663 - Introduce a way for Languages to specify whether values of "reference types" are "nil" (not pointing to anything) or uninitialized (never made to point at anything)

Author: enrico Date: Tue Nov 10 16:39:15 2015 New Revision: 252663 URL: http://llvm.org/viewvc/llvm-project?rev=252663=rev Log: Introduce a way for Languages to specify whether values of "reference types" are "nil" (not pointing to anything) or uninitialized (never made to point at anything)

[Lldb-commits] [lldb] r252665 - Made the ClangASTImporter into a shared pointer, eliminating a race condition.

Author: spyffe Date: Tue Nov 10 16:54:42 2015 New Revision: 252665 URL: http://llvm.org/viewvc/llvm-project?rev=252665=rev Log: Made the ClangASTImporter into a shared pointer, eliminating a race condition. It used to be a unique pointer, and there could be a case where ClangASTSource held onto

[Lldb-commits] [lldb] r252657 - Updated a relative path in Makefile.rules to reflect the new testsuite location.

Author: spyffe Date: Tue Nov 10 15:56:04 2015 New Revision: 252657 URL: http://llvm.org/viewvc/llvm-project?rev=252657=rev Log: Updated a relative path in Makefile.rules to reflect the new testsuite location. Modified: lldb/trunk/packages/Python/lldbsuite/test/make/Makefile.rules Modified:

[Lldb-commits] [PATCH] D14555: Create PythonCallable and PythonTuple wrappers with appropriate unit tests

zturner created this revision. zturner added reviewers: granata.enrico, clayborg. zturner added a subscriber: lldb-commits. zturner added a dependency: D14524: Create a `PythonModule` class and add a root-level method for name lookup. This adds PythonTuple and PythonCallable classes to

Re: [Lldb-commits] [PATCH] D14507: Make sure we use symbol flags to detect thumbness.

sas added a comment. Ok I'll integrate that with the code that uses m_address_class_map. http://reviews.llvm.org/D14507 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D14531: Add more autotools/gmake NetBSD glue

krytarowski created this revision. krytarowski added subscribers: lldb-commits, brucem, joerg. krytarowski set the repository for this revision to rL LLVM. This diff approaches building the project natively on NetBSD with the autoconf/gmake framework. Repository: rL LLVM

Re: [Lldb-commits] [PATCH] D14507: Make sure we use symbol flags to detect thumbness.

tberghammer requested changes to this revision. Comment at: source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp:2191-2213 @@ -2170,25 +2190,25 @@ if (arch.GetMachine() == llvm::Triple::arm) { if (symbol_type == eSymbolTypeCode)

Re: [Lldb-commits] [PATCH] D14531: Add more autotools/gmake NetBSD glue

tberghammer added a subscriber: tberghammer. tberghammer added a comment. I have no objection against this change but considering that LLVM plans to remove the autotools/gmake support after branching the 3.8 release (most likely in January 2016) it would be good if you can bring up CMake on

[Lldb-commits] [PATCH] D14538: Fix DwarfSymbolFile when appending global functions from different modules

ADodds created this revision. ADodds added a reviewer: clayborg. ADodds added a subscriber: lldb-commits. ADodds set the repository for this revision to rL LLVM. This patch fixes a bug in SymbolFileDWARF::FindFunctions(), where functions may not be correctly found when appending to a list

Re: [Lldb-commits] [PATCH] D14538: Fix DwarfSymbolFile when appending global functions from different modules

tberghammer added a subscriber: tberghammer. tberghammer accepted this revision. tberghammer added a reviewer: tberghammer. tberghammer added a comment. This revision is now accepted and ready to land. Looks good (I remember fixing some similar issues in SymbolFileDWARF where we specify

[Lldb-commits] [PATCH] D14536: Add empty symbols to symtab for skipped symbols

tberghammer created this revision. tberghammer added a reviewer: clayborg. tberghammer added a subscriber: lldb-commits. Herald added a subscriber: aemerson. Add empty symbols to symtab for skipped symbols LLDB skips several special purpose symbols during symtab parsing (e.g.: arm/aarch64

[Lldb-commits] [lldb] r252707 - Marked test_qRegisterInfo_returns_{one_valid_result, all_valid_results} XFAIL on Darwin.

Author: tfiala Date: Wed Nov 11 00:32:44 2015 New Revision: 252707 URL: http://llvm.org/viewvc/llvm-project?rev=252707=rev Log: Marked test_qRegisterInfo_returns_{one_valid_result,all_valid_results} XFAIL on Darwin. Tracked by: https://llvm.org/bugs/show_bug.cgi?id=25486 Modified:

Re: [Lldb-commits] [PATCH] D14538: Fix DwarfSymbolFile when appending global functions from different modules

This revision was automatically updated to reflect the committed changes. Closed by commit rL252605: Differential Revision: http://reviews.llvm.org/D14538 (authored by aidandodds). Changed prior to commit: http://reviews.llvm.org/D14538?vs=39802=39809#toc Repository: rL LLVM

[Lldb-commits] [lldb] r252605 - Differential Revision: http://reviews.llvm.org/D14538

Author: aidandodds Date: Tue Nov 10 08:10:57 2015 New Revision: 252605 URL: http://llvm.org/viewvc/llvm-project?rev=252605=rev Log: Differential Revision: http://reviews.llvm.org/D14538 Modified: lldb/trunk/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp Modified:

Re: [Lldb-commits] [PATCH] D14555: Create PythonCallable and PythonTuple wrappers with appropriate unit tests

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko added a comment. Please also run Clang-tidy modernize checks. Comment at: source/Plugins/ScriptInterpreter/Python/PythonDataObjects.cpp:895 @@ +894,3 @@ + + +void Unnecessary line.

Re: [Lldb-commits] [PATCH] D14524: Create a `PythonModule` class and add a root-level method for name lookup

tfiala added a comment. Okay Greg's not had a chance to look at this. I just had a look at it. I'm okay with it, Zachary. Feel free to check it in. http://reviews.llvm.org/D14524 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [lldb] r252702 - Mark TestCompletion.py test_symbol_name_dwarf XFAIL on Darwin.

Author: tfiala Date: Tue Nov 10 23:01:30 2015 New Revision: 252702 URL: http://llvm.org/viewvc/llvm-project?rev=252702=rev Log: Mark TestCompletion.py test_symbol_name_dwarf XFAIL on Darwin. This test fails most of the time when run under heavy load. The dsym variant doesn't seem to be failing.

[Lldb-commits] [lldb] r252703 - Bump up test timeout interval on Darwin from 4 to 6 minutes.

Author: tfiala Date: Tue Nov 10 23:10:07 2015 New Revision: 252703 URL: http://llvm.org/viewvc/llvm-project?rev=252703=rev Log: Bump up test timeout interval on Darwin from 4 to 6 minutes. We have several tests that TIMEOUT under heavy load but just need a bit more time to complete. Modified:

Re: [Lldb-commits] [PATCH] D14531: Add more autotools/gmake NetBSD glue

krytarowski added a comment. In http://reviews.llvm.org/D14531#285997, @tberghammer wrote: > I have no objection against this change but considering that LLVM plans to > remove the autotools/gmake support after branching the 3.8 release (most > likely in January 2016) it would be good if you

[Lldb-commits] [lldb] r252699 - Mark TestTerminal.py as XFAIL on OS X.

Author: tfiala Date: Tue Nov 10 21:43:05 2015 New Revision: 252699 URL: http://llvm.org/viewvc/llvm-project?rev=252699=rev Log: Mark TestTerminal.py as XFAIL on OS X. See the following tracking bug: https://llvm.org/bugs/show_bug.cgi?id=25484 Modified: