Re: [Lldb-commits] [PATCH] D14673: Fix buildbot breakage after r253106

zturner added a comment. In http://reviews.llvm.org/D14673#290280, @jingham wrote: > If the problem is that the self of the test object doesn't always have a > debug_info setting, why not just always initialize it to None? Seems weird > to have a general property like this that we don't

[Lldb-commits] [PATCH] D14718: Insert the SWIG version into LLDB's __init__.py

zturner created this revision. zturner added a reviewer: tfiala. zturner added a subscriber: lldb-commits. The goal here is to allow us to add expectedFailure / etc decorators based on SWIG version. The end result of this is that patch is that after running SWIG generation you will have a line

Re: [Lldb-commits] [PATCH] D14633: [LLDB][MIPS] Clear bug 25194 - LLDB-Server Assertion raised when single stepping on MIPS

clayborg requested changes to this revision. This revision now requires changes to proceed. Comment at: source/Plugins/Process/Linux/NativeRegisterContextLinux_mips64.cpp:1378 @@ -1377,2 +1377,3 @@ GPR_linux_mips regs; +lldb_private::ArchSpec arch; ::memset(, 0,

Re: [Lldb-commits] [PATCH] D14673: Fix buildbot breakage after r253106

jingham added a comment. If the problem is that the self of the test object doesn't always have a debug_info setting, why not just always initialize it to None? Seems weird to have a general property like this that we don't initialize. http://reviews.llvm.org/D14673

[Lldb-commits] [lldb] r253263 - Add the ability to xfail or skip based on swig / python version.

Author: zturner Date: Mon Nov 16 16:40:30 2015 New Revision: 253263 URL: http://llvm.org/viewvc/llvm-project?rev=253263=rev Log: Add the ability to xfail or skip based on swig / python version. Modified: lldb/trunk/packages/Python/lldbsuite/test/lldbtest.py Modified:

[Lldb-commits] [lldb] r253262 - Insert the SWIG version into LLDB's __init__.py

Author: zturner Date: Mon Nov 16 16:40:20 2015 New Revision: 253262 URL: http://llvm.org/viewvc/llvm-project?rev=253262=rev Log: Insert the SWIG version into LLDB's __init__.py The goal here is to allow us to add skip / xfail decorators based on SWIG version. Modified:

[Lldb-commits] [lldb] r253261 - Python3 - Fix some issues related to `PythonFile` class.

Author: zturner Date: Mon Nov 16 16:40:12 2015 New Revision: 253261 URL: http://llvm.org/viewvc/llvm-project?rev=253261=rev Log: Python3 - Fix some issues related to `PythonFile` class. Python 3 has lots of new debug asserts, and some of these were firing on PythonFile. Specifically related to

Re: [Lldb-commits] [PATCH] D14673: Fix buildbot breakage after r253106

chying added a comment. In http://reviews.llvm.org/D14673#290556, @zturner wrote: > Ahh, sorry. I litearlly just committed a change to the same function. You > may have to do a merge, sorry about that. Ahh, I see, will merge again. http://reviews.llvm.org/D14673

Re: [Lldb-commits] [PATCH] D14673: Fix buildbot breakage after r253106

chying updated this revision to Diff 40347. chying added a comment. Recommit r253106 - Add a "not_in()" function you can apply to the list type arguments to expectedFailureAll ... Initialize self.debug_info in Base::setUp() Check for None before calling "value in list"

Re: [Lldb-commits] [PATCH] D14631: [dwarf] Handle DWARF forms for address other than DW_FORM_GNU_addr_index and DW_FORM_addr.

dawn added a comment. In http://reviews.llvm.org/D14631#289917, @tberghammer wrote: > How you end up in calling DWARFFormValue::Address() with a value what have a > form type other then DW_FORM_addr and DW_FORM_GNU_addr_index? What is the > attribute tag and the form type used? Can you post a

Re: [Lldb-commits] [PATCH] D14673: Fix buildbot breakage after r253106

chying added a comment. The compiler None check is because inside of check_list_or_lambda function, it checks for "value in list_or_lamda", which will throw exception if value is None I agree that the code will be cleaner if debug_info is initialized to None. Will try to upload another patch

[Lldb-commits] [PATCH] D14726: Add the ability to skip or xfail based on Python and/or SWIG version

zturner created this revision. zturner added reviewers: tfiala, clayborg. zturner added a subscriber: lldb-commits. http://reviews.llvm.org/D14726 Files: packages/Python/lldbsuite/test/lldbtest.py Index: packages/Python/lldbsuite/test/lldbtest.py

Re: [Lldb-commits] [PATCH] D14673: Fix buildbot breakage after r253106

This revision was automatically updated to reflect the committed changes. Closed by commit rL253272: Re-Apply "Add a "not_in()" function you can apply to the list type arguments… (authored by chying). Changed prior to commit: http://reviews.llvm.org/D14673?vs=40353=40357#toc Repository: rL

Re: [Lldb-commits] [PATCH] D14689: Embed libpanel(3) for NetBSD-7.0

krytarowski abandoned this revision. krytarowski added a comment. I will go with other way around. If curses(3) or libpanel(3) is missing, disable the curses(3) option for LLDB. Repository: rL LLVM http://reviews.llvm.org/D14689 ___

Re: [Lldb-commits] [PATCH] D14673: Fix buildbot breakage after r253106

chying updated this revision to Diff 40353. chying added a comment. Rebase on the latest commit. http://reviews.llvm.org/D14673 Files: packages/Python/lldbsuite/test/functionalities/breakpoint/consecutive_breakpoins/TestConsecutiveBreakpoints.py packages/Python/lldbsuite/test/lldbtest.py

[Lldb-commits] LLVM buildmaster will be restarted tonight

Hello everyone, LLVM buildmaster will be updated restarted after 7 PM Pacific time today. Thanks Galina ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] r253273 - Python 3 - Skip a certain test for a particular (swig, python) combo.

Author: zturner Date: Mon Nov 16 17:58:20 2015 New Revision: 253273 URL: http://llvm.org/viewvc/llvm-project?rev=253273=rev Log: Python 3 - Skip a certain test for a particular (swig,python) combo. Current versions of SWIG have a bug with Python 3 that causes Python to assert when iterating over

Re: [Lldb-commits] [PATCH] D14689: Embed libpanel(3) for NetBSD-7.0

tberghammer added a subscriber: tberghammer. tberghammer added a comment. Can't you address this issue with compiling LLDB on NetBSD with -DLLDB_DISABLE_CURSES? If you want to go with the current approach then you should add somebody who can verify that committing it in to the LLVM source tree

[Lldb-commits] [PATCH] D14740: Define LLDB_DISABLE_CURSES as a fallback for missing curses(3) or panel(3)

krytarowski created this revision. krytarowski added reviewers: clayborg, emaste. krytarowski added subscribers: lldb-commits, joerg, brucem. krytarowski set the repository for this revision to rL LLVM. This enables build on NetBSD-7.0. It would be nice to have a fall-back for externally provided

[Lldb-commits] [lldb] r253272 - Re-Apply "Add a "not_in()" function you can apply to the list type arguments to expectedFailureAll ..." with fix

Author: chying Date: Mon Nov 16 17:41:02 2015 New Revision: 253272 URL: http://llvm.org/viewvc/llvm-project?rev=253272=rev Log: Re-Apply "Add a "not_in()" function you can apply to the list type arguments to expectedFailureAll ..." with fix Summary: - Re-Commit r253106 - Initialize

[Lldb-commits] [lldb] r253308 - Add the ability (through the SB API & command line) to specify an address

Author: jingham Date: Mon Nov 16 21:39:13 2015 New Revision: 253308 URL: http://llvm.org/viewvc/llvm-project?rev=253308=rev Log: Add the ability (through the SB API & command line) to specify an address breakpoint as "file address" so that the address breakpoint will track that module even if it

Re: [Lldb-commits] [PATCH] D14633: [LLDB][MIPS] Clear bug 25194 - LLDB-Server Assertion raised when single stepping on MIPS

sagar updated this revision to Diff 40256. sagar added a comment. Addressed review comments. Repository: rL LLVM http://reviews.llvm.org/D14633 Files: source/Plugins/Process/Linux/NativeRegisterContextLinux_mips64.cpp Index:

Re: [Lldb-commits] [PATCH] D14633: [LLDB][MIPS] Clear bug 25194 - LLDB-Server Assertion raised when single stepping on MIPS

sagar added a comment. > Admittedly it's a bit unintuitive for an unsigned 32-bit value from a MIPS32 > binary to be represented in a 64-bit register as, for example, > 0x8000 but the debugger shouldn't normally admit to the existence > of the extra bits when debugging 32-bit code

Re: [Lldb-commits] [PATCH] D14689: Embed libpanel(3) for NetBSD-7.0

joerg added a comment. I'd settle for requiring ncurses for 7.0 and get libpanel into 7.1. Repository: rL LLVM http://reviews.llvm.org/D14689 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

Re: [Lldb-commits] [PATCH] D14633: [LLDB][MIPS] Clear bug 25194 - LLDB-Server Assertion raised when single stepping on MIPS

tberghammer added a comment. Looks much better, but I think the root cause of your problem is that you are using RegisterValue::SetBytes instead of RegisterValue::SetUInt. I would suggest to use a code like this (I don't have a mips environment at the moment to try it out): Error

Re: [Lldb-commits] [PATCH] D14631: [dwarf] Handle DWARF forms for address other than DW_FORM_GNU_addr_index and DW_FORM_addr.

tberghammer added a comment. The feature Greg mentioned is already implemented in DWARFDebugInfoEntry::GetAttributeHighPC and we shouldn't move it to DWARFFormValue::Address because it is only needed for DW_AT_high_pc but DWARFFormValue::Address used for other places as well (e.g.

[Lldb-commits] [lldb] r253197 - Revert "Add a "not_in()" function you can apply to the list type arguments to expectedFailureAll to reverse"

Author: labath Date: Mon Nov 16 05:11:10 2015 New Revision: 253197 URL: http://llvm.org/viewvc/llvm-project?rev=253197=rev Log: Revert "Add a "not_in()" function you can apply to the list type arguments to expectedFailureAll to reverse" This reverts commit r253106. Modified:

[Lldb-commits] [lldb] r253319 - Revert out Xcode hookup of r253317.

Author: tfiala Date: Tue Nov 17 01:56:42 2015 New Revision: 253319 URL: http://llvm.org/viewvc/llvm-project?rev=253319=rev Log: Revert out Xcode hookup of r253317. The green dragon OS X builder doesn't have swig on the path. I need to enable behavior where we can look for it in some well known

Re: [Lldb-commits] [PATCH] D14726: Add the ability to skip or xfail based on Python and/or SWIG version

tfiala accepted this revision. tfiala added a comment. Yep, looks good. http://reviews.llvm.org/D14726 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] r253317 - Add Pythonic language binding wrapper generation script.

Author: tfiala Date: Tue Nov 17 01:17:38 2015 New Revision: 253317 URL: http://llvm.org/viewvc/llvm-project?rev=253317=rev Log: Add Pythonic language binding wrapper generation script. This is only used by Xcode at the moment. It replaces the buildSwigWrapperClasses.py and related

Re: [Lldb-commits] [PATCH] D14718: Insert the SWIG version into LLDB's __init__.py

tfiala accepted this revision. tfiala added a comment. This revision is now accepted and ready to land. LGTM http://reviews.llvm.org/D14718 ___ lldb-commits mailing list lldb-commits@lists.llvm.org