Re: [Lldb-commits] [PATCH] D15182: [MIPS] Fix TestCrashDuringStep.py for MIPS

labath accepted this revision. labath added a reviewer: labath. labath added a comment. This revision is now accepted and ready to land. Thanks. If you wish, you can link it to the same bug as the arm xfail above, as that is the same underlying issue. Repository: rL LLVM

Re: [Lldb-commits] [PATCH] D15182: [MIPS] Fix TestCrashDuringStep.py for MIPS

jaydeep closed this revision. jaydeep added a comment. Closed by commit http://reviews.llvm.org/rL254710 Repository: rL LLVM http://reviews.llvm.org/D15182 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [lldb] r254711 - [LLDB][MIPS] Fix gdbremote_testcase.py

Author: mohit.bhakkad Date: Fri Dec 4 03:58:07 2015 New Revision: 254711 URL: http://llvm.org/viewvc/llvm-project?rev=254711=rev Log: [LLDB][MIPS] Fix gdbremote_testcase.py Patch by Nitesh Jain Reviewers: clayborg, ovyalov. Subscribers: jaydeep, bhushan, mohit.bhakkad, sagar. Differential

[Lldb-commits] [lldb] r254710 - [LLDB][MIPS] XFAIL TestCrashDuringStep.py for MIPS

Author: jaydeep Date: Fri Dec 4 03:56:36 2015 New Revision: 254710 URL: http://llvm.org/viewvc/llvm-project?rev=254710=rev Log: [LLDB][MIPS] XFAIL TestCrashDuringStep.py for MIPS SUMMARY: Marked TestCrashDuringStep.py as XFAIL for MIPS. The test generates IO error due to breakpoint at

Re: [Lldb-commits] [PATCH] D15152: Add a new option to Platform::LoadImage to install the image

tberghammer retitled this revision from "Change Platform::LoadImage to copy the file to the remote platform" to "Add a new option to Platform::LoadImage to install the image". tberghammer updated the summary for this revision. tberghammer updated this revision to Diff 41877. tberghammer added a

Re: [Lldb-commits] [PATCH] D14952: Modify "platform connect" to connect to processes as well

labath added a comment. Just a tiny remark from my side.. Comment at: source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerPlatform.cpp:184 @@ +183,3 @@ +std::string hostname; +// TODO: /tmp/ should not be hardcoded. User might want to override /tmp +//

Re: [Lldb-commits] [PATCH] D14952: Modify "platform connect" to connect to processes as well

tberghammer retitled this revision from "Create new "platform process connect" command" to "Modify "platform connect" to connect to processes as well". tberghammer updated the summary for this revision. tberghammer updated this revision to Diff 41867. http://reviews.llvm.org/D14952 Files:

Re: [Lldb-commits] [PATCH] D14952: Modify "platform connect" to connect to processes as well

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. So my main issue with this is the new virtual "Platform::GetPendingGdbServerList(...)" function. Can we remove this function and just put the functionality into

Re: [Lldb-commits] [PATCH] D15209: Fix script import --allow-reload on Python 3

tfiala added a comment. Looking at this now. http://reviews.llvm.org/D15209 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D15175: Fix breakpoint language filtering for other C variants (like C99) and Pascal.

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. OK. It would have been better to make a patch that fixes the specific problem with other C variants. That's just a straight up bug, and mixing it with comments on the two separate issues,

Re: [Lldb-commits] [PATCH] D15218: Implement GetMemoryRegionInfo for mini dumps.

amccarth updated this revision to Diff 41884. amccarth added a comment. Address comments. Factored the decoding of the page protection bits to share that logic between the live and mini dump debugging. http://reviews.llvm.org/D15218 Files:

[Lldb-commits] [PATCH] D15233: Make TestThreadStates more stable

labath created this revision. labath added a reviewer: clayborg. labath added a subscriber: lldb-commits. Because of the large number of XFAILs TestThreadStates has decayed quite a bit. This commit does the following: - removes the "breakpoint list" expectations. Most tests have been failing on

Re: [Lldb-commits] [PATCH] D15241: Simplify TestThreadSpecificBreakpoint.py

zturner added a comment. Also the origianl test as written was either flaky or disabled on almost every platform, so it doesn't seem like it was providing much value to anyone. http://reviews.llvm.org/D15241 ___ lldb-commits mailing list

[Lldb-commits] [lldb] r254768 - Fix typo in a comment

Author: kamil Date: Fri Dec 4 15:23:24 2015 New Revision: 254768 URL: http://llvm.org/viewvc/llvm-project?rev=254768=rev Log: Fix typo in a comment Modified: lldb/trunk/source/Core/IOHandler.cpp Modified: lldb/trunk/source/Core/IOHandler.cpp URL:

[Lldb-commits] [lldb] r254755 - Add a benchmark that validates how much time LLDB spends trying to fully print a fairly large std::list

Author: enrico Date: Fri Dec 4 13:40:26 2015 New Revision: 254755 URL: http://llvm.org/viewvc/llvm-project?rev=254755=rev Log: Add a benchmark that validates how much time LLDB spends trying to fully print a fairly large std::list This is meant to help me track optimizations to the libc++

Re: [Lldb-commits] [PATCH] D12809: Better scheme to lookup alternate mangled name when looking up function address.

dawn added a comment. In http://reviews.llvm.org/D12809#301752, @sivachandra wrote: > @dawn: Thanks for accepting the patch. I guess I still need to wait for > sign-off/comments from a CODE_OWNER. Yeah. Maybe add more proactive reviewers? And definitely be a squeaky wheel about it. Keep

[Lldb-commits] [lldb] r254757 - Improve the std::list data formatter to not need to calculate indices for every loop iteration

Author: enrico Date: Fri Dec 4 13:48:08 2015 New Revision: 254757 URL: http://llvm.org/viewvc/llvm-project?rev=254757=rev Log: Improve the std::list data formatter to not need to calculate indices for every loop iteration This saves about 5 seconds on a 1500 elements list from my local

[Lldb-commits] [lldb] r254758 - Fix an issue where all tests marked with skip_if_callable would be skipped regardless of the actual callable

Author: enrico Date: Fri Dec 4 13:50:05 2015 New Revision: 254758 URL: http://llvm.org/viewvc/llvm-project?rev=254758=rev Log: Fix an issue where all tests marked with skip_if_callable would be skipped regardless of the actual callable Modified:

[Lldb-commits] [PATCH] D15241: Simplify TestThreadSpecificBreakpoint.py

zturner created this revision. zturner added reviewers: jingham, labath. zturner added a subscriber: lldb-commits. This test would fail before if conditional breakpoints weren't working correctly, and the nature of the test (spinning up 10 threads, etc) opens the door to raciness.

[Lldb-commits] [lldb] r254762 - Cache the incremental iterators as you traverse the list, so that you don't have to keep recomputing them

Author: enrico Date: Fri Dec 4 14:12:46 2015 New Revision: 254762 URL: http://llvm.org/viewvc/llvm-project?rev=254762=rev Log: Cache the incremental iterators as you traverse the list, so that you don't have to keep recomputing them If memory turns out to be a problem, which I don't think it

Re: [Lldb-commits] [PATCH] D15241: Simplify TestThreadSpecificBreakpoint.py

jingham added a comment. It doesn't require any thread rendezvousing or anything fancy like that. http://reviews.llvm.org/D15241 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] r254787 - Reduce memory traffic in ConstString in the std::map formatter

Author: enrico Date: Fri Dec 4 16:49:27 2015 New Revision: 254787 URL: http://llvm.org/viewvc/llvm-project?rev=254787=rev Log: Reduce memory traffic in ConstString in the std::map formatter Modified: lldb/trunk/source/Plugins/Language/CPlusPlus/LibCxxMap.cpp Modified:

Re: [Lldb-commits] [PATCH] D15241: Simplify TestThreadSpecificBreakpoint.py

zturner added a comment. Ahh, derp. I commented that out when I was testing something locally, and forgot to uncomment it. So yea, that should be uncommented. I was having some trouble following the logic of the original test, so it's possible this test misses an edge case that I haven't

Re: [Lldb-commits] [PATCH] D15241: Simplify TestThreadSpecificBreakpoint.py

jingham added a comment. The logic was: - Set a breakpoint on some loop that will get hit multiple times in some thread worker function. - The first time it is hit, make it specific to the thread that hit it by setting a Thread ID on the breakpoint. - Then add a condition to the breakpoint

Re: [Lldb-commits] [PATCH] D15241: Simplify TestThreadSpecificBreakpoint.py

zturner added a comment. For now I'll just make this a separate test in the same file I guess. But it's a bummer to have a test that's broken almost everywhere. Makes me think something is wrong with the test instead of with LLDB. I agree with you though that it's not obvious what might be

[Lldb-commits] [lldb] r254779 - Add a similar benchmark for our std::map performance

Author: enrico Date: Fri Dec 4 16:16:14 2015 New Revision: 254779 URL: http://llvm.org/viewvc/llvm-project?rev=254779=rev Log: Add a similar benchmark for our std::map performance Added: lldb/trunk/packages/Python/lldbsuite/test/benchmarks/libcxxmap/

[Lldb-commits] [lldb] r254763 - Add documentation for SBTarget::CreateValueFromAddress.

Author: jingham Date: Fri Dec 4 14:16:51 2015 New Revision: 254763 URL: http://llvm.org/viewvc/llvm-project?rev=254763=rev Log: Add documentation for SBTarget::CreateValueFromAddress. Modified: lldb/trunk/scripts/interface/SBTarget.i Modified: lldb/trunk/scripts/interface/SBTarget.i URL:

Re: [Lldb-commits] [PATCH] D15241: Simplify TestThreadSpecificBreakpoint.py

zturner added a comment. Wouldn't the functionality that's tested by that combination of two things at the same be equivalently tested by this test, plus a test that only tests the behavior of conditional breakpoints? In other words, if you had two tests, one which only tests thread specific

Re: [Lldb-commits] [PATCH] D15241: Simplify TestThreadSpecificBreakpoint.py

jingham added a comment. The test that test "Only breakpoint conditions" will always have LLDB_INVALID_ID for the breakpoint thread ID. That means the thread test is a no-op. So it doesn't test the case "thread passes, condition doesn't" or "condition passes, thread doesn't". I wrote this

[Lldb-commits] [lldb] r254781 - Do the same iterator caching optimization for std::map

Author: enrico Date: Fri Dec 4 16:25:52 2015 New Revision: 254781 URL: http://llvm.org/viewvc/llvm-project?rev=254781=rev Log: Do the same iterator caching optimization for std::map This brings the timings down for 1500 elements from 166 to 2 seconds on my machine - if I can math correctly,

[Lldb-commits] [lldb] r254792 - Make TestThreadSpecificBreakpoint.py more focused.

Author: zturner Date: Fri Dec 4 16:59:41 2015 New Revision: 254792 URL: http://llvm.org/viewvc/llvm-project?rev=254792=rev Log: Make TestThreadSpecificBreakpoint.py more focused. This test would fail before if conditional breakpoints weren't working correctly, and the nature of the test

[Lldb-commits] [lldb] r254791 - Python 3 - Fix script import --allow-reload.

Author: zturner Date: Fri Dec 4 16:59:14 2015 New Revision: 254791 URL: http://llvm.org/viewvc/llvm-project?rev=254791=rev Log: Python 3 - Fix script import --allow-reload. Differential Revision: http://reviews.llvm.org/D15209 Reviewed By: Todd Fiala Modified:

Re: [Lldb-commits] [PATCH] D15218: Implement GetMemoryRegionInfo for mini dumps.

This revision was automatically updated to reflect the committed changes. Closed by commit rL254780: Implement GetMemoryRegionInfo for mini dumps. (authored by amccarth). Changed prior to commit: http://reviews.llvm.org/D15218?vs=41898=41940#toc Repository: rL LLVM

Re: [Lldb-commits] [PATCH] D15241: Simplify TestThreadSpecificBreakpoint.py

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. Anyway, adding a separate test is fine with me. http://reviews.llvm.org/D15241 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [lldb] r254790 - Make it clear how you would get the pointee out of an SBValue with

Author: jingham Date: Fri Dec 4 16:51:19 2015 New Revision: 254790 URL: http://llvm.org/viewvc/llvm-project?rev=254790=rev Log: Make it clear how you would get the pointee out of an SBValue with GetType().IsPointerType() returns true. Modified: lldb/trunk/include/lldb/API/SBValue.h

[Lldb-commits] [lldb] r254780 - Implement GetMemoryRegionInfo for mini dumps.

Author: amccarth Date: Fri Dec 4 16:22:15 2015 New Revision: 254780 URL: http://llvm.org/viewvc/llvm-project?rev=254780=rev Log: Implement GetMemoryRegionInfo for mini dumps. Differential Revision: http://reviews.llvm.org/D15218 Modified:

Re: [Lldb-commits] [PATCH] D15241: Simplify TestThreadSpecificBreakpoint.py

jingham added a comment. The comments in llvm.org/pr18522 seem to me to be bugs that the test is uncovering, not bugs in the test itself. It looks like we hit a breakpoint on thread A, and try to run the condition on thread B. In some cases, thread B isn't really alive yet, and so the

[Lldb-commits] LLVM buildmaster will be restarted tonight

Hello everyone, LLVM buildmaster will be updated and restarted after 7 PM Pacific time today. Thanks Galina ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D15152: Add a new option to Platform::LoadImage to install the image

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. Add header doc for the new LoadImage and make Platform::LoadImage virtual in case platforms want to override this and this is good to go. Comment at:

[Lldb-commits] [lldb] r254743 - Fill in the generic register kind if in AugmentRegisterInfoViaABI if it is available.

Author: gclayton Date: Fri Dec 4 12:37:48 2015 New Revision: 254743 URL: http://llvm.org/viewvc/llvm-project?rev=254743=rev Log: Fill in the generic register kind if in AugmentRegisterInfoViaABI if it is available. Modified: lldb/trunk/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp

[Lldb-commits] [lldb] r254744 - Fix test error in TestObjCCheckers.py

Author: tfiala Date: Fri Dec 4 12:40:34 2015 New Revision: 254744 URL: http://llvm.org/viewvc/llvm-project?rev=254744=rev Log: Fix test error in TestObjCCheckers.py Modified: lldb/trunk/packages/Python/lldbsuite/test/lang/objc/objc-checker/TestObjCCheckers.py Modified:

[Lldb-commits] [lldb] r254753 - Fix breakpoint language filtering for other C variants (like C99) and Pascal.

Author: dperchik Date: Fri Dec 4 13:34:00 2015 New Revision: 254753 URL: http://llvm.org/viewvc/llvm-project?rev=254753=rev Log: Fix breakpoint language filtering for other C variants (like C99) and Pascal. This patch fixes setting breakpoints on symbol for variants of C and Pascal where the

Re: [Lldb-commits] [PATCH] D15175: Fix breakpoint language filtering for other C variants (like C99) and Pascal.

This revision was automatically updated to reflect the committed changes. Closed by commit rL254753: Fix breakpoint language filtering for other C variants (like C99) and Pascal. (authored by dperchik). Changed prior to commit: http://reviews.llvm.org/D15175?vs=41713=41902#toc Repository:

Re: [Lldb-commits] [PATCH] D15209: Fix script import --allow-reload on Python 3

Thanks, I'll commit this later today then. On Fri, Dec 4, 2015 at 10:25 AM Todd Fiala wrote: > tfiala accepted this revision. > tfiala added a comment. > This revision is now accepted and ready to land. > > Hey Zachary, > > As best as I can tell, we don't need to do