Re: [Lldb-commits] [PATCH] D15877: Fix for undefined behavior while updating PC value on arm-linux

2016-01-05 Thread Tamas Berghammer via lldb-commits
tberghammer accepted this revision. tberghammer added a comment. Looks good but please fix the indentation to match with the LLDB style (4 space) http://reviews.llvm.org/D15877 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

Re: [Lldb-commits] [PATCH] D15834: Handle hardcoded breakpoints on Windows (e.g., int3 or __debugbreak())

2016-01-05 Thread Pavel Labath via lldb-commits
labath added a comment. I agree that the new test is better than the existing linux one, which can therefore be removed. If you wish, I can do it after you get this in. http://reviews.llvm.org/D15834 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D15886: [LLDB][MIPS32]Merge emulation of similar instructions

2016-01-05 Thread Bhushan Attarde via lldb-commits
bhushan created this revision. bhushan added a reviewer: clayborg. bhushan added subscribers: lldb-commits, nitesh.jain, mohit.bhakkad, sagar, jaydeep. bhushan set the repository for this revision to rL LLVM. Herald added a subscriber: dsanders. Currently there is a separate emulation function

Re: [Lldb-commits] [PATCH] D15877: Fix for undefined behavior while updating PC value on arm-linux

2016-01-05 Thread Muhammad Omair Javaid via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL256847: Fix for undefined behavior while updating PC value on arm-linux (authored by omjavaid). Changed prior to commit: http://reviews.llvm.org/D15877?vs=43941=44015#toc Repository: rL LLVM

[Lldb-commits] [lldb] r256847 - Fix for undefined behavior while updating PC value on arm-linux

2016-01-05 Thread Omair Javaid via lldb-commits
Author: omjavaid Date: Tue Jan 5 10:56:13 2016 New Revision: 256847 URL: http://llvm.org/viewvc/llvm-project?rev=256847=rev Log: Fix for undefined behavior while updating PC value on arm-linux Differential revision: http://reviews.llvm.org/D15877 Modified:

[Lldb-commits] [PATCH] D15893: Adds expectedFailureArmLinux test decorator

2016-01-05 Thread Muhammad Omair Javaid via lldb-commits
omjavaid created this revision. omjavaid added a reviewer: clayborg. omjavaid added a subscriber: lldb-commits. Herald added subscribers: rengolin, aemerson. This patch adds a new expectedFailureArmLinux which marks arm-linux tests as xfails. Also marked a couple of failing tests to use

[Lldb-commits] [lldb] r256835 - Mark a test_lldbmi_gdb_set_target_async_on as flaky on linux

2016-01-05 Thread Pavel Labath via lldb-commits
Author: labath Date: Tue Jan 5 08:21:15 2016 New Revision: 256835 URL: http://llvm.org/viewvc/llvm-project?rev=256835=rev Log: Mark a test_lldbmi_gdb_set_target_async_on as flaky on linux Test fails in about 1% of buildbot runs. Marking as flaky to avoid the noise. Modified:

Re: [Lldb-commits] [PATCH] D15773: Add LogDump methods to lldb_private::StringList to ease printing of iterable string containers

2016-01-05 Thread Luke Drummond via lldb-commits
ldrumm added a subscriber: lldb-commits. ldrumm updated this revision to Diff 44000. ldrumm added a comment. Addresses @clayborg's feedback in http://reviews.llvm.org/D15773 http://reviews.llvm.org/D15773 Files: source/Core/StringList.cpp Index: source/Core/StringList.cpp

[Lldb-commits] [lldb] r256834 - [LLDB][MIPS] Make register read/write to set/get the size of register according to abi.

2016-01-05 Thread Sagar Thakur via lldb-commits
Author: slthakur Date: Tue Jan 5 08:03:45 2016 New Revision: 256834 URL: http://llvm.org/viewvc/llvm-project?rev=256834=rev Log: [LLDB][MIPS] Make register read/write to set/get the size of register according to abi. Summary: For O32 abi register size should be 4 bytes. For N32 and N64 abi

Re: [Lldb-commits] [PATCH] D15886: [LLDB][MIPS32]Merge emulation of similar instructions

2016-01-05 Thread Greg Clayton via lldb-commits
clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Looks fine. Repository: rL LLVM http://reviews.llvm.org/D15886 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

Re: [Lldb-commits] [PATCH] D15593: Add support for "source info" and use it to fix MI's -symbol-list-lines.

2016-01-05 Thread Dawn Perchik via lldb-commits
dawn added a comment. In http://reviews.llvm.org/D15593#319670, @clayborg wrote: > ... in the future when adding things for MI, please add an API in the > lldb::SB layer to do what you need. Thanks for not asking me to do that as part of this patch. > Text scraping is really not the solution

Re: [Lldb-commits] [PATCH] D15593: Add support for "source info" and use it to fix MI's -symbol-list-lines.

2016-01-05 Thread Greg Clayton via lldb-commits
clayborg accepted this revision. clayborg added a comment. So I am going to let this through because you have done all we asked and I really like the "source info" command! But in the future when adding things for MI, please add an API in the lldb::SB layer to do what you need. Text scraping

[Lldb-commits] [lldb] r256853 - Add logging to SBProcess::GetRestartedFromEvent

2016-01-05 Thread Pavel Labath via lldb-commits
Author: labath Date: Tue Jan 5 11:55:35 2016 New Revision: 256853 URL: http://llvm.org/viewvc/llvm-project?rev=256853=rev Log: Add logging to SBProcess::GetRestartedFromEvent Modified: lldb/trunk/source/API/SBProcess.cpp Modified: lldb/trunk/source/API/SBProcess.cpp URL:

[Lldb-commits] [lldb] r256851 - Fix a typo in lldbutil.py

2016-01-05 Thread Pavel Labath via lldb-commits
Author: labath Date: Tue Jan 5 11:55:29 2016 New Revision: 256851 URL: http://llvm.org/viewvc/llvm-project?rev=256851=rev Log: Fix a typo in lldbutil.py Modified: lldb/trunk/packages/Python/lldbsuite/test/lldbutil.py Modified: lldb/trunk/packages/Python/lldbsuite/test/lldbutil.py URL:

[Lldb-commits] [lldb] r256852 - Fix a typo in Process.cpp

2016-01-05 Thread Pavel Labath via lldb-commits
Author: labath Date: Tue Jan 5 11:55:32 2016 New Revision: 256852 URL: http://llvm.org/viewvc/llvm-project?rev=256852=rev Log: Fix a typo in Process.cpp Modified: lldb/trunk/source/Target/Process.cpp Modified: lldb/trunk/source/Target/Process.cpp URL:

Re: [Lldb-commits] [PATCH] D15593: Add support for "source info" and use it to fix MI's -symbol-list-lines.

2016-01-05 Thread Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL256863: Add support for "source info" and use it to fix MI's -symbol-list-lines. (authored by dperchik). Changed prior to commit: http://reviews.llvm.org/D15593?vs=43429=44038#toc Repository: rL

Re: [Lldb-commits] [PATCH] D15884: [LLDB][MIPS] Make register read/write to set/get the size of register according to abi.

2016-01-05 Thread Sagar Thakur via lldb-commits
sagar closed this revision. sagar marked an inline comment as done. sagar added a comment. Committed in revision 256834 Repository: rL LLVM http://reviews.llvm.org/D15884 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [lldb] r256915 - [LLDB][MIPS32]Merge emulation of similar instructions

2016-01-05 Thread Bhushan D. Attarde via lldb-commits
Author: bhushan.attarde Date: Tue Jan 5 23:44:02 2016 New Revision: 256915 URL: http://llvm.org/viewvc/llvm-project?rev=256915=rev Log: [LLDB][MIPS32]Merge emulation of similar instructions SUMMARY: This patch merges emulation of similar instructions into a single function

[Lldb-commits] [PATCH] D15915: [LLDB][MIPS] Fix TestDisassembleRawData.py

2016-01-05 Thread Nitesh Jain via lldb-commits
nitesh.jain created this revision. nitesh.jain added reviewers: clayborg, ovehakola, emaste. nitesh.jain added subscribers: jaydeep, bhushan, sagar, mohit.bhakkad, lldb-commits. nitesh.jain set the repository for this revision to rL LLVM. This patch adds check for the correctness of

[Lldb-commits] [PATCH] D15904: Fix tests after svn r256863 - can someone please commit?

2016-01-05 Thread Dawn Perchik via lldb-commits
dawn created this revision. dawn added a reviewer: lldb-commits. dawn added a subscriber: lldb-commits. dawn set the repository for this revision to rL LLVM. This patch includes missed changes that should have gone in with r256863, but I can't get to svn at lldb.org at the moment (is it down?),

Re: [Lldb-commits] [PATCH] D15593: Add support for "source info" and use it to fix MI's -symbol-list-lines.

2016-01-05 Thread Dawn Perchik via lldb-commits
dawn added a comment. Amended patch was posted to http://reviews.llvm.org/D15593 - hopefully someone who can get to llvm.org will commit. Repository: rL LLVM http://reviews.llvm.org/D15593 ___ lldb-commits mailing list

[Lldb-commits] [lldb] r256824 - Remove old flaky test rerun logic

2016-01-05 Thread Pavel Labath via lldb-commits
Author: labath Date: Tue Jan 5 04:44:36 2016 New Revision: 256824 URL: http://llvm.org/viewvc/llvm-project?rev=256824=rev Log: Remove old flaky test rerun logic Summary: This removes the old logic for rerunning flaky tests. The new test runners will take care of rerunning failing tests.

Re: [Lldb-commits] [PATCH] D15884: [LLDB][MIPS] Make register read/write to set/get the size of register according to abi.

2016-01-05 Thread Tamas Berghammer via lldb-commits
tberghammer accepted this revision. tberghammer added a comment. This revision is now accepted and ready to land. Looks good Comment at: source/Plugins/Process/Linux/NativeRegisterContextLinux_mips64.cpp:1391 @@ -1390,3 +1390,3 @@ if

Re: [Lldb-commits] [PATCH] D15855: Remove old flaky test rerun logic

2016-01-05 Thread Pavel Labath via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL256824: Remove old flaky test rerun logic (authored by labath). Changed prior to commit: http://reviews.llvm.org/D15855?vs=43871=43974#toc Repository: rL LLVM http://reviews.llvm.org/D15855 Files:

Re: [Lldb-commits] [PATCH] D15593: Add support for "source info" and use it to fix MI's -symbol-list-lines.

2016-01-05 Thread Dawn Perchik via lldb-commits
dawn added a comment. I forgot to commit updated changes to the tests: MiSymbolTestCase.test_lldbmi_symbol_list_lines_file HelpCommandTestCase.test_help_image_du_line_should_work so they are failing now, but svn at llvm.org appears to be down at the moment. I'll commit those changes as soon

[Lldb-commits] [lldb] r256833 - Revert r256769

2016-01-05 Thread Ewan Crawford via lldb-commits
Author: ewancrawford Date: Tue Jan 5 07:18:46 2016 New Revision: 256833 URL: http://llvm.org/viewvc/llvm-project?rev=256833=rev Log: Revert r256769 Reverts "Use correct format identifiers to print something meaningful." Original format specifiers were correct. Instead use void* casts to remove

[Lldb-commits] [lldb] r256877 - Apply missed changes from svn r256863 "Add support for "source info" and use it to fix MI's -symbol-list-lines.".

2016-01-05 Thread Dawn Perchik via lldb-commits
Author: dperchik Date: Tue Jan 5 18:03:43 2016 New Revision: 256877 URL: http://llvm.org/viewvc/llvm-project?rev=256877=rev Log: Apply missed changes from svn r256863 "Add support for "source info" and use it to fix MI's -symbol-list-lines.". Patch is part of Differential Revision:

Re: [Lldb-commits] [PATCH] D15904: Fix tests after svn r256863 - can someone please commit?

2016-01-05 Thread Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL256877: Apply missed changes from svn r256863 "Add support for "source info" and useā€¦ (authored by dperchik). Changed prior to commit: http://reviews.llvm.org/D15904?vs=44061=44067#toc Repository:

Re: [Lldb-commits] [PATCH] D15593: Add support for "source info" and use it to fix MI's -symbol-list-lines.

2016-01-05 Thread Dawn Perchik via lldb-commits
dawn added a comment. Amended patch was committed in svn r256877 (svn at lldb.org is back up now) Repository: rL LLVM http://reviews.llvm.org/D15593 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [lldb] r256863 - Add support for "source info" and use it to fix MI's -symbol-list-lines.

2016-01-05 Thread Dawn Perchik via lldb-commits
Author: dperchik Date: Tue Jan 5 13:51:51 2016 New Revision: 256863 URL: http://llvm.org/viewvc/llvm-project?rev=256863=rev Log: Add support for "source info" and use it to fix MI's -symbol-list-lines. This patch adds support the command 'source info' as follows: (lldb) help source info

[Lldb-commits] [lldb] r256827 - Remove XTIMEOUT from TestEvents on linux

2016-01-05 Thread Pavel Labath via lldb-commits
Author: labath Date: Tue Jan 5 06:51:26 2016 New Revision: 256827 URL: http://llvm.org/viewvc/llvm-project?rev=256827=rev Log: Remove XTIMEOUT from TestEvents on linux I'm getting rid of the expected timeouts. I'll XFAIL/skip any tests that show up as failing after this (I haven't seen any