Re: [Lldb-commits] [PATCH] D15593: Add support for "source info" and use it to fix MI's -symbol-list-lines.

labath added a subscriber: labath. labath added a comment. Hi, the new check you have added to TestMiSymbol fails on linux: all the source lines are listed twice for some reason. I don't know if this is expected behavior (and the test needs to be fixed) or it's an bug (and the code needs to be

Re: [Lldb-commits] [PATCH] D15886: [LLDB][MIPS32]Merge emulation of similar instructions

labath added a subscriber: labath. labath added a comment. Hi, this introduces loads of new compiler warnings like: lldb/source/Plugins/Instruction/MIPS/EmulateInstructionMIPS.cpp:1434:14: warning: variable 'target' is used uninitialized whenever 'if' condition is false

Re: [Lldb-commits] [PATCH] D15893: Adds expectedFailureArmLinux test decorator

labath added a subscriber: labath. labath added a comment. Yes, please don't insert new decorators, we have enough as it is. You can achieve the behavior you want with the correct arguments to expectedFailureAll decorator. http://reviews.llvm.org/D15893

[Lldb-commits] [lldb] r256928 - Fix a bug in lldbutil.expect_state_changes

Author: labath Date: Wed Jan 6 05:40:06 2016 New Revision: 256928 URL: http://llvm.org/viewvc/llvm-project?rev=256928=rev Log: Fix a bug in lldbutil.expect_state_changes The logic for skipping over the stop-and-restart events was incorrect as it was also skipping the expectations. Implement it

[Lldb-commits] [lldb] r256925 - XFAIL TestMiSymbol on linux

Author: labath Date: Wed Jan 6 03:48:54 2016 New Revision: 256925 URL: http://llvm.org/viewvc/llvm-project?rev=256925=rev Log: XFAIL TestMiSymbol on linux new test introduced in r256863 fails on linux. Modified:

Re: [Lldb-commits] [PATCH] D15773: Add LogDump methods to lldb_private::StringList to ease printing of iterable string containers

This revision was automatically updated to reflect the committed changes. Closed by commit rL256927: Add LogDump methods to lldb_private::StringList. (authored by EwanCrawford). Changed prior to commit: http://reviews.llvm.org/D15773?vs=44000=44104#toc Repository: rL LLVM

[Lldb-commits] [lldb] r256927 - Add LogDump methods to lldb_private::StringList.

Author: ewancrawford Date: Wed Jan 6 05:06:30 2016 New Revision: 256927 URL: http://llvm.org/viewvc/llvm-project?rev=256927=rev Log: Add LogDump methods to lldb_private::StringList. This patch eases the printing of iterable string containers. Author: Luke Drummond

[Lldb-commits] [lldb] r256929 - Fix build warnings after rL256915

Author: bhushan.attarde Date: Wed Jan 6 06:08:22 2016 New Revision: 256929 URL: http://llvm.org/viewvc/llvm-project?rev=256929=rev Log: Fix build warnings after rL256915 Modified: lldb/trunk/source/Plugins/Instruction/MIPS/EmulateInstructionMIPS.cpp Modified:

Re: [Lldb-commits] [PATCH] D15886: [LLDB][MIPS32]Merge emulation of similar instructions

bhushan added a comment. Hi Pavel, Could you please confirm if http://reviews.llvm.org/rL256929 resolves the build warnings? Repository: rL LLVM http://reviews.llvm.org/D15886 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

Re: [Lldb-commits] [PATCH] D15886: [LLDB][MIPS32]Merge emulation of similar instructions

labath added a comment. It's looking good now, thanks. Repository: rL LLVM http://reviews.llvm.org/D15886 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] r256935 - Remove XTIMEOUT from TestMultithreaded on linux

Author: labath Date: Wed Jan 6 08:15:32 2016 New Revision: 256935 URL: http://llvm.org/viewvc/llvm-project?rev=256935=rev Log: Remove XTIMEOUT from TestMultithreaded on linux instead, mark the test as expected flaky, which will trigger a rerun in case the test hangs. Modified:

[Lldb-commits] [lldb] r256941 - [Renderscript] Fix stack argument inspection.

Author: aidandodds Date: Wed Jan 6 09:43:52 2016 New Revision: 256941 URL: http://llvm.org/viewvc/llvm-project?rev=256941=rev Log: [Renderscript] Fix stack argument inspection. Function arguments that were spilled and passed on the stack were incorrectly read. The value was written back into

Re: [Lldb-commits] [PATCH] D15886: [LLDB][MIPS32]Merge emulation of similar instructions

bhushan closed this revision. bhushan added a comment. Closed by commit http://reviews.llvm.org/rL256915 Repository: rL LLVM http://reviews.llvm.org/D15886 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

Re: [Lldb-commits] [PATCH] D15834: Handle hardcoded breakpoints on Windows (e.g., int3 or __debugbreak())

amccarth added a comment. PTAL: I've enhanced the test to do a couple extra checks that TestBuiltinTrap.py was doing, and I've eliminated that old test. I believe it should work on Linux as well as Windows, but I'm not set up with a Linux machine right now. If someone could try this patch on

Re: [Lldb-commits] [PATCH] D15834: Handle hardcoded breakpoints on Windows (e.g., int3 or __debugbreak())

amccarth updated this revision to Diff 44179. amccarth added a comment. Herald added subscribers: srhines, danalbert, tberghammer. I've rolled bits of TestBuiltinTrap.py into the new test and deleted the old one. This still works on Windows. I'm not set up to test it on Linux.

Re: [Lldb-commits] [PATCH] D12809: Better scheme to lookup alternate mangled name when looking up function address.

sivachandra added a comment. Thanks a lot Dwan Perchik, for persisting on my behalf. And thanks to Sean and Greg for taking a look. I second Dwan's earlier comment about Greg's code reviews. He has been the best reviewer I have worked with, internally and externally. Will commit this change

Re: [Lldb-commits] [PATCH] D15708: Advance the return-address breakpoint location to the end of the next source line, or the next branching instruction, when stepping over a func call

jasonmolenda added a comment. Thanks for the comments. As for calling Clear() on the instruction list manually, I was aping the dtor on ThreadPlanStepRange which reads, // FIXME: The DisassemblerLLVMC has a reference cycle and won't go away if it has any active instructions. // I'll fix

Re: [Lldb-commits] [PATCH] D15708: Advance the return-address breakpoint location to the end of the next source line, or the next branching instruction, when stepping over a func call

jasonmolenda updated this revision to Diff 44189. jasonmolenda added a comment. Updated to address Jim's first round of comments. 1. fix typeo in comment 2. update change argument name from "private_step_out" to "continue_to_next_branch" 3. Change continue_to_next_branch argument to have a

Re: [Lldb-commits] [PATCH] D12809: Better scheme to lookup alternate mangled name when looking up function address.

dawn added a comment. @spyffe I think this review is waiting on you since you had previously rejected it. Can you please have a look? It continues to show up on my "Blocking Others" list and there's nothing more I can do on my side. Please review or resign out of curtesy to sivachandra???

Re: [Lldb-commits] [PATCH] D12809: Better scheme to lookup alternate mangled name when looking up function address.

clayborg resigned from this revision. clayborg removed a reviewer: clayborg. clayborg added a comment. I looked at this before, and resigned to let Sean Callanan comment on the fix since this is in his area of expertise: the expression parser. http://reviews.llvm.org/D12809

Re: [Lldb-commits] [PATCH] D12809: Better scheme to lookup alternate mangled name when looking up function address.

dawn added a reviewer: clayborg. dawn added a subscriber: clayborg. dawn added a comment. Adding Greg - he is an excellent reviewer and quite responsive (poor guy - ends up with way more than his fair share of reviews as a result :( ). @clayborg would you be willing to be a 2nd pair of eyes

Re: [Lldb-commits] [PATCH] D12809: Better scheme to lookup alternate mangled name when looking up function address.

spyffe accepted this revision. spyffe added a comment. This revision is now accepted and ready to land. The expression parser side fixes look fine to me, and they remove some hacks and make things slightly more elegant. Obviously the ideal would be to have GCC generate full debug info, but to me