Re: [Lldb-commits] [PATCH] D15684: Add note about the "thread until" command to the llvm-gdb cheatsheet.

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. Thanks for adding this, are you able to check it in? Otherwise I will. http://reviews.llvm.org/D15684 ___ lldb-commits mailing list

[Lldb-commits] [lldb] r257186 - Treat an embedded int3/__debugbreak() as a breakpoint on Windows, includes a cross-platform test.

Author: amccarth Date: Fri Jan 8 12:28:03 2016 New Revision: 257186 URL: http://llvm.org/viewvc/llvm-project?rev=257186=rev Log: Treat an embedded int3/__debugbreak() as a breakpoint on Windows, includes a cross-platform test. Added:

Re: [Lldb-commits] [PATCH] D15684: Add note about the "thread until" command to the llvm-gdb cheatsheet.

jlebar added a comment. I just got commit access yesterday, will check in. http://reviews.llvm.org/D15684 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D15684: Add note about the "thread until" command to the llvm-gdb cheatsheet.

jlebar added a comment. Thank you for the review! http://reviews.llvm.org/D15684 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D15978: Prevent infinite recursive loop in AppleObjCTrampolineHandler constructor

fjricci added a comment. Would you still like me to make the parameter change to InferiorCallMmap before merging? http://reviews.llvm.org/D15978 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

Re: [Lldb-commits] [PATCH] D15684: Add note about the "thread until" command to the llvm-gdb cheatsheet.

This revision was automatically updated to reflect the committed changes. Closed by commit rL257189: Add note about the "thread until" command to the llvm-gdb cheatsheet. (authored by jlebar). Changed prior to commit: http://reviews.llvm.org/D15684?vs=43346=44340#toc Repository: rL LLVM

[Lldb-commits] [lldb] r257189 - Add note about the "thread until" command to the llvm-gdb cheatsheet.

Author: jlebar Date: Fri Jan 8 12:56:18 2016 New Revision: 257189 URL: http://llvm.org/viewvc/llvm-project?rev=257189=rev Log: Add note about the "thread until" command to the llvm-gdb cheatsheet. Differential Revision: http://reviews.llvm.org/D15684 Modified: lldb/trunk/www/lldb-gdb.html

[Lldb-commits] [lldb] r257204 - Prevent infinite recursive loop in AppleObjCTrampolineHandler constructor

Author: sas Date: Fri Jan 8 14:32:35 2016 New Revision: 257204 URL: http://llvm.org/viewvc/llvm-project?rev=257204=rev Log: Prevent infinite recursive loop in AppleObjCTrampolineHandler constructor Summary: When we construct AppleObjCTrampolineHandler, if m_impl_fn_addr is invalid, we call

Re: [Lldb-commits] [PATCH] D15978: Prevent infinite recursive loop in AppleObjCTrampolineHandler constructor

sas closed this revision. sas added a comment. Committed as r257204. http://reviews.llvm.org/D15978 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] r257207 - Remove XFAIL from TestThreadStates on Windows.

Author: zturner Date: Fri Jan 8 15:08:19 2016 New Revision: 257207 URL: http://llvm.org/viewvc/llvm-project?rev=257207=rev Log: Remove XFAIL from TestThreadStates on Windows. Modified: lldb/trunk/packages/Python/lldbsuite/test/functionalities/thread/state/TestThreadStates.py Modified:

[Lldb-commits] [lldb] r257208 - XFAIL 2 more tests based on SWIG version.

Author: zturner Date: Fri Jan 8 15:08:24 2016 New Revision: 257208 URL: http://llvm.org/viewvc/llvm-project?rev=257208=rev Log: XFAIL 2 more tests based on SWIG version. There's a bug in versions of SWIG prior to 3.0.8 that prevent these tests from succeeding with Python 3.x Modified:

Re: [Lldb-commits] [PATCH] D15978: Prevent infinite recursive loop in AppleObjCTrampolineHandler constructor

jingham accepted this revision. jingham added a comment. Great, thanks! http://reviews.llvm.org/D15978 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] r257209 - Add support for the LEAVE x86 instruction to AssemblyParse_x86.

Author: jmolenda Date: Fri Jan 8 15:13:26 2016 New Revision: 257209 URL: http://llvm.org/viewvc/llvm-project?rev=257209=rev Log: Add support for the LEAVE x86 instruction to AssemblyParse_x86. Modified: lldb/trunk/source/Plugins/UnwindAssembly/x86/UnwindAssembly-x86.cpp Modified:

Re: [Lldb-commits] [lldb] r257228 - Fix TestDebugBreak.py failure with gcc, for loop declarations are not allowed by default with gcc

Oops! Thanks for the fix. I'd tested only with clang, which seems to apply C++ rules even with .c files. I'm curious why I didn't see this break on any of the build bots. Adrian. On Fri, Jan 8, 2016 at 3:10 PM, Ying Chen via lldb-commits < lldb-commits@lists.llvm.org> wrote: > Author: chying

[Lldb-commits] [lldb] r257242 - Writing a test case for r257234 I found another place that was

Author: jingham Date: Fri Jan 8 19:20:30 2016 New Revision: 257242 URL: http://llvm.org/viewvc/llvm-project?rev=257242=rev Log: Writing a test case for r257234 I found another place that was assuming a ValueObject always has a process. So this is that fix and the test case. Added:

[Lldb-commits] [lldb] r257235 - Fiddling with Pavel's fix for getting the breakpoint right when there's debug info for sleep.

Author: jingham Date: Fri Jan 8 18:08:16 2016 New Revision: 257235 URL: http://llvm.org/viewvc/llvm-project?rev=257235=rev Log: Fiddling with Pavel's fix for getting the breakpoint right when there's debug info for sleep. I prefer to use "-p" over using line_number and then setting by line

Re: [Lldb-commits] [lldb] r257228 - Fix TestDebugBreak.py failure with gcc, for loop declarations are not allowed by default with gcc

I think it's actually C99 rules, but... Jim > On Jan 8, 2016, at 3:25 PM, Adrian McCarthy via lldb-commits > wrote: > > Oops! Thanks for the fix. I'd tested only with clang, which seems to apply > C++ rules even with .c files. > > I'm curious why I didn't see

[Lldb-commits] [lldb] r257228 - Fix TestDebugBreak.py failure with gcc, for loop declarations are not allowed by default with gcc

Author: chying Date: Fri Jan 8 17:10:56 2016 New Revision: 257228 URL: http://llvm.org/viewvc/llvm-project?rev=257228=rev Log: Fix TestDebugBreak.py failure with gcc, for loop declarations are not allowed by default with gcc - fix buildbot breakage after r257186 - move declaration outside of

[Lldb-commits] [PATCH] D16017: Fix TestMiniDump.py for Python 3

amccarth created this revision. amccarth added a reviewer: zturner. amccarth added a subscriber: lldb-commits. Under Python 3, lldb sees an extra frame on the stack, so I check that the stack has at least the number frames we expect. Python 3 doesn't have dict.iteritems(). I used a wrapper

[Lldb-commits] [lldb] r257229 - In the questionmark packet ("T"), print the "threads:" and "thread-pcs:"

Author: jmolenda Date: Fri Jan 8 17:16:03 2016 New Revision: 257229 URL: http://llvm.org/viewvc/llvm-project?rev=257229=rev Log: In the questionmark packet ("T"), print the "threads:" and "thread-pcs:" keys before we print the libdispatch queues keys (qname, qkind, qserialnum) to make it easier

[Lldb-commits] [lldb] r257234 - Fix a thinko in the asserts in GetDynamicTypeAndAddress. It was requiring that the

Author: jingham Date: Fri Jan 8 17:44:51 2016 New Revision: 257234 URL: http://llvm.org/viewvc/llvm-project?rev=257234=rev Log: Fix a thinko in the asserts in GetDynamicTypeAndAddress. It was requiring that the process in the incoming value be non-null, but Value Objects created off the

Re: [Lldb-commits] [PATCH] D15992: Centralize the handling of attach permissions on linux in tests

jingham added a subscriber: jingham. jingham added a comment. Would you mind adding a note to README-TestSuite saying that you have to call this function if you want to attach to the binary you are building as part of the testsuite. As with all docs it's likely very few will read the note, but

[Lldb-commits] [lldb] r257165 - Another fix for TestBatchMode on linux

Author: labath Date: Fri Jan 8 05:16:45 2016 New Revision: 257165 URL: http://llvm.org/viewvc/llvm-project?rev=257165=rev Log: Another fix for TestBatchMode on linux On locked down systems (such as our buildbot) one needs to do a special dance to allow attaching to processes. This commit adds

[Lldb-commits] [lldb] r257166 - Fix TestBatchMode for gcc

Author: labath Date: Fri Jan 8 05:23:21 2016 New Revision: 257166 URL: http://llvm.org/viewvc/llvm-project?rev=257166=rev Log: Fix TestBatchMode for gcc gcc by default does not accept for loop declarations in C files (one must choose C99 mode first, which we don't). Place the declaration

[Lldb-commits] [lldb] r257210 - Re-apply r257117 (reverted in r257138 temporarily),

Author: jmolenda Date: Fri Jan 8 15:40:11 2016 New Revision: 257210 URL: http://llvm.org/viewvc/llvm-project?rev=257210=rev Log: Re-apply r257117 (reverted in r257138 temporarily), with the one change that ThreadPlanStepOut::ThreadPlanStepOut will now only advance the return address breakpoint

Re: [Lldb-commits] [PATCH] D16017: Fix TestMiniDump.py for Python 3

What's the extra frame? Why does Python have an effect on the number of frames seen by the minidump? Something seems wrong about that. On Fri, Jan 8, 2016 at 3:41 PM Adrian McCarthy wrote: > amccarth created this revision. > amccarth added a reviewer: zturner. > amccarth

[Lldb-commits] [lldb] r257160 - Fix TestBatchMode on linux

Author: labath Date: Fri Jan 8 04:38:20 2016 New Revision: 257160 URL: http://llvm.org/viewvc/llvm-project?rev=257160=rev Log: Fix TestBatchMode on linux New test introduced in r257120 was failing on linux. The reason for that the regex for setting the breakpoint was being applied to the

[Lldb-commits] [PATCH] D15992: Centralize the handling of attach permissions on linux in tests

labath created this revision. labath added a reviewer: clayborg. labath added a subscriber: lldb-commits. On linux we need the process to give us special permissions before we can attach to it. Previously, the code for this was copied into every file that needed it. This moves the code to a

Re: [Lldb-commits] [PATCH] D15834: Handle hardcoded breakpoints on Windows (e.g., int3 or __debugbreak())

labath accepted this revision. labath added a reviewer: labath. labath added a comment. `__builtin_debugtrap()` indeed works (thanks Jim), but only on clang (no gcc). Since that is architecture-independent, I think we should use that and just make the test @skipIfGcc. Apart from that, the test

Re: [Lldb-commits] [PATCH] D15533: Make the aarch64 lldb-server capable of debugging arm32 applications

tberghammer added a comment. @omjavaid: What is your opinion about submitting this patch in its current form with knowing that setting watchpoints from a 64bit lldb-server into 32bit inferior will fail? I think this patch is a step in the good direction to make a 64bit lldb-server capable of

Re: [Lldb-commits] [PATCH] D15834: Handle hardcoded breakpoints on Windows (e.g., int3 or __debugbreak())

amccarth marked 3 inline comments as done. amccarth added a comment. Thanks for the Linux check Pavel. I'm running one last check and then I'll submit and keep an eye on the buildbots for the rest of the day. Comment at: