Re: [Lldb-commits] [PATCH] D19124: [LLDB] Added support for PHI nodes to IR interpreter

2016-05-09 Thread Sean Callanan via lldb-commits
spyffe accepted this revision. spyffe added a comment. This revision is now accepted and ready to land. This patch is fine. I especially appreciate the time you took making the IRInterpreter properly testable. I will use this myself. Comment at:

[Lldb-commits] [lldb] r268923 - Enable NamespaceLookupTestCase.test_scope_lookup_before_using_with_run_command on linux

2016-05-09 Thread Pavel Labath via lldb-commits
Author: labath Date: Mon May 9 09:43:22 2016 New Revision: 268923 URL: http://llvm.org/viewvc/llvm-project?rev=268923=rev Log: Enable NamespaceLookupTestCase.test_scope_lookup_before_using_with_run_command on linux test appears to be passing now. Modified:

Re: [Lldb-commits] [PATCH] D19124: [LLDB] Added support for PHI nodes to IR interpreter

2016-05-09 Thread Cameron via lldb-commits
cameron314 added a comment. @spyffe, do you have time to look at this sometime this week? It's a very simple patch (the test code took longer to write than the patch itself). Thanks! http://reviews.llvm.org/D19124 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D20065: Fix race in TestExitDuringStep and unify pseudo_barrier handling

2016-05-09 Thread Pavel Labath via lldb-commits
labath created this revision. labath added a reviewer: clayborg. labath added a subscriber: lldb-commits. TestExitDuringStep was very rarely hanging on the buildbots. I can't be sure, but I believe this was because of the fact that it declared its pseudo_barrier variable as "volatile int",

Re: [Lldb-commits] [lldb] r268906 - Fix assertion in SymbolFilePDB

2016-05-09 Thread Pavel Labath via lldb-commits
Zach, I have put this in to unblock the builds with assertions enabled, please fix it up if you want to handle this differently. pl On 9 May 2016 at 12:07, Pavel Labath via lldb-commits wrote: > Author: labath > Date: Mon May 9 06:07:43 2016 > New Revision: 268906

[Lldb-commits] [lldb] r268906 - Fix assertion in SymbolFilePDB

2016-05-09 Thread Pavel Labath via lldb-commits
Author: labath Date: Mon May 9 06:07:43 2016 New Revision: 268906 URL: http://llvm.org/viewvc/llvm-project?rev=268906=rev Log: Fix assertion in SymbolFilePDB llvm::Error requires all errors to be handled. Simply checking the whether there was an error is not enough, you have to actuall call