[Lldb-commits] [lldb] r270818 - Small further refinement to the check in ObjectFileMachO::ParseSymtab

Author: jmolenda Date: Wed May 25 23:22:47 2016 New Revision: 270818 URL: http://llvm.org/viewvc/llvm-project?rev=270818=rev Log: Small further refinement to the check in ObjectFileMachO::ParseSymtab which looks for binaries missing an LC_FUNCTION_STARTS section because it was stripped/not

Re: [Lldb-commits] [PATCH] D20623: [cmake] Add ability to customize (and skip) debugserver codesign

sas accepted this revision. sas added a comment. This is really useful. http://reviews.llvm.org/D20623 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] r270803 - Make sure to try and take the process stop lock when calling:

Author: gclayton Date: Wed May 25 19:08:39 2016 New Revision: 270803 URL: http://llvm.org/viewvc/llvm-project?rev=270803=rev Log: Make sure to try and take the process stop lock when calling: uint32_t SBProcess::GetNumQueues(); SBQueue SBProcess::GetQueueAtIndex (size_t index); Otherwise this

[Lldb-commits] [lldb] r270793 - It has been brought to my attention that, given two variables

Author: enrico Date: Wed May 25 18:19:01 2016 New Revision: 270793 URL: http://llvm.org/viewvc/llvm-project?rev=270793=rev Log: It has been brought to my attention that, given two variables T x; U y; doing x = *((T*)y) is undefined behavior, even if sizeof(T) == sizeof(U), due to pointer

[Lldb-commits] [lldb] r270780 - Mark some aarch64-linux specific xfails marking bug entries

Author: omjavaid Date: Wed May 25 17:30:05 2016 New Revision: 270780 URL: http://llvm.org/viewvc/llvm-project?rev=270780=rev Log: Mark some aarch64-linux specific xfails marking bug entries TestBSDArchives.py and TestWatchLocation.py fail due to unicode error and bug has already been reported

[Lldb-commits] [lldb] r270770 - Add logging to ValueObjectSyntheticFilter such that one can trace through the creation of synthetic children

Author: enrico Date: Wed May 25 16:38:32 2016 New Revision: 270770 URL: http://llvm.org/viewvc/llvm-project?rev=270770=rev Log: Add logging to ValueObjectSyntheticFilter such that one can trace through the creation of synthetic children Modified:

Re: [Lldb-commits] Builder llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast is back to normal

A factory required a successful step of removing the llvm.obj directory, which could be missing in some cases. The fix is committed as r270773 Thanks Galina On Wed, May 25, 2016 at 12:22 PM, Sean Silva wrote: > What was the issue? > > On Wed, May 25, 2016 at 12:17 PM,

[Lldb-commits] Builder llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast is back to normal

Hello, Builder http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast is back to normal. Sorry for the noise. Thanks Galina ___ lldb-commits mailing list lldb-commits@lists.llvm.org

Re: [Lldb-commits] [PATCH] D19998: Add a "-gmodules" category to the test suite.

tfiala added a comment. Okay, thanks Zachary. http://reviews.llvm.org/D19998 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D19998: Add a "-gmodules" category to the test suite.

zturner added a comment. Going to try this out on Windows and see how it goes. http://reviews.llvm.org/D19998 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D19998: Add a "-gmodules" category to the test suite.

tfiala marked 15 inline comments as done. tfiala added a comment. Marked all code comments as done. http://reviews.llvm.org/D19998 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D19998: Add a "-gmodules" category to the test suite.

tfiala added a comment. I believe this now accounts for everything we discussed changing. http://reviews.llvm.org/D19998 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D19998: Add a "-gmodules" category to the test suite.

tfiala updated this revision to Diff 58459. tfiala added a comment. Remove the now-unneeded second check for Windows. http://reviews.llvm.org/D19998 Files: packages/Python/lldbsuite/support/gmodules.py packages/Python/lldbsuite/test/decorators.py

Re: [Lldb-commits] [PATCH] D19998: Add a "-gmodules" category to the test suite.

tfiala updated this revision to Diff 58458. tfiala added a comment. Adjustments per review, removal of decorator, fixup of incorrect build method call in inline tests. http://reviews.llvm.org/D19998 Files: packages/Python/lldbsuite/support/gmodules.py

Re: [Lldb-commits] [PATCH] D19998: Add a "-gmodules" category to the test suite.

tfiala added a comment. I also stuck a print in to verify the gmodules build was being run everywhere I expected (i.e. for normal tests, inline tests, and the gmodules-explicit tests). http://reviews.llvm.org/D19998 ___ lldb-commits mailing list

Re: [Lldb-commits] [PATCH] D19998: Add a "-gmodules" category to the test suite.

tfiala added a comment. Yep, I see how it works now. I'll do a quick follow-up review after this to get that other issue with the debug info multiplicator (you may have just coined a word ;-)) fixed since I'm already in this code. Just finishing testing it on OS X.

Re: [Lldb-commits] [PATCH] D20623: [cmake] Add ability to customize (and skip) debugserver codesign

tberghammer accepted this revision. tberghammer added a comment. This revision is now accepted and ready to land. lgtm http://reviews.llvm.org/D20623 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

Re: [Lldb-commits] [PATCH] D19998: Add a "-gmodules" category to the test suite.

labath added inline comments. Comment at: packages/Python/lldbsuite/test/decorators.py:527 @@ -525,3 +526,3 @@ -def skipUnlessClangModules(): +def skipUnlessClangModules(func): """Decorate the item to skip test unless Clang -gmodules flag is supported."""

Re: [Lldb-commits] [PATCH] D19998: Add a "-gmodules" category to the test suite.

tfiala updated this revision to Diff 58449. tfiala added a comment. Just updating the patch set to what I had intended to give Adrian in r6. This does not yet contain any of the suggestions from the latest round. http://reviews.llvm.org/D19998 Files:

Re: [Lldb-commits] [PATCH] D19998: Add a "-gmodules" category to the test suite.

tfiala added a comment. > @aprantl, the lldbsuite/support/gmodules.py file didn't make it into your > patch set here. (It was the top file in the -v6 diff). Totally incorrect. The top file is the new file, but it is malformed and is showing a diff rather than the whole file. Not sure

Re: [Lldb-commits] [PATCH] D19998: Add a "-gmodules" category to the test suite.

tfiala commandeered this revision. tfiala edited reviewers, added: aprantl; removed: tfiala. tfiala added a comment. Commandeering. Thanks, Adrian! http://reviews.llvm.org/D19998 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

Re: [Lldb-commits] [PATCH] D19998: Add a "-gmodules" category to the test suite.

aprantl abandoned this revision. aprantl added a comment. Todd, I'm abandoning the review. This should allow you to claim it as your own so you can iterate quicker. Thanks! http://reviews.llvm.org/D19998 ___ lldb-commits mailing list

Re: [Lldb-commits] [PATCH] D19998: Add a "-gmodules" category to the test suite.

tfiala added a comment. @aprantl, the lldbsuite/support/gmodules.py file didn't make it into your patch set here. (It was the top file in the -v6 diff). I'm going to adjust per comments above. @labath, see question on add_test_categories. I may end up filing this as a separate review since

Re: [Lldb-commits] [PATCH] D20368: Remove Platform usages from NativeProcessLinux

labath abandoned this revision. Comment at: source/Plugins/Process/Linux/NativeRegisterContextLinux.cpp:53 @@ -22,2 +52,3 @@ + NativeRegisterContextLinux::NativeRegisterContextLinux(NativeThreadProtocol _thread, uint32_t

[Lldb-commits] [PATCH] D20623: [cmake] Add ability to customize (and skip) debugserver codesign

labath created this revision. labath added reviewers: sas, tberghammer. labath added a subscriber: lldb-commits. This adds the ability to customize the debugserver codesign process via cmake cache variable. The user can set the codesign indentity (with the default being the customary

Re: [Lldb-commits] [PATCH] D20567: Avoid using stdio in TestVirtual

labath updated this revision to Diff 58418. labath added a comment. New version, which does not rely on pretty-printers. http://reviews.llvm.org/D20567 Files: packages/Python/lldbsuite/test/lang/cpp/virtual/TestVirtual.py packages/Python/lldbsuite/test/lang/cpp/virtual/main.cpp Index:

Re: [Lldb-commits] [PATCH] D20570: Add unit tests for ModuleCache

labath added inline comments. Comment at: unittests/Utility/ModuleCacheTest.cpp:74 @@ +73,3 @@ +{ +HostInfo::Initialize(); +ObjectFileELF::Initialize(); ovyalov wrote: > If it's one-off initialization can we use setUpTestCase for these purposes > (for

Re: [Lldb-commits] [PATCH] D20570: Add unit tests for ModuleCache

This revision was automatically updated to reflect the committed changes. Closed by commit rL270684: Add unit tests for ModuleCache (authored by labath). Changed prior to commit: http://reviews.llvm.org/D20570?vs=58244=58400#toc Repository: rL LLVM http://reviews.llvm.org/D20570 Files:

[Lldb-commits] [lldb] r270684 - Add unit tests for ModuleCache

Author: labath Date: Wed May 25 05:48:16 2016 New Revision: 270684 URL: http://llvm.org/viewvc/llvm-project?rev=270684=rev Log: Add unit tests for ModuleCache Reviewers: ovyalov, zturner Subscribers: lldb-commits Differential Revision: http://reviews.llvm.org/D20570 Added:

Re: [Lldb-commits] [PATCH] D19998: Add a "-gmodules" category to the test suite.

labath added a comment. I think we should make one more iteration on this, as there is still some room for improvement. In http://reviews.llvm.org/D19998#438756, @zturner wrote: > Should this be disabled by default unless explicitly requested? Seems like > "run the entire test suite N times"