[Lldb-commits] [lldb] r280692 - Added the "frame diagnose" command and use its output to make crash info better.

2016-09-05 Thread Sean Callanan via lldb-commits
Author: spyffe Date: Mon Sep 5 23:48:36 2016 New Revision: 280692 URL: http://llvm.org/viewvc/llvm-project?rev=280692=rev Log: Added the "frame diagnose" command and use its output to make crash info better. When a process stops due to a crash, we get the crashing instruction and the crashing

Re: [Lldb-commits] [lldb] r280652 - Add default_packet_timeout key to the new TestGdbRemoteHostInfo test

2016-09-05 Thread Todd Fiala via lldb-commits
Thanks, Pavel! I grepped around the code for all the keys used, but looks like I missed that one. Thanks for addressing. -Todd On Mon, Sep 5, 2016 at 1:34 AM, Pavel Labath via lldb-commits < lldb-commits@lists.llvm.org> wrote: > Author: labath > Date: Mon Sep 5 03:34:56 2016 > New Revision:

[Lldb-commits] [lldb] r280675 - remove dependence of TestGdbRemoteExitCode.py on parent directory source

2016-09-05 Thread Todd Fiala via lldb-commits
Author: tfiala Date: Mon Sep 5 17:03:02 2016 New Revision: 280675 URL: http://llvm.org/viewvc/llvm-project?rev=280675=rev Log: remove dependence of TestGdbRemoteExitCode.py on parent directory source As Pavel pointed out in a comment on llvm.org/pr30271, the VPATH I was using here to eliminate

[Lldb-commits] [lldb] r280668 - Intel(R) Memory Protection Extensions (Intel(R) MPX) support.

2016-09-05 Thread Valentina Giusti via lldb-commits
Author: valentinagiusti Date: Mon Sep 5 12:43:10 2016 New Revision: 280668 URL: http://llvm.org/viewvc/llvm-project?rev=280668=rev Log: Intel(R) Memory Protection Extensions (Intel(R) MPX) support. Summary: The Intel(R) Memory Protection Extensions (Intel(R) MPX) associates pointers to bounds,

Re: [Lldb-commits] [PATCH] D24187: Intel(R) Memory Protection Extensions (Intel(R) MPX) support.

2016-09-05 Thread Valentina Giusti via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL280668: Intel(R) Memory Protection Extensions (Intel(R) MPX) support. (authored by valentinagiusti). Changed prior to commit: https://reviews.llvm.org/D24187?vs=70152=70342#toc Repository: rL LLVM

Re: [Lldb-commits] [PATCH] D23882: Replace uses of MIUtilParse::CRegexParser with llvm::Regex

2016-09-05 Thread Pavel Labath via lldb-commits
BTW, what tests are failing for you now? I bet they failures are caused by one of two things: - unexpected compiler, for which we don't have the correct @xfail annotations: the annotations are correct for gcc-4.8, gcc-4.9, clang-3.5, clang-3.6 and ToT clang. If you have a different compiler, they

Re: [Lldb-commits] [PATCH] D20041: File path comparisons should be case-insensitive on OS X

2016-09-05 Thread Zachary Turner via lldb-commits
Assert probably On Mon, Sep 5, 2016 at 4:04 AM Pavel Labath wrote: > labath added a subscriber: labath. > labath added a comment. > > > > > > Comment at: include/lldb/Host/FileSpec.h:712 > @@ +711,3 @@ > + PathSyntax syntax =

Re: [Lldb-commits] [PATCH] D23882: Replace uses of MIUtilParse::CRegexParser with llvm::Regex

2016-09-05 Thread Pavel Labath via lldb-commits
labath closed this revision. labath added a comment. r280662 https://reviews.llvm.org/D23882 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] r280662 - Replace uses of MIUtilParse::CRegexParser with llvm::Regex

2016-09-05 Thread Pavel Labath via lldb-commits
Author: labath Date: Mon Sep 5 10:15:12 2016 New Revision: 280662 URL: http://llvm.org/viewvc/llvm-project?rev=280662=rev Log: Replace uses of MIUtilParse::CRegexParser with llvm::Regex Summary: Replace uses of the local MIUtilParse::CRegexParser class with the LLVM support class llvm::Regex.

Re: [Lldb-commits] [PATCH] D16128: Fix TestProcessLaunch.test_environment_with_special_char for Python 3

2016-09-05 Thread Pavel Labath via lldb-commits
labath added a comment. There has been no activity here for 6 months. Shall we close it? https://reviews.llvm.org/D16128 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D22914: [WIP] Add concurrent packets support to gdb-remote client

2016-09-05 Thread Pavel Labath via lldb-commits
labath abandoned this revision. labath added a comment. I am abandoning this for the time being in favour of https://reviews.llvm.org/D24236. The actual implementation of it turned out to be more hackish then I anticipated. https://reviews.llvm.org/D22914

[Lldb-commits] [PATCH] D24236: gdb-remote: Add jModulesInfo packet

2016-09-05 Thread Pavel Labath via lldb-commits
labath created this revision. labath added a reviewer: clayborg. labath added a subscriber: lldb-commits. Herald added subscribers: danalbert, tberghammer. This adds the jModulesInfo packet, which is the equivalent of qModulesInfo, but it enables us to query multiple modules at once. This makes

Re: [Lldb-commits] [PATCH] D23882: Replace uses of MIUtilParse::CRegexParser with llvm::Regex

2016-09-05 Thread Michał Górny via lldb-commits
mgorny added a comment. In https://reviews.llvm.org/D23882#534038, @labath wrote: > Tests run clean when I apply this locally. Do you want me to put that in for > you? I'd appreciate that. Thanks a lot! https://reviews.llvm.org/D23882 ___

Re: [Lldb-commits] [PATCH] D23882: Replace uses of MIUtilParse::CRegexParser with llvm::Regex

2016-09-05 Thread Pavel Labath via lldb-commits
labath added a comment. Tests run clean when I apply this locally. Do you want me to put that in for you? https://reviews.llvm.org/D23882 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

Re: [Lldb-commits] [PATCH] D20041: File path comparisons should be case-insensitive on OS X

2016-09-05 Thread Vyacheslav Karpukhin via lldb-commits
stigger added inline comments. Comment at: include/lldb/Host/FileSpec.h:712 @@ +711,3 @@ + PathSyntax syntax = ePathSyntaxHostNative, + llvm::Triple *triple = nullptr); + labath wrote: > I don't think the default-null parameter here is a

Re: [Lldb-commits] [PATCH] D20041: File path comparisons should be case-insensitive on OS X

2016-09-05 Thread Pavel Labath via lldb-commits
labath added a subscriber: labath. labath added a comment. Comment at: include/lldb/Host/FileSpec.h:712 @@ +711,3 @@ + PathSyntax syntax = ePathSyntaxHostNative, + llvm::Triple *triple = nullptr); + I don't think the default-null

Re: [Lldb-commits] [PATCH] D24187: Intel(R) Memory Protection Extensions (Intel(R) MPX) support.

2016-09-05 Thread Pavel Labath via lldb-commits
labath added a comment. Thanks for the patch. The changes seem pretty straight-forward. I'd just like to sort out some issues in the new test first. Comment at: packages/Python/lldbsuite/test/functionalities/register/intel_xtended_registers/TestMPXRegisters.py:27 @@ +26,3 @@

[Lldb-commits] [lldb] r280652 - Add default_packet_timeout key to the new TestGdbRemoteHostInfo test

2016-09-05 Thread Pavel Labath via lldb-commits
Author: labath Date: Mon Sep 5 03:34:56 2016 New Revision: 280652 URL: http://llvm.org/viewvc/llvm-project?rev=280652=rev Log: Add default_packet_timeout key to the new TestGdbRemoteHostInfo test android targets use this key, so the test should recognize it. Modified: