Re: [Lldb-commits] [PATCH] D24283: [lldb] Set the correct triple when creating an ArchSpec for windows

wallace added a comment. oh, thank you, first time i'm sending lldb diffs Repository: rL LLVM https://reviews.llvm.org/D24283 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D24283: [lldb] Set the correct triple when creating an ArchSpec for windows

wallace added a comment. This fixes some issues with arm architectures (where this was unsetting the thumbv7 and was fallbacking to thumb). This is also needed for https://reviews.llvm.org/D24284, where the objet file requires a correct architecture inferred from the machine arch Repository:

[Lldb-commits] [PATCH] D24284: [lldb] Read modules from memory when a local copy is not available

wallace created this revision. wallace added reviewers: zturner, sas. wallace added a subscriber: LLDB. wallace set the repository for this revision to rL LLVM. wallace added a project: LLDB. When the local lldb doesn't have access to a copy of the modules in the target, e.g. winphone, with this

Re: [Lldb-commits] [PATCH] D24283: [lldb] Set the correct triple when creating an ArchSpec for windows

zturner added a comment. In https://reviews.llvm.org/D24283#535405, @wallace wrote: > This fixes some issues with arm architectures (where this was unsetting the > thumbv7 and was fallbacking to thumb). > This is also needed for https://reviews.llvm.org/D24284, where the objet > file requires

Re: [Lldb-commits] [PATCH] D24284: [lldb] Read modules from memory when a local copy is not available

zturner added a comment. Right, I'm just wondering if when you run `ninja check-lldb` before and after this patch, do the results differ at all? Repository: rL LLVM https://reviews.llvm.org/D24284 ___ lldb-commits mailing list

Re: [Lldb-commits] [PATCH] D24283: [lldb] Set the correct triple when creating an ArchSpec for windows

zturner added a comment. BTW, you will need to rebase this on top of trunk, and make sure you run clang-format before submitting. Repository: rL LLVM https://reviews.llvm.org/D24283 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

Re: [Lldb-commits] [PATCH] D24283: [lldb] Set the correct triple when creating an ArchSpec for windows

zturner accepted this revision. zturner added a comment. This revision is now accepted and ready to land. Does this affect the running of the test suite in any way? Is anything fixed or regressed as a result of this? Repository: rL LLVM https://reviews.llvm.org/D24283

[Lldb-commits] [lldb] r280763 - Revert "Fix tests on Windows."

Author: zturner Date: Tue Sep 6 17:40:11 2016 New Revision: 280763 URL: http://llvm.org/viewvc/llvm-project?rev=280763=rev Log: Revert "Fix tests on Windows." This reverts commit 9b757b6e3946311802972409f38c6cefbea917b3. This seems to cause strange breakages about on Ubuntu. Modified:

Re: [Lldb-commits] [PATCH] D24251: LLDB: API for Permission of object file's sections

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko added a comment. Please rebase code on trunk and run Clang-format. https://reviews.llvm.org/D24251 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [lldb] r280759 - Fix tests on Windows.

Author: zturner Date: Tue Sep 6 17:14:22 2016 New Revision: 280759 URL: http://llvm.org/viewvc/llvm-project?rev=280759=rev Log: Fix tests on Windows. This wasn't actually a problem with the reformat, but rather a problem with Visual Studio 2015 Update 3, which uses some c++14 features in its

Re: [Lldb-commits] [lldb] r280755 - Reorder FreeBSD Host.cpp #includes to fix build

Thanks for clarifying. That said, I think we should still follow the LLVM convention of putting system headers last. (i.e. everything in <> comes after everything in "", but within <> you can still arrange according to the system rules). This encourages "include what you use" as header files

Re: [Lldb-commits] [lldb] r280755 - Reorder FreeBSD Host.cpp #includes to fix build

On NetBSD /usr/share/misc/style says:   /*  * Kernel include files come first.  */ #include          /* first, */ #include          /*   next, */ #include          /*   and then the rest, */ #include         /*   sorted lexicographically.  */ #include #include           /* Non-local

[Lldb-commits] [lldb] r280758 - Put the LLVM_ALIGNAS directive in the right place.

Author: zturner Date: Tue Sep 6 17:02:06 2016 New Revision: 280758 URL: http://llvm.org/viewvc/llvm-project?rev=280758=rev Log: Put the LLVM_ALIGNAS directive in the right place. Modified: lldb/trunk/source/Plugins/Process/Utility/RegisterContext_x86.h Modified:

Re: [Lldb-commits] [lldb] r280755 - Reorder FreeBSD Host.cpp #includes to fix build

In general, and headers should be at the top, followed by standard headers such as , then followed by application-specific headers. IIRC this is also the case for Linux. -Dimitry > On 07 Sep 2016, at 00:02, Zachary Turner via lldb-commits > wrote: > > Why was

Re: [Lldb-commits] [lldb] r280755 - Reorder FreeBSD Host.cpp #includes to fix build

Why was this causing a problem? The only headers that were re-ordered are system headers. Does FreeBSD's libraries have requirements about certain headers being included before other headers? On Tue, Sep 6, 2016 at 2:33 PM Ed Maste via lldb-commits < lldb-commits@lists.llvm.org> wrote: >

[Lldb-commits] [lldb] r280757 - Make LLDB compile on Windows after the reformat.

Author: zturner Date: Tue Sep 6 16:52:14 2016 New Revision: 280757 URL: http://llvm.org/viewvc/llvm-project?rev=280757=rev Log: Make LLDB compile on Windows after the reformat. Most of these issues arose as a result of header re-ordering, but it turned up a real bug, which is that MSVC doesn't

[Lldb-commits] [lldb] r280755 - Reorder FreeBSD Host.cpp #includes to fix build

Author: emaste Date: Tue Sep 6 16:25:31 2016 New Revision: 280755 URL: http://llvm.org/viewvc/llvm-project?rev=280755=rev Log: Reorder FreeBSD Host.cpp #includes to fix build Modified: lldb/trunk/source/Host/freebsd/Host.cpp Modified: lldb/trunk/source/Host/freebsd/Host.cpp URL:

[Lldb-commits] LLVM buildmaster will be restarted in few minutes

Hello everyone, LLVM buildmaster will be restarted in few minutes. Sorry for inconvenience. Thanks Galina ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] r280721 - Updated .clang-format rules so bring LLDB in line with LLVM standards.

Author: kate Date: Tue Sep 6 12:19:00 2016 New Revision: 280721 URL: http://llvm.org/viewvc/llvm-project?rev=280721=rev Log: Updated .clang-format rules so bring LLDB in line with LLVM standards. Added: lldb/trunk/packages/Python/lldbsuite/.clang-format Modified:

Re: [Lldb-commits] [PATCH] D24255: Fix for rL280668, Intel(R) Memory Protection Extensions (Intel(R) MPX) support.

clayborg requested changes to this revision. clayborg added a comment. Just switch to using CFLAGS_EXTRAS and LD_EXTRAS and this is good to go. Comment at: packages/Python/lldbsuite/test/functionalities/register/intel_xtended_registers/Makefile:6-11 @@ +5,8 @@ +ifeq "$(ARCH)"

Re: [Lldb-commits] [PATCH] D24236: gdb-remote: Add jModulesInfo packet

clayborg added a comment. Just take a look and see if there is anything worth re-using. If there is too much mac specific stuff in there, then just use the one created, but be sure to make it your new format completely agnostic to any platform so it can work for anything. It is OK to include

Re: [Lldb-commits] [PATCH] D24236: gdb-remote: Add jModulesInfo packet

labath added a reviewer: jasonmolenda. labath added a comment. Hm... I was not aware of that packet. It does not appear to be directly applicable to this situation, because it queries the module information by load address, whereas here I query by file path. Also my packet does not return the

Re: [Lldb-commits] [PATCH] D24251: LLDB: API for Permission of object file's sections

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. Just add header doc and this is good to go. Comment at: include/lldb/API/SBSection.h:74 @@ -73,1 +73,3 @@ +uint32_t +GetPermissions () const;

Re: [Lldb-commits] [PATCH] D24236: gdb-remote: Add jModulesInfo packet

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. Jason Molenda already has a packet that does multiple module infos. Is this change using his packet format? Look for "jGetLoadedDynamicLibrariesInfos". We should try to use the

Re: [Lldb-commits] [PATCH] D24255: Fix for rL280668, Intel(R) Memory Protection Extensions (Intel(R) MPX) support.

valentinagiusti added a comment. Hi, inline there are my other replies. Comment at: packages/Python/lldbsuite/test/functionalities/register/intel_xtended_registers/Makefile:5 @@ +4,3 @@ + +ifeq "$(ARCH)" "i386" + CXXFLAGS += -mmpx -fcheck-pointer-bounds -fuse-ld=bfd -m32

Re: [Lldb-commits] [PATCH] D24236: gdb-remote: Add jModulesInfo packet

labath updated this revision to Diff 70409. labath added a comment. - fix a bug where we would mark all modules as invalid if communicating with a stub which does not support this packet - extend the packet documentation about what to do when modules are not found and the server volunteering

Re: [Lldb-commits] [PATCH] D24187: Intel(R) Memory Protection Extensions (Intel(R) MPX) support.

valentinagiusti added a comment. Thanks for the review! You can find my replies inline. Comment at: packages/Python/lldbsuite/test/functionalities/register/intel_xtended_registers/TestMPXRegisters.py:27 @@ +26,3 @@ + +@skipIfiOSSimulator +@skipIf(compiler="clang")

[Lldb-commits] [PATCH] D24255: Fix for rL280668, Intel(R) Memory Protection Extensions (Intel(R) MPX) support.

valentinagiusti created this revision. valentinagiusti added a subscriber: lldb-commits. Signed-off-by: Valentina Giusti https://reviews.llvm.org/D24255 Files: packages/Python/lldbsuite/test/functionalities/register/Makefile

[Lldb-commits] [lldb] r280707 - Fixing an MSVC error from rL280692

Author: dvlahovski Date: Tue Sep 6 07:48:10 2016 New Revision: 280707 URL: http://llvm.org/viewvc/llvm-project?rev=280707=rev Log: Fixing an MSVC error from rL280692 MSVC emits an error when one uses a const variable in a lambda without capturing it. gcc and clang don't emit an error in this

[Lldb-commits] [lldb] r280704 - Second round of fixups for r280692

Author: labath Date: Tue Sep 6 06:08:02 2016 New Revision: 280704 URL: http://llvm.org/viewvc/llvm-project?rev=280704=rev Log: Second round of fixups for r280692 Android targets don't have std::to_string and std::stoul. Use llvm::to_string and strtoul instead. Modified:

[Lldb-commits] [lldb] r280703 - Revert "Intel(R) Memory Protection Extensions (Intel(R) MPX) support."

Author: dvlahovski Date: Tue Sep 6 06:00:37 2016 New Revision: 280703 URL: http://llvm.org/viewvc/llvm-project?rev=280703=rev Log: Revert "Intel(R) Memory Protection Extensions (Intel(R) MPX) support." This reverts commit rL280668 because the register tests fail on i386 Linux. I investigated a

Re: [Lldb-commits] [lldb] r280692 - Added the "frame diagnose" command and use its output to make crash info better.

On 6 September 2016 at 05:48, Sean Callanan via lldb-commits wrote: > + > +struct Operand > +{ > +enum class Type { > +Invalid = 0, > +Register, > +Immediate, > +Dereference, > +Sum, > +

[Lldb-commits] [lldb] r280697 - Fix build breakage in r280692

Author: labath Date: Tue Sep 6 05:04:22 2016 New Revision: 280697 URL: http://llvm.org/viewvc/llvm-project?rev=280697=rev Log: Fix build breakage in r280692 The commit introduced an array of const objects, which libstdc++ does not like. Make the object non-const. Also fix a compiler warning