Re: [Lldb-commits] [PATCH] D23026: [LLDB-MI] removing requirement of a parameter for -break-insert's -f flag

pieandcakes added a comment. Would you be willing to please take another look? I think this should be the fix. Repository: rL LLVM https://reviews.llvm.org/D23026 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [lldb] r280965 - Fix MSVC error from r280919

Author: labath Date: Thu Sep 8 11:58:30 2016 New Revision: 280965 URL: http://llvm.org/viewvc/llvm-project?rev=280965=rev Log: Fix MSVC error from r280919 MSVC did not understand my brace-initializer syntax. :/ Modified: lldb/trunk/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp

Re: [Lldb-commits] [PATCH] D24013: Removed the `GetStringRef()` functions of `StringExtractor`

I will try to pick this up again sometime next week. I will also try to get my test suite working on Linux first so I can find these failures myself. On Thu, Sep 8, 2016 at 4:28 AM Pavel Labath wrote: > labath added a comment. > > The reformat is complete, and our main

Re: [Lldb-commits] [PATCH] D24255: Fix for rL280668, Intel(R) Memory Protection Extensions (Intel(R) MPX) support.

This revision was automatically updated to reflect the committed changes. Closed by commit rL280942: Fix for rL280668, Intel(R) Memory Protection Extensions (Intel(R) MPX) support. (authored by valentinagiusti). Changed prior to commit: https://reviews.llvm.org/D24255?vs=70695=70698#toc

Re: [Lldb-commits] [PATCH] D5867: Minimal API support for non-8-bit byte targets

emaste added a comment. This change will no longer apply. Is it still desired? If so, can you please rebase the patch. https://reviews.llvm.org/D5867 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

Re: [Lldb-commits] [PATCH] D24255: Fix for rL280668, Intel(R) Memory Protection Extensions (Intel(R) MPX) support.

valentinagiusti added inline comments. Comment at: packages/Python/lldbsuite/test/functionalities/register/intel_xtended_registers/Makefile:7 @@ +6,2 @@ + +include $(LEVEL)/Makefile.rules Np, thanks for the review and explanations ;)

Re: [Lldb-commits] [PATCH] D24255: Fix for rL280668, Intel(R) Memory Protection Extensions (Intel(R) MPX) support.

valentinagiusti updated this revision to Diff 70695. valentinagiusti added a comment. Improved MPX test Makefile and removed workaround for unnamed register sets, and rebased according to the new coding style. https://reviews.llvm.org/D24255 Files:

[Lldb-commits] [lldb] r280933 - Fix -Wcovered-switch-default warning in AppleObjCRuntimeV2.cpp

Author: emaste Date: Thu Sep 8 08:17:42 2016 New Revision: 280933 URL: http://llvm.org/viewvc/llvm-project?rev=280933=rev Log: Fix -Wcovered-switch-default warning in AppleObjCRuntimeV2.cpp The switch coveres all possible values. If a new one is added in the future the compiler will start

[Lldb-commits] [lldb] r280931 - Fix unused variable and integer sign warnings from r280906

Author: emaste Date: Thu Sep 8 08:11:31 2016 New Revision: 280931 URL: http://llvm.org/viewvc/llvm-project?rev=280931=rev Log: Fix unused variable and integer sign warnings from r280906 Modified: lldb/trunk/source/Core/Disassembler.cpp Modified: lldb/trunk/source/Core/Disassembler.cpp URL:

[Lldb-commits] [lldb] r280924 - LLDB: API for iPermission of object file's sections

Author: abhishek Date: Thu Sep 8 07:22:56 2016 New Revision: 280924 URL: http://llvm.org/viewvc/llvm-project?rev=280924=rev Log: LLDB: API for iPermission of object file's sections Summary: - Added an API to public interface that provides permissions (RWX) of individual sections of an

Re: [Lldb-commits] [PATCH] D24251: LLDB: API for Permission of object file's sections

abhishek.aggarwal updated this revision to Diff 70677. abhishek.aggarwal added a comment. Removed get() for shared_ptr https://reviews.llvm.org/D24251 Files: include/lldb/API/SBSection.h scripts/interface/SBSection.i source/API/SBSection.cpp Index: source/API/SBSection.cpp

Re: [Lldb-commits] [PATCH] D24013: Removed the `GetStringRef()` functions of `StringExtractor`

labath added a comment. The reformat is complete, and our main buildbot is (as I think you've already found out) in the non-experimental mode. As far as I am concerned, we can proceed with this. If you can't test on linux before hand, just look out for the emails and be ready to respond. If

[Lldb-commits] [lldb] r280922 - Fix test breakage in r280919

Author: labath Date: Thu Sep 8 06:09:14 2016 New Revision: 280922 URL: http://llvm.org/viewvc/llvm-project?rev=280922=rev Log: Fix test breakage in r280919 It turns out that self.dbg.GetSelectedPlatform().GetTriple() is not a good way to get the triple of the process, as it returns the

Re: [Lldb-commits] [PATCH] D24236: gdb-remote: Add jModulesInfo packet

This revision was automatically updated to reflect the committed changes. Closed by commit rL280919: gdb-remote: Add jModulesInfo packet (authored by labath). Changed prior to commit: https://reviews.llvm.org/D24236?vs=70409=70671#toc Repository: rL LLVM https://reviews.llvm.org/D24236

[Lldb-commits] [lldb] r280919 - gdb-remote: Add jModulesInfo packet

Author: labath Date: Thu Sep 8 05:07:04 2016 New Revision: 280919 URL: http://llvm.org/viewvc/llvm-project?rev=280919=rev Log: gdb-remote: Add jModulesInfo packet Summary: This adds the jModulesInfo packet, which is the equivalent of qModulesInfo, but it enables us to query multiple modules at

Re: [Lldb-commits] [PATCH] D24331: Fix about a dozen compile warnings

ki.stfu marked an inline comment as done. Comment at: source/Target/StackFrame.cpp:1425 @@ -1423,3 +1424,3 @@ - if (offset >= pointee->GetByteSize()) { + if (offset > 0 && uint64_t(offset) >= pointee->GetByteSize()) { int64_t index = offset / pointee->GetByteSize();

Re: [Lldb-commits] [PATCH] D24331: Fix about a dozen compile warnings

ki.stfu updated this revision to Diff 70656. ki.stfu marked 3 inline comments as done. ki.stfu added a comment. Fixes per Zachary's comments https://reviews.llvm.org/D24331 Files: source/Core/Log.cpp source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp

Re: [Lldb-commits] [PATCH] D24331: Fix about a dozen compile warnings

zturner added inline comments. Comment at: source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp:1462-1467 @@ -1461,8 +1461,8 @@ const uint32_t segment_permissions = ((load_cmd.initprot & VM_PROT_READ) ? ePermissionsReadable -

Re: [Lldb-commits] [PATCH] D24331: Fix about a dozen compile warnings

ki.stfu updated this revision to Diff 70654. ki.stfu added a comment. Apply clang-format https://reviews.llvm.org/D24331 Files: source/Core/Log.cpp source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp

Re: [Lldb-commits] [PATCH] D24331: Fix about a dozen compile warnings

ki.stfu added a comment. BTW, the following warnings remain: 1. unrecognized command line option ‘-Wno-vla-extension’ 2. unrecognized command line option ‘-Wno-deprecated-register’ 3. comparison of unsigned expression >= 0 is always true [2782/3295] Building CXX object

[Lldb-commits] [PATCH] D24331: Fix about a dozen compile warnings

ki.stfu created this revision. ki.stfu added reviewers: clayborg, jingham, zturner. ki.stfu added a subscriber: lldb-commits. It fixes the following compile warnings: 1. '0' flag ignored with precision and ‘%d’ gnu_printf format 2. enumeral and non-enumeral type in conditional expression 3.