[Lldb-commits] [lldb] r283520 - [lit] Don't assume you'll find debugserver

2016-10-06 Thread Hal Finkel via lldb-commits
Author: hfinkel Date: Thu Oct 6 21:26:41 2016 New Revision: 283520 URL: http://llvm.org/viewvc/llvm-project?rev=283520=rev Log: [lit] Don't assume you'll find debugserver On Linux, there is no "debugserver" process, and the RUN-line substitution will fail if you try to substitute '%debugserver'

[Lldb-commits] [lldb] r283497 - disable TSAN tests on macOS i386

2016-10-06 Thread Todd Fiala via lldb-commits
Author: tfiala Date: Thu Oct 6 16:30:33 2016 New Revision: 283497 URL: http://llvm.org/viewvc/llvm-project?rev=283497=rev Log: disable TSAN tests on macOS i386 These are erroring out on macOS i386. Tracked by: rdar://28659145 Modified:

[Lldb-commits] [lldb] r283494 - Convert UniqueCStringMap to use StringRef.

2016-10-06 Thread Zachary Turner via lldb-commits
Author: zturner Date: Thu Oct 6 16:22:44 2016 New Revision: 283494 URL: http://llvm.org/viewvc/llvm-project?rev=283494=rev Log: Convert UniqueCStringMap to use StringRef. Modified: lldb/trunk/include/lldb/Core/Stream.h lldb/trunk/include/lldb/Core/UniqueCStringMap.h

[Lldb-commits] [lldb] r283493 - xfail TestReportData.py on i386

2016-10-06 Thread Todd Fiala via lldb-commits
Author: tfiala Date: Thu Oct 6 16:16:37 2016 New Revision: 283493 URL: http://llvm.org/viewvc/llvm-project?rev=283493=rev Log: xfail TestReportData.py on i386 Tracked by: rdar://28658860 Modified: lldb/trunk/packages/Python/lldbsuite/test/functionalities/asan/TestReportData.py Modified:

Re: [Lldb-commits] [PATCH] D25329: Add bound violation handling for Intel(R) Memory Protection Extensions (Intel(R) MPX)

2016-10-06 Thread Ed Maste via lldb-commits
On 6 October 2016 at 16:42, Zachary Turner wrote: > I'm not sure actually. I only noticed this because I was in IRC and I saw > the message go by about the failure. > > Ed (already CC'ed) maintains the FreeBSD builder, so he might have an answer > for you. I'm not sure why

[Lldb-commits] [lldb] r283492 - xfail TestQueues on macOS

2016-10-06 Thread Todd Fiala via lldb-commits
Author: tfiala Date: Thu Oct 6 16:07:45 2016 New Revision: 283492 URL: http://llvm.org/viewvc/llvm-project?rev=283492=rev Log: xfail TestQueues on macOS This test is failing on CI. I cannot get it to fail on my local setup. Tracked by: rdar://28658529 Modified:

[Lldb-commits] [lldb] r283491 - Fix GetDisplayName when only a demangled name is available

2016-10-06 Thread Francis Ricci via lldb-commits
Author: fjricci Date: Thu Oct 6 15:41:11 2016 New Revision: 283491 URL: http://llvm.org/viewvc/llvm-project?rev=283491=rev Log: Fix GetDisplayName when only a demangled name is available Summary: GetDisplayDemangledName will already return a ConstString() when there is neither a mangled name or

[Lldb-commits] [PATCH] D25201: Fix GetDisplayName when only a demangled name is available

2016-10-06 Thread Francis Ricci via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL283491: Fix GetDisplayName when only a demangled name is available (authored by fjricci). Changed prior to commit: https://reviews.llvm.org/D25201?vs=73307=73847#toc Repository: rL LLVM

Re: [Lldb-commits] [PATCH] D25329: Add bound violation handling for Intel(R) Memory Protection Extensions (Intel(R) MPX)

2016-10-06 Thread Zachary Turner via lldb-commits
I'm not sure actually. I only noticed this because I was in IRC and I saw the message go by about the failure. Ed (already CC'ed) maintains the FreeBSD builder, so he might have an answer for you. On Thu, Oct 6, 2016 at 12:02 PM Giusti, Valentina < valentina.giu...@intel.com> wrote: > Ok, I

[Lldb-commits] [lldb] r283484 - xfail TestSBTypeTypeClass.py on macOS i386

2016-10-06 Thread Todd Fiala via lldb-commits
Author: tfiala Date: Thu Oct 6 14:23:29 2016 New Revision: 283484 URL: http://llvm.org/viewvc/llvm-project?rev=283484=rev Log: xfail TestSBTypeTypeClass.py on macOS i386 Tracked by: rdar://28656677 Modified:

[Lldb-commits] [lldb] r283483 - xfail TestDataFormatterNSIndexPath.py on macOS i386

2016-10-06 Thread Todd Fiala via lldb-commits
Author: tfiala Date: Thu Oct 6 14:18:48 2016 New Revision: 283483 URL: http://llvm.org/viewvc/llvm-project?rev=283483=rev Log: xfail TestDataFormatterNSIndexPath.py on macOS i386 Tracked by: rdar://28656605 Modified:

[Lldb-commits] [lldb] r283482 - xfail TestExec.py on macOS i386

2016-10-06 Thread Todd Fiala via lldb-commits
Author: tfiala Date: Thu Oct 6 14:12:05 2016 New Revision: 283482 URL: http://llvm.org/viewvc/llvm-project?rev=283482=rev Log: xfail TestExec.py on macOS i386 Tracked by: rdar://28656532 Modified: lldb/trunk/packages/Python/lldbsuite/test/functionalities/exec/TestExec.py Modified:

[Lldb-commits] [lldb] r283481 - xfail TestDiagnoseDereferenceFunctionReturn.py on macOS i386

2016-10-06 Thread Todd Fiala via lldb-commits
Author: tfiala Date: Thu Oct 6 14:04:58 2016 New Revision: 283481 URL: http://llvm.org/viewvc/llvm-project?rev=283481=rev Log: xfail TestDiagnoseDereferenceFunctionReturn.py on macOS i386 Tracked by: rdar://28656408 Modified:

[Lldb-commits] [lldb] r283479 - StringRef::front asserts on empty strings, causing "break modify -c ''" to assert.

2016-10-06 Thread Jim Ingham via lldb-commits
Author: jingham Date: Thu Oct 6 13:57:30 2016 New Revision: 283479 URL: http://llvm.org/viewvc/llvm-project?rev=283479=rev Log: StringRef::front asserts on empty strings, causing "break modify -c ''" to assert. Added a check for empty at the point where we were going to crash. Modified:

Re: [Lldb-commits] [PATCH] D25329: Add bound violation handling for Intel(R) Memory Protection Extensions (Intel(R) MPX)

2016-10-06 Thread Zachary Turner via lldb-commits
Seems like this has caused this buildbot failure: http://lab.llvm.org:8011/builders/lldb-amd64-ninja-freebsd11/builds/12936/steps/ninja%20build%20local/logs/stdio On Thu, Oct 6, 2016 at 11:14 AM Valentina Giusti wrote: > This revision was automatically updated to

[Lldb-commits] [lldb] r283477 - xfail TestDarwinLogBasic.py for i386 macOS

2016-10-06 Thread Todd Fiala via lldb-commits
Author: tfiala Date: Thu Oct 6 13:25:54 2016 New Revision: 283477 URL: http://llvm.org/viewvc/llvm-project?rev=283477=rev Log: xfail TestDarwinLogBasic.py for i386 macOS Tracked by: rdar://28655626 Modified:

[Lldb-commits] [lldb] r283474 - Add bound violation handling for Intel(R) Memory Protection Extensions (Intel(R) MPX)

2016-10-06 Thread Valentina Giusti via lldb-commits
Author: valentinagiusti Date: Thu Oct 6 13:05:12 2016 New Revision: 283474 URL: http://llvm.org/viewvc/llvm-project?rev=283474=rev Log: Add bound violation handling for Intel(R) Memory Protection Extensions (Intel(R) MPX) Summary: This patch adds support for handling the SIGSEGV signal with

[Lldb-commits] [PATCH] D25329: Add bound violation handling for Intel(R) Memory Protection Extensions (Intel(R) MPX)

2016-10-06 Thread Valentina Giusti via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL283474: Add bound violation handling for Intel(R) Memory Protection Extensions (Intel… (authored by valentinagiusti). Changed prior to commit: https://reviews.llvm.org/D25329?vs=73823=73826#toc

[Lldb-commits] [lldb] r283472 - Match printf field width arg and type

2016-10-06 Thread Ed Maste via lldb-commits
Author: emaste Date: Thu Oct 6 12:55:22 2016 New Revision: 283472 URL: http://llvm.org/viewvc/llvm-project?rev=283472=rev Log: Match printf field width arg and type A '*' as a field width or precision specifies that the field width or precision is supplied by an int argument. Modified:

[Lldb-commits] [PATCH] D25329: Add bound violation handling for Intel(R) Memory Protection Extensions (Intel(R) MPX)

2016-10-06 Thread Valentina Giusti via lldb-commits
valentinagiusti updated this revision to Diff 73823. valentinagiusti added a comment. fixed usage of llvm:raw_string_ostream https://reviews.llvm.org/D25329 Files: packages/Python/lldbsuite/test/functionalities/register/intel_xtended_registers/mpx_bound_violation/Makefile

[Lldb-commits] [lldb] r283468 - These test cases don't test different debug info formats.

2016-10-06 Thread Jim Ingham via lldb-commits
Author: jingham Date: Thu Oct 6 12:01:00 2016 New Revision: 283468 URL: http://llvm.org/viewvc/llvm-project?rev=283468=rev Log: These test cases don't test different debug info formats. Modified:

[Lldb-commits] [PATCH] D25329: Add bound violation handling for Intel(R) Memory Protection Extensions (Intel(R) MPX)

2016-10-06 Thread Zachary Turner via lldb-commits
zturner added inline comments. > CrashReason.cpp:38 > + stream << ")"; > + str += stream.str(); > +} Actually I'm not sure this is correct. Since you initialize the stream with `str`, as soon as you call `stream.str()` it will flush everything to the underlying string. Now `str` will

[Lldb-commits] [PATCH] D25329: Add bound violation handling for Intel(R) Memory Protection Extensions (Intel(R) MPX)

2016-10-06 Thread Valentina Giusti via lldb-commits
valentinagiusti updated this revision to Diff 73811. valentinagiusti added a comment. used llvm:raw_string_ostream instead of std::stringstream https://reviews.llvm.org/D25329 Files: packages/Python/lldbsuite/test/functionalities/register/intel_xtended_registers/mpx_bound_violation/Makefile

[Lldb-commits] [lldb] r283461 - Improve test for Intel(R) MPX registers.

2016-10-06 Thread Valentina Giusti via lldb-commits
Author: valentinagiusti Date: Thu Oct 6 10:49:10 2016 New Revision: 283461 URL: http://llvm.org/viewvc/llvm-project?rev=283461=rev Log: Improve test for Intel(R) MPX registers. Summary: Let the inferior test code determine if CPU and kernel support Intel(R) MPX and cleanup test script.

Re: [Lldb-commits] [PATCH] D25329: Add bound violation handling for Intel(R) Memory Protection Extensions (Intel(R) MPX)

2016-10-06 Thread Zachary Turner via lldb-commits
Can you use llvm:raw_string_ostream instead of std::stringstream? After that this looks fine On Thu, Oct 6, 2016 at 8:51 AM Pavel Labath wrote: > labath accepted this revision. > labath added a comment. > This revision is now accepted and ready to land. > > lgtm. > > At one

[Lldb-commits] [PATCH] D25329: Add bound violation handling for Intel(R) Memory Protection Extensions (Intel(R) MPX)

2016-10-06 Thread Pavel Labath via lldb-commits
labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. lgtm. At one point I'd like to change this code to not transfer the "crash reason" as string, but in a more structured way (i.e., `qXfer:siginfo:read` packet), but that is certainly out of

[Lldb-commits] [PATCH] D25329: Add bound violation handling for Intel(R) Memory Protection Extensions (Intel(R) MPX)

2016-10-06 Thread Valentina Giusti via lldb-commits
valentinagiusti created this revision. valentinagiusti added reviewers: zturner, labath. valentinagiusti added subscribers: emaste, lldb-commits. This patch adds support for handling the SIGSEGV signal with 'si_code == SEGV_BNDERR', which is thrown when a bound violation is caught by the Intel(R)

[Lldb-commits] [PATCH] D25328: Improve test for Intel(R) MPX registers.

2016-10-06 Thread Valentina Giusti via lldb-commits
valentinagiusti created this revision. valentinagiusti added a reviewer: zturner. valentinagiusti added a subscriber: lldb-commits. Let the inferior test code determine if CPU and kernel support Intel(R) MPX and cleanup test script. Signed-off-by: Valentina Giusti

[Lldb-commits] [PATCH] D24284: [lldb] Read modules from memory when a local copy is not available

2016-10-06 Thread walter erquinigo via lldb-commits
wallace added a comment. F2469236: before.txt F2469237: after.txt These are the output from running the tests. Btw, this was failing before because it was reading the export table incorrectly, but I updated it and it