[Lldb-commits] [PATCH] D25392: Remove TimeValue usage from FileSpec.h

2016-10-07 Thread Pavel Labath via lldb-commits
labath added a subscriber: mehdi_amini. labath added inline comments. Comment at: source/Host/common/FileSystem.cpp:103 + + return system_clock::from_time_t(file_stats.st_mtimespec.tv_sec) + + nanoseconds(file_stats.st_mtimespec.tv_nsec); The conversion

[Lldb-commits] [PATCH] D25393: Remove IntervalTimer class

2016-10-07 Thread Pavel Labath via lldb-commits
labath created this revision. labath added reviewers: clayborg, zturner. labath added a subscriber: lldb-commits. it was added back in 2013, but there are no uses of it. I started refactoring it, but then it occured to me it would better to delete it. https://reviews.llvm.org/D25393 Files:

[Lldb-commits] [PATCH] D25392: Remove TimeValue usage from FileSpec.h

2016-10-07 Thread Pavel Labath via lldb-commits
labath created this revision. labath added reviewers: clayborg, zturner. labath added a subscriber: lldb-commits. Herald added subscribers: mgorny, beanz, danalbert, tberghammer. The only usage there was in GetModificationTime(). I also took the opportunity to move this function from FileSpec to

[Lldb-commits] [PATCH] D25391: Remove usages of TimeValue from gdb-remote process plugin

2016-10-07 Thread Pavel Labath via lldb-commits
labath created this revision. labath added reviewers: clayborg, zturner. labath added a subscriber: lldb-commits. Most of the changes are very straight-forward, the only tricky part was the "packet speed-test" function, which is very time-heavy. As the function was completely untested, I added a

[Lldb-commits] [lldb] r283652 - Fix compiler warnings in TestClangASTContext.cpp

2016-10-07 Thread Pavel Labath via lldb-commits
Author: labath Date: Fri Oct 7 23:03:19 2016 New Revision: 283652 URL: http://llvm.org/viewvc/llvm-project?rev=283652=rev Log: Fix compiler warnings in TestClangASTContext.cpp Modified: lldb/trunk/unittests/Symbol/TestClangASTContext.cpp Modified:

[Lldb-commits] [lldb] r283651 - Fix compiler warnings in PlatformDarwinTest.cpp

2016-10-07 Thread Pavel Labath via lldb-commits
Author: labath Date: Fri Oct 7 23:03:15 2016 New Revision: 283651 URL: http://llvm.org/viewvc/llvm-project?rev=283651=rev Log: Fix compiler warnings in PlatformDarwinTest.cpp Modified: lldb/trunk/unittests/Platform/PlatformDarwinTest.cpp Modified:

[Lldb-commits] [lldb] r283607 - Fix a few warnings caught by clang.

2016-10-07 Thread Zachary Turner via lldb-commits
Author: zturner Date: Fri Oct 7 16:32:16 2016 New Revision: 283607 URL: http://llvm.org/viewvc/llvm-project?rev=283607=rev Log: Fix a few warnings caught by clang. Modified: lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp

[Lldb-commits] [lldb] r283604 - Remove a stray dump().

2016-10-07 Thread Sean Callanan via lldb-commits
Author: spyffe Date: Fri Oct 7 16:25:29 2016 New Revision: 283604 URL: http://llvm.org/viewvc/llvm-project?rev=283604=rev Log: Remove a stray dump(). Modified: lldb/trunk/source/Expression/IRExecutionUnit.cpp Modified: lldb/trunk/source/Expression/IRExecutionUnit.cpp URL:

[Lldb-commits] [lldb] r283603 - Remove unused variable.

2016-10-07 Thread Zachary Turner via lldb-commits
Author: zturner Date: Fri Oct 7 16:23:31 2016 New Revision: 283603 URL: http://llvm.org/viewvc/llvm-project?rev=283603=rev Log: Remove unused variable. Modified: lldb/trunk/source/Interpreter/OptionValueEnumeration.cpp Modified: lldb/trunk/source/Interpreter/OptionValueEnumeration.cpp URL:

[Lldb-commits] [lldb] r283578 - The PR that caused this test ot fail was fixed in July, removing the XFAIL.

2016-10-07 Thread Jim Ingham via lldb-commits
Author: jingham Date: Fri Oct 7 13:15:11 2016 New Revision: 283578 URL: http://llvm.org/viewvc/llvm-project?rev=283578=rev Log: The PR that caused this test ot fail was fixed in July, removing the XFAIL. Modified:

[Lldb-commits] [PATCH] D25362: Fix build failure on lldb-amd64-ninja-freebsd11 error caused by rL283474

2016-10-07 Thread Valentina Giusti via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL283548: Fix build failure on lldb-amd64-ninja-freebsd11 error caused by rL283474 (authored by valentinagiusti). Changed prior to commit: https://reviews.llvm.org/D25362?vs=73909=73945#toc Repository:

[Lldb-commits] [lldb] r283548 - Fix build failure on lldb-amd64-ninja-freebsd11 error caused by rL283474

2016-10-07 Thread Valentina Giusti via lldb-commits
Author: valentinagiusti Date: Fri Oct 7 08:21:59 2016 New Revision: 283548 URL: http://llvm.org/viewvc/llvm-project?rev=283548=rev Log: Fix build failure on lldb-amd64-ninja-freebsd11 error caused by rL283474 Differential Revision: https://reviews.llvm.org/D25362 Modified:

[Lldb-commits] [PATCH] D25362: Fix build failure on lldb-amd64-ninja-freebsd11 error caused by rL283474

2016-10-07 Thread Ed Maste via lldb-commits
emaste accepted this revision. emaste added a reviewer: emaste. emaste added a comment. This revision is now accepted and ready to land. Not tested, but looks reasonable to me. I think we should avoid `siginfo_t` altogether here in order to support cross-debugging, but that's for a different

[Lldb-commits] [PATCH] D25362: Fix build failure on lldb-amd64-ninja-freebsd11 error caused by rL283474

2016-10-07 Thread Valentina Giusti via lldb-commits
valentinagiusti updated this revision to Diff 73909. valentinagiusti added a comment. cleaned up code https://reviews.llvm.org/D25362 Files: source/Plugins/Process/POSIX/CrashReason.cpp source/Plugins/Process/POSIX/CrashReason.h Index: source/Plugins/Process/POSIX/CrashReason.h

[Lldb-commits] [PATCH] D25362: Fix build failure on lldb-amd64-ninja-freebsd11 error caused by rL283474

2016-10-07 Thread Valentina Giusti via lldb-commits
valentinagiusti updated this revision to Diff 73907. valentinagiusti added a comment. applied clang-format https://reviews.llvm.org/D25362 Files: source/Plugins/Process/POSIX/CrashReason.cpp source/Plugins/Process/POSIX/CrashReason.h Index: source/Plugins/Process/POSIX/CrashReason.h

[Lldb-commits] [PATCH] D25362: Fix build failure on lldb-amd64-ninja-freebsd11 error caused by rL283474

2016-10-07 Thread Valentina Giusti via lldb-commits
valentinagiusti created this revision. valentinagiusti added reviewers: zturner, labath. valentinagiusti added subscribers: lldb-commits, emaste. https://reviews.llvm.org/D25362 Files: source/Plugins/Process/POSIX/CrashReason.cpp source/Plugins/Process/POSIX/CrashReason.h Index: