[Lldb-commits] [PATCH] D26470: Fix weak symbol linkage in SBStructuredData, update docs.

2016-11-09 Thread Todd Fiala via lldb-commits
tfiala added a comment. Thanks, Jim! https://reviews.llvm.org/D26470 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D26478: Unify Darwin and Non-Darwin printing of version output

2016-11-09 Thread Todd Fiala via lldb-commits
tfiala accepted this revision. tfiala added a reviewer: tfiala. tfiala added a comment. This revision is now accepted and ready to land. Looks good, @beanz! https://reviews.llvm.org/D26478 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D26470: Fix weak symbol linkage in SBStructuredData, update docs.

2016-11-09 Thread Jim Ingham via lldb-commits
jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. Looks good. https://reviews.llvm.org/D26470 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D26470: Fix weak symbol linkage in SBStructuredData, update docs.

2016-11-09 Thread Todd Fiala via lldb-commits
tfiala updated this revision to Diff 77405. tfiala added a comment. Adjusted web docs. https://reviews.llvm.org/D26470 Files: API/SBStructuredData.cpp SB-api-coding-rules.html lldb/API/SBStructuredData.h Index: SB-api-coding-rules.html

[Lldb-commits] [PATCH] D26478: Unify Darwin and Non-Darwin printing of version output

2016-11-09 Thread Chris Bieneman via lldb-commits
beanz created this revision. beanz added a reviewer: lldb-commits. beanz added a subscriber: tfiala. Herald added a subscriber: mgorny. This change unifies and simplifies the code paths between the Darwin and non-Darwin code to print the LLDB version information. It also introduces a new

[Lldb-commits] [PATCH] D26470: Fix weak symbol linkage in SBStructuredData, update docs.

2016-11-09 Thread Todd Fiala via lldb-commits
tfiala added a comment. Making changes to the text... Comment at: SB-api-coding-rules.html:51-54 +An example of this is the SBValue class. Please note it is necessary for the Impl class to +not

[Lldb-commits] [PATCH] D26470: Fix weak symbol linkage in SBStructuredData, update docs.

2016-11-09 Thread Jim Ingham via lldb-commits
jingham added a comment. This is fine with one comment on the text. Comment at: SB-api-coding-rules.html:51-54 +An example of this is the SBValue class. Please note it is necessary for the Impl class to +

[Lldb-commits] [PATCH] D26470: Fix weak symbol linkage in SBStructuredData, update docs.

2016-11-09 Thread Todd Fiala via lldb-commits
tfiala created this revision. tfiala added a reviewer: jingham. tfiala added a subscriber: lldb-commits. This change fixes an issue where I was leaking a weakly-linked symbol in the SBAPI. It also updates the docs to call out what I did wrong. https://reviews.llvm.org/D26470 Files:

[Lldb-commits] [lldb] r286387 - [RenderScript] Fix reduction argument printing

2016-11-09 Thread Luke Drummond via lldb-commits
Author: ldrumm Date: Wed Nov 9 13:20:39 2016 New Revision: 286387 URL: http://llvm.org/viewvc/llvm-project?rev=286387=rev Log: [RenderScript] Fix reduction argument printing When placing function name breakpoints on RenderScript Reduction kernel functions, we were not skipping over the function

[Lldb-commits] [PATCH] D26403: Display the pointer value in the libstdc++ unique_ptr summary

2016-11-09 Thread Enrico Granata via lldb-commits
granata.enrico added a comment. Makes sense. Feel free to commit. Repository: rL LLVM https://reviews.llvm.org/D26403 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D26451: Remove TimeValue class

2016-11-09 Thread Pavel Labath via lldb-commits
labath created this revision. labath added reviewers: clayborg, zturner. labath added a subscriber: lldb-commits. Herald added a subscriber: mgorny. All usages have been replaced by appropriate std::chrono funcionality, and the class is now unused. The only used part of the cpp file is the

[Lldb-commits] [lldb] r286373 - Remove TimeValue usage from ObjectContainerBSDArchive

2016-11-09 Thread Pavel Labath via lldb-commits
Author: labath Date: Wed Nov 9 09:05:45 2016 New Revision: 286373 URL: http://llvm.org/viewvc/llvm-project?rev=286373=rev Log: Remove TimeValue usage from ObjectContainerBSDArchive Modified: lldb/trunk/source/Plugins/ObjectContainer/BSD-Archive/ObjectContainerBSDArchive.cpp

[Lldb-commits] [lldb] r286371 - Remove TimeValue usage from lldb/Host

2016-11-09 Thread Pavel Labath via lldb-commits
Author: labath Date: Wed Nov 9 08:53:32 2016 New Revision: 286371 URL: http://llvm.org/viewvc/llvm-project?rev=286371=rev Log: Remove TimeValue usage from lldb/Host Modified: lldb/trunk/source/Host/common/Socket.cpp lldb/trunk/source/Host/windows/ConnectionGenericFileWindows.cpp

[Lldb-commits] [lldb] r286366 - Remove TimeValue usage from lldb/Core. NFC.

2016-11-09 Thread Pavel Labath via lldb-commits
Author: labath Date: Wed Nov 9 08:04:08 2016 New Revision: 286366 URL: http://llvm.org/viewvc/llvm-project?rev=286366=rev Log: Remove TimeValue usage from lldb/Core. NFC. Modified: lldb/trunk/include/lldb/Core/ModuleSpec.h lldb/trunk/include/lldb/Core/SourceManager.h

[Lldb-commits] [lldb] r286360 - Fix expectation in TestStaticVariables.py after rL286302

2016-11-09 Thread Tamas Berghammer via lldb-commits
Author: tberghammer Date: Wed Nov 9 05:52:12 2016 New Revision: 286360 URL: http://llvm.org/viewvc/llvm-project?rev=286360=rev Log: Fix expectation in TestStaticVariables.py after rL286302 The debug info emitted by clang for static variables improved by rL286302 and it exposed an incorrect test

[Lldb-commits] [PATCH] D26403: Display the pointer value in the libstdc++ unique_ptr summary

2016-11-09 Thread Pavel Labath via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL286355: Display the pointer value in the libstdc++ unique_ptr summary (authored by labath). Changed prior to commit: https://reviews.llvm.org/D26403?vs=77202=77329#toc Repository: rL LLVM

[Lldb-commits] [lldb] r286355 - Display the pointer value in the libstdc++ unique_ptr summary

2016-11-09 Thread Pavel Labath via lldb-commits
Author: labath Date: Wed Nov 9 04:42:29 2016 New Revision: 286355 URL: http://llvm.org/viewvc/llvm-project?rev=286355=rev Log: Display the pointer value in the libstdc++ unique_ptr summary Summary: r284830 added a summary provider for unique_ptr in libstdc++, whose value printed the value of

[Lldb-commits] [PATCH] D26393: Disable windows-only minidump plugin

2016-11-09 Thread Pavel Labath via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL286352: Disable windows-only minidump plugin (authored by labath). Changed prior to commit: https://reviews.llvm.org/D26393?vs=77175=77325#toc Repository: rL LLVM https://reviews.llvm.org/D26393

[Lldb-commits] [lldb] r286352 - Disable windows-only minidump plugin

2016-11-09 Thread Pavel Labath via lldb-commits
Author: labath Date: Wed Nov 9 04:16:11 2016 New Revision: 286352 URL: http://llvm.org/viewvc/llvm-project?rev=286352=rev Log: Disable windows-only minidump plugin Summary: This commit disables the windows-only minidump plugin and enables the new cross-platform plugin for windows minidump

[Lldb-commits] [PATCH] D26393: Disable windows-only minidump plugin

2016-11-09 Thread Pavel Labath via lldb-commits
labath added a comment. Yeah, feel free to take over. I was not planning to do any more work here - just wanted to wrap things up. I am going to commit this then, and leave the rest to you. https://reviews.llvm.org/D26393 ___ lldb-commits mailing

[Lldb-commits] [PATCH] D26275: Remove TimeValue usage from Core/Module

2016-11-09 Thread Pavel Labath via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL286349: Remove TimeValue usage from Core/Module (authored by labath). Changed prior to commit: https://reviews.llvm.org/D26275?vs=77209=77323#toc Repository: rL LLVM https://reviews.llvm.org/D26275

[Lldb-commits] [lldb] r286349 - Remove TimeValue usage from Core/Module

2016-11-09 Thread Pavel Labath via lldb-commits
Author: labath Date: Wed Nov 9 03:59:18 2016 New Revision: 286349 URL: http://llvm.org/viewvc/llvm-project?rev=286349=rev Log: Remove TimeValue usage from Core/Module Summary: The only interesting part here is that TimePoint and TimeValue have different natural string representations, which