[Lldb-commits] [PATCH] D29215: [LLDB][MIPS] Fix TestMiniDumpNew

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. I am glad we could come closer to the cause of the problem. At one point we should have a common base class for all core tests, so that we don't have to do this manually (and also avoid doing

[Lldb-commits] [PATCH] D29266: Synchronize PlatformNetBSD with Linux

labath requested changes to this revision. labath added a comment. This revision now requires changes to proceed. How much of the code is now actually different between the two classes? If the only changes are of the s/linux/netbsd type, then we should just create a new base class for the two,

[Lldb-commits] [PATCH] D29256: Do not pass non-POD type variables through variadic function

labath accepted this revision. labath added a comment. > Interesting. Passing to what? I thought it means we shouldn't pass > non-trivial types through variadic arguments (... expression), and in this > case we don't do it because CMIUtilString is the type of the parameter > vFormating which

[Lldb-commits] [PATCH] D29256: Do not pass non-POD type variables through variadic function

joerg added a comment. #include #include void f(std::string msg, ...) { va_list ap; va_start(ap, msg); } compiled against libc++ gives: test.cc:6:3: error: cannot pass object of non-POD type 'std::string' (aka 'basic_string') through

[Lldb-commits] [PATCH] D29095: Open ELF core dumps with more than 64K sections

EugeneBi added a comment. So, what's now? Can somebody commit it, please? I do not see any option to do it myself. https://reviews.llvm.org/D29095 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D29288: Switch std::call_once to llvm::call_once

krytarowski added a comment. In https://reviews.llvm.org/D29288#660703, @mehdi_amini wrote: > In https://reviews.llvm.org/D29288#660677, @krytarowski wrote: > > > In https://reviews.llvm.org/D29288#660636, @clayborg wrote: > > > > > Be very careful when using this, you can't change member

[Lldb-commits] [PATCH] D29288: Switch std::call_once to llvm::call_once

krytarowski added a comment. namespace llvm { namespace sys { void MemoryFence(); #ifdef _MSC_VER typedef long cas_flag; #else typedef uint32_t cas_flag; #endif cas_flag CompareAndSwap(volatile cas_flag* ptr, cas_flag new_value,

[Lldb-commits] [PATCH] D29288: Switch std::call_once to llvm::call_once

krytarowski added a comment. In https://reviews.llvm.org/D29288#660636, @clayborg wrote: > Be very careful when using this, you can't change member variables that used > to be std::once to be statics. We also don't need the llvm namespace to be > included with "using namespace llvm;" in many

[Lldb-commits] [PATCH] D29288: Switch std::call_once to llvm::call_once

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. Be very careful when using this, you can't change member variables that used to be std::once to be statics. We also don't need the llvm namespace to be included with "using

[Lldb-commits] [PATCH] D29288: Switch std::call_once to llvm::call_once

mehdi_amini added a comment. I'm fine with this change, but I'll leave the approval to one of the LLDB developer :) (Thanks for following-up with the libstdc++ on these platforms!) Repository: rL LLVM https://reviews.llvm.org/D29288 ___

[Lldb-commits] [PATCH] D29288: Switch std::call_once to llvm::call_once

krytarowski added a comment. I can build and test this patch on NetBSD/amd64. I don't have access right now to a performant FreeBSD, Linux, Android, Windows and FreeBSD hosts to test build and execute tests for this patch on other platforms. Please check. I was in touch with `libstdc++`

[Lldb-commits] [PATCH] D29288: Switch std::call_once to llvm::call_once

krytarowski created this revision. krytarowski added a project: LLDB. The std::call_once implementation in libstdc++ has problems on few systems: NetBSD, OpenBSD and Linux PPC. LLVM ships with a homegrown implementation llvm::call_once to help on these platforms. This change is

[Lldb-commits] [PATCH] D28155: Force the installation of lldb-server and lldb-argdumper

sylvestre.ledru abandoned this revision. sylvestre.ledru added a comment. Thanks! https://reviews.llvm.org/D28155 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D29215: [LLDB][MIPS] Fix TestMiniDumpNew

nitesh.jain updated this revision to Diff 86268. nitesh.jain added a comment. Added setUp/tearDown code, which saves and restores the original platform after each run. Thanks https://reviews.llvm.org/D29215 Files:

[Lldb-commits] [PATCH] D29256: Do not pass non-POD type variables through variadic function

krytarowski added a comment. Hmm, I'm not reproducing it right now either. It's a patch added a year ago. I've pinged Tobias. Repository: rL LLVM https://reviews.llvm.org/D29256 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D29256: Do not pass non-POD type variables through variadic function

ki.stfu added a comment. In https://reviews.llvm.org/D29256#660159, @krytarowski wrote: > It's undefined (implementation defined) behavior. > > C++11 5.2.2/7: > > > > Passing a potentially-evaluated argument of class type having a > > non-trivial copy constructor, a non-trivial move

[Lldb-commits] [PATCH] D29256: Do not pass non-POD type variables through variadic function

krytarowski added a comment. In https://reviews.llvm.org/D29256#660072, @ki.stfu wrote: > I don't know the point of this patch (probably it's something special for > NetBSD? @emaste) but I'm okay with that. It's undefined (implementation defined) behavior. C++11 5.2.2/7: > Passing a