Re: [Lldb-commits] [PATCH] D29909: Break some more dependencies in lldbUtility

2017-02-14 Thread Zachary Turner via lldb-commits
Indeed it should, but unfortunately this is a hand maintained project, and I don't have a Mac. Usually in these cases the first person to notice the Xcode project is broken just submits a fix for it On Tue, Feb 14, 2017 at 11:27 PM Boris Ulasevich via Phabricator < revi...@reviews.llvm.org> wrote:

[Lldb-commits] [PATCH] D29909: Break some more dependencies in lldbUtility

2017-02-14 Thread Boris Ulasevich via Phabricator via lldb-commits
boris.ulasevich added a comment. FYI. After r295088 commit Xcode project fails with "no such file or directory: '/Users/boris/ws/lldb/lldb/source/Utility/ModuleCache.cpp'" message. I think lldb.xcodeproj/project.pbxproj should be updated. Repository: rL LLVM https://reviews.llvm.org/D29909

[Lldb-commits] [PATCH] D29964: Finish breaking the dependency from lldbUtility -> Host

2017-02-14 Thread Zachary Turner via Phabricator via lldb-commits
zturner created this revision. Herald added subscribers: mgorny, srhines, danalbert. This patch finally gets `lldbUtility` to be dependency-free. This was done through the following changes: 1. `PseudoTerminal.cpp` : `Utility` -> `Host` 2. Introduce a `vasprintf` / `vsnprintf` wrapper into util

[Lldb-commits] [PATCH] D29144: LLDB: fix for TestCallThatThrows.py test fail

2017-02-14 Thread Jim Ingham via Phabricator via lldb-commits
jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. Okay, I buy that. https://reviews.llvm.org/D29144 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailm

[Lldb-commits] [lldb] r295091 - Use StringRef and APFloat instead of lldb/StringConvert.h

2017-02-14 Thread Zachary Turner via lldb-commits
Author: zturner Date: Tue Feb 14 13:07:01 2017 New Revision: 295091 URL: http://llvm.org/viewvc/llvm-project?rev=295091&view=rev Log: Use StringRef and APFloat instead of lldb/StringConvert.h Modified: lldb/trunk/source/Utility/JSON.cpp Modified: lldb/trunk/source/Utility/JSON.cpp URL: http

[Lldb-commits] [PATCH] D29144: LLDB: fix for TestCallThatThrows.py test fail

2017-02-14 Thread Boris Ulasevich via Phabricator via lldb-commits
boris.ulasevich added a comment. Yes, it is quite old story. Original issue was that breakpoint with false condition resumes execution in spite of completed step plan. There was two local fix proposals, but finally the issue was fixed by StopInfoBreakpoint::PerformAction and Thread::GetStopInfo

[Lldb-commits] [PATCH] D29895: Refactor log channel registration mechanism

2017-02-14 Thread Pavel Labath via Phabricator via lldb-commits
labath updated this revision to Diff 88395. labath marked an inline comment as done. labath added a comment. Encapsulate the atomic stuff into the Log::Channel class. Add a couple of comments. Let me know what you think. https://reviews.llvm.org/D29895 Files: include/lldb/Core/Log.h inclu

[Lldb-commits] [PATCH] D29144: LLDB: fix for TestCallThatThrows.py test fail

2017-02-14 Thread Jim Ingham via Phabricator via lldb-commits
jingham added a comment. If the problem is related to the handling of "don't stop at breakpoints" expressions, can we fix it closer to there? https://reviews.llvm.org/D29144 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llv

[Lldb-commits] [PATCH] D29895: Refactor log channel registration mechanism

2017-02-14 Thread Pavel Labath via Phabricator via lldb-commits
labath updated this revision to Diff 88381. labath added a comment. New version of the patch. I can still see a bit of room for improvement, but I am not sure if I'll manage to do it today, so this should at least enable us to do another round-trip. https://reviews.llvm.org/D29895 Files: inc

[Lldb-commits] [PATCH] D29895: Refactor log channel registration mechanism

2017-02-14 Thread Pavel Labath via Phabricator via lldb-commits
labath marked an inline comment as done. labath added a comment. Comment at: source/Core/Log.cpp:72 +if (llvm::StringRef("all").equals_lower(categories[i])) { + flags |= ~0; + continue; zturner wrote: > This is a little clearer if you just say `f

[Lldb-commits] [PATCH] D29932: Fix TestNameLookup for GCC

2017-02-14 Thread Pavel Labath via Phabricator via lldb-commits
labath created this revision. GCC emits also symbols for the __PRETTY_FUNCTION__ virtual variable, which we accidentaly pick up when looking for functions for with "unique_function_name" in the name. This makes the target.FindFunctions call fail, as that symbol is not a function. I also strenghte

[Lldb-commits] [lldb] r295047 - XFAIL TestNameLookup for GCC

2017-02-14 Thread Pavel Labath via lldb-commits
Author: labath Date: Tue Feb 14 06:06:54 2017 New Revision: 295047 URL: http://llvm.org/viewvc/llvm-project?rev=295047&view=rev Log: XFAIL TestNameLookup for GCC I think I have a fix for this, but it needs review. This should keep the bots happy until then. Modified: lldb/trunk/packages/Pyt

[Lldb-commits] [PATCH] D29909: Break some more dependencies in lldbUtility

2017-02-14 Thread Pavel Labath via Phabricator via lldb-commits
labath accepted this revision. labath added a comment. looks good https://reviews.llvm.org/D29909 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D29144: LLDB: fix for TestCallThatThrows.py test fail

2017-02-14 Thread Boris Ulasevich via Phabricator via lldb-commits
boris.ulasevich added a comment. ping! https://reviews.llvm.org/D29144 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits