eugene marked an inline comment as done.
eugene added inline comments.
Comment at: packages/Python/lldbsuite/test/tools/lldb-server/main.cpp:32-42
+static const char *const RETVAL_PREFIX = "retval:";
+static const char *const SLEEP_PREFIX = "sleep:";
+static const char *const
Author: jmolenda
Date: Tue Feb 21 20:10:00 2017
New Revision: 295804
URL: http://llvm.org/viewvc/llvm-project?rev=295804=rev
Log:
Mark TestDarwinLogBasic.py as an xfail because the logging is
not being picked up; filed to track
the work to investigate this.
Modified:
eugene added a comment.
In https://reviews.llvm.org/D30234#683018, @jingham wrote:
> Anyway, it might be better just to do that to this file using the top level
> .clang-format. Note that you are making several choices which were not the
> choices made by clang-format using the .clang-format
eugene updated this revision to Diff 89312.
https://reviews.llvm.org/D30234
Files:
packages/Python/lldbsuite/test/tools/lldb-server/main.cpp
Index: packages/Python/lldbsuite/test/tools/lldb-server/main.cpp
===
---
eugene updated this revision to Diff 89311.
https://reviews.llvm.org/D30234
Files:
packages/Python/lldbsuite/test/tools/lldb-server/main.cpp
Index: packages/Python/lldbsuite/test/tools/lldb-server/main.cpp
===
---
Hello everyone,
Below are some buildbot numbers for the last week of 02/12/2017 -
02/18/2017.
Please see the same data in attached csv files:
The longest time each builder was red during the last week;
"Status change ratio" by active builder (percent of builds that changed the
builder status
jingham added a comment.
Actually, we didn't run the clang-format over the test case source files, since
we didn't want to have to deal with the possible failures resulting. So just
clang-formatting this file is probably the right way to go.
https://reviews.llvm.org/D30234
eugene added a comment.
In https://reviews.llvm.org/D30234#682990, @jmajors wrote:
> Do we have any plans to put something like cpplint into effect?
First step would be to have warning free build.
Then we can turn "warnings as errors" on.
https://reviews.llvm.org/D30234
amccarth accepted this revision.
amccarth added a comment.
This revision is now accepted and ready to land.
LGTM.
Maybe we have too many categories.
Comment at: source/Plugins/Process/Windows/Common/DebuggerThread.cpp:207
if (m_active_exception.get()) {
-
Author: labath
Date: Tue Feb 21 03:58:23 2017
New Revision: 295712
URL: http://llvm.org/viewvc/llvm-project?rev=295712=rev
Log:
Log: Fix race in accessing the stream variable
Summary:
The code was attempting to copy the shared pointer member in order to
guarantee atomicity, but this is not
10 matches
Mail list logo
