[Lldb-commits] [PATCH] D30374: Support NetBSD Thread ID in lldb-server

2017-02-24 Thread Kamil Rytarowski via Phabricator via lldb-commits
krytarowski created this revision. krytarowski added a project: LLDB. Native Thread ID is retrieved with _lwp_self() on NetBSD. The returned value is of type int32_t, but for consistency with other Operating Systems cast it to uint64_t. Sponsored by Repository: rL LLVM

[Lldb-commits] [lldb] r296243 - Three LoadLibCxxFormatters formatters were given a regex string to

2017-02-24 Thread Jason Molenda via lldb-commits
Author: jmolenda Date: Fri Feb 24 23:43:51 2017 New Revision: 296243 URL: http://llvm.org/viewvc/llvm-project?rev=296243=rev Log: Three LoadLibCxxFormatters formatters were given a regex string to match but the 'is_regex' argument was not passed as true. Not sure this is causing a bug, but

[Lldb-commits] [lldb] r296238 - DataBufferMemoryMap.cpp out, DataBufferLLVM.cpp in. Unbreak the build.

2017-02-24 Thread Jason Molenda via lldb-commits
Author: jmolenda Date: Fri Feb 24 22:06:09 2017 New Revision: 296238 URL: http://llvm.org/viewvc/llvm-project?rev=296238=rev Log: DataBufferMemoryMap.cpp out, DataBufferLLVM.cpp in. Unbreak the build. Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj Modified:

[Lldb-commits] [PATCH] D30272: Improve data formatter for libstdcpp unique_ptr

2017-02-24 Thread Jim Ingham via Phabricator via lldb-commits
jingham added a comment. I also thought about having the synthetic child provider mark up the special child value objects when it made them. It bugs me a little but that you couldn't, for instance, have a synthetic child provider that doesn't display a child that is the result of the

[Lldb-commits] [PATCH] D30054: Delete DataBufferMemoryMap

2017-02-24 Thread Zachary Turner via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL296159: Delete DataBufferMemoryMap. (authored by zturner). Changed prior to commit: https://reviews.llvm.org/D30054?vs=89547=89701#toc Repository: rL LLVM https://reviews.llvm.org/D30054 Files:

[Lldb-commits] [PATCH] D30249: Clear expression when breakpoint location becomes unresolved

2017-02-24 Thread Pavel Labath via Phabricator via lldb-commits
labath updated this revision to Diff 89645. labath added a comment. Switch SBBreakpoint to weak_ptr. This diff is pretty big but it amounts to s/m_opaque_sp/m_opaque_wp and inserting a lock at the beginning of every function. Since I had to touch them anyway, I took the opportunity to upgrade the

[Lldb-commits] [lldb] r296107 - Attempt to fix windows unit tests

2017-02-24 Thread Pavel Labath via lldb-commits
Author: labath Date: Fri Feb 24 05:17:40 2017 New Revision: 296107 URL: http://llvm.org/viewvc/llvm-project?rev=296107=rev Log: Attempt to fix windows unit tests In LLVM r296049, IPDBSession::getGlobalScope lost its constness. Adjust the unittest to account for that. Modified:

[Lldb-commits] [PATCH] D30054: Delete DataBufferMemoryMap

2017-02-24 Thread Pavel Labath via Phabricator via lldb-commits
labath added a comment. I am not sure if this is a voting situation, but I agree with what Zachary said above. Since we're already speaking about tests, it looks like the new DataBufferLLVM class could use a unit test or two, just so we get in the habit of writing those.

[Lldb-commits] [PATCH] D30286: Implement QPassSignals GDB package in lldb-server

2017-02-24 Thread Pavel Labath via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL296101: Implement QPassSignals GDB package in lldb-server (authored by labath). Changed prior to commit: https://reviews.llvm.org/D30286?vs=89575=89623#toc Repository: rL LLVM

[Lldb-commits] [PATCH] D30286: Implement QPassSignals GDB package in lldb-server

2017-02-24 Thread Pavel Labath via Phabricator via lldb-commits
labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Looks great. Thank you. https://reviews.llvm.org/D30286 ___ lldb-commits mailing list lldb-commits@lists.llvm.org