[Lldb-commits] [PATCH] D31485: Verify memory address range validity in GDBRemoteCommunicationClient

sas added a reviewer: clayborg. sas added a subscriber: clayborg. sas added a comment. Doing additional checking on the packets returned over the wire seems decent to me. CC'ing @clayborg to see what he thinks about it also. https://reviews.llvm.org/D31485

[Lldb-commits] [PATCH] D31450: Battery of NetBSD support improvements

krytarowski added inline comments. Comment at: source/Plugins/Process/NetBSD/NativeProcessNetBSD.cpp:249 + // Initialize new thread + struct ptrace_lwpinfo info = {}; + Error error = PtraceWrapper(PT_LWPINFO, pid, , sizeof(info)); labath wrote: >

[Lldb-commits] [PATCH] D31451: New C++ function name parsing logic

eugene updated this revision to Diff 93438. eugene added reviewers: labath, zturner, jingham. eugene changed the visibility from "eugene (Eugene Zemtsov)" to "Public (No Login Required)". eugene changed the edit policy from "eugene (Eugene Zemtsov)" to "All Users". eugene added a subscriber:

Re: [Lldb-commits] [lldb] r298189 - Remove some dead code from DumpValueObjectOptions::PointerDepth

This is not dead code in Swift-enabled LLDB, as I just found out doing a merge. I'm going to use Default and see what breaks. Sean > On Mar 18, 2017, at 10:33 AM, Tamas Berghammer via lldb-commits > wrote: > > Author: tberghammer > Date: Sat Mar 18 12:33:00 2017

[Lldb-commits] [lldb] r299040 - Mask out EXC_SYSCALL exceptions as well.

Author: jmolenda Date: Wed Mar 29 19:23:46 2017 New Revision: 299040 URL: http://llvm.org/viewvc/llvm-project?rev=299040=rev Log: Mask out EXC_SYSCALL exceptions as well. Modified: lldb/trunk/tools/debugserver/source/MacOSX/MachException.cpp Modified:

[Lldb-commits] [PATCH] D31485: Verify memory address range validity in GDBRemoteCommunicationClient

xiaobai created this revision. This aims to verify the validity of the response from the debugging server in GDBRemoteCommunicationClient::GetMemoryRegionInfo. I was working with ds2 (https://github.com/facebook/ds2) and encountered a bug that caused the server's response to have a 'size' value

[Lldb-commits] [lldb] r299028 - Centralize libc++ test skipping logic

Author: labath Date: Wed Mar 29 16:01:14 2017 New Revision: 299028 URL: http://llvm.org/viewvc/llvm-project?rev=299028=rev Log: Centralize libc++ test skipping logic Summary: This aims to replace the different decorators we've had on each libc++ test with a single solution. Each libc++ will be

[Lldb-commits] [PATCH] D30984: Centralize libc++ test skipping logic

This revision was automatically updated to reflect the committed changes. Closed by commit rL299028: Centralize libc++ test skipping logic (authored by labath). Changed prior to commit: https://reviews.llvm.org/D30984?vs=91878=93407#toc Repository: rL LLVM https://reviews.llvm.org/D30984

[Lldb-commits] [PATCH] D30984: Centralize libc++ test skipping logic

EricWF added a comment. In https://reviews.llvm.org/D30984#713490, @labath wrote: > In https://reviews.llvm.org/D30984#711806, @EricWF wrote: > > > I don't see anything wrong with this, but I only know libc++ and not LLDB. > > > I'm not sure why you ended up here. I think you have too wide

[Lldb-commits] [PATCH] D30984: Centralize libc++ test skipping logic

labath added a comment. In https://reviews.llvm.org/D30984#711806, @EricWF wrote: > I don't see anything wrong with this, but I only know libc++ and not LLDB. I'm not sure why you ended up here. I think you have too wide phabricator filter somewhere. :) > > >> libc++'s atomic does not

[Lldb-commits] [PATCH] D31367: Expression: add missing linkage to RuntimeDyld component

labath added a comment. We don't depend on the RuntimeDyld component of llvm directy -- we only use it indirectly through the ExecutionEngine component. Shouldn't that be reflected as a dependency in the build system somehow, so that the former can be pulled in directly ? RuntimeDyld is listed

[Lldb-commits] [lldb] r299023 - Add NetBSD path for Debugging Information in Separate Files

Author: kamil Date: Wed Mar 29 14:52:24 2017 New Revision: 299023 URL: http://llvm.org/viewvc/llvm-project?rev=299023=rev Log: Add NetBSD path for Debugging Information in Separate Files Summary: NetBSD stores debug information files in the `/usr/libdata/debug` path. This change fixes debugging

[Lldb-commits] [PATCH] D31450: Battery of NetBSD support improvements

labath added inline comments. Comment at: source/Plugins/Process/NetBSD/NativeProcessNetBSD.cpp:249 + // Initialize new thread + struct ptrace_lwpinfo info = {}; + Error error = PtraceWrapper(PT_LWPINFO, pid, , sizeof(info)); krytarowski wrote: >

[Lldb-commits] [lldb] r299020 - Move the definition of SBListener::GetSP() to SBListener.cpp.

Author: spyffe Date: Wed Mar 29 14:32:59 2017 New Revision: 299020 URL: http://llvm.org/viewvc/llvm-project?rev=299020=rev Log: Move the definition of SBListener::GetSP() to SBListener.cpp. This is the requirement for all functions in the public API, to eliminate weak symbol definitions.

Re: [Lldb-commits] [PATCH] D31371: Stop calling ValueObject::SetName from synthetic child providers

> On Mar 29, 2017, at 2:06 AM, Tamas Berghammer via Phabricator > wrote: > > tberghammer added a comment. > > SBValue::SetName is not part of the SB API (what is the right decision IMO as > an SBValue should be mostly immutable) so this issue doesn't effect it. I >

[Lldb-commits] [PATCH] D31073: Enable lldm-mi commands -stack-list-locals -stack-list-variables and -var-create to work only with variables in scope

ayuckhulk added a comment. Yes, please do. https://reviews.llvm.org/D31073 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D31073: Enable lldm-mi commands -stack-list-locals -stack-list-variables and -var-create to work only with variables in scope

ki.stfu accepted this revision. ki.stfu added a comment. This revision is now accepted and ready to land. Would you like me to commit it? https://reviews.llvm.org/D31073 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D31450: Battery of NetBSD support improvements

kettenis added a comment. The core file reading bits look ok to me. Comment at: source/Plugins/DynamicLoader/POSIX-DYLD/DYLDRendezvous.cpp:383 // On Linux the executable is indicated by an empty path in the entry. On // FreeBSD and on Android it is the full path to the

[Lldb-commits] [PATCH] D31450: Battery of NetBSD support improvements

krytarowski added a comment. I think I will start the threading segment with proper handling of core(5) files. It looks like the simplest start point. OpenBSD uses very similar format and can catch up quickly. Repository: rL LLVM https://reviews.llvm.org/D31450

[Lldb-commits] [PATCH] D31450: Battery of NetBSD support improvements

krytarowski added inline comments. Comment at: source/Plugins/Process/NetBSD/NativeProcessNetBSD.cpp:249 + // Initialize new thread + struct ptrace_lwpinfo info = {}; + Error error = PtraceWrapper(PT_LWPINFO, pid, , sizeof(info)); labath wrote: >

[Lldb-commits] [PATCH] D31461: Add NetBSD path for Debugging Information in Separate Files

krytarowski created this revision. krytarowski added a project: LLDB. Herald added a subscriber: aprantl. NetBSD stores debug information files in the `/usr/libdata/debug` path. This change fixes debugging distribution executables, e.g. `look`(1): $ lldb /usr/bin/look

[Lldb-commits] [PATCH] D31073: Enable lldm-mi commands -stack-list-locals -stack-list-variables and -var-create to work only with variables in scope

ayuckhulk updated this revision to Diff 93369. ayuckhulk added a comment. Thank you for the review! I've updated the patch with requested changes: - renamed `lexical-scope` to `lexical_scope`, - renamed `TestLexicalScope.py` to `TestMiLexicalScope.py` - removed utf8 encoding string

[Lldb-commits] [PATCH] D31371: Stop calling ValueObject::SetName from synthetic child providers

tberghammer added a comment. SBValue::SetName is not part of the SB API (what is the right decision IMO as an SBValue should be mostly immutable) so this issue doesn't effect it. I looked through the code in examples/synthetic/gnu_libstdcpp.py and it is always using one of the SBValue::Create*

[Lldb-commits] [PATCH] D31073: Enable lldm-mi commands -stack-list-locals -stack-list-variables and -var-create to work only with variables in scope

ki.stfu requested changes to this revision. ki.stfu added a comment. This revision now requires changes to proceed. Hi. LGTM. Just fix a few minor issues before committing. Thank you for your contribution to LLDB project! Comment at: