[Lldb-commits] [lldb] r301686 - Public headers need to be public.

Author: penryu Date: Fri Apr 28 16:03:18 2017 New Revision: 301686 URL: http://llvm.org/viewvc/llvm-project?rev=301686=rev Log: Public headers need to be public. Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj URL:

[Lldb-commits] [PATCH] D32149: Correct handling NetBSD core(5) files with threads

krytarowski updated this revision to Diff 97150. krytarowski added a comment. Remove another unrelated style improvement. Repository: rL LLVM https://reviews.llvm.org/D32149 Files: source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp source/Plugins/Process/elf-core/ProcessElfCore.cpp

[Lldb-commits] [PATCH] D32149: Correct handling NetBSD core(5) files with threads

krytarowski updated this revision to Diff 97149. krytarowski added a comment. Strip non-functional style improvements in unrelated code-parts. Apply changes to address comments from Joerg. Repository: rL LLVM https://reviews.llvm.org/D32149 Files:

[Lldb-commits] [PATCH] D25886: [Test Suite] Properly respect --framework option

fjricci added inline comments. Comment at: lldb/trunk/packages/Python/lldbsuite/test/lldbtest.py:1418 "include")), -'LD_EXTRAS': "-L%s -llldb" % lib_dir} +'LD_EXTRAS': "-L%s/../lib -llldb

[Lldb-commits] [lldb] r301664 - Add remaining SBTrace headers to LLDB framework

Author: penryu Date: Fri Apr 28 13:10:53 2017 New Revision: 301664 URL: http://llvm.org/viewvc/llvm-project?rev=301664=rev Log: Add remaining SBTrace headers to LLDB framework Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj URL:

[Lldb-commits] [PATCH] D32585: Implementation of remote packets for Trace data.

zturner added inline comments. Comment at: docs/lldb-gdb-remote.txt:214 +// +// BRIEF +// Packet for starting tracing of type lldb::TraceType. The following I just noticed that none of our documentation uses doxygen? Weird. Comment at:

[Lldb-commits] [PATCH] D32585: Implementation of remote packets for Trace data.

clayborg added inline comments. Comment at: docs/lldb-gdb-remote.txt:212 //-- +// QTrace:1:type:; +// labath wrote: > ravitheja wrote: > > clayborg wrote: > > > Should we make all these new

[Lldb-commits] [PATCH] D32306: Remove lock from ConstString::GetLength

labath added inline comments. Comment at: source/Utility/ConstString.cpp:49 + // pointer, we don't need the lock. const StringPoolEntryType = GetStringMapEntryFromKeyData(ccstr); return entry.getKey().size(); scott.smith wrote: > labath

[Lldb-commits] [lldb] r301642 - Remove lock from ConstString::GetLength

Author: labath Date: Fri Apr 28 07:08:28 2017 New Revision: 301642 URL: http://llvm.org/viewvc/llvm-project?rev=301642=rev Log: Remove lock from ConstString::GetLength Summary: ConstStrings are immutable, so there is no need to grab even a reader lock in order to read the length field.

[Lldb-commits] [PATCH] D32306: Remove lock from ConstString::GetLength

This revision was automatically updated to reflect the committed changes. Closed by commit rL301642: Remove lock from ConstString::GetLength (authored by labath). Changed prior to commit: https://reviews.llvm.org/D32306?vs=96841=97083#toc Repository: rL LLVM https://reviews.llvm.org/D32306

[Lldb-commits] [PATCH] D32585: Implementation of remote packets for Trace data.

labath added a reviewer: zturner. labath requested changes to this revision. labath added a comment. This revision now requires changes to proceed. I am adding Zachary, as he usually has good ideas about APIs. All in all, it's not a very controversal change, but I have a bunch of inline

[Lldb-commits] [PATCH] D32600: Resurrect pselect MainLoop implementation

This revision was automatically updated to reflect the committed changes. Closed by commit rL301636: Resurrect pselect MainLoop implementation (authored by labath). Changed prior to commit: https://reviews.llvm.org/D32600?vs=97074=97075#toc Repository: rL LLVM

[Lldb-commits] [lldb] r301636 - Resurrect pselect MainLoop implementation

Author: labath Date: Fri Apr 28 05:26:06 2017 New Revision: 301636 URL: http://llvm.org/viewvc/llvm-project?rev=301636=rev Log: Resurrect pselect MainLoop implementation Summary: It turns out that even though ppoll is available on all the android devices we support, it does not seem to be

[Lldb-commits] [PATCH] D32600: Resurrect pselect MainLoop implementation

labath added a comment. I am going to check this in to unbork the android bots. I'm happy to address any additional feedback in a followup. I'm also planning to come some unit tests for this class next week. https://reviews.llvm.org/D32600 ___

[Lldb-commits] [PATCH] D32626: Make the symbol demangling loop order independent

labath added a comment. If you're going to be making drastic changes here, could you please look at the possibility of making a more targeted test, rather than relying on the "run the whole debugger and set a breakpoint" type of tests to verify the finer details of the implementation. I was

[Lldb-commits] [PATCH] D32568: Protect Proces::GetMemoryRegionInfo and ::GetFileLoadAddress with a lock

labath added a comment. Cool, glad that's sorted. I've had some ideas about introducing limited amount of paralellism to the server side, but that's probably is not interesting to you if you're not doing remote debugging. Repository: rL LLVM https://reviews.llvm.org/D32568

[Lldb-commits] [PATCH] D32585: Implementation of remote packets for Trace data.

ravitheja added inline comments. Comment at: docs/lldb-gdb-remote.txt:212 //-- +// QTrace:1:type:; +// clayborg wrote: > Should we make all these new packets JSON based to start with? "jTrace"?

[Lldb-commits] [PATCH] D32600: Resurrect pselect MainLoop implementation

labath added inline comments. Comment at: source/Host/common/MainLoop.cpp:82 + int queue_id; + std::vector events; + struct kevent event_list[4]; eugene wrote: > here and below struct seems to be redundant One of them holds the input events, and the other the