Author: jingham
Date: Wed Jul 12 17:36:21 2017
New Revision: 307870
URL: http://llvm.org/viewvc/llvm-project?rev=307870=rev
Log:
The llvm.org bugzilla moved.
Modified:
lldb/trunk/www/sidebar.incl
Modified: lldb/trunk/www/sidebar.incl
URL:
jingham added a comment.
What Greg said...
https://reviews.llvm.org/D31172
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
jingham added a comment.
Sorry I wasn't clear. I meant that since the Target knows everything it needs
to know to vend the correct Architecture plugin, you should get it from the
Target, not the Process. In general, I think that the highest class in the
stack that can vend a plugin is the
clayborg added a comment.
I think is saying we should just store the Architecture plug-in in the target
instead of in the process. It will also need to be cleared when the target arch
is changed.
https://reviews.llvm.org/D31172
___
lldb-commits
labath added a comment.
In https://reviews.llvm.org/D31172#806804, @jingham wrote:
> This is a good addition. However, it seems to me that since you only need an
> ArchSpec to make one of these Architecture plugins, which plugin you get
> seems fully determined by the Target, not the Process.
brunoalr added a comment.
In https://reviews.llvm.org/D35065#803602, @brunoalr wrote:
> @labath @joerg @krytarowski thanks for the review. Can anyone commit this,
> please? I still don't have commit privileges.
thanks, @labath
Repository:
rL LLVM
https://reviews.llvm.org/D35065
clayborg added a comment.
Ah yes, I thought there was something missing...
Repository:
rL LLVM
https://reviews.llvm.org/D33213
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
jingham added a comment.
This is a good addition. However, it seems to me that since you only need an
ArchSpec to make one of these Architecture plugins, which plugin you get seems
fully determined by the Target, not the Process. I understand that the only
need for it at present is to do a
labath requested changes to this revision.
labath added a comment.
This revision now requires changes to proceed.
Have you tried that this actually works? (It doesn't work for me)
As far as I can tell, you will have to teach lldb-server to understand the
`--fd` argument before you can flip this
clayborg added a comment.
Looks fine to me, lets make sure Pavel is OK with this. On MacOS socketpair is
also much faster. Please run the following command while stopped at a
breakpoint with and without your change:
(lldb) process plugin packet speed-test
It will send and receive packets
labath created this revision.
Herald added subscribers: mgorny, srhines.
This adds support for running the lldb-server test suite (currently consisting
of only one test) against the debugserver. Currently, the choice which binary
to test is based on the host system. This will need to be replaced
clayborg added a comment.
Note that if you put "Differential Revision: " followed by the URL for this:
Differential Revision: https://reviews.llvm.org/D34945
in your source control commit message it will automatically close this for you
and add the SVN revision number into this as a message.
clayborg added a comment.
A few inline fixes, but this looks great. Very close
Comment at: include/lldb/Core/ArchSpec.h:26-30
namespace lldb_private {
class Platform;
-}
-namespace lldb_private {
class Stream;
-}
-namespace lldb_private {
class StringList;
}
labath created this revision.
It is not presently used, and it's quite dangerous to use -- it assumes the
integer is an osx kern_return_t, but very few of the integers we have lying
around are mach kernel error codes. The error can still be used to a
mach error using a slightly longer (but more
This revision was automatically updated to reflect the committed changes.
Closed by commit rL307782: [MainLoop] Fix possible use of an invalid iterator
(authored by petr.pavlu).
Changed prior to commit:
https://reviews.llvm.org/D35298?vs=106164=106187#toc
Repository:
rL LLVM
Author: petr.pavlu
Date: Wed Jul 12 05:38:31 2017
New Revision: 307782
URL: http://llvm.org/viewvc/llvm-project?rev=307782=rev
Log:
[MainLoop] Fix possible use of an invalid iterator
Store file descriptors from loop.m_read_fds (if FORCE_PSELECT is
defined) and signals from loop.m_signals that
Author: ravitheja
Date: Wed Jul 12 04:54:17 2017
New Revision: 307773
URL: http://llvm.org/viewvc/llvm-project?rev=307773=rev
Log:
Fixing Android builder
Modified:
lldb/trunk/source/Utility/StringExtractorGDBRemote.cpp
Modified: lldb/trunk/source/Utility/StringExtractorGDBRemote.cpp
URL:
Author: ravitheja
Date: Wed Jul 12 04:15:34 2017
New Revision: 307768
URL: http://llvm.org/viewvc/llvm-project?rev=307768=rev
Log:
Adding Support for Error Strings in Remote Packets
Summary:
This patch adds support for sending strings along with
error codes in the reply packets. The
labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
Looks great, thanks for catching this.
The code was doing it this way initially, but then this got lost with all the
frantic refactors.
https://reviews.llvm.org/D35298
labath updated this revision to Diff 106165.
labath added a comment.
Herald added subscribers: javed.absar, mgorny.
The architecture plugin idea
https://reviews.llvm.org/D31172
Files:
include/lldb/Core/ArchSpec.h
include/lldb/Core/Architecture.h
include/lldb/Core/PluginManager.h
petpav01 created this revision.
Store file descriptors from `loop.m_read_fds` (if `FORCE_PSELECT` is defined)
and signals from `loop.m_signals` that need to be processed in
`MainLoop::RunImpl::ProcessEvents()` into a separate vector and then iterate
over this container to invoke the callbacks.
labath commandeered this revision.
labath edited reviewers, added: zturner; removed: labath.
labath added a comment.
It looks like this has ground to a halt, but it seems the consensus was to try
the Architecture plugin idea. I'm going to hijack this revision to maintain
context, and upload a
22 matches
Mail list logo
