[Lldb-commits] [lldb] r327692 - Skip more lldb-mi tests which time out on Darwin

Author: vedantk Date: Thu Mar 15 21:11:03 2018 New Revision: 327692 URL: http://llvm.org/viewvc/llvm-project?rev=327692=rev Log: Skip more lldb-mi tests which time out on Darwin Bot failure:

[Lldb-commits] [PATCH] D44507: [cmake] Copy system debugserver from the right place when only CommandLineTools are installed

This revision was automatically updated to reflect the committed changes. Closed by commit rL327691: [cmake] Copy system debugserver from the right place when only CommandLineTools (authored by vedantk, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM

[Lldb-commits] [lldb] r327691 - [cmake] Copy system debugserver from the right place when only CommandLineTools

Author: vedantk Date: Thu Mar 15 20:31:16 2018 New Revision: 327691 URL: http://llvm.org/viewvc/llvm-project?rev=327691=rev Log: [cmake] Copy system debugserver from the right place when only CommandLineTools are installed Instead of building debugserver when building lldb, I'd rather pass

[Lldb-commits] [PATCH] D44507: [cmake] Copy system debugserver from the right place when only CommandLineTools are installed

xiaobai added a comment. @vsk Would you mind committing this for me when you get the chance? I don't have commit access. :) https://reviews.llvm.org/D44507 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D44472: Add and fix some tests for PPC64

alexandreyy added a comment. In https://reviews.llvm.org/D44472#1038656, @labath wrote: > I wonder if we shouldn't just fix the TestDisassembleBreakpoint to not > require adding every single architecture. That test was added because > lldb-server was not removing the traps from the memory read

[Lldb-commits] [PATCH] D44472: Add and fix some tests for PPC64

alexandreyy updated this revision to Diff 138610. alexandreyy added a comment. Modified TestDisassembleBreakpoint.py to consider multiple architectures. https://reviews.llvm.org/D44472 Files: packages/Python/lldbsuite/test/expression_command/char/TestExprsChar.py

Re: [Lldb-commits] [lldb] r327625 - Next batch of test-tree-cleaning changes

All right, I've configured greendragon's cmake/xcode builds to become unstable when there are test failures. I've also enabled email notifications for the 'default set of recipients'. From what I've gathered, Jenkins determines this set by looking at the changelist. Let me know if there

Re: [Lldb-commits] [lldb] r327625 - Next batch of test-tree-cleaning changes

I haven't received any greendragon bot failure notifications. I'll look into that. vedant > On Mar 15, 2018, at 8:32 AM, Davide Italiano wrote: > > On Thu, Mar 15, 2018 at 8:28 AM, Pavel Labath wrote: >> Yea, this is strange. The bot does not even

[Lldb-commits] [PATCH] D44507: [cmake] Copy system debugserver from the right place when only CommandLineTools are installed

vsk accepted this revision. vsk added a comment. This revision is now accepted and ready to land. Thank you, lgtm. https://reviews.llvm.org/D44507 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D44526: [dotest] Clean up test folder clean-up

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. Thanks! I think this makes sense. Comment at: packages/Python/lldbsuite/test/lldbtest.py:707 +"""Create the test-specific working directory, deleting any previous

[Lldb-commits] [PATCH] D44526: [dotest] Clean up test folder clean-up

labath created this revision. labath added a reviewer: aprantl. Herald added subscribers: eraman, mgorny, ki.stfu, emaste. This patch implements a unified way of cleaning the build folder of each test. This is done by completely removing the build folder before each test, in the respective

[Lldb-commits] [lldb] r327644 - Split skipIf decorator, the condition is supposed to be OR

Author: adrian Date: Thu Mar 15 10:07:05 2018 New Revision: 327644 URL: http://llvm.org/viewvc/llvm-project?rev=327644=rev Log: Split skipIf decorator, the condition is supposed to be OR Modified:

[Lldb-commits] [lldb] r327643 - [dotest] remove confirm_directory_exclusivity remnants

Author: labath Date: Thu Mar 15 09:52:37 2018 New Revision: 327643 URL: http://llvm.org/viewvc/llvm-project?rev=327643=rev Log: [dotest] remove confirm_directory_exclusivity remnants Modified: lldb/trunk/packages/Python/lldbsuite/test/lldbtest.py Modified:

Re: [Lldb-commits] [lldb] r327356 - [ExpressionParser] Fix crash when evaluating invalid expresssions.

On Wed, Mar 14, 2018 at 1:52 AM, Pavel Labath wrote: > I'm not familiar with all of the magic we do when we synthesize clang Decls, > but I feel I should point out that we can't get out of business of > sanity-checking the declarations we inject into clang. The reason for that

Re: [Lldb-commits] [lldb] r327625 - Next batch of test-tree-cleaning changes

On Thu, Mar 15, 2018 at 8:28 AM, Pavel Labath wrote: > Yea, this is strange. The bot does not even appear to be red. It's just > yellow. > This is historical. We ought to change this. We just delayed this because we wanted to be *really sure* things were green for a while.

Re: [Lldb-commits] [lldb] r327625 - Next batch of test-tree-cleaning changes

Yea, this is strange. The bot does not even appear to be red. It's just yellow. Anyway, r327633 ought to fix the breakage. As I said in the commit message, the cause is different treatment of relative paths to "process launch --stdin". Do you guys have any opinion on which behavior makes more

[Lldb-commits] [lldb] r327633 - Fix TestProcessLaunch breakage on MacOS

Author: labath Date: Thu Mar 15 08:21:54 2018 New Revision: 327633 URL: http://llvm.org/viewvc/llvm-project?rev=327633=rev Log: Fix TestProcessLaunch breakage on MacOS This test started failing after r327625. The cause seems difference in the treatment of relative --stdin paths between MacOS

Re: [Lldb-commits] [lldb] r327625 - Next batch of test-tree-cleaning changes

I don't seem to receive mails either (although I should). Vedant is babysitting the bots this week. Vedant, are you receiving blame mails or the mail notification is disabled altogether? On Thu, Mar 15, 2018 at 8:06 AM, Pavel Labath wrote: > Yes, it certainly looks that way.

Re: [Lldb-commits] [lldb] r327625 - Next batch of test-tree-cleaning changes

Yes, it certainly looks that way. Taking a look now. PS: I didn't get any email about this. On Thu, 15 Mar 2018 at 15:04, Davide Italiano wrote: > This is the most likely cause for the failures we're starting to see > on both our bots on greendragon. > Can you please

Re: [Lldb-commits] [lldb] r327625 - Next batch of test-tree-cleaning changes

This is the most likely cause for the failures we're starting to see on both our bots on greendragon. Can you please take a look? http://lab.llvm.org:8080/green/view/LLDB/job/lldb-cmake/5791/ Thanks! -- Davide On Thu, Mar 15, 2018 at 6:47 AM, Pavel Labath via lldb-commits

[Lldb-commits] [PATCH] D44159: Next batch of test-tree-cleaning changes

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL327625: Next batch of test-tree-cleaning changes (authored by labath, committed by ). Herald added a subscriber:

[Lldb-commits] [lldb] r327625 - Next batch of test-tree-cleaning changes

Author: labath Date: Thu Mar 15 06:47:09 2018 New Revision: 327625 URL: http://llvm.org/viewvc/llvm-project?rev=327625=rev Log: Next batch of test-tree-cleaning changes Summary: The changes here fall into several categories. - some tests were redirecting inferior stdout/err to a file. For these

[Lldb-commits] [PATCH] D44472: Add and fix some tests for PPC64

labath added a comment. I wonder if we shouldn't just fix the TestDisassembleBreakpoint to not require adding every single architecture. That test was added because lldb-server was not removing the traps from the memory read packets. This is something that is completely independent of us later

[Lldb-commits] [PATCH] D44306: Move Args::StringToAddress to Target::EvaluateAddressExpression

labath updated this revision to Diff 138540. labath added a comment. s/toAddress/ToAddress/ https://reviews.llvm.org/D44306 Files: include/lldb/Interpreter/Args.h include/lldb/Interpreter/OptionArgParser.h include/lldb/Interpreter/Options.h source/API/SBDebugger.cpp

[Lldb-commits] [lldb] r327611 - @skipUnlessDarwin TestTargetSourceMap

Author: labath Date: Thu Mar 15 02:16:15 2018 New Revision: 327611 URL: http://llvm.org/viewvc/llvm-project?rev=327611=rev Log: @skipUnlessDarwin TestTargetSourceMap Our MachO parser works only on darwin. Modified:

[Lldb-commits] [PATCH] D44502: Fix a bug in "target.source-map" where we would resolve unmapped paths incorrectly

labath added a comment. I think a .ll file would be better abstraction level for this test. You can still hardcode all the paths needed for the test while avoiding spelling out the irrelevant details like debug info abbreviations. But I guess this will work as well... Repository: rL LLVM