Author: davide
Date: Thu Apr 19 17:44:33 2018
New Revision: 330385
URL: http://llvm.org/viewvc/llvm-project?rev=330385=rev
Log:
[DWARFASTParserClang] Remove dead code. NFCI.
Modified:
lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp
Modified:
The mix of backward and forward slashes doesn't impact my current project
but it would be nice to have a consistent path syntax (both within a single
path and also cross platforms).
> Leonard, is it reasonable to assume that all paths in the minidumps will be
> absolute (and thus resolving is
lemo added subscribers: bgianfo, penryu.
lemo added a comment.
> It looks like nobody except me is worried about the
> module-without-an-object-file situation, so I guess we can try this out and
> see how it goes.
Sorry Pavel, I meant to respond to this: most of the code seems to
explicitly
>
> It looks like nobody except me is worried about the
> module-without-an-object-file situation, so I guess we can try this out and
> see how it goes.
>
Sorry Pavel, I meant to respond to this: most of the code seems to
explicitly handle this case (module-without-object-file), I just had to fix
Yes, I noticed that as well, but I did not want to change it, as it wasn't
related to the problem I was trying to fix. I agree that not resolving the
path sounds like a better idea.
Leonard, is it reasonable to assume that all paths in the minidumps will be
absolute (and thus resolving is
Any reason we are trying to resolve the path with the 2nd true argument to
FileSpec? If you still want to resolve the path, I would suggest checking if
GetArchitecture() is compatible with any host architectures before passing true.
> On Apr 19, 2018, at 2:38 AM, Pavel Labath via lldb-commits
labath added a comment.
It looks like nobody except me is worried about the
module-without-an-object-file situation, so I guess we can try this out and see
how it goes.
The test you've added here has been failing on windows though. I've tried to
fix this in r330314, but it meant modifying the
Author: labath
Date: Thu Apr 19 02:38:42 2018
New Revision: 330314
URL: http://llvm.org/viewvc/llvm-project?rev=330314=rev
Log:
Attempt to fix TestMiniDump on windows
It was failing because the modules names were coming out as
C:\Windows\System32/MSVCP120D.dll (last separator is a forward slash)
