[Lldb-commits] [PATCH] D50274: Misc module/dwarf logging improvements

lemo added inline comments. Comment at: source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp:3413 +section->GetName().GetCString(), +llvm::toString(Decompressor.takeError()).c_str()); +return 0; labath wrote: > lemo wrote: > > labath wrote: > > >

[Lldb-commits] [PATCH] D50274: Misc module/dwarf logging improvements

lemo updated this revision to Diff 159432. lemo marked an inline comment as done. lemo added a comment. Updated the LIT file too https://reviews.llvm.org/D50274 Files: lit/Modules/compressed-sections.yaml source/Core/Module.cpp source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp

[Lldb-commits] [PATCH] D48465: Added initial code completion support for the `expr` command

teemperor updated this revision to Diff 159426. teemperor added a comment. - Resolved merge conflicts. https://reviews.llvm.org/D48465 Files: include/lldb/Expression/ExpressionParser.h include/lldb/Expression/UserExpression.h

[Lldb-commits] [PATCH] D50365: Add a new tool named "lldb-vscode" that implements the Visual Studio Code Debug Adaptor Protocol

xiaobai added a comment. Can't speak much to the contents yet (Haven't done a thorough pass yet) but it looks like there's a lot of dead code you might want to remove. I commented on a few of them but there is probably more. Comment at:

[Lldb-commits] [lldb] r339076 - [lit, python] Always add quotes around the python path in lit

Author: stella.stamenova Date: Mon Aug 6 15:37:53 2018 New Revision: 339076 URL: http://llvm.org/viewvc/llvm-project?rev=339076=rev Log: [lit, python] Always add quotes around the python path in lit Summary: The issue with the python path is that the path to python on Windows can contain

[Lldb-commits] [lldb] r339071 - Revert "Add a relocation for R_AARCH64_ABS32 in ObjectFileELF"

Author: sas Date: Mon Aug 6 15:21:28 2018 New Revision: 339071 URL: http://llvm.org/viewvc/llvm-project?rev=339071=rev Log: Revert "Add a relocation for R_AARCH64_ABS32 in ObjectFileELF" This reverts commit f055ce7eb893cd0d17ebcfd4125018f46f983aff. Modified:

Re: [Lldb-commits] [lldb] r339068 - Add a relocation for R_AARCH64_ABS32 in ObjectFileELF

You should be able to add a unittest for this, I think? -- Davide On Mon, Aug 6, 2018 at 3:04 PM Stephane Sezer via lldb-commits wrote: > > Author: sas > Date: Mon Aug 6 15:04:08 2018 > New Revision: 339068 > > URL: http://llvm.org/viewvc/llvm-project?rev=339068=rev > Log: > Add a relocation

[Lldb-commits] [lldb] r339068 - Add a relocation for R_AARCH64_ABS32 in ObjectFileELF

Author: sas Date: Mon Aug 6 15:04:08 2018 New Revision: 339068 URL: http://llvm.org/viewvc/llvm-project?rev=339068=rev Log: Add a relocation for R_AARCH64_ABS32 in ObjectFileELF Summary: .rela.debug_info relocations are being done via ObjectFileELF::ApplyRelocations for aarch64. Currently, the

[Lldb-commits] [PATCH] D50362: Add instructions for building LLDB on Mac OS X with CMake

xiaobai updated this revision to Diff 159400. xiaobai added a comment. Reducing redundancy and changing some wording around. https://reviews.llvm.org/D50362 Files: www/build.html Index: www/build.html === --- www/build.html

[Lldb-commits] [PATCH] D50274: Misc module/dwarf logging improvements

labath added inline comments. Comment at: source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp:3413 +section->GetName().GetCString(), +llvm::toString(Decompressor.takeError()).c_str()); +return 0; lemo wrote: > labath wrote: > > This needs to be

[Lldb-commits] [PATCH] D50274: Misc module/dwarf logging improvements

lemo added inline comments. Comment at: source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp:3413 +section->GetName().GetCString(), +llvm::toString(Decompressor.takeError()).c_str()); +return 0; labath wrote: > This needs to be `std::move(Error)`.

[Lldb-commits] [lldb] r339051 - [IRMemoryMap] Avoid redundant zero-init in the Allocation constructor (NFC)

Author: vedantk Date: Mon Aug 6 13:13:52 2018 New Revision: 339051 URL: http://llvm.org/viewvc/llvm-project?rev=339051=rev Log: [IRMemoryMap] Avoid redundant zero-init in the Allocation constructor (NFC) In the lldb-bench/arithmetic benchmark, 1.7% of the total running time is spent

[Lldb-commits] [PATCH] D50274: Misc module/dwarf logging improvements

labath added inline comments. Comment at: source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp:3413 +section->GetName().GetCString()); +return 0; } lemo wrote: > labath wrote: > > `lit/Modules/compressed-sections.yaml` test will need to be updated to

[Lldb-commits] [PATCH] D50274: Misc module/dwarf logging improvements

lemo marked 2 inline comments as done. lemo added inline comments. Comment at: source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp:3413 +section->GetName().GetCString()); +return 0; } labath wrote: > `lit/Modules/compressed-sections.yaml` test will

[Lldb-commits] [PATCH] D50274: Misc module/dwarf logging improvements

lemo updated this revision to Diff 159368. lemo added a comment. Incorporating feedback, thanks. https://reviews.llvm.org/D50274 Files: source/Core/Module.cpp source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp source/Plugins/Process/minidump/ProcessMinidump.cpp source/Target/Process.cpp

[Lldb-commits] [PATCH] D49963: Preliminary patch to support prompt interpolation

nealsid added a comment. In https://reviews.llvm.org/D49963#1183036, @clayborg wrote: > This will be very cool. Biggest issues to watch out for is to make sure it > doesn't return incorrect values when running for things like the thread > count. If you switch to use the >

[Lldb-commits] [PATCH] D49740: Move RegisterValue, Scalar, State from Core to Utility

jingham added a comment. In https://reviews.llvm.org/D49740#1188587, @labath wrote: > In https://reviews.llvm.org/D49740#1188055, @jingham wrote: > > > First off, I'm fine with Zachary's suggestion that we let the dust settle a > > bit before we try to organize things better. We'll probably do

[Lldb-commits] [PATCH] D50271: [IRMemoryMap] Shrink Allocation make it move-only (NFC)

vsk updated this revision to Diff 159339. vsk retitled this revision from "[IRMemoryMap] Shrink Allocation by sizeof(addr_t) (NFC)" to "[IRMemoryMap] Shrink Allocation make it move-only (NFC)". vsk edited the summary of this revision. vsk added a comment. - Make Allocation move-only. This

[Lldb-commits] [PATCH] D50336: Add support for ARM and ARM64 breakpad generated minidump files (version 2).

clayborg added a comment. More offsetof issues: $ svn commit Sendingsource/Plugins/Process/minidump/RegisterContextMinidump_ARM.cpp Transmitting file data .done Committing transaction... Committed revision 339034. Repository: rL LLVM https://reviews.llvm.org/D50336

[Lldb-commits] [lldb] r339034 - Fix more offsetof issues.

Author: gclayton Date: Mon Aug 6 10:26:53 2018 New Revision: 339034 URL: http://llvm.org/viewvc/llvm-project?rev=339034=rev Log: Fix more offsetof issues. Modified: lldb/trunk/source/Plugins/Process/minidump/RegisterContextMinidump_ARM.cpp Modified:

[Lldb-commits] [PATCH] D50304: [lldb] CommandObjectThreadUntil should set breakpoint at either on exact or the nearest subsequent line number but not on all the subsequent line numbers

jingham added a comment. This implementation forces an extra lookup when the line number slides. For instance, if there were only one line match, but it was not exact, you're going to look up the exact address, fail, then look it up with exact = false. Wouldn't it be more efficient to look

[Lldb-commits] [PATCH] D50336: Add support for ARM and ARM64 breakpad generated minidump files (version 2).

clayborg added a comment. Passing patches between linux and mac the offsetof fixes got lost. When binary files are involved, patches are trickier to pass between to machines. Repository: rL LLVM https://reviews.llvm.org/D50336 ___ lldb-commits

[Lldb-commits] [PATCH] D50336: Add support for ARM and ARM64 breakpad generated minidump files (version 2).

clayborg added a comment. Fixed offsetof issues with: $ svn commit Sendingsource/Plugins/Process/minidump/RegisterContextMinidump_ARM.cpp Sendingsource/Plugins/Process/minidump/RegisterContextMinidump_ARM64.cpp Transmitting file data ..done Committing transaction... Committed

[Lldb-commits] [lldb] r339033 - Fix offsetof usage that got lost when passing patches between linux and mac.

Author: gclayton Date: Mon Aug 6 10:07:50 2018 New Revision: 339033 URL: http://llvm.org/viewvc/llvm-project?rev=339033=rev Log: Fix offsetof usage that got lost when passing patches between linux and mac. Modified: lldb/trunk/source/Plugins/Process/minidump/RegisterContextMinidump_ARM.cpp

[Lldb-commits] [PATCH] D50336: Add support for ARM and ARM64 breakpad generated minidump files (version 2).

This revision was automatically updated to reflect the committed changes. Closed by commit rL339032: Add support for ARM and ARM64 breakpad generated minidump files (version 2). (authored by gclayton, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[Lldb-commits] [PATCH] D50336: Add support for ARM and ARM64 breakpad generated minidump files (version 2).

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB339032: Add support for ARM and ARM64 breakpad generated minidump files (version 2). (authored by gclayton, committed by ). Changed prior to commit:

[Lldb-commits] [lldb] r339032 - Add support for ARM and ARM64 breakpad generated minidump files (version 2).

Author: gclayton Date: Mon Aug 6 09:56:10 2018 New Revision: 339032 URL: http://llvm.org/viewvc/llvm-project?rev=339032=rev Log: Add support for ARM and ARM64 breakpad generated minidump files (version 2). In this patch I add support for ARM and ARM64 break pad files. There are two flavors of

[Lldb-commits] [PATCH] D50336: Add support for ARM and ARM64 breakpad generated minidump files (version 2).

clayborg updated this revision to Diff 159324. clayborg added a comment. Herald added a subscriber: mgorny. Added CMakeList.txt changes, tested on linux, and removed unused "log" variable. https://reviews.llvm.org/D50336 Files: include/lldb/Target/Target.h lldb.xcodeproj/project.pbxproj

[Lldb-commits] [PATCH] D50336: Add support for ARM and ARM64 breakpad generated minidump files (version 2).

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. This should be fine once the cmake thing is addressed. https://reviews.llvm.org/D50336 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

Re: [Lldb-commits] [PATCH] D50336: Add support for ARM and ARM64 breakpad generated minidump files (version 2).

I was in the process of testing on linux. I will fix this. > On Aug 6, 2018, at 8:19 AM, Zachary Turner wrote: > > Did you see my comments on the first round about how the CMake build didn’t > work? Because I don’t see any changes to CMakeLists.txt here, which means it > still won’t work. >

[Lldb-commits] [PATCH] D50336: Add support for ARM and ARM64 breakpad generated minidump files (version 2).

zturner added a subscriber: clayborg. zturner added a comment. Did you see my comments on the first round about how the CMake build didn’t work? Because I don’t see any changes to CMakeLists.txt here, which means it still won’t work. The easiest way to make sure you get all the fixes that may

Re: [Lldb-commits] [PATCH] D50336: Add support for ARM and ARM64 breakpad generated minidump files (version 2).

Did you see my comments on the first round about how the CMake build didn’t work? Because I don’t see any changes to CMakeLists.txt here, which means it still won’t work. The easiest way to make sure you get all the fixes that may have gone in after your initial commit is to revert the revert and

[Lldb-commits] [PATCH] D50336: Add support for ARM and ARM64 breakpad generated minidump files (version 2).

clayborg created this revision. clayborg added reviewers: labath, zturner, markmentovai, javed.absar. Herald added subscribers: chrib, kristof.beyls. In this patch I add support for ARM and ARM64 break pad files. There are two flavors of ARM: Apple where FP is

Re: [Lldb-commits] [PATCH] D49980: [PDB] Parse UDT symbols and pointers to members (combined patch)

I am OOO this week and only have access to mobile, so hopefully someone else can review it On Mon, Aug 6, 2018 at 11:05 AM Aleksandr Urakov via Phabricator < revi...@reviews.llvm.org> wrote: > aleksandr.urakov added a comment. > > Ping! > > Can you review this, please? > > >

[Lldb-commits] [PATCH] D49980: [PDB] Parse UDT symbols and pointers to members (combined patch)

zturner added a subscriber: aleksandr.urakov. zturner added a comment. I am OOO this week and only have access to mobile, so hopefully someone else can review it https://reviews.llvm.org/D49980 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D49980: [PDB] Parse UDT symbols and pointers to members (combined patch)

aleksandr.urakov added a comment. Ping! Can you review this, please? https://reviews.llvm.org/D49980 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D50334: Add ConstString test FromMidOfBufferStringRef

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. In general, I would assume that a function taking a StringRef can take *any* StringRef object (including the non-terminated ones), unless the limitations are very clearly documented. That

[Lldb-commits] [PATCH] D50334: Add ConstString test FromMidOfBufferStringRef

sgraenitz created this revision. sgraenitz added a reviewer: labath. It was not immediately clear to me whether or not non-null-terminated StringRef's are supported in ConstString and/or the counterpart mechanism. From this test it seems to be fine. Maybe useful to keep?

[Lldb-commits] [PATCH] D50327: Add ConstString::IsNull() to tell between null vs. empty strings and fix usage in Mangled::GetDemangledName()

This revision was automatically updated to reflect the committed changes. Closed by commit rL339014: Add ConstString::IsNull() to tell between null vs. empty strings and fix usage… (authored by stefan.graenitz, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[Lldb-commits] [PATCH] D50327: Add ConstString::IsNull() to tell between null vs. empty strings and fix usage in Mangled::GetDemangledName()

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. LGTM. Thanks for splitting this out. https://reviews.llvm.org/D50327 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D50071: Use rich mangling information in Symtab::InitNameIndexes()

sgraenitz added a comment. Ok I will fix the details, rebase and update the review. Btw: I also spilt off the `ConstString::IsNull()` addition with unit test and fix in `Mangled` to https://reviews.llvm.org/D50327 Comment at: source/Core/RichManglingInfo.cpp:126 + case

[Lldb-commits] [PATCH] D50327: Add ConstString::IsNull() to tell between null vs. empty strings and fix usage in Mangled::GetDemangledName()

sgraenitz created this revision. sgraenitz added reviewers: labath, jingham. Herald added a subscriber: erik.pilkington. `IsEmpty()` and `operator bool() == false` have equal semantics. Usage in Mangled::GetDemangledName() was incorrect. What it actually wants is a check for null-string. Split

[Lldb-commits] [PATCH] D50071: Use rich mangling information in Symtab::InitNameIndexes()

labath added a comment. I think we're getting there, but all these changes mean I have another round of comments. None of them should be major though. I'm also wondering whether it wouldn't be good to add a couple (one for each mangling scheme?) unit tests for the new class, as a way to show

[Lldb-commits] [PATCH] D50161: Add raw_ostream wrapper to the Stream class

labath added a comment. In https://reviews.llvm.org/D50161#1187972, @teemperor wrote: > StreamTee is copying it, which is expected to be copyable when we copy > CommandObjectResult around. And then I just added the copy-constructor as > CommandObjectResult refactoring sound time-expensive.