Author: vedantk
Date: Tue Aug 7 16:48:40 2018
New Revision: 339206
URL: http://llvm.org/viewvc/llvm-project?rev=339206=rev
Log:
Delete a dead Function constructor (NFC)
Modified:
lldb/trunk/include/lldb/Symbol/Function.h
lldb/trunk/source/Symbol/Function.cpp
Modified:
Author: vedantk
Date: Tue Aug 7 16:48:25 2018
New Revision: 339205
URL: http://llvm.org/viewvc/llvm-project?rev=339205=rev
Log:
[StackFrame] Add more clarifying comments to StackFrameList (NFC)
Modified:
lldb/trunk/source/Target/StackFrameList.cpp
Modified:
Author: teemperor
Date: Tue Aug 7 16:47:05 2018
New Revision: 339204
URL: http://llvm.org/viewvc/llvm-project?rev=339204=rev
Log:
Removed doxygen comment that doesn't fit to function signature
Modified:
lldb/trunk/source/Plugins/ExpressionParser/Clang/ClangExpressionDeclMap.h
Modified:
Author: teemperor
Date: Tue Aug 7 16:24:24 2018
New Revision: 339202
URL: http://llvm.org/viewvc/llvm-project?rev=339202=rev
Log:
Removed duplicated commented-out code [NFC]
Modified:
lldb/trunk/source/Symbol/ClangASTContext.cpp
Modified: lldb/trunk/source/Symbol/ClangASTContext.cpp
URL:
polyakov.alex abandoned this revision.
polyakov.alex added a comment.
Abandoned since suggested functionality is already done in
https://reviews.llvm.org/D49739.
https://reviews.llvm.org/D47302
___
lldb-commits mailing list
Author: apolyakov
Date: Tue Aug 7 14:41:59 2018
New Revision: 339189
URL: http://llvm.org/viewvc/llvm-project?rev=339189=rev
Log:
Add documentation for SBTarget::AppendImageSearchPath
Modified:
lldb/trunk/include/lldb/API/SBTarget.h
lldb/trunk/scripts/interface/SBTarget.i
Modified:
Author: jingham
Date: Tue Aug 7 14:09:55 2018
New Revision: 339182
URL: http://llvm.org/viewvc/llvm-project?rev=339182=rev
Log:
If a function starts with line number 0, don't try to check if a breakpoint
crossed function boundaries.
clang doesn't use line number 0 (to mean artifically
Author: jingham
Date: Tue Aug 7 14:05:34 2018
New Revision: 339181
URL: http://llvm.org/viewvc/llvm-project?rev=339181=rev
Log:
Fix the Xcode project for the Core -> Utility moves.
Scalar.{h,cpp}, RegisterValue.{h,cpp}, State.{h,cpp} were moved.
Modified:
jingham added a comment.
Thanks! No need for review...
Repository:
rL LLVM
https://reviews.llvm.org/D49739
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: stella.stamenova
Date: Tue Aug 7 13:58:02 2018
New Revision: 339180
URL: http://llvm.org/viewvc/llvm-project?rev=339180=rev
Log:
[lit, python] Change the order of the quotes in the lit cfg file
Double quotes are always correct in paths on windows while single quotes only
work sometimes.
Author: apolyakov
Date: Tue Aug 7 13:45:46 2018
New Revision: 339178
URL: http://llvm.org/viewvc/llvm-project?rev=339178=rev
Log:
[lldb-mi] Re-implement target-select command
Now target-select uses SB API instead of HandleCommand.
This patch has been reviewed along with the r339175.
apolyakov added a comment.
Sure, will do it.
Repository:
rL LLVM
https://reviews.llvm.org/D49739
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
jingham added a comment.
Could you add a short doc to this API - it's particularly useful to do this to
the .i version. I know there are lots of API's that don't have docs, but that
is not a happy situation. I'd like it if we all at least didn't make the
problem worse by documenting all the
Author: apolyakov
Date: Tue Aug 7 13:23:57 2018
New Revision: 339175
URL: http://llvm.org/viewvc/llvm-project?rev=339175=rev
Log:
Add new API to SBTarget class
Summary:
The new API appends an image search path to the
target's path mapping list.
Reviewers: aprantl, clayborg, labath
Reviewed
This revision was automatically updated to reflect the committed changes.
Closed by commit rL339175: Add new API to SBTarget class (authored by
apolyakov, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D49739?vs=159582=159587#toc
apolyakov updated this revision to Diff 159582.
apolyakov retitled this revision from "[WIP] Re-implement MI target-select
command." to "Add new API to SBTarget class".
apolyakov edited the summary of this revision.
apolyakov added a comment.
Splitted the patch into two parts: this part with the
labath added inline comments.
Comment at: source/Core/RichManglingContext.cpp:133
+ case PluginCxxLanguage:
+m_cxx_method_str = ConstString(
+
get(m_cxx_method_parser)->GetBasename());
I thought we were going to get rid of this ConstString? The C++
sgraenitz added a comment.
> I'm also wondering whether it wouldn't be good to add a couple unit tests for
> the new class, as a way to show the way the API is supposed to be used
This is still missing, but working on it.
https://reviews.llvm.org/D50071
sgraenitz updated this revision to Diff 159556.
sgraenitz marked 5 inline comments as done.
sgraenitz added a comment.
Many small things
https://reviews.llvm.org/D50071
Files:
include/lldb/Core/Mangled.h
include/lldb/Core/RichManglingContext.h
include/lldb/Symbol/Symtab.h
This revision was automatically updated to reflect the committed changes.
Closed by commit rL339161: Misc module/dwarf logging improvements (authored by
lemo, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D50274?vs=159432=159551#toc
Author: lemo
Date: Tue Aug 7 11:00:30 2018
New Revision: 339161
URL: http://llvm.org/viewvc/llvm-project?rev=339161=rev
Log:
Misc module/dwarf logging improvements
This change improves the logging for the lldb.module category to note a few
interesting cases:
1. Local object file found, but
Author: apolyakov
Date: Tue Aug 7 10:55:26 2018
New Revision: 339160
URL: http://llvm.org/viewvc/llvm-project?rev=339160=rev
Log:
[lldb-mi] Re-implement MI HandleProcessEventStateSuspended.
Summary: Now this function uses SB API instead of HandleCommand.
Reviewers: aprantl, clayborg, labath
This revision was automatically updated to reflect the committed changes.
Closed by commit rL339160: [lldb-mi] Re-implement MI
HandleProcessEventStateSuspended. (authored by apolyakov, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
This revision was automatically updated to reflect the committed changes.
Closed by commit rLLDB339155: Add instructions for building LLDB on Mac OS X
with CMake (authored by xiaobai, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D50362?vs=159400=159540#toc
Repository:
Author: xiaobai
Date: Tue Aug 7 10:34:13 2018
New Revision: 339155
URL: http://llvm.org/viewvc/llvm-project?rev=339155=rev
Log:
Add instructions for building LLDB on Mac OS X with CMake
Summary:
There were previously no instructions for building LLDB on Mac OS X
with CMake. It's sufficiently
xiaobai added a comment.
Hurray for more layering improvements!
It looks like Raphael recently committed a modulemap for compiling the LLDB
headers into C++ modules (`include/lldb/module.modulemap`) that has a reference
to Predicate.h in in Host. You should probably modify that as well.
clayborg added a comment.
In https://reviews.llvm.org/D50365#1191059, @lemo wrote:
> Really cool! Are you planning to add some documentation for it? (set up
> instructions, etc...)
Yes. I will add a README.txt for this patch and also a python script that will
create an VSCode extension.
jingham accepted this revision.
jingham added a comment.
This revision is now accepted and ready to land.
That looks good. Thanks for cleaning this up!
https://reviews.llvm.org/D50304
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
lemo added subscribers: clayborg, jingham, jasonmolenda, labath, lemo.
lemo added a comment.
Really cool! Are you planning to add some documentation for it? (set up
instructions, etc...)
https://reviews.llvm.org/D50365
___
lldb-commits mailing list
Really cool! Are you planning to add some documentation for it? (set up
instructions, etc...)
On Tue, Aug 7, 2018 at 9:24 AM, Greg Clayton via Phabricator via
lldb-commits wrote:
> clayborg updated this revision to Diff 159526.
> clayborg added a comment.
>
> Removed dead code from python
Author: tkrasnukha
Date: Tue Aug 7 09:46:11 2018
New Revision: 339153
URL: http://llvm.org/viewvc/llvm-project?rev=339153=rev
Log:
Check result after setting PC value.
Modified:
lldb/trunk/source/Commands/CommandObjectTarget.cpp
Modified: lldb/trunk/source/Commands/CommandObjectTarget.cpp
ramana-nvr updated this revision to Diff 159517.
ramana-nvr added a comment.
Yes, updated the patch accordingly.
https://reviews.llvm.org/D50304
Files:
source/Commands/CommandObjectThread.cpp
Index: source/Commands/CommandObjectThread.cpp
Author: labath
Date: Tue Aug 7 06:10:16 2018
New Revision: 339136
URL: http://llvm.org/viewvc/llvm-project?rev=339136=rev
Log:
Move ScalarTest to follow the class being tested
This should have been a part of r339127, but I missed it somehow.
Added:
labath created this revision.
labath added reviewers: jingham, zturner, teemperor.
Herald added a subscriber: mgorny.
This class was initially in Host because its implementation used to be
very OS-specific. However, with C++11, it has become a very simple
std::condition_variable wrapper, with no
labath created this revision.
labath added reviewers: jingham, zturner, teemperor.
Herald added a subscriber: fedor.sergeev.
One of the conclusions of the discussion on https://reviews.llvm.org/D49740 was
that SafeMachO is better
off in the Host module (as that's the only place which should
Author: labath
Date: Tue Aug 7 05:16:49 2018
New Revision: 339130
URL: http://llvm.org/viewvc/llvm-project?rev=339130=rev
Log:
Fix a couple of extended-offsetof warnings that had slipped through
Modified:
lldb/trunk/source/Plugins/Process/minidump/RegisterContextMinidump_ARM64.cpp
labath added a comment.
Thanks. I'll commit this and look at moving SafeMachO next.
> But I guess I'm looking for an organization based on "groups by
> functionality" rather than "who uses what". So even though other actors
> might use Scalar, it's reason for being is to present values. For
labath accepted this revision.
labath added inline comments.
This revision is now accepted and ready to land.
Comment at: source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp:3413
+section->GetName().GetCString(),
+llvm::toString(Decompressor.takeError()).c_str());
+
labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
Makes sense to me.
https://reviews.llvm.org/D50362
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
Merged to 7.0 in r339107.
On Sat, Aug 4, 2018 at 4:15 AM, Leonard Mosescu via lldb-commits
wrote:
> Author: lemo
> Date: Fri Aug 3 19:15:26 2018
> New Revision: 338949
>
> URL: http://llvm.org/viewvc/llvm-project?rev=338949=rev
> Log:
> Fix a bug in VMRange
>
> I noticed a suspicious failure:
>
40 matches
Mail list logo
