jingham requested changes to this revision.
jingham added a comment.
This revision now requires changes to proceed.
This patch changes the SB API. We don't break binary compatibility with the SB
API's, and especially not for something like
GetInstructions/GetInstructionsWithFlavor, which are
vsk planned changes to this revision.
vsk added a comment.
While testing this out, I found an issue with CallEdge::GetReturnPCAddress.
Getting the load address there adds an unnecessary slide to the PC. I'll try to
have that worked out next week.
https://reviews.llvm.org/D50478
apolyakov added a comment.
Do you mean `ConnectToRemote` method from
`lldb/tools/lldb-server/lldb-gdbserver.cpp`?
https://reviews.llvm.org/D52139
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
Great. Do you think that having an abstracted stream I/O tunneled through
DAP would lose anything compared to the direct file handle? I can see a few
problems using a native platform file handle:
1. It's specific to the platform (with subtle differences between platforms)
2. It assumes a local
tatyana-krasnukha created this revision.
tatyana-krasnukha added reviewers: spyffe, clayborg, zturner.
tatyana-krasnukha added a project: LLDB.
Herald added a subscriber: lldb-commits.
Slightly refactored typemaps to combine overloading with default arguments.
Repository:
rLLDB LLDB
sgraenitz created this revision.
sgraenitz added reviewers: clayborg, aprantl, jingham, jasonmolenda.
Herald added subscribers: dexonsmith, JDevlieghere, mehdi_amini.
So far SymbolFileDWARFDebugMap did only parse one compile unit per OSO entry.
Thus, LLDB failed to resolve breakpoint locations
vsk updated this revision to Diff 166534.
vsk added a comment.
As discussed offline, print out a note when stepping out of a frame with
artificial ancestors explaining that they were skipped while stepping out. See
the added test: functionalities/tail_call_frames/thread_step_out_message.
This revision was automatically updated to reflect the committed changes.
Closed by commit rLLDB342762: Move architecture-specific address adjustment to
architecture plugins (authored by tkrasnukha, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D48623?vs=166520=166530#toc
Author: tkrasnukha
Date: Fri Sep 21 11:56:44 2018
New Revision: 342762
URL: http://llvm.org/viewvc/llvm-project?rev=342762=rev
Log:
Move architecture-specific address adjustment to architecture plugins
Differential Revision: https://reviews.llvm.org/D48623
Added:
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
much better! Thanks for making the changes
Repository:
rLLDB LLDB
https://reviews.llvm.org/D48623
___
lldb-commits mailing list
This revision was automatically updated to reflect the committed changes.
Closed by commit rL342757: build: add libedit to include paths (authored by
tkrasnukha, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
Author: tkrasnukha
Date: Fri Sep 21 11:34:41 2018
New Revision: 342757
URL: http://llvm.org/viewvc/llvm-project?rev=342757=rev
Log:
build: add libedit to include paths
Differential Revision: https://reviews.llvm.org/D51999
Modified:
lldb/trunk/source/Core/CMakeLists.txt
compnerd accepted this revision.
compnerd added a comment.
This revision is now accepted and ready to land.
LGTM, thanks!
Repository:
rLLDB LLDB
https://reviews.llvm.org/D51999
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
tatyana-krasnukha updated this revision to Diff 166520.
Repository:
rLLDB LLDB
https://reviews.llvm.org/D48623
Files:
include/lldb/Core/Architecture.h
source/Plugins/Architecture/Arm/ArchitectureArm.cpp
source/Plugins/Architecture/Arm/ArchitectureArm.h
tatyana-krasnukha updated this revision to Diff 166507.
tatyana-krasnukha added a comment.
LLDB's static libraries link each other as INTERFACE, that's why CMake doesn't
propagate lldbHost's include directories to lldbCore and lldbInterpreter.
For lldbHost itself, I had to use PUBLIC, because
> On Sep 21, 2018, at 10:31 AM, Leonard Mosescu wrote:
>
> The solution I would love to see is to have the initialize packet return
> something via the DAP that says "I have a command line interpreter, please
> send a packet with a file handle (slave path to slave side of pseudo terminal
>
>
> The solution I would love to see is to have the initialize packet return
> something via the DAP that says "I have a command line interpreter, please
> send a packet with a file handle (slave path to slave side of pseudo
> terminal maybe)". VS Code and Nuclide both emulated tty already, so we
clayborg added a comment.
So I would suggest not removing any functions from lldb_private::Target, just
change the old ones to call through the arch plug-ins if there is one. Then
many changes in this diff just go away and we still get the clean
implementation where things are delegated to the
clayborg added a comment.
In https://reviews.llvm.org/D50365#1241149, @lemo wrote:
> Hi Greg, looking at request_evaluate() I noticed that it will evaluate the
> string as a lldb command if prefixed by ` .
>
> This is a great feature (it allows building REPL consoles on top of DAP), but
> I'm
> On Sep 20, 2018, at 3:05 PM, Leonard Mosescu wrote:
>
> Hi Greg, looking at request_evaluate() I noticed that it will evaluate the
> string as a lldb command if prefixed by ` .
>
> This is a great feature (it allows building REPL consoles on top of DAP), but
> I'm curious how you picked
tatyana-krasnukha updated this revision to Diff 166475.
tatyana-krasnukha added a comment.
Make overriding functions public.
Repository:
rLLDB LLDB
https://reviews.llvm.org/D48623
Files:
include/lldb/Core/Architecture.h
include/lldb/Target/Target.h
source/Core/Address.cpp
Author: tkrasnukha
Date: Fri Sep 21 06:40:22 2018
New Revision: 342733
URL: http://llvm.org/viewvc/llvm-project?rev=342733=rev
Log:
Add dependency on llc required by find-variable-dwo test
Modified:
lldb/trunk/lit/CMakeLists.txt
Modified: lldb/trunk/lit/CMakeLists.txt
URL:
Author: tkrasnukha
Date: Fri Sep 21 06:20:26 2018
New Revision: 342732
URL: http://llvm.org/viewvc/llvm-project?rev=342732=rev
Log:
Skip test if gcc version is less than 7.1 since it doesn't support
-gcolumn-info option
Modified:
teemperor added a comment.
Sure, here is the output: After some debugging it seems that our `select`
wrapper code is failing. We probably could fix this by terminating the process
like in the other error cases in the same method (grep for the "failed to write
to the unnamed pipe" error to see
tatyana-krasnukha updated this revision to Diff 166342.
tatyana-krasnukha retitled this revision from "WIP: Move architecture-specific
address adjustment to architecture plugins." to "Move architecture-specific
address adjustment to architecture plugins.".
tatyana-krasnukha added a comment.
25 matches
Mail list logo
